Re: [PATCH] net/mlx5: fix ICC compiler warning

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 10/16/2017 7:46 PM, Xueming Li wrote:
> Initialize variable to avoid ICC compiler warning:
> http://www.dpdk.org/ml/archives/dev/2017-October/077971.html

Hi Xueming, Nelio,

I disabled that warning for ICC in Makefile [1], as mentioned in above mail.

If you prefer to fix it instead of disable, can you please update the patch,
and remove that workaround in this patch?

Thanks,
ferruh


[1]
http://dpdk.org/browse/dpdk/tree/drivers/net/mlx5/Makefile#n93
 # Disable false positive warning
 ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
 CFLAGS_mlx5_txq.o += -wd3656
 endif



> 
> Fixes: f8b9a3bad467 ("net/mlx5: install a socket to exchange a file...")
> 
> Signed-off-by: Xueming Li <xuemingl@mellanox.com>
> ---
>  drivers/net/mlx5/mlx5_txq.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c
> index 9deaa7e..93f1388 100644
> --- a/drivers/net/mlx5/mlx5_txq.c
> +++ b/drivers/net/mlx5/mlx5_txq.c
> @@ -246,6 +246,7 @@
>  	int already_mapped;
>  	size_t page_size = sysconf(_SC_PAGESIZE);
>  
> +	memset(pages, 0, priv->txqs_n * sizeof(uintptr_t));
>  	/*
>  	 * As rdma-core, UARs are mapped in size of OS page size.
>  	 * Use aligned address to avoid duplicate mmap.
>