From: Zack Rusin <zackr@vmware.com>
To: "airlied@linux.ie" <airlied@linux.ie>,
"tzimmermann@suse.de" <tzimmermann@suse.de>,
"javierm@redhat.com" <javierm@redhat.com>,
"hdegoede@redhat.com" <hdegoede@redhat.com>,
"maarten.lankhorst@linux.intel.com"
<maarten.lankhorst@linux.intel.com>,
"deller@gmx.de" <deller@gmx.de>,
"daniel@ffwll.ch" <daniel@ffwll.ch>,
"mripard@kernel.org" <mripard@kernel.org>
Cc: "dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>
Subject: Re: [PATCH 1/5] fbdev: Hot-unplug firmware fb devices on forced removal
Date: Mon, 24 Jan 2022 15:59:16 +0000 [thread overview]
Message-ID: <e7cd09a7b302c4c7ea9b13cf0b59328cca5dc89e.camel@vmware.com> (raw)
In-Reply-To: <20220124123659.4692-2-tzimmermann@suse.de>
On Mon, 2022-01-24 at 13:36 +0100, Thomas Zimmermann wrote:
> Hot-unplug all firmware-framebuffer devices as part of removing
> them via remove_conflicting_framebuffers() et al. Releases all
> memory regions to be acquired by native drivers.
>
> Firmware, such as EFI, install a framebuffer while posting the
> computer. After removing the firmware-framebuffer device from fbdev,
> a native driver takes over the hardware and the firmware framebuffer
> becomes invalid.
>
> Firmware-framebuffer drivers, specifically simplefb, don't release
> their device from Linux' device hierarchy. It still owns the firmware
> framebuffer and blocks the native drivers from loading. This has been
> observed in the vmwgfx driver. [1]
>
> Initiating a device removal (i.e., hot unplug) as part of
> remove_conflicting_framebuffers() removes the underlying device and
> returns the memory range to the system.
>
> [1]
> https://lore.kernel.org/dri-devel/20220117180359.18114-1-zack@kde.org/
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> CC: stable@vger.kernel.org # v5.11+
Looks great, thanks!
Reviewed-by: Zack Rusin <zackr@vmware.com>
WARNING: multiple messages have this Message-ID (diff)
From: Zack Rusin <zackr@vmware.com>
To: "airlied@linux.ie" <airlied@linux.ie>,
"tzimmermann@suse.de" <tzimmermann@suse.de>,
"javierm@redhat.com" <javierm@redhat.com>,
"hdegoede@redhat.com" <hdegoede@redhat.com>,
"maarten.lankhorst@linux.intel.com"
<maarten.lankhorst@linux.intel.com>,
"deller@gmx.de" <deller@gmx.de>,
"daniel@ffwll.ch" <daniel@ffwll.ch>,
"mripard@kernel.org" <mripard@kernel.org>
Cc: "linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 1/5] fbdev: Hot-unplug firmware fb devices on forced removal
Date: Mon, 24 Jan 2022 15:59:16 +0000 [thread overview]
Message-ID: <e7cd09a7b302c4c7ea9b13cf0b59328cca5dc89e.camel@vmware.com> (raw)
In-Reply-To: <20220124123659.4692-2-tzimmermann@suse.de>
On Mon, 2022-01-24 at 13:36 +0100, Thomas Zimmermann wrote:
> Hot-unplug all firmware-framebuffer devices as part of removing
> them via remove_conflicting_framebuffers() et al. Releases all
> memory regions to be acquired by native drivers.
>
> Firmware, such as EFI, install a framebuffer while posting the
> computer. After removing the firmware-framebuffer device from fbdev,
> a native driver takes over the hardware and the firmware framebuffer
> becomes invalid.
>
> Firmware-framebuffer drivers, specifically simplefb, don't release
> their device from Linux' device hierarchy. It still owns the firmware
> framebuffer and blocks the native drivers from loading. This has been
> observed in the vmwgfx driver. [1]
>
> Initiating a device removal (i.e., hot unplug) as part of
> remove_conflicting_framebuffers() removes the underlying device and
> returns the memory range to the system.
>
> [1]
> https://lore.kernel.org/dri-devel/20220117180359.18114-1-zack@kde.org/
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> CC: stable@vger.kernel.org # v5.11+
Looks great, thanks!
Reviewed-by: Zack Rusin <zackr@vmware.com>
next prev parent reply other threads:[~2022-01-24 15:59 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 12:36 [PATCH 0/5] sysfb: Fix memory-region management Thomas Zimmermann
2022-01-24 12:36 ` Thomas Zimmermann
2022-01-24 12:36 ` [PATCH 1/5] fbdev: Hot-unplug firmware fb devices on forced removal Thomas Zimmermann
2022-01-24 12:36 ` Thomas Zimmermann
2022-01-24 13:52 ` Javier Martinez Canillas
2022-01-24 13:52 ` Javier Martinez Canillas
2022-01-24 13:56 ` Javier Martinez Canillas
2022-01-24 13:56 ` Javier Martinez Canillas
2022-01-24 14:19 ` Thomas Zimmermann
2022-01-24 14:19 ` Thomas Zimmermann
2022-01-24 14:31 ` Javier Martinez Canillas
2022-01-24 14:31 ` Javier Martinez Canillas
2022-01-24 15:59 ` Zack Rusin [this message]
2022-01-24 15:59 ` Zack Rusin
2022-01-24 12:36 ` [PATCH 2/5] drivers/firmware: Don't mark as busy the simple-framebuffer IO resource Thomas Zimmermann
2022-01-24 12:36 ` Thomas Zimmermann
2022-01-24 15:59 ` Zack Rusin
2022-01-24 15:59 ` Zack Rusin
2022-01-24 12:36 ` [PATCH 3/5] drm/simpledrm: Request memory region in driver Thomas Zimmermann
2022-01-24 12:36 ` Thomas Zimmermann
2022-01-24 14:00 ` Javier Martinez Canillas
2022-01-24 14:00 ` Javier Martinez Canillas
2022-01-24 14:23 ` Jocelyn Falempe
2022-01-25 8:31 ` Thomas Zimmermann
2022-01-24 12:36 ` [PATCH 4/5] fbdev/simplefb: " Thomas Zimmermann
2022-01-24 12:36 ` Thomas Zimmermann
2022-01-24 14:24 ` Javier Martinez Canillas
2022-01-24 14:24 ` Javier Martinez Canillas
2022-01-24 12:36 ` [PATCH 5/5] drm: Add TODO item for requesting memory regions Thomas Zimmermann
2022-01-24 12:36 ` Thomas Zimmermann
2022-01-24 14:25 ` Javier Martinez Canillas
2022-01-24 14:25 ` Javier Martinez Canillas
2022-01-25 9:12 [PATCH 0/5] sysfb: Fix memory-region management Thomas Zimmermann
2022-01-25 9:12 ` [PATCH 1/5] fbdev: Hot-unplug firmware fb devices on forced removal Thomas Zimmermann
2022-01-25 9:12 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7cd09a7b302c4c7ea9b13cf0b59328cca5dc89e.camel@vmware.com \
--to=zackr@vmware.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=javierm@redhat.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.