All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Kravetz <mike.kravetz@oracle.com>
To: "Bodeddula, Balasubramaniam" <bodeddub@amazon.com>,
	Chen Huang <chenhuang5@huawei.com>,
	Muchun Song <songmuchun@bytedance.com>,
	"will@kernel.org" <will@kernel.org>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"david@redhat.com" <david@redhat.com>,
	"osalvador@suse.de" <osalvador@suse.de>,
	"rientjes@google.com" <rientjes@google.com>
Cc: "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"duanxiongchun@bytedance.com" <duanxiongchun@bytedance.com>,
	"Umesh Sargur, Gautam" <sargur@amazon.com>
Subject: Re: [PATCH 0/3] Add support for free vmemmap pages of HugeTLB for arm64
Date: Fri, 12 Mar 2021 09:38:17 -0800	[thread overview]
Message-ID: <e7ec1e95-5aa9-0147-46fa-91cda70fd4af@oracle.com> (raw)
In-Reply-To: <FE02DFEF-9706-4CEE-8949-89BD13C2AE00@amazon.com>

On 3/11/21 10:00 AM, Bodeddula, Balasubramaniam wrote:
> Hey, thanks for the testing steps.
> 
> I tried applying these patches on 5.11 source tree. These patches were applied on top of the x86 patch, which worked fine. But in this case we don't see the same improvements in our testing. We made sure we set CONFIG_HUGETLB_PAGE_FREE_VMEMMAP=y in our .config file.
> 
> Are we missing any more configuration settings to get this patch to work on ARM? Can you please help with general troubleshooting steps to debug what could be going wrong.
> 

Are you specifying 'hugetlb_free_vmemmap=on' on the kernel command line?
This feature is only enabled if you 'opt in' via the command line option.

-- 
Mike Kravetz

WARNING: multiple messages have this Message-ID (diff)
From: Mike Kravetz <mike.kravetz@oracle.com>
To: "Bodeddula, Balasubramaniam" <bodeddub@amazon.com>,
	Chen Huang <chenhuang5@huawei.com>,
	Muchun Song <songmuchun@bytedance.com>,
	"will@kernel.org" <will@kernel.org>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"david@redhat.com" <david@redhat.com>,
	"osalvador@suse.de" <osalvador@suse.de>,
	"rientjes@google.com" <rientjes@google.com>
Cc: "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"duanxiongchun@bytedance.com" <duanxiongchun@bytedance.com>,
	"Umesh Sargur, Gautam" <sargur@amazon.com>
Subject: Re: [PATCH 0/3] Add support for free vmemmap pages of HugeTLB for arm64
Date: Fri, 12 Mar 2021 09:38:17 -0800	[thread overview]
Message-ID: <e7ec1e95-5aa9-0147-46fa-91cda70fd4af@oracle.com> (raw)
In-Reply-To: <FE02DFEF-9706-4CEE-8949-89BD13C2AE00@amazon.com>

On 3/11/21 10:00 AM, Bodeddula, Balasubramaniam wrote:
> Hey, thanks for the testing steps.
> 
> I tried applying these patches on 5.11 source tree. These patches were applied on top of the x86 patch, which worked fine. But in this case we don't see the same improvements in our testing. We made sure we set CONFIG_HUGETLB_PAGE_FREE_VMEMMAP=y in our .config file.
> 
> Are we missing any more configuration settings to get this patch to work on ARM? Can you please help with general troubleshooting steps to debug what could be going wrong.
> 

Are you specifying 'hugetlb_free_vmemmap=on' on the kernel command line?
This feature is only enabled if you 'opt in' via the command line option.

-- 
Mike Kravetz

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-03-12 17:45 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-10  7:15 [PATCH 0/3] Add support for free vmemmap pages of HugeTLB for arm64 Muchun Song
2021-03-10  7:15 ` Muchun Song
2021-03-10  7:15 ` [PATCH 1/3] mm: bootmem_info: mark register_page_bootmem_info_section __init Muchun Song
2021-03-10  7:15   ` Muchun Song
2021-03-10  7:15 ` [PATCH 2/3] mm: hugetlb: introduce arch_free_vmemmap_page Muchun Song
2021-03-10  7:15   ` Muchun Song
2021-03-10 12:16   ` kernel test robot
2021-03-10 12:16     ` kernel test robot
2021-03-10 12:16     ` kernel test robot
2021-03-11  0:15   ` kernel test robot
2021-03-11  0:15     ` kernel test robot
2021-03-11  0:15     ` kernel test robot
2021-03-10  7:15 ` [PATCH 3/3] arm64: mm: hugetlb: add support for free vmemmap pages of HugeTLB Muchun Song
2021-03-10  7:15   ` Muchun Song
2021-03-11  0:47   ` kernel test robot
2021-03-11  0:47     ` kernel test robot
2021-03-11  0:47     ` kernel test robot
2021-03-11  4:12 ` [PATCH 0/3] Add support for free vmemmap pages of HugeTLB for arm64 Chen Huang
2021-03-11  4:12   ` Chen Huang
2021-03-11  5:00   ` Bodeddula, Balasubramaniam
2021-03-11  5:00     ` Bodeddula, Balasubramaniam
2021-03-11  5:00     ` Bodeddula, Balasubramaniam
2021-03-11  6:01     ` Chen Huang
2021-03-11  6:01       ` Chen Huang
2021-03-11  6:01       ` Chen Huang
2021-03-11 18:00       ` Bodeddula, Balasubramaniam
2021-03-11 18:00         ` Bodeddula, Balasubramaniam
2021-03-11 18:00         ` Bodeddula, Balasubramaniam
2021-03-12  2:52         ` Chen Huang
2021-03-12  2:52           ` Chen Huang
2021-03-12  2:52           ` Chen Huang
2021-03-12 17:38         ` Mike Kravetz [this message]
2021-03-12 17:38           ` Mike Kravetz
2021-03-12 17:38           ` Mike Kravetz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e7ec1e95-5aa9-0147-46fa-91cda70fd4af@oracle.com \
    --to=mike.kravetz@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=bodeddub@amazon.com \
    --cc=chenhuang5@huawei.com \
    --cc=david@redhat.com \
    --cc=duanxiongchun@bytedance.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=osalvador@suse.de \
    --cc=rientjes@google.com \
    --cc=sargur@amazon.com \
    --cc=songmuchun@bytedance.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.