All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ideapad-laptop: Add another DMI entry for Yoga 900
@ 2016-10-19 10:27 Mika Westerberg
  2016-10-19 16:36 ` Andy Shevchenko
  2016-10-19 20:10 ` Darren Hart
  0 siblings, 2 replies; 5+ messages in thread
From: Mika Westerberg @ 2016-10-19 10:27 UTC (permalink / raw)
  To: platform-driver-x86; +Cc: Darren Hart, Ike Panhc, Mika Westerberg

This particular laptop has its motherboard replaced and after that, even
with the latest BIOS, some DMI identification strings have become
"INVALID". This includes DMI_PRODUCT_VERSION which results Wifi being
blocked.

It seems that DMI_BOARD_NAME is still valid so use that as an
alternative for Lenovo Yoga 900.

Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
 drivers/platform/x86/ideapad-laptop.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
index d1a091b..d99b45e 100644
--- a/drivers/platform/x86/ideapad-laptop.c
+++ b/drivers/platform/x86/ideapad-laptop.c
@@ -933,6 +933,13 @@ static const struct dmi_system_id no_hw_rfkill_list[] = {
 			DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo YOGA 900"),
 		},
 	},
+	{
+		.ident = "Lenovo Yoga 900",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+			DMI_MATCH(DMI_BOARD_NAME, "VIUU4"),
+		},
+	},
 	{}
 };
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] ideapad-laptop: Add another DMI entry for Yoga 900
  2016-10-19 10:27 [PATCH] ideapad-laptop: Add another DMI entry for Yoga 900 Mika Westerberg
@ 2016-10-19 16:36 ` Andy Shevchenko
  2016-10-19 20:10 ` Darren Hart
  1 sibling, 0 replies; 5+ messages in thread
From: Andy Shevchenko @ 2016-10-19 16:36 UTC (permalink / raw)
  To: Mika Westerberg; +Cc: platform-driver-x86, Darren Hart, Ike Panhc

On Wed, Oct 19, 2016 at 1:27 PM, Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
> This particular laptop has its motherboard replaced and after that, even
> with the latest BIOS, some DMI identification strings have become
> "INVALID". This includes DMI_PRODUCT_VERSION which results Wifi being
> blocked.
>
> It seems that DMI_BOARD_NAME is still valid so use that as an
> alternative for Lenovo Yoga 900.
>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Reviewed-by: Andy Shevchenko <andy.shevchenko@linux.intel.com>

> --- a/drivers/platform/x86/ideapad-laptop.c
> +++ b/drivers/platform/x86/ideapad-laptop.c
> @@ -933,6 +933,13 @@ static const struct dmi_system_id no_hw_rfkill_list[] = {
>                         DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo YOGA 900"),
>                 },
>         },
> +       {
> +               .ident = "Lenovo Yoga 900",
> +               .matches = {
> +                       DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +                       DMI_MATCH(DMI_BOARD_NAME, "VIUU4"),
> +               },
> +       },
>         {}
>  };

-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ideapad-laptop: Add another DMI entry for Yoga 900
  2016-10-19 10:27 [PATCH] ideapad-laptop: Add another DMI entry for Yoga 900 Mika Westerberg
  2016-10-19 16:36 ` Andy Shevchenko
@ 2016-10-19 20:10 ` Darren Hart
  2016-10-20  0:56   ` Ike Panhc
  1 sibling, 1 reply; 5+ messages in thread
From: Darren Hart @ 2016-10-19 20:10 UTC (permalink / raw)
  To: Mika Westerberg; +Cc: platform-driver-x86, Ike Panhc

On Wed, Oct 19, 2016 at 01:27:40PM +0300, Mika Westerberg wrote:
> This particular laptop has its motherboard replaced and after that, even
> with the latest BIOS, some DMI identification strings have become
> "INVALID". This includes DMI_PRODUCT_VERSION which results Wifi being
> blocked.
> 
> It seems that DMI_BOARD_NAME is still valid so use that as an
> alternative for Lenovo Yoga 900.

Well, that stinks. We have a similar split for the Yoga 2 11/13/Pro.

Applied.

-- 
Darren Hart
Intel Open Source Technology Center

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ideapad-laptop: Add another DMI entry for Yoga 900
  2016-10-19 20:10 ` Darren Hart
@ 2016-10-20  0:56   ` Ike Panhc
  2016-10-20  7:37     ` Mika Westerberg
  0 siblings, 1 reply; 5+ messages in thread
From: Ike Panhc @ 2016-10-20  0:56 UTC (permalink / raw)
  To: Mika Westerberg; +Cc: Darren Hart, platform-driver-x86

On 10/20/2016 04:10 AM, Darren Hart wrote:
> On Wed, Oct 19, 2016 at 01:27:40PM +0300, Mika Westerberg wrote:
>> This particular laptop has its motherboard replaced and after that, even
>> with the latest BIOS, some DMI identification strings have become
>> "INVALID". This includes DMI_PRODUCT_VERSION which results Wifi being
>> blocked.
>>
>> It seems that DMI_BOARD_NAME is still valid so use that as an
>> alternative for Lenovo Yoga 900.
> 
> Well, that stinks. We have a similar split for the Yoga 2 11/13/Pro.
> 
> Applied.
> 

Hi Mika,

Could you post output of acpidump and `cat /sys/class/dmi/id/modalias` for record please?

Thanks a lot.

--
Ike Panhc

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ideapad-laptop: Add another DMI entry for Yoga 900
  2016-10-20  0:56   ` Ike Panhc
@ 2016-10-20  7:37     ` Mika Westerberg
  0 siblings, 0 replies; 5+ messages in thread
From: Mika Westerberg @ 2016-10-20  7:37 UTC (permalink / raw)
  To: Ike Panhc; +Cc: Darren Hart, platform-driver-x86

On Thu, Oct 20, 2016 at 08:56:30AM +0800, Ike Panhc wrote:
> On 10/20/2016 04:10 AM, Darren Hart wrote:
> > On Wed, Oct 19, 2016 at 01:27:40PM +0300, Mika Westerberg wrote:
> >> This particular laptop has its motherboard replaced and after that, even
> >> with the latest BIOS, some DMI identification strings have become
> >> "INVALID". This includes DMI_PRODUCT_VERSION which results Wifi being
> >> blocked.
> >>
> >> It seems that DMI_BOARD_NAME is still valid so use that as an
> >> alternative for Lenovo Yoga 900.
> > 
> > Well, that stinks. We have a similar split for the Yoga 2 11/13/Pro.
> > 
> > Applied.
> > 
> 
> Hi Mika,
> 
> Could you post output of acpidump and `cat /sys/class/dmi/id/modalias` for record please?
> 

Here it is:

dmi:bvnLENOVO:bvrC6CN37WW:bd03/01/2016:svnLENOVO:pnINVALID:pvrINVALID:rvnLENOVO:rnVIUU4:rvrSDK0K17763WIN:cvnLENOVO:ct10:cvrINVALID:

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2016-10-20  7:43 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-19 10:27 [PATCH] ideapad-laptop: Add another DMI entry for Yoga 900 Mika Westerberg
2016-10-19 16:36 ` Andy Shevchenko
2016-10-19 20:10 ` Darren Hart
2016-10-20  0:56   ` Ike Panhc
2016-10-20  7:37     ` Mika Westerberg

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.