All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] net/kni: fix crash
@ 2017-04-18 14:00 Ferruh Yigit
  2017-04-18 16:36 ` Ferruh Yigit
  0 siblings, 1 reply; 2+ messages in thread
From: Ferruh Yigit @ 2017-04-18 14:00 UTC (permalink / raw)
  To: Ferruh Yigit, Thomas Monjalon; +Cc: dev

eth_dev->device is now NULL, and accessing eth_dev->device->driver
crashes.
No need to set this value, removed completely.

Fixes: 5d2aa461cbca ("vdev: use generic vdev struct for probe and remove")

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 drivers/net/kni/rte_eth_kni.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/kni/rte_eth_kni.c b/drivers/net/kni/rte_eth_kni.c
index a0b18cd..0e0e4ad 100644
--- a/drivers/net/kni/rte_eth_kni.c
+++ b/drivers/net/kni/rte_eth_kni.c
@@ -393,7 +393,6 @@ eth_kni_create(const char *name, struct eth_kni_args *args,
 
 	eth_dev->data = data;
 	eth_dev->dev_ops = &eth_kni_ops;
-	eth_dev->device->driver = NULL;
 
 	data->dev_flags = RTE_ETH_DEV_DETACHABLE;
 	data->kdrv = RTE_KDRV_NONE;
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] net/kni: fix crash
  2017-04-18 14:00 [PATCH] net/kni: fix crash Ferruh Yigit
@ 2017-04-18 16:36 ` Ferruh Yigit
  0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2017-04-18 16:36 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: dev

On 4/18/2017 3:00 PM, Ferruh Yigit wrote:
> eth_dev->device is now NULL, and accessing eth_dev->device->driver
> crashes.
> No need to set this value, removed completely.
> 
> Fixes: 5d2aa461cbca ("vdev: use generic vdev struct for probe and remove")
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/master, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-04-18 16:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-18 14:00 [PATCH] net/kni: fix crash Ferruh Yigit
2017-04-18 16:36 ` Ferruh Yigit

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.