* [PATCH] perf/fsmonitor: use test_must_be_empty helper
@ 2020-11-25 22:11 Nipunn Koorapati via GitGitGadget
2020-11-30 14:15 ` Derrick Stolee
0 siblings, 1 reply; 2+ messages in thread
From: Nipunn Koorapati via GitGitGadget @ 2020-11-25 22:11 UTC (permalink / raw)
To: git; +Cc: Nipunn Koorapati, Nipunn Koorapati
From: Nipunn Koorapati <nipunn@dropbox.com>
Simplify test and make error messages more clear here.
Per feedback from Junio in
33226af42b (t/perf/fsmonitor: improve error message if typoing hook
name, 2020-10-26)
Signed-off-by: Nipunn Koorapati <nipunn@dropbox.com>
---
perf/fsmonitor: use test_must_be_empty helper
Simplify perf/fsmonitor test and make error messages more clear.
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-799%2Fnipunn1313%2Fnk%2Ffsmonitor-test-cleanup-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-799/nipunn1313/nk/fsmonitor-test-cleanup-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/799
t/perf/p7519-fsmonitor.sh | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/t/perf/p7519-fsmonitor.sh b/t/perf/p7519-fsmonitor.sh
index 163a13bea3..9b43342806 100755
--- a/t/perf/p7519-fsmonitor.sh
+++ b/t/perf/p7519-fsmonitor.sh
@@ -129,8 +129,7 @@ setup_for_fsmonitor() {
git config core.fsmonitor "$INTEGRATION_SCRIPT" &&
git update-index --fsmonitor 2>error &&
- cat error &&
- [ ! -s error ] # ensure no silent error
+ test_must_be_empty error # ensure no silent error
}
test_perf_w_drop_caches () {
base-commit: b291b0a628020eedb10b6236d87fe25d295cea81
--
gitgitgadget
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] perf/fsmonitor: use test_must_be_empty helper
2020-11-25 22:11 [PATCH] perf/fsmonitor: use test_must_be_empty helper Nipunn Koorapati via GitGitGadget
@ 2020-11-30 14:15 ` Derrick Stolee
0 siblings, 0 replies; 2+ messages in thread
From: Derrick Stolee @ 2020-11-30 14:15 UTC (permalink / raw)
To: Nipunn Koorapati via GitGitGadget, git; +Cc: Nipunn Koorapati, Nipunn Koorapati
On 11/25/2020 5:11 PM, Nipunn Koorapati via GitGitGadget wrote:
> From: Nipunn Koorapati <nipunn@dropbox.com>
>
> Simplify test and make error messages more clear here.
> Per feedback from Junio in
> 33226af42b (t/perf/fsmonitor: improve error message if typoing hook
> name, 2020-10-26)
Thanks, Nipunn. This patch looks good to me.
-Stolee
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-30 14:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-25 22:11 [PATCH] perf/fsmonitor: use test_must_be_empty helper Nipunn Koorapati via GitGitGadget
2020-11-30 14:15 ` Derrick Stolee
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.