* [PATCH] net: dsa: Remove documentation for port_fdb_prepare
@ 2019-02-22 19:07 Hauke Mehrtens
2019-02-22 19:28 ` Florian Fainelli
2019-02-24 2:38 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Hauke Mehrtens @ 2019-02-22 19:07 UTC (permalink / raw)
To: davem; +Cc: arkadis, netdev, linux-doc, Hauke Mehrtens
This callback was removed some time ago, also remove the documentation.
Fixes: 1b6dd556c304 ("net: dsa: Remove prepare phase for FDB")
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
---
Documentation/networking/dsa/dsa.txt | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/Documentation/networking/dsa/dsa.txt b/Documentation/networking/dsa/dsa.txt
index 25170ad7d25b..101f2b2c69ad 100644
--- a/Documentation/networking/dsa/dsa.txt
+++ b/Documentation/networking/dsa/dsa.txt
@@ -533,16 +533,12 @@ Bridge VLAN filtering
function that the driver has to call for each VLAN the given port is a member
of. A switchdev object is used to carry the VID and bridge flags.
-- port_fdb_prepare: bridge layer function invoked when the bridge prepares the
- installation of a Forwarding Database entry. If the operation is not
- supported, this function should return -EOPNOTSUPP to inform the bridge code
- to fallback to a software implementation. No hardware setup must be done in
- this function. See port_fdb_add for this and details.
-
- port_fdb_add: bridge layer function invoked when the bridge wants to install a
Forwarding Database entry, the switch hardware should be programmed with the
specified address in the specified VLAN Id in the forwarding database
- associated with this VLAN ID
+ associated with this VLAN ID. If the operation is not supported, this
+ function should return -EOPNOTSUPP to inform the bridge code to fallback to
+ a software implementation.
Note: VLAN ID 0 corresponds to the port private database, which, in the context
of DSA, would be the its port-based VLAN, used by the associated bridge device.
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: dsa: Remove documentation for port_fdb_prepare
2019-02-22 19:07 [PATCH] net: dsa: Remove documentation for port_fdb_prepare Hauke Mehrtens
@ 2019-02-22 19:28 ` Florian Fainelli
2019-02-24 2:38 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2019-02-22 19:28 UTC (permalink / raw)
To: Hauke Mehrtens, davem; +Cc: arkadis, netdev, linux-doc
On 2/22/19 11:07 AM, Hauke Mehrtens wrote:
> This callback was removed some time ago, also remove the documentation.
>
> Fixes: 1b6dd556c304 ("net: dsa: Remove prepare phase for FDB")
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Not sure if this is worth a Fixes: tag since this is not quite a
functional change, but other than:
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: dsa: Remove documentation for port_fdb_prepare
2019-02-22 19:07 [PATCH] net: dsa: Remove documentation for port_fdb_prepare Hauke Mehrtens
2019-02-22 19:28 ` Florian Fainelli
@ 2019-02-24 2:38 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-02-24 2:38 UTC (permalink / raw)
To: hauke; +Cc: arkadis, netdev, linux-doc
From: Hauke Mehrtens <hauke@hauke-m.de>
Date: Fri, 22 Feb 2019 20:07:45 +0100
> This callback was removed some time ago, also remove the documentation.
>
> Fixes: 1b6dd556c304 ("net: dsa: Remove prepare phase for FDB")
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-24 2:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-22 19:07 [PATCH] net: dsa: Remove documentation for port_fdb_prepare Hauke Mehrtens
2019-02-22 19:28 ` Florian Fainelli
2019-02-24 2:38 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.