All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Yi Wang <wang.yi59@zte.com.cn>, Huang Zijiang <huang.zijiang@zte.com.cn>
Cc: LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org, Ben Segall <bsegall@google.com>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Ingo Molnar <mingo@redhat.com>,
	Juri Lelli <juri.lelli@redhat.com>, Mel Gorman <mgorman@suse.de>,
	Peter Zijlstra <peterz@infradead.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	up2wing@gmail.com, Vincent Guittot <vincent.guittot@linaro.org>,
	Wang Liang <wang.liang82@zte.com.cn>,
	Xue Zhihong <xue.zhihong@zte.com.cn>
Subject: Re: [PATCH] sched: Use kmem_cache_zalloc() instead of kmem_cache_alloc() with flag GFP_ZERO.
Date: Mon, 23 Dec 2019 17:07:50 +0100	[thread overview]
Message-ID: <e880ee66-2d7f-be97-5600-a8a459a39feb@web.de> (raw)
In-Reply-To: <1577065949-25631-1-git-send-email-wang.yi59@zte.com.cn>

…
> +++ b/kernel/sched/core.c
> @@ -6939,7 +6939,7 @@ struct task_group *sched_create_group(struct task_group *parent)
…
> -    tg = kmem_cache_alloc(task_group_cache, GFP_KERNEL | __GFP_ZERO);
> +tg = kmem_cache_zalloc(task_group_cache, GFP_KERNEL);
>      if (!tg)
…

Please fix the indentation.

Would you like to apply a script for the semantic patch language
like the following?

@replacement@
expression gfp, x;
@@
 x =
(
-    kmalloc
+    kzalloc
|
-    kmem_cache_alloc
+    kmem_cache_zalloc
)
            (...,
             gfp
-            | __GFP_ZERO
            )


Regards,
Markus

WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: Yi Wang <wang.yi59@zte.com.cn>, Huang Zijiang <huang.zijiang@zte.com.cn>
Cc: LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org, Ben Segall <bsegall@google.com>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Ingo Molnar <mingo@redhat.com>,
	Juri Lelli <juri.lelli@redhat.com>, Mel Gorman <mgorman@suse.de>,
	Peter Zijlstra <peterz@infradead.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	up2wing@gmail.com, Vincent Guittot <vincent.guittot@linaro.org>,
	Wang Liang <wang.liang82@zte.com.cn>,
	Xue Zhihong <xue.zhihong@zte.com.cn>
Subject: Re: [PATCH] sched: Use kmem_cache_zalloc() instead of kmem_cache_alloc() with flag GFP_ZERO.
Date: Mon, 23 Dec 2019 16:07:50 +0000	[thread overview]
Message-ID: <e880ee66-2d7f-be97-5600-a8a459a39feb@web.de> (raw)
In-Reply-To: <1577065949-25631-1-git-send-email-wang.yi59@zte.com.cn>

…
> +++ b/kernel/sched/core.c
> @@ -6939,7 +6939,7 @@ struct task_group *sched_create_group(struct task_group *parent)
…
> -    tg = kmem_cache_alloc(task_group_cache, GFP_KERNEL | __GFP_ZERO);
> +tg = kmem_cache_zalloc(task_group_cache, GFP_KERNEL);
>      if (!tg)
…

Please fix the indentation.

Would you like to apply a script for the semantic patch language
like the following?

@replacement@
expression gfp, x;
@@
 x =
(
-    kmalloc
+    kzalloc
|
-    kmem_cache_alloc
+    kmem_cache_zalloc
)
            (...,
             gfp
-            | __GFP_ZERO
            )


Regards,
Markus

  reply	other threads:[~2019-12-23 16:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-23  1:52 [PATCH] sched: Use kmem_cache_zalloc() instead of kmem_cache_alloc() with flag GFP_ZERO Yi Wang
2019-12-23 16:07 ` Markus Elfring [this message]
2019-12-23 16:07   ` Markus Elfring
2020-02-12  9:54 Yi Wang
2020-02-12 10:11 ` Peter Zijlstra
2020-06-17  7:54 Yi Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e880ee66-2d7f-be97-5600-a8a459a39feb@web.de \
    --to=markus.elfring@web.de \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=huang.zijiang@zte.com.cn \
    --cc=juri.lelli@redhat.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=up2wing@gmail.com \
    --cc=vincent.guittot@linaro.org \
    --cc=wang.liang82@zte.com.cn \
    --cc=wang.yi59@zte.com.cn \
    --cc=xue.zhihong@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.