From: Yicong Yang <yangyicong@hisilicon.com> To: Daniel Thompson <daniel.thompson@linaro.org> Cc: <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <coresight@lists.linaro.org>, <linux-pci@vger.kernel.org>, <alexander.shishkin@linux.intel.com>, <helgaas@kernel.org>, <gregkh@linuxfoundation.org>, <lorenzo.pieralisi@arm.com>, <will@kernel.org>, <mark.rutland@arm.com>, <mathieu.poirier@linaro.org>, <suzuki.poulose@arm.com>, <mike.leach@linaro.org>, <leo.yan@linaro.org>, <jonathan.cameron@huawei.com>, <song.bao.hua@hisilicon.com>, <john.garry@huawei.com>, <prime.zeng@huawei.com>, <liuqi115@huawei.com>, <zhangshaokun@hisilicon.com>, <linuxarm@huawei.com> Subject: Re: [PATCH RESEND 3/4] docs: Add HiSilicon PTT device driver documentation Date: Mon, 19 Apr 2021 21:12:57 +0800 [thread overview] Message-ID: <e884000f-3131-490b-eb0c-bc82ed642a85@hisilicon.com> (raw) In-Reply-To: <20210419090750.g6aeyyrki7fiotxl@maple.lan> On 2021/4/19 17:07, Daniel Thompson wrote: > On Sat, Apr 17, 2021 at 06:17:10PM +0800, Yicong Yang wrote: >> Document the introduction and usage of HiSilicon PTT device driver. >> >> Signed-off-by: Yicong Yang <yangyicong@hisilicon.com> >> --- >> Documentation/trace/hisi-ptt.rst | 326 +++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 326 insertions(+) >> create mode 100644 Documentation/trace/hisi-ptt.rst >> >> diff --git a/Documentation/trace/hisi-ptt.rst b/Documentation/trace/hisi-ptt.rst >> new file mode 100644 >> index 0000000..f093846 >> --- /dev/null >> +++ b/Documentation/trace/hisi-ptt.rst >> @@ -0,0 +1,326 @@ >> [...] >> +On Kunpeng 930 SoC, the PCIe Root Complex is composed of several >> +PCIe cores. Each PCIe core includes several Root Ports and a PTT >> +RCiEP, like below. The PTT device is capable of tuning and >> +tracing the link of the PCIe core. >> +:: >> + +--------------Core 0-------+ >> + | | [ PTT ] | >> + | | [Root Port]---[Endpoint] >> + | | [Root Port]---[Endpoint] >> + | | [Root Port]---[Endpoint] >> + Root Complex |------Core 1-------+ >> + | | [ PTT ] | >> + | | [Root Port]---[ Switch ]---[Endpoint] >> + | | [Root Port]---[Endpoint] `-[Endpoint] >> + | | [Root Port]---[Endpoint] >> + +---------------------------+ >> + >> +The PTT device driver cannot be loaded if debugfs is not mounted. > > This can't be right can it? Obviously debugfs must be enabled but why > mounted? > just mention the limit as I'm not sure it's always be mounted. > >> +Each PTT device will be presented under /sys/kernel/debugfs/hisi_ptt >> +as its root directory, with name of its BDF number. >> +:: >> + >> + /sys/kernel/debug/hisi_ptt/<domain>:<bus>:<device>.<function> >> + >> +Tune >> +==== >> + >> +PTT tune is designed for monitoring and adjusting PCIe link parameters (events). >> +Currently we support events in 4 classes. The scope of the events >> +covers the PCIe core to which the PTT device belongs. >> + >> +Each event is presented as a file under $(PTT root dir)/$(BDF)/tune, and >> +mostly a simple open/read/write/close cycle will be used to tune >> +the event. >> +:: >> + $ cd /sys/kernel/debug/hisi_ptt/$(BDF)/tune >> + $ ls >> + qos_tx_cpl qos_tx_np qos_tx_p >> + tx_path_rx_req_alloc_buf_level >> + tx_path_tx_req_alloc_buf_level >> + $ cat qos_tx_dp >> + 1 >> + $ echo 2 > qos_tx_dp >> + $ cat qos_tx_dp >> + 2 >> + >> +Current value (numerical value) of the event can be simply read >> +from the file, and the desired value written to the file to tune. > > I saw that this RFC asks about whether debugfs is an appropriate > interface for the *tracing* capability of the platform. Have similar > questions been raised about the tuning interfaces? > yes. as well. > It looks to me like tuning could be handled entirely using sysfs > attributes. I think trying to handle these mostly decoupled feature > in the same place is likely to be a mistake. > Tuning and tracing are two separate functions and it does make sense to decouple them. Thanks for the advice, we can make tuning using sysfs attributes as debugfs is not encouraged. Regards, Yicong > > Daniel. > > . >
WARNING: multiple messages have this Message-ID (diff)
From: Yicong Yang <yangyicong@hisilicon.com> To: Daniel Thompson <daniel.thompson@linaro.org> Cc: <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <coresight@lists.linaro.org>, <linux-pci@vger.kernel.org>, <alexander.shishkin@linux.intel.com>, <helgaas@kernel.org>, <gregkh@linuxfoundation.org>, <lorenzo.pieralisi@arm.com>, <will@kernel.org>, <mark.rutland@arm.com>, <mathieu.poirier@linaro.org>, <suzuki.poulose@arm.com>, <mike.leach@linaro.org>, <leo.yan@linaro.org>, <jonathan.cameron@huawei.com>, <song.bao.hua@hisilicon.com>, <john.garry@huawei.com>, <prime.zeng@huawei.com>, <liuqi115@huawei.com>, <zhangshaokun@hisilicon.com>, <linuxarm@huawei.com> Subject: Re: [PATCH RESEND 3/4] docs: Add HiSilicon PTT device driver documentation Date: Mon, 19 Apr 2021 21:12:57 +0800 [thread overview] Message-ID: <e884000f-3131-490b-eb0c-bc82ed642a85@hisilicon.com> (raw) In-Reply-To: <20210419090750.g6aeyyrki7fiotxl@maple.lan> On 2021/4/19 17:07, Daniel Thompson wrote: > On Sat, Apr 17, 2021 at 06:17:10PM +0800, Yicong Yang wrote: >> Document the introduction and usage of HiSilicon PTT device driver. >> >> Signed-off-by: Yicong Yang <yangyicong@hisilicon.com> >> --- >> Documentation/trace/hisi-ptt.rst | 326 +++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 326 insertions(+) >> create mode 100644 Documentation/trace/hisi-ptt.rst >> >> diff --git a/Documentation/trace/hisi-ptt.rst b/Documentation/trace/hisi-ptt.rst >> new file mode 100644 >> index 0000000..f093846 >> --- /dev/null >> +++ b/Documentation/trace/hisi-ptt.rst >> @@ -0,0 +1,326 @@ >> [...] >> +On Kunpeng 930 SoC, the PCIe Root Complex is composed of several >> +PCIe cores. Each PCIe core includes several Root Ports and a PTT >> +RCiEP, like below. The PTT device is capable of tuning and >> +tracing the link of the PCIe core. >> +:: >> + +--------------Core 0-------+ >> + | | [ PTT ] | >> + | | [Root Port]---[Endpoint] >> + | | [Root Port]---[Endpoint] >> + | | [Root Port]---[Endpoint] >> + Root Complex |------Core 1-------+ >> + | | [ PTT ] | >> + | | [Root Port]---[ Switch ]---[Endpoint] >> + | | [Root Port]---[Endpoint] `-[Endpoint] >> + | | [Root Port]---[Endpoint] >> + +---------------------------+ >> + >> +The PTT device driver cannot be loaded if debugfs is not mounted. > > This can't be right can it? Obviously debugfs must be enabled but why > mounted? > just mention the limit as I'm not sure it's always be mounted. > >> +Each PTT device will be presented under /sys/kernel/debugfs/hisi_ptt >> +as its root directory, with name of its BDF number. >> +:: >> + >> + /sys/kernel/debug/hisi_ptt/<domain>:<bus>:<device>.<function> >> + >> +Tune >> +==== >> + >> +PTT tune is designed for monitoring and adjusting PCIe link parameters (events). >> +Currently we support events in 4 classes. The scope of the events >> +covers the PCIe core to which the PTT device belongs. >> + >> +Each event is presented as a file under $(PTT root dir)/$(BDF)/tune, and >> +mostly a simple open/read/write/close cycle will be used to tune >> +the event. >> +:: >> + $ cd /sys/kernel/debug/hisi_ptt/$(BDF)/tune >> + $ ls >> + qos_tx_cpl qos_tx_np qos_tx_p >> + tx_path_rx_req_alloc_buf_level >> + tx_path_tx_req_alloc_buf_level >> + $ cat qos_tx_dp >> + 1 >> + $ echo 2 > qos_tx_dp >> + $ cat qos_tx_dp >> + 2 >> + >> +Current value (numerical value) of the event can be simply read >> +from the file, and the desired value written to the file to tune. > > I saw that this RFC asks about whether debugfs is an appropriate > interface for the *tracing* capability of the platform. Have similar > questions been raised about the tuning interfaces? > yes. as well. > It looks to me like tuning could be handled entirely using sysfs > attributes. I think trying to handle these mostly decoupled feature > in the same place is likely to be a mistake. > Tuning and tracing are two separate functions and it does make sense to decouple them. Thanks for the advice, we can make tuning using sysfs attributes as debugfs is not encouraged. Regards, Yicong > > Daniel. > > . > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-19 13:16 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-17 10:17 [PATCH RESEND 0/4] Add support for HiSilicon PCIe Tune and Trace device Yicong Yang 2021-04-17 10:17 ` Yicong Yang 2021-04-17 10:17 ` [PATCH RESEND 1/4] hwtracing: Add trace function " Yicong Yang 2021-04-17 10:17 ` Yicong Yang 2021-04-17 10:17 ` [PATCH RESEND 2/4] hwtracing: Add tune " Yicong Yang 2021-04-17 10:17 ` Yicong Yang 2021-04-17 10:17 ` [PATCH RESEND 3/4] docs: Add HiSilicon PTT device driver documentation Yicong Yang 2021-04-17 10:17 ` Yicong Yang 2021-04-19 9:07 ` Daniel Thompson 2021-04-19 9:07 ` Daniel Thompson 2021-04-19 13:12 ` Yicong Yang [this message] 2021-04-19 13:12 ` Yicong Yang 2021-04-17 10:17 ` [PATCH RESEND 4/4] MAINTAINERS: Add maintainer for HiSilicon PTT driver Yicong Yang 2021-04-17 10:17 ` Yicong Yang 2021-04-17 13:56 ` [PATCH RESEND 0/4] Add support for HiSilicon PCIe Tune and Trace device Alexander Shishkin 2021-04-17 13:56 ` Alexander Shishkin 2021-04-19 13:03 ` Yicong Yang 2021-04-19 13:03 ` Yicong Yang 2021-04-22 3:49 ` Leo Yan 2021-04-22 3:49 ` Leo Yan 2021-04-22 12:54 ` Yicong Yang 2021-04-22 12:54 ` Yicong Yang 2021-04-19 11:17 ` Suzuki K Poulose 2021-04-19 11:17 ` Suzuki K Poulose 2021-04-19 13:21 ` Yicong Yang 2021-04-19 13:21 ` Yicong Yang 2021-04-19 16:11 ` Suzuki K Poulose 2021-04-19 16:11 ` Suzuki K Poulose
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=e884000f-3131-490b-eb0c-bc82ed642a85@hisilicon.com \ --to=yangyicong@hisilicon.com \ --cc=alexander.shishkin@linux.intel.com \ --cc=coresight@lists.linaro.org \ --cc=daniel.thompson@linaro.org \ --cc=gregkh@linuxfoundation.org \ --cc=helgaas@kernel.org \ --cc=john.garry@huawei.com \ --cc=jonathan.cameron@huawei.com \ --cc=leo.yan@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=linuxarm@huawei.com \ --cc=liuqi115@huawei.com \ --cc=lorenzo.pieralisi@arm.com \ --cc=mark.rutland@arm.com \ --cc=mathieu.poirier@linaro.org \ --cc=mike.leach@linaro.org \ --cc=prime.zeng@huawei.com \ --cc=song.bao.hua@hisilicon.com \ --cc=suzuki.poulose@arm.com \ --cc=will@kernel.org \ --cc=zhangshaokun@hisilicon.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.