* Re: [PATCH v2 5/7] include: dt-bindings: sound: Add sc7180-lpass bindings header
@ 2020-05-18 9:22 ` Srinivas Kandagatla
0 siblings, 0 replies; 6+ messages in thread
From: Srinivas Kandagatla @ 2020-05-18 9:22 UTC (permalink / raw)
To: Ajit Pandey, broonie, plai, bgoswami; +Cc: alsa-devel, devicetree, linux-kernel
On 14/05/2020 17:38, Ajit Pandey wrote:
> Add header defining dai-id and mclk id for SC7180 lpass soc.
>
> Signed-off-by: Ajit Pandey <ajitp@codeaurora.org>
> ---
> include/dt-bindings/sound/sc7180-lpass.h | 10 ++++++++++
Why not reuse or rename include/dt-bindings/sound/apq8016-lpass.h to
include/dt-bindings/sound/lpass.h and reuse across all the LPASS variants?
--srini
> 1 file changed, 10 insertions(+)
> create mode 100644 include/dt-bindings/sound/sc7180-lpass.h
>
> diff --git a/include/dt-bindings/sound/sc7180-lpass.h b/include/dt-bindings/sound/sc7180-lpass.h
> new file mode 100644
> index 0000000..7d988f6
> --- /dev/null
> +++ b/include/dt-bindings/sound/sc7180-lpass.h
> @@ -0,0 +1,10 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +#ifndef __DT_SC7180_LPASS_H
> +#define __DT_SC7180_LPASS_H
> +
> +#define MI2S_PRIMARY 0
> +#define MI2S_SECONDARY 1
> +
> +#define LPASS_MCLK0 0
> +
> +#endif /* __DT_APQ8016_LPASS_H */
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 5/7] include: dt-bindings: sound: Add sc7180-lpass bindings header
@ 2020-05-18 9:22 ` Srinivas Kandagatla
0 siblings, 0 replies; 6+ messages in thread
From: Srinivas Kandagatla @ 2020-05-18 9:22 UTC (permalink / raw)
To: Ajit Pandey, broonie, plai, bgoswami; +Cc: devicetree, alsa-devel, linux-kernel
On 14/05/2020 17:38, Ajit Pandey wrote:
> Add header defining dai-id and mclk id for SC7180 lpass soc.
>
> Signed-off-by: Ajit Pandey <ajitp@codeaurora.org>
> ---
> include/dt-bindings/sound/sc7180-lpass.h | 10 ++++++++++
Why not reuse or rename include/dt-bindings/sound/apq8016-lpass.h to
include/dt-bindings/sound/lpass.h and reuse across all the LPASS variants?
--srini
> 1 file changed, 10 insertions(+)
> create mode 100644 include/dt-bindings/sound/sc7180-lpass.h
>
> diff --git a/include/dt-bindings/sound/sc7180-lpass.h b/include/dt-bindings/sound/sc7180-lpass.h
> new file mode 100644
> index 0000000..7d988f6
> --- /dev/null
> +++ b/include/dt-bindings/sound/sc7180-lpass.h
> @@ -0,0 +1,10 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +#ifndef __DT_SC7180_LPASS_H
> +#define __DT_SC7180_LPASS_H
> +
> +#define MI2S_PRIMARY 0
> +#define MI2S_SECONDARY 1
> +
> +#define LPASS_MCLK0 0
> +
> +#endif /* __DT_APQ8016_LPASS_H */
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 5/7] include: dt-bindings: sound: Add sc7180-lpass bindings header
@ 2020-05-16 18:14 ` Ajit Pandey
0 siblings, 0 replies; 6+ messages in thread
From: Ajit Pandey @ 2020-05-16 18:14 UTC (permalink / raw)
To: Mark Brown
Cc: plai, bgoswami, srinivas.kandagatla, alsa-devel, devicetree,
linux-kernel
On 5/14/2020 10:18 PM, Mark Brown wrote:
> On Thu, May 14, 2020 at 10:08:16PM +0530, Ajit Pandey wrote:
>
>> +#define MI2S_PRIMARY 0
>> +#define MI2S_SECONDARY 1
>> +
>> +#define LPASS_MCLK0 0
> These look like they could use namespacing. Is primary/secondary
> perhaps something that could be a boolean property?
Primary/secondary is a dai id and can be from 0-4 (SC7180 soc driver
support only 0-1 at present). Such id is mainly used in dtsi and machine
driver to do dai id based configuration for a soc hence we placed them
in dt headers file for now.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 5/7] include: dt-bindings: sound: Add sc7180-lpass bindings header
@ 2020-05-16 18:14 ` Ajit Pandey
0 siblings, 0 replies; 6+ messages in thread
From: Ajit Pandey @ 2020-05-16 18:14 UTC (permalink / raw)
To: Mark Brown
Cc: devicetree, alsa-devel, bgoswami, plai, linux-kernel,
srinivas.kandagatla
On 5/14/2020 10:18 PM, Mark Brown wrote:
> On Thu, May 14, 2020 at 10:08:16PM +0530, Ajit Pandey wrote:
>
>> +#define MI2S_PRIMARY 0
>> +#define MI2S_SECONDARY 1
>> +
>> +#define LPASS_MCLK0 0
> These look like they could use namespacing. Is primary/secondary
> perhaps something that could be a boolean property?
Primary/secondary is a dai id and can be from 0-4 (SC7180 soc driver
support only 0-1 at present). Such id is mainly used in dtsi and machine
driver to do dai id based configuration for a soc hence we placed them
in dt headers file for now.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 5/7] include: dt-bindings: sound: Add sc7180-lpass bindings header
2020-05-14 16:38 ` [PATCH v2 5/7] include: dt-bindings: sound: Add sc7180-lpass bindings header Ajit Pandey
@ 2020-05-14 16:48 ` Mark Brown
0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2020-05-14 16:48 UTC (permalink / raw)
To: Ajit Pandey
Cc: devicetree, alsa-devel, bgoswami, plai, linux-kernel,
srinivas.kandagatla
[-- Attachment #1: Type: text/plain, Size: 264 bytes --]
On Thu, May 14, 2020 at 10:08:16PM +0530, Ajit Pandey wrote:
> +#define MI2S_PRIMARY 0
> +#define MI2S_SECONDARY 1
> +
> +#define LPASS_MCLK0 0
These look like they could use namespacing. Is primary/secondary
perhaps something that could be a boolean property?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 5/7] include: dt-bindings: sound: Add sc7180-lpass bindings header
2020-05-14 16:38 ` [PATCH v2 0/7] ASoC: QCOM: Add support for SC7180 lpass variant Ajit Pandey
@ 2020-05-14 16:38 ` Ajit Pandey
2020-05-14 16:48 ` Mark Brown
0 siblings, 1 reply; 6+ messages in thread
From: Ajit Pandey @ 2020-05-14 16:38 UTC (permalink / raw)
To: broonie, plai, bgoswami, srinivas.kandagatla
Cc: devicetree, alsa-devel, linux-kernel, Ajit Pandey
Add header defining dai-id and mclk id for SC7180 lpass soc.
Signed-off-by: Ajit Pandey <ajitp@codeaurora.org>
---
include/dt-bindings/sound/sc7180-lpass.h | 10 ++++++++++
1 file changed, 10 insertions(+)
create mode 100644 include/dt-bindings/sound/sc7180-lpass.h
diff --git a/include/dt-bindings/sound/sc7180-lpass.h b/include/dt-bindings/sound/sc7180-lpass.h
new file mode 100644
index 0000000..7d988f6
--- /dev/null
+++ b/include/dt-bindings/sound/sc7180-lpass.h
@@ -0,0 +1,10 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+#ifndef __DT_SC7180_LPASS_H
+#define __DT_SC7180_LPASS_H
+
+#define MI2S_PRIMARY 0
+#define MI2S_SECONDARY 1
+
+#define LPASS_MCLK0 0
+
+#endif /* __DT_APQ8016_LPASS_H */
--
('The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project')
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-05-18 9:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-18 9:22 [PATCH v2 5/7] include: dt-bindings: sound: Add sc7180-lpass bindings header Srinivas Kandagatla
2020-05-18 9:22 ` Srinivas Kandagatla
-- strict thread matches above, loose matches on Subject: below --
2020-05-16 18:14 Ajit Pandey
2020-05-16 18:14 ` Ajit Pandey
[not found] <“1586592171-31644-1-git-send-email-ajitp@codeaurora.org”>
2020-05-14 16:38 ` [PATCH v2 0/7] ASoC: QCOM: Add support for SC7180 lpass variant Ajit Pandey
2020-05-14 16:38 ` [PATCH v2 5/7] include: dt-bindings: sound: Add sc7180-lpass bindings header Ajit Pandey
2020-05-14 16:48 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.