All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Julia Lawall <julia.lawall@lip6.fr>,
	Himanshu Jha <himanshujha199640@gmail.com>,
	Linus Torvalds <torvalds@linuxfoundation.org>,
	<kernel-janitors@vger.kernel.org>, Arnd Bergmann <arnd@arndb.de>,
	<tglx@linutronix.de>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] coccinelle: api/devm_platform_ioremap_resource: remove useless script
Date: Thu, 17 Oct 2019 17:13:47 +0100	[thread overview]
Message-ID: <e895d04ef5a282b5b48fcb21cbc175d2@www.loen.fr> (raw)
In-Reply-To: <20191017142237.9734-1-alexandre.belloni@bootlin.com>

On 2019-10-17 15:22, Alexandre Belloni wrote:
> While it is useful for new drivers to use 
> devm_platform_ioremap_resource,
> this script is currently used to spam maintainers, often updating 
> very old
> drivers. The net benefit is the removal of 2 lines of code in the 
> driver
> but the review load for the maintainers is huge. As of now, more that 
> 560
> patches have been sent, some of them obviously broken, as in:
>
> 
> https://lore.kernel.org/lkml/9bbcce19c777583815c92ce3c2ff2586@www.loen.fr/
>
> Remove the script to reduce the spam.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

I think part of the issue is that the script reports a WARNING for 
something
that is definitely correct code, and could instead be simply toned 
down.

Anyway, FWIW:

Acked-by: Marc Zyngier <maz@kernel.org>

         M.
-- 
Jazz is not dead. It just smells funny...

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Julia Lawall <julia.lawall@lip6.fr>,
	Himanshu Jha <himanshujha199640@gmail.com>,
	Linus Torvalds <torvalds@linuxfoundation.org>,
	kernel-janitors@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] coccinelle: api/devm_platform_ioremap  =?UTF-8?Q?=5Fresource=3A=20remove
Date: Thu, 17 Oct 2019 16:13:47 +0000	[thread overview]
Message-ID: <e895d04ef5a282b5b48fcb21cbc175d2@www.loen.fr> (raw)
In-Reply-To: <20191017142237.9734-1-alexandre.belloni@bootlin.com>

On 2019-10-17 15:22, Alexandre Belloni wrote:
> While it is useful for new drivers to use 
> devm_platform_ioremap_resource,
> this script is currently used to spam maintainers, often updating 
> very old
> drivers. The net benefit is the removal of 2 lines of code in the 
> driver
> but the review load for the maintainers is huge. As of now, more that 
> 560
> patches have been sent, some of them obviously broken, as in:
>
> 
> https://lore.kernel.org/lkml/9bbcce19c777583815c92ce3c2ff2586@www.loen.fr/
>
> Remove the script to reduce the spam.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

I think part of the issue is that the script reports a WARNING for 
something
that is definitely correct code, and could instead be simply toned 
down.

Anyway, FWIW:

Acked-by: Marc Zyngier <maz@kernel.org>

         M.
-- 
Jazz is not dead. It just smells funny...

  parent reply	other threads:[~2019-10-17 16:13 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-17 14:22 [PATCH] coccinelle: api/devm_platform_ioremap_resource: remove useless script Alexandre Belloni
2019-10-17 14:22 ` Alexandre Belloni
2019-10-17 14:34 ` Julia Lawall
2019-10-17 14:34   ` Julia Lawall
2019-10-17 16:13 ` Marc Zyngier [this message]
2019-10-17 16:13   ` [PATCH] coccinelle: api/devm_platform_ioremap =?UTF-8?Q?=5Fresource=3A=20remove Marc Zyngier
2019-10-19 11:35   ` coccinelle: api/devm_platform_ioremap_resource: remove useless script Markus Elfring
2019-10-19 11:35     ` [Cocci] " Markus Elfring
2019-10-19 11:35     ` Markus Elfring
2019-10-19 20:43     ` Marc Zyngier
2019-10-19 20:43       ` [Cocci] " Marc Zyngier
2019-10-19 20:43       ` Marc Zyngier
2019-10-19 22:13       ` Joe Perches
2019-10-19 22:13         ` [Cocci] " Joe Perches
2019-10-19 22:13         ` Joe Perches
2019-10-24 15:40         ` Masahiro Yamada
2019-10-24 15:40           ` [Cocci] " Masahiro Yamada
2019-10-24 15:40           ` Masahiro Yamada
2019-10-24 18:30           ` Markus Elfring
2019-10-24 18:30             ` [Cocci] " Markus Elfring
2019-10-24 18:30             ` Markus Elfring
2019-10-25  8:08           ` Andy Shevchenko
2019-10-25  8:08             ` [Cocci] " Andy Shevchenko
2019-10-25  8:08             ` Andy Shevchenko
2019-10-25  8:38             ` Julia Lawall
2019-10-25  8:38               ` [Cocci] " Julia Lawall
2019-10-25  8:38               ` Julia Lawall
2019-10-29  2:58               ` Masahiro Yamada
2019-10-29  2:58                 ` [Cocci] " Masahiro Yamada
2019-10-29  2:58                 ` Masahiro Yamada
2019-10-29  8:55                 ` Julia Lawall
2019-10-29  8:55                   ` [Cocci] " Julia Lawall
2019-10-29  8:55                   ` Julia Lawall
2019-10-20  5:38       ` Julia Lawall
2019-10-20  5:38         ` [Cocci] " Julia Lawall
2019-10-20  5:38         ` Julia Lawall
2019-10-20  9:34         ` Marc Zyngier
2019-10-20  9:34           ` [Cocci] " Marc Zyngier
2019-10-20  9:34           ` Marc Zyngier
2019-10-20  5:45       ` Markus Elfring
2019-10-20  5:45         ` [Cocci] " Markus Elfring
2019-10-20  5:45         ` Markus Elfring
2019-10-19  9:00 ` [PATCH] " Markus Elfring
2019-10-19  9:00   ` [Cocci] " Markus Elfring
2019-10-19  9:00   ` Markus Elfring
2019-10-19 12:09   ` Alexandre Belloni
2019-10-19 12:09     ` [Cocci] " Alexandre Belloni
2019-10-19 12:09     ` Alexandre Belloni
2019-10-19 14:06     ` Markus Elfring
2019-10-19 14:06       ` [Cocci] " Markus Elfring
2019-10-19 14:06       ` Markus Elfring
2019-10-19 14:29     ` [PATCH] " Bartosz Golaszewski
2019-10-19 14:29       ` [Cocci] " Bartosz Golaszewski
2019-10-19 14:29       ` Bartosz Golaszewski
2019-10-19 16:36       ` Markus Elfring
2019-10-19 16:36         ` [Cocci] " Markus Elfring
2019-10-19 16:36         ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e895d04ef5a282b5b48fcb21cbc175d2@www.loen.fr \
    --to=maz@kernel.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=arnd@arndb.de \
    --cc=himanshujha199640@gmail.com \
    --cc=julia.lawall@lip6.fr \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.