All of lore.kernel.org
 help / color / mirror / Atom feed
From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Arnd Bergmann <arnd@kernel.org>, Will Deacon <will@kernel.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Arnd Bergmann <arnd@arndb.de>, Marc Zyngier <maz@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	David Brazdil <dbrazdil@google.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Catalin Marinas <catalin.marinas@arm.com>
Subject: Re: [PATCH] [RFC] arm64: export this_cpu_has_cap
Date: Tue, 2 Nov 2021 23:16:30 +0000	[thread overview]
Message-ID: <e8fa9099-ec4c-d6c5-ce40-1b98ed11005c@arm.com> (raw)
In-Reply-To: <YXw4H2BNx85KnLDh@arm.com>

Arnd


On 29/10/2021 19:06, Catalin Marinas wrote:
> On Fri, Oct 29, 2021 at 02:31:23PM +0100, Suzuki K Poulose wrote:
>> On 29/10/2021 12:30, Arnd Bergmann wrote:
>>> From: Arnd Bergmann <arnd@arndb.de>
>>>
>>> It's now used in a coresight driver that can be a loadable module:
>>>
>>> ERROR: modpost: "this_cpu_has_cap" [drivers/hwtracing/coresight/coresight-trbe.ko] undefined!
>>>
>>> Fixes: 8a1065127d95 ("coresight: trbe: Add infrastructure for Errata handling")
>>
>> Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
>> Tested-by: Suzuki K Poulose <suzuki.poulose@arm.com>
>>
>> Will, Catalin, Mathieu,
>>
>> Do you have a preference on how this fix can be pulled in ? This may
>> be safe to go via coresight tree if it is not too late. Otherwise,
>> it could go via the arm64 tree.
> 
> I think Will already closed/tagged the arm64 tree for the upcoming
> merging window, though he could take it as a fix afterwards.
> 
> If it doesn't conflict with the arm64 for-next/core, it's fine by me to
> go through the coresight tree.
> 
>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>> ---
>>> Not sure if we actually want this to be exported, this is my local
>>> workaround for the randconfig build bot.
>>> ---
>>>    arch/arm64/kernel/cpufeature.c | 1 +
>>>    1 file changed, 1 insertion(+)
>>>
>>> diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c
>>> index ecbdff795f5e..beccbcfa7391 100644
>>> --- a/arch/arm64/kernel/cpufeature.c
>>> +++ b/arch/arm64/kernel/cpufeature.c
>>> @@ -2864,6 +2864,7 @@ bool this_cpu_has_cap(unsigned int n)
>>>    	return false;
>>>    }
>>> +EXPORT_SYMBOL(this_cpu_has_cap);
> 
> EXPORT_SYMBOL_GPL? I think this_cpu_has_cap() is a bit more more
> specialised than cpus_have_const_cap().
> 
> With that:
> 
> Acked-by: Catalin Marinas <catalin.marinas@arm.com>
> 

Do you plan to send an updated patch with above ?

Suzuki



WARNING: multiple messages have this Message-ID (diff)
From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Arnd Bergmann <arnd@kernel.org>, Will Deacon <will@kernel.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Arnd Bergmann <arnd@arndb.de>, Marc Zyngier <maz@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	David Brazdil <dbrazdil@google.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Catalin Marinas <catalin.marinas@arm.com>
Subject: Re: [PATCH] [RFC] arm64: export this_cpu_has_cap
Date: Tue, 2 Nov 2021 23:16:30 +0000	[thread overview]
Message-ID: <e8fa9099-ec4c-d6c5-ce40-1b98ed11005c@arm.com> (raw)
In-Reply-To: <YXw4H2BNx85KnLDh@arm.com>

Arnd


On 29/10/2021 19:06, Catalin Marinas wrote:
> On Fri, Oct 29, 2021 at 02:31:23PM +0100, Suzuki K Poulose wrote:
>> On 29/10/2021 12:30, Arnd Bergmann wrote:
>>> From: Arnd Bergmann <arnd@arndb.de>
>>>
>>> It's now used in a coresight driver that can be a loadable module:
>>>
>>> ERROR: modpost: "this_cpu_has_cap" [drivers/hwtracing/coresight/coresight-trbe.ko] undefined!
>>>
>>> Fixes: 8a1065127d95 ("coresight: trbe: Add infrastructure for Errata handling")
>>
>> Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
>> Tested-by: Suzuki K Poulose <suzuki.poulose@arm.com>
>>
>> Will, Catalin, Mathieu,
>>
>> Do you have a preference on how this fix can be pulled in ? This may
>> be safe to go via coresight tree if it is not too late. Otherwise,
>> it could go via the arm64 tree.
> 
> I think Will already closed/tagged the arm64 tree for the upcoming
> merging window, though he could take it as a fix afterwards.
> 
> If it doesn't conflict with the arm64 for-next/core, it's fine by me to
> go through the coresight tree.
> 
>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>> ---
>>> Not sure if we actually want this to be exported, this is my local
>>> workaround for the randconfig build bot.
>>> ---
>>>    arch/arm64/kernel/cpufeature.c | 1 +
>>>    1 file changed, 1 insertion(+)
>>>
>>> diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c
>>> index ecbdff795f5e..beccbcfa7391 100644
>>> --- a/arch/arm64/kernel/cpufeature.c
>>> +++ b/arch/arm64/kernel/cpufeature.c
>>> @@ -2864,6 +2864,7 @@ bool this_cpu_has_cap(unsigned int n)
>>>    	return false;
>>>    }
>>> +EXPORT_SYMBOL(this_cpu_has_cap);
> 
> EXPORT_SYMBOL_GPL? I think this_cpu_has_cap() is a bit more more
> specialised than cpus_have_const_cap().
> 
> With that:
> 
> Acked-by: Catalin Marinas <catalin.marinas@arm.com>
> 

Do you plan to send an updated patch with above ?

Suzuki



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-11-02 23:16 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-29 11:30 [PATCH] [RFC] arm64: export this_cpu_has_cap Arnd Bergmann
2021-10-29 11:30 ` Arnd Bergmann
2021-10-29 13:31 ` Suzuki K Poulose
2021-10-29 13:31   ` Suzuki K Poulose
2021-10-29 15:12   ` Mathieu Poirier
2021-10-29 15:12     ` Mathieu Poirier
2021-10-29 18:06   ` Catalin Marinas
2021-10-29 18:06     ` Catalin Marinas
2021-11-01  9:01     ` Will Deacon
2021-11-01  9:01       ` Will Deacon
2021-11-01  9:34       ` Suzuki K Poulose
2021-11-01  9:34         ` Suzuki K Poulose
2021-11-01  9:40         ` Will Deacon
2021-11-01  9:40           ` Will Deacon
2021-11-01  9:52           ` Suzuki K Poulose
2021-11-01  9:52             ` Suzuki K Poulose
2021-11-01 11:13             ` Greg Kroah-Hartman
2021-11-01 11:13               ` Greg Kroah-Hartman
2021-11-01 15:32               ` Mathieu Poirier
2021-11-01 15:32                 ` Mathieu Poirier
2021-11-02 23:16     ` Suzuki K Poulose [this message]
2021-11-02 23:16       ` Suzuki K Poulose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e8fa9099-ec4c-d6c5-ce40-1b98ed11005c@arm.com \
    --to=suzuki.poulose@arm.com \
    --cc=anshuman.khandual@arm.com \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=dbrazdil@google.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mathieu.poirier@linaro.org \
    --cc=maz@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.