* [PATCH] serial: 8250_bcm7271: use NULL to initialized a null pointer
@ 2021-07-19 9:55 Colin King
2021-07-19 23:45 ` Florian Fainelli
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2021-07-19 9:55 UTC (permalink / raw)
To: Al Cooper, Jiri Slaby, linux-serial, bcm-kernel-feedback-list
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Pointer membase is currently being in initialized with zero rather
than NULL. Fix this.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/tty/serial/8250/8250_bcm7271.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/8250/8250_bcm7271.c b/drivers/tty/serial/8250/8250_bcm7271.c
index 725a450058f8..7f656fac503f 100644
--- a/drivers/tty/serial/8250/8250_bcm7271.c
+++ b/drivers/tty/serial/8250/8250_bcm7271.c
@@ -941,7 +941,7 @@ static int brcmuart_probe(struct platform_device *pdev)
struct clk *baud_mux_clk;
struct uart_8250_port up;
struct resource *irq;
- void __iomem *membase = 0;
+ void __iomem *membase = NULL;
resource_size_t mapbase = 0;
u32 clk_rate = 0;
int ret;
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] serial: 8250_bcm7271: use NULL to initialized a null pointer
2021-07-19 9:55 [PATCH] serial: 8250_bcm7271: use NULL to initialized a null pointer Colin King
@ 2021-07-19 23:45 ` Florian Fainelli
0 siblings, 0 replies; 2+ messages in thread
From: Florian Fainelli @ 2021-07-19 23:45 UTC (permalink / raw)
To: Colin King, Al Cooper, Jiri Slaby, linux-serial,
bcm-kernel-feedback-list
Cc: kernel-janitors, linux-kernel
On 7/19/21 2:55 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Pointer membase is currently being in initialized with zero rather
> than NULL. Fix this.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-20 2:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-19 9:55 [PATCH] serial: 8250_bcm7271: use NULL to initialized a null pointer Colin King
2021-07-19 23:45 ` Florian Fainelli
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.