All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Beulich <JBeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Wei Liu <wl@xen.org>, RogerPau Monne <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH v9 11/23] x86emul: support of AVX512* population count insns
Date: Thu, 4 Jul 2019 14:54:41 +0000	[thread overview]
Message-ID: <e95d1c2c-feea-b8cc-0fca-a005668f269f@suse.com> (raw)
In-Reply-To: <3240eb2e-ff32-bfc6-fa49-0cc8bb84582d@citrix.com>

On 04.07.2019 16:47, Andrew Cooper wrote:
> On 01/07/2019 12:22, Jan Beulich wrote:
>> --- a/xen/tools/gen-cpuid.py
>> +++ b/xen/tools/gen-cpuid.py
>> @@ -268,7 +268,7 @@ def crunch_numbers(state):
>>            # AVX512 extensions acting on vectors of bytes/words are made
>>            # dependents of AVX512BW (as to requiring wider than 16-bit mask
>>            # registers), despite the SDM not formally making this connection.
>> -        AVX512BW: [AVX512_BF16, AVX512_VBMI, AVX512_VBMI2],
>> +        AVX512BW: [AVX512_BF16, AVX512_BITALG, AVX512_VBMI, AVX512_VBMI2],
> 
> BITALG should be after VBMI2, because everything in this table is
> ordered by bit number.

As said before - there's no ordering by bit number possible here.
The individual features may live on different (sub)leaves. By
what you say BF16 shouldn't be first. The list here clearly is
sorted alphabetically, and imo that's the only future proof sorting
possible (and also for AVX512F, where I had previously offered to
put together a patch to switch to alphabetical ordering, if only we
could agree on that).

> With this fixed, Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

As per above I'm not going to apply this without hearing back from
you.

Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2019-07-04 14:59 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-01 11:13 [Xen-devel] [PATCH v9 00/23] x86emul: remaining AVX512 support Jan Beulich
2019-07-01 11:16 ` [Xen-devel] [PATCH v9 01/23] x86emul: support AVX512{F, _VBMI2} compress/expand insns Jan Beulich
2019-07-04 13:12   ` Andrew Cooper
2019-07-01 11:17 ` [Xen-devel] [PATCH v9 02/23] x86emul: support remaining misc AVX512{F, BW} insns Jan Beulich
2019-07-01 11:17 ` [Xen-devel] [PATCH v9 03/23] x86emul: prepare for AVX512F S/G insns Jan Beulich
2019-07-04 13:50   ` Andrew Cooper
2019-07-01 11:18 ` [Xen-devel] [PATCH v9 04/23] x86emul: test harness adjustments " Jan Beulich
2019-07-04 13:52   ` Andrew Cooper
2019-07-01 11:18 ` [Xen-devel] [PATCH v9 05/23] x86emul: support AVX512F gather insns Jan Beulich
2019-07-04 14:10   ` Andrew Cooper
2019-07-04 14:16     ` Andrew Cooper
2019-07-04 14:25       ` Jan Beulich
2019-07-04 18:26         ` Andrew Cooper
2019-07-04 14:22     ` Jan Beulich
2019-07-04 18:40       ` Andrew Cooper
2019-07-01 11:19 ` [Xen-devel] [PATCH v9 06/23] x86emul: add high register S/G test cases Jan Beulich
2019-07-01 11:20 ` [Xen-devel] [PATCH v9 07/23] x86emul: support AVX512F scatter insns Jan Beulich
2019-07-04 14:19   ` Andrew Cooper
2019-07-01 11:20 ` [Xen-devel] [PATCH v9 08/23] x86emul: support AVX512PF insns Jan Beulich
2019-07-04 14:44   ` Andrew Cooper
2019-07-04 14:50     ` Jan Beulich
2019-07-04 18:29       ` Andrew Cooper
2019-07-01 11:21 ` [Xen-devel] [PATCH v9 09/23] x86emul: support AVX512CD insns Jan Beulich
2019-07-01 11:21 ` [Xen-devel] [PATCH v9 10/23] x86emul: complete support of AVX512_VBMI insns Jan Beulich
2019-07-01 11:22 ` [Xen-devel] [PATCH v9 11/23] x86emul: support of AVX512* population count insns Jan Beulich
2019-07-04 14:47   ` Andrew Cooper
2019-07-04 14:54     ` Jan Beulich [this message]
2019-07-04 18:38       ` Andrew Cooper
2019-07-05  8:10         ` Jan Beulich
2019-07-01 11:22 ` [Xen-devel] [PATCH v9 12/23] x86emul: support of AVX512_IFMA insns Jan Beulich
2019-07-01 11:23 ` [Xen-devel] [PATCH v9 13/23] x86emul: support remaining AVX512_VBMI2 insns Jan Beulich
2019-07-01 11:23 ` [Xen-devel] [PATCH v9 14/23] x86emul: support AVX512_4FMAPS insns Jan Beulich
2019-07-04 14:49   ` Andrew Cooper
2019-07-01 11:24 ` [Xen-devel] [PATCH v9 15/23] x86emul: support AVX512_4VNNIW insns Jan Beulich
2019-07-01 11:24 ` [Xen-devel] [PATCH v9 16/23] x86emul: support AVX512_VNNI insns Jan Beulich
2019-07-04 14:50   ` Andrew Cooper
2019-07-01 11:25 ` [Xen-devel] [PATCH v9 17/23] x86emul: support VPCLMULQDQ insns Jan Beulich
2019-07-01 11:25 ` [Xen-devel] [PATCH v9 18/23] x86emul: support VAES insns Jan Beulich
2019-07-01 11:26 ` [Xen-devel] [PATCH v9 19/23] x86emul: support GFNI insns Jan Beulich
2019-07-04 15:10   ` Andrew Cooper
2019-07-01 11:26 ` [Xen-devel] [PATCH v9 20/23] x86emul: restore ordering within main switch statement Jan Beulich
2019-07-01 11:27 ` [Xen-devel] [PATCH v9 21/23] x86emul: add an AES/VAES test case to the harness Jan Beulich
2019-07-01 11:28 ` [Xen-devel] [PATCH v9 22/23] x86emul: add a SHA " Jan Beulich
2019-07-01 11:28 ` [Xen-devel] [PATCH v9 23/23] x86emul: support VPCLMULQDQ insns Jan Beulich
2019-07-03 16:05 ` [Xen-devel] [PATCH v9 00/23] x86emul: remaining AVX512 support Jan Beulich
2019-07-03 16:06 ` [Xen-devel] [PATCH v9 23/23] x86emul: add a PCLMUL/VPCLMUL test case to the harness Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e95d1c2c-feea-b8cc-0fca-a005668f269f@suse.com \
    --to=jbeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=roger.pau@citrix.com \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.