From: Joe Perches <joe@perches.com> To: Jiri Kosina <trivial@kernel.org>, Patrik Jakobsson <patrik.r.jakobsson@gmail.com> Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 09/29] drm/gma500: Avoid comma separated statements Date: Mon, 24 Aug 2020 21:56:06 -0700 [thread overview] Message-ID: <e96626cd1301ff44e5101e0e5913d8439b425c9f.1598331148.git.joe@perches.com> (raw) In-Reply-To: <cover.1598331148.git.joe@perches.com> Use semicolons and braces. Signed-off-by: Joe Perches <joe@perches.com> --- drivers/gpu/drm/gma500/mdfld_intel_display.c | 44 +++++++++++++------- 1 file changed, 28 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/gma500/mdfld_intel_display.c b/drivers/gpu/drm/gma500/mdfld_intel_display.c index aae2d358364c..bfa330df9443 100644 --- a/drivers/gpu/drm/gma500/mdfld_intel_display.c +++ b/drivers/gpu/drm/gma500/mdfld_intel_display.c @@ -824,33 +824,45 @@ static int mdfld_crtc_mode_set(struct drm_crtc *crtc, if ((ksel == KSEL_CRYSTAL_19) || (ksel == KSEL_BYPASS_19)) { refclk = 19200; - if (is_mipi || is_mipi2) - clk_n = 1, clk_p2 = 8; - else if (is_hdmi) - clk_n = 1, clk_p2 = 10; + if (is_mipi || is_mipi2) { + clk_n = 1; + clk_p2 = 8; + } else if (is_hdmi) { + clk_n = 1; + clk_p2 = 10; + } } else if (ksel == KSEL_BYPASS_25) { refclk = 25000; - if (is_mipi || is_mipi2) - clk_n = 1, clk_p2 = 8; - else if (is_hdmi) - clk_n = 1, clk_p2 = 10; + if (is_mipi || is_mipi2) { + clk_n = 1; + clk_p2 = 8; + } else if (is_hdmi) { + clk_n = 1; + clk_p2 = 10; + } } else if ((ksel == KSEL_BYPASS_83_100) && dev_priv->core_freq == 166) { refclk = 83000; - if (is_mipi || is_mipi2) - clk_n = 4, clk_p2 = 8; - else if (is_hdmi) - clk_n = 4, clk_p2 = 10; + if (is_mipi || is_mipi2) { + clk_n = 4; + clk_p2 = 8; + } else if (is_hdmi) { + clk_n = 4; + clk_p2 = 10; + } } else if ((ksel == KSEL_BYPASS_83_100) && (dev_priv->core_freq == 100 || dev_priv->core_freq == 200)) { refclk = 100000; - if (is_mipi || is_mipi2) - clk_n = 4, clk_p2 = 8; - else if (is_hdmi) - clk_n = 4, clk_p2 = 10; + if (is_mipi || is_mipi2) { + clk_n = 4; + clk_p2 = 8; + } else if (is_hdmi) { + clk_n = 4; + clk_p2 = 10; + } } if (is_mipi) -- 2.26.0
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com> To: Jiri Kosina <trivial@kernel.org>, Patrik Jakobsson <patrik.r.jakobsson@gmail.com> Cc: David Airlie <airlied@linux.ie>, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 09/29] drm/gma500: Avoid comma separated statements Date: Mon, 24 Aug 2020 21:56:06 -0700 [thread overview] Message-ID: <e96626cd1301ff44e5101e0e5913d8439b425c9f.1598331148.git.joe@perches.com> (raw) In-Reply-To: <cover.1598331148.git.joe@perches.com> Use semicolons and braces. Signed-off-by: Joe Perches <joe@perches.com> --- drivers/gpu/drm/gma500/mdfld_intel_display.c | 44 +++++++++++++------- 1 file changed, 28 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/gma500/mdfld_intel_display.c b/drivers/gpu/drm/gma500/mdfld_intel_display.c index aae2d358364c..bfa330df9443 100644 --- a/drivers/gpu/drm/gma500/mdfld_intel_display.c +++ b/drivers/gpu/drm/gma500/mdfld_intel_display.c @@ -824,33 +824,45 @@ static int mdfld_crtc_mode_set(struct drm_crtc *crtc, if ((ksel == KSEL_CRYSTAL_19) || (ksel == KSEL_BYPASS_19)) { refclk = 19200; - if (is_mipi || is_mipi2) - clk_n = 1, clk_p2 = 8; - else if (is_hdmi) - clk_n = 1, clk_p2 = 10; + if (is_mipi || is_mipi2) { + clk_n = 1; + clk_p2 = 8; + } else if (is_hdmi) { + clk_n = 1; + clk_p2 = 10; + } } else if (ksel == KSEL_BYPASS_25) { refclk = 25000; - if (is_mipi || is_mipi2) - clk_n = 1, clk_p2 = 8; - else if (is_hdmi) - clk_n = 1, clk_p2 = 10; + if (is_mipi || is_mipi2) { + clk_n = 1; + clk_p2 = 8; + } else if (is_hdmi) { + clk_n = 1; + clk_p2 = 10; + } } else if ((ksel == KSEL_BYPASS_83_100) && dev_priv->core_freq == 166) { refclk = 83000; - if (is_mipi || is_mipi2) - clk_n = 4, clk_p2 = 8; - else if (is_hdmi) - clk_n = 4, clk_p2 = 10; + if (is_mipi || is_mipi2) { + clk_n = 4; + clk_p2 = 8; + } else if (is_hdmi) { + clk_n = 4; + clk_p2 = 10; + } } else if ((ksel == KSEL_BYPASS_83_100) && (dev_priv->core_freq == 100 || dev_priv->core_freq == 200)) { refclk = 100000; - if (is_mipi || is_mipi2) - clk_n = 4, clk_p2 = 8; - else if (is_hdmi) - clk_n = 4, clk_p2 = 10; + if (is_mipi || is_mipi2) { + clk_n = 4; + clk_p2 = 8; + } else if (is_hdmi) { + clk_n = 4; + clk_p2 = 10; + } } if (is_mipi) -- 2.26.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-08-25 4:59 UTC|newest] Thread overview: 135+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-25 4:55 [PATCH 00/29] treewide: Convert comma separated statements Joe Perches 2020-08-25 4:55 ` Joe Perches 2020-08-25 4:55 ` [Intel-gfx] " Joe Perches 2020-08-25 4:55 ` Joe Perches 2020-08-25 4:55 ` Joe Perches 2020-08-25 4:55 ` Joe Perches 2020-08-25 4:55 ` Joe Perches 2020-08-25 4:55 ` Joe Perches 2020-08-25 4:55 ` Joe Perches 2020-08-25 4:55 ` [PATCH 01/29] coding-style.rst: Avoid comma statements Joe Perches 2021-01-30 18:53 ` Joe Perches 2021-02-04 21:41 ` Jonathan Corbet 2020-08-25 4:55 ` [PATCH 02/29] alpha: Avoid comma separated statements Joe Perches 2020-08-25 6:37 ` Robert Richter 2021-01-30 18:54 ` Joe Perches 2021-02-16 14:39 ` Robert Richter 2021-02-16 14:39 ` Robert Richter 2021-02-16 15:10 ` Joe Perches 2021-02-16 15:10 ` Joe Perches 2020-08-25 4:56 ` [PATCH 03/29] ia64: " Joe Perches 2020-08-25 4:56 ` Joe Perches 2021-01-30 18:55 ` Joe Perches 2021-01-30 18:55 ` Joe Perches 2020-08-25 4:56 ` [PATCH 04/29] sparc: " Joe Perches 2020-08-25 4:56 ` Joe Perches 2021-01-30 18:56 ` Joe Perches 2021-01-30 18:56 ` Joe Perches 2020-08-25 4:56 ` [PATCH 05/29] ata: " Joe Perches 2021-01-30 18:56 ` Joe Perches 2021-01-31 15:06 ` Jens Axboe 2020-08-25 4:56 ` [PATCH 06/29] drbd: " Joe Perches 2021-01-30 18:57 ` Joe Perches 2021-01-31 15:06 ` Jens Axboe 2020-08-25 4:56 ` [PATCH 07/29] lp: " Joe Perches 2020-08-25 4:56 ` [PATCH 08/29] dma-buf: " Joe Perches 2020-08-25 4:56 ` Joe Perches 2020-08-26 15:08 ` Christian König 2020-08-26 15:08 ` Christian König 2020-09-03 12:21 ` Sumit Semwal 2020-09-03 12:21 ` Sumit Semwal 2020-09-04 11:42 ` Kieran Bingham 2020-09-04 11:42 ` Kieran Bingham 2020-09-04 21:33 ` Joe Perches 2020-09-04 21:33 ` Joe Perches 2021-01-30 18:47 ` Joe Perches 2021-01-30 18:47 ` Joe Perches 2021-02-03 13:26 ` Christian König 2021-02-03 13:26 ` Christian König 2021-01-31 17:39 ` Joe Perches 2021-01-31 17:39 ` Joe Perches 2021-01-31 17:53 ` Christian König 2021-01-31 17:53 ` Christian König 2021-02-01 21:54 ` Lyude Paul 2021-02-01 21:54 ` Lyude Paul 2021-02-02 8:33 ` [Linaro-mm-sig] " Christian König 2021-02-02 8:33 ` Christian König 2021-02-02 18:24 ` Lyude Paul 2021-02-02 18:24 ` Lyude Paul 2020-08-25 4:56 ` Joe Perches [this message] 2020-08-25 4:56 ` [PATCH 09/29] drm/gma500: " Joe Perches 2021-01-30 18:47 ` Joe Perches 2021-01-30 18:47 ` Joe Perches 2021-01-30 21:21 ` Patrik Jakobsson 2021-01-30 21:21 ` Patrik Jakobsson 2020-08-25 4:56 ` [PATCH 10/29] drm/i915: " Joe Perches 2020-08-25 4:56 ` [Intel-gfx] " Joe Perches 2020-08-25 4:56 ` Joe Perches 2021-01-30 18:47 ` Joe Perches 2021-01-30 18:47 ` [Intel-gfx] " Joe Perches 2021-01-30 18:47 ` Joe Perches 2021-02-01 8:41 ` Jani Nikula 2021-02-01 8:41 ` [Intel-gfx] " Jani Nikula 2021-02-01 8:41 ` Jani Nikula 2020-08-25 4:56 ` [PATCH 11/29] hwmon: (scmi-hwmon): " Joe Perches 2020-08-25 23:33 ` Guenter Roeck 2020-08-25 4:56 ` [PATCH 12/29] Input: MT - " Joe Perches 2020-08-25 17:07 ` Dmitry Torokhov 2020-08-25 4:56 ` [PATCH 13/29] bcache: " Joe Perches 2021-01-30 18:59 ` Joe Perches 2021-01-31 15:58 ` Coly Li 2020-08-25 4:56 ` [PATCH 14/29] media: " Joe Perches 2020-09-04 11:45 ` Kieran Bingham 2020-08-25 4:56 ` [PATCH 15/29] mtd: " Joe Perches 2020-08-25 4:56 ` Joe Perches 2020-09-07 7:34 ` Miquel Raynal 2020-09-07 7:34 ` Miquel Raynal 2020-08-25 4:56 ` [PATCH 16/29] 8390: " Joe Perches 2020-08-25 14:54 ` David Miller 2020-08-25 4:56 ` [PATCH 17/29] fs_enet: " Joe Perches 2020-08-25 4:56 ` Joe Perches 2020-08-25 14:55 ` David Miller 2020-08-25 14:55 ` David Miller 2020-08-25 4:56 ` [PATCH 18/29] wan: sbni: " Joe Perches 2020-08-25 14:55 ` David Miller 2020-08-25 4:56 ` [PATCH 19/29] s390/tty3270: " Joe Perches 2021-01-30 19:01 ` Joe Perches 2021-01-30 19:01 ` Joe Perches 2020-08-25 4:56 ` [PATCH 20/29] scai/arm: " Joe Perches 2020-08-25 4:56 ` Joe Perches 2020-08-25 4:56 ` [PATCH 21/29] media: atomisp: " Joe Perches 2020-08-25 4:56 ` Joe Perches 2020-09-04 11:46 ` Kieran Bingham 2020-09-04 11:46 ` Kieran Bingham 2020-08-25 4:56 ` [PATCH 22/29] video: fbdev: " Joe Perches 2020-08-25 4:56 ` Joe Perches 2020-08-25 4:56 ` Joe Perches 2020-09-08 11:37 ` Bartlomiej Zolnierkiewicz 2020-09-08 11:37 ` Bartlomiej Zolnierkiewicz 2020-09-08 11:37 ` Bartlomiej Zolnierkiewicz 2020-08-25 4:56 ` [PATCH 23/29] fuse: " Joe Perches 2021-01-30 19:04 ` Joe Perches 2021-02-01 8:12 ` Miklos Szeredi 2020-08-25 4:56 ` [PATCH 24/29] reiserfs: " Joe Perches 2021-01-30 19:04 ` Joe Perches 2020-08-25 4:56 ` [PATCH 25/29] lib/zlib: " Joe Perches 2021-01-30 19:05 ` Joe Perches 2020-08-25 4:56 ` [PATCH 26/29] lib: zstd: " Joe Perches 2021-01-30 19:06 ` Joe Perches 2020-08-25 4:56 ` [PATCH 27/29] ipv6: fib6: " Joe Perches 2020-08-25 14:55 ` David Miller 2020-08-25 4:56 ` [PATCH 28/29] sunrpc: " Joe Perches 2020-08-25 14:55 ` David Miller 2020-08-25 4:56 ` [PATCH 29/29] tools: " Joe Perches 2020-08-26 9:30 ` Thomas Renninger 2020-08-26 14:45 ` Joe Perches 2020-08-26 16:13 ` Thomas Renninger 2020-09-09 2:09 ` [PATCH 00/29] treewide: Convert " Martin K. Petersen 2020-09-09 2:09 ` Martin K. Petersen 2020-09-09 2:09 ` [Intel-gfx] " Martin K. Petersen 2020-09-09 2:09 ` Martin K. Petersen 2020-09-09 2:09 ` Martin K. Petersen 2020-09-09 2:09 ` Martin K. Petersen 2020-09-09 2:09 ` Martin K. Petersen 2020-09-09 2:09 ` Martin K. Petersen 2020-09-09 2:09 ` Martin K. Petersen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=e96626cd1301ff44e5101e0e5913d8439b425c9f.1598331148.git.joe@perches.com \ --to=joe@perches.com \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-kernel@vger.kernel.org \ --cc=patrik.r.jakobsson@gmail.com \ --cc=trivial@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.