All of lore.kernel.org
 help / color / mirror / Atom feed
* [linux-next:master 5896/7280] drivers/scsi/lpfc/lpfc_nvmet.c:3340:1: warning: no previous prototype for function 'lpfc_nvmet_prep_abort_wqe'
@ 2020-11-20 10:26 ` kernel test robot
  0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2020-11-20 10:26 UTC (permalink / raw)
  To: James Smart
  Cc: kbuild-all, clang-built-linux, Linux Memory Management List,
	Martin K. Petersen, Dick Kennedy

[-- Attachment #1: Type: text/plain, Size: 3553 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   95065cb54210eba86bed10cb2118041524d54573
commit: db7531d2b3775c662466e4eeda774986472c6d18 [5896/7280] scsi: lpfc: Convert abort handling to SLI-3 and SLI-4 handlers
config: x86_64-randconfig-a011-20201120 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 3ded927cf80ac519f9f9c4664fef08787f7c537d)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=db7531d2b3775c662466e4eeda774986472c6d18
        git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
        git fetch --no-tags linux-next master
        git checkout db7531d2b3775c662466e4eeda774986472c6d18
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/scsi/lpfc/lpfc_nvmet.c:3340:1: warning: no previous prototype for function 'lpfc_nvmet_prep_abort_wqe' [-Wmissing-prototypes]
   lpfc_nvmet_prep_abort_wqe(struct lpfc_iocbq *pwqeq, u16 xritag, u8 opt)
   ^
   drivers/scsi/lpfc/lpfc_nvmet.c:3339:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void
   ^
   static 
   1 warning generated.

vim +/lpfc_nvmet_prep_abort_wqe +3340 drivers/scsi/lpfc/lpfc_nvmet.c

  3329	
  3330	/**
  3331	 * lpfc_nvmet_prep_abort_wqe - set up 'abort' work queue entry.
  3332	 * @pwqeq: Pointer to command iocb.
  3333	 * @xritag: Tag that  uniqely identifies the local exchange resource.
  3334	 * @opt: Option bits -
  3335	 *		bit 0 = inhibit sending abts on the link
  3336	 *
  3337	 * This function is called with hbalock held.
  3338	 **/
  3339	void
> 3340	lpfc_nvmet_prep_abort_wqe(struct lpfc_iocbq *pwqeq, u16 xritag, u8 opt)
  3341	{
  3342		union lpfc_wqe128 *wqe = &pwqeq->wqe;
  3343	
  3344		/* WQEs are reused.  Clear stale data and set key fields to
  3345		 * zero like ia, iaab, iaar, xri_tag, and ctxt_tag.
  3346		 */
  3347		memset(wqe, 0, sizeof(*wqe));
  3348	
  3349		if (opt & INHIBIT_ABORT)
  3350			bf_set(abort_cmd_ia, &wqe->abort_cmd, 1);
  3351		/* Abort specified xri tag, with the mask deliberately zeroed */
  3352		bf_set(abort_cmd_criteria, &wqe->abort_cmd, T_XRI_TAG);
  3353	
  3354		bf_set(wqe_cmnd, &wqe->abort_cmd.wqe_com, CMD_ABORT_XRI_CX);
  3355	
  3356		/* Abort the I/O associated with this outstanding exchange ID. */
  3357		wqe->abort_cmd.wqe_com.abort_tag = xritag;
  3358	
  3359		/* iotag for the wqe completion. */
  3360		bf_set(wqe_reqtag, &wqe->abort_cmd.wqe_com, pwqeq->iotag);
  3361	
  3362		bf_set(wqe_qosd, &wqe->abort_cmd.wqe_com, 1);
  3363		bf_set(wqe_lenloc, &wqe->abort_cmd.wqe_com, LPFC_WQE_LENLOC_NONE);
  3364	
  3365		bf_set(wqe_cmd_type, &wqe->abort_cmd.wqe_com, OTHER_COMMAND);
  3366		bf_set(wqe_wqec, &wqe->abort_cmd.wqe_com, 1);
  3367		bf_set(wqe_cqid, &wqe->abort_cmd.wqe_com, LPFC_WQE_CQ_ID_DEFAULT);
  3368	}
  3369	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 41741 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [linux-next:master 5896/7280] drivers/scsi/lpfc/lpfc_nvmet.c:3340:1: warning: no previous prototype for function 'lpfc_nvmet_prep_abort_wqe'
@ 2020-11-20 10:26 ` kernel test robot
  0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2020-11-20 10:26 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 3633 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   95065cb54210eba86bed10cb2118041524d54573
commit: db7531d2b3775c662466e4eeda774986472c6d18 [5896/7280] scsi: lpfc: Convert abort handling to SLI-3 and SLI-4 handlers
config: x86_64-randconfig-a011-20201120 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 3ded927cf80ac519f9f9c4664fef08787f7c537d)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=db7531d2b3775c662466e4eeda774986472c6d18
        git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
        git fetch --no-tags linux-next master
        git checkout db7531d2b3775c662466e4eeda774986472c6d18
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/scsi/lpfc/lpfc_nvmet.c:3340:1: warning: no previous prototype for function 'lpfc_nvmet_prep_abort_wqe' [-Wmissing-prototypes]
   lpfc_nvmet_prep_abort_wqe(struct lpfc_iocbq *pwqeq, u16 xritag, u8 opt)
   ^
   drivers/scsi/lpfc/lpfc_nvmet.c:3339:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void
   ^
   static 
   1 warning generated.

vim +/lpfc_nvmet_prep_abort_wqe +3340 drivers/scsi/lpfc/lpfc_nvmet.c

  3329	
  3330	/**
  3331	 * lpfc_nvmet_prep_abort_wqe - set up 'abort' work queue entry.
  3332	 * @pwqeq: Pointer to command iocb.
  3333	 * @xritag: Tag that  uniqely identifies the local exchange resource.
  3334	 * @opt: Option bits -
  3335	 *		bit 0 = inhibit sending abts on the link
  3336	 *
  3337	 * This function is called with hbalock held.
  3338	 **/
  3339	void
> 3340	lpfc_nvmet_prep_abort_wqe(struct lpfc_iocbq *pwqeq, u16 xritag, u8 opt)
  3341	{
  3342		union lpfc_wqe128 *wqe = &pwqeq->wqe;
  3343	
  3344		/* WQEs are reused.  Clear stale data and set key fields to
  3345		 * zero like ia, iaab, iaar, xri_tag, and ctxt_tag.
  3346		 */
  3347		memset(wqe, 0, sizeof(*wqe));
  3348	
  3349		if (opt & INHIBIT_ABORT)
  3350			bf_set(abort_cmd_ia, &wqe->abort_cmd, 1);
  3351		/* Abort specified xri tag, with the mask deliberately zeroed */
  3352		bf_set(abort_cmd_criteria, &wqe->abort_cmd, T_XRI_TAG);
  3353	
  3354		bf_set(wqe_cmnd, &wqe->abort_cmd.wqe_com, CMD_ABORT_XRI_CX);
  3355	
  3356		/* Abort the I/O associated with this outstanding exchange ID. */
  3357		wqe->abort_cmd.wqe_com.abort_tag = xritag;
  3358	
  3359		/* iotag for the wqe completion. */
  3360		bf_set(wqe_reqtag, &wqe->abort_cmd.wqe_com, pwqeq->iotag);
  3361	
  3362		bf_set(wqe_qosd, &wqe->abort_cmd.wqe_com, 1);
  3363		bf_set(wqe_lenloc, &wqe->abort_cmd.wqe_com, LPFC_WQE_LENLOC_NONE);
  3364	
  3365		bf_set(wqe_cmd_type, &wqe->abort_cmd.wqe_com, OTHER_COMMAND);
  3366		bf_set(wqe_wqec, &wqe->abort_cmd.wqe_com, 1);
  3367		bf_set(wqe_cqid, &wqe->abort_cmd.wqe_com, LPFC_WQE_CQ_ID_DEFAULT);
  3368	}
  3369	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 41741 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [linux-next:master 5896/7280] drivers/scsi/lpfc/lpfc_nvmet.c:3340:1: warning: no previous prototype for function 'lpfc_nvmet_prep_abort_wqe'
  2020-11-20 10:26 ` kernel test robot
@ 2020-11-20 18:56   ` James Smart
  -1 siblings, 0 replies; 4+ messages in thread
From: James Smart @ 2020-11-20 18:56 UTC (permalink / raw)
  To: kernel test robot
  Cc: kbuild-all, clang-built-linux, Linux Memory Management List,
	Martin K. Petersen, Dick Kennedy

[-- Attachment #1: Type: text/plain, Size: 2117 bytes --]



On 11/20/2020 2:26 AM, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   95065cb54210eba86bed10cb2118041524d54573
> commit: db7531d2b3775c662466e4eeda774986472c6d18 [5896/7280] scsi: lpfc: Convert abort handling to SLI-3 and SLI-4 handlers
> config: x86_64-randconfig-a011-20201120 (attached as .config)
> compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 3ded927cf80ac519f9f9c4664fef08787f7c537d)
> reproduce (this is a W=1 build):
>          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>          chmod +x ~/bin/make.cross
>          # install x86_64 cross compiling tool for clang build
>          # apt-get install binutils-x86-64-linux-gnu
>          # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=db7531d2b3775c662466e4eeda774986472c6d18
>          git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>          git fetch --no-tags linux-next master
>          git checkout db7531d2b3775c662466e4eeda774986472c6d18
>          # save the attached .config to linux build tree
>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
>>> drivers/scsi/lpfc/lpfc_nvmet.c:3340:1: warning: no previous prototype for function 'lpfc_nvmet_prep_abort_wqe' [-Wmissing-prototypes]
>     lpfc_nvmet_prep_abort_wqe(struct lpfc_iocbq *pwqeq, u16 xritag, u8 opt)
>     ^
>     drivers/scsi/lpfc/lpfc_nvmet.c:3339:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
>     void
>     ^
>     static
>     1 warning generated.
>
> vim +/lpfc_nvmet_prep_abort_wqe +3340 drivers/scsi/lpfc/lpfc_nvmet.c
>
Fixed by  185d17e11e7f  scsi: lpfc: Fix missing prototype for 
lpfc_nvmet_prep_abort_wqe()

checked in yesterday....

-- james


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4163 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [linux-next:master 5896/7280] drivers/scsi/lpfc/lpfc_nvmet.c:3340:1: warning: no previous prototype for function 'lpfc_nvmet_prep_abort_wqe'
@ 2020-11-20 18:56   ` James Smart
  0 siblings, 0 replies; 4+ messages in thread
From: James Smart @ 2020-11-20 18:56 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 2119 bytes --]



On 11/20/2020 2:26 AM, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   95065cb54210eba86bed10cb2118041524d54573
> commit: db7531d2b3775c662466e4eeda774986472c6d18 [5896/7280] scsi: lpfc: Convert abort handling to SLI-3 and SLI-4 handlers
> config: x86_64-randconfig-a011-20201120 (attached as .config)
> compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 3ded927cf80ac519f9f9c4664fef08787f7c537d)
> reproduce (this is a W=1 build):
>          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>          chmod +x ~/bin/make.cross
>          # install x86_64 cross compiling tool for clang build
>          # apt-get install binutils-x86-64-linux-gnu
>          # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=db7531d2b3775c662466e4eeda774986472c6d18
>          git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>          git fetch --no-tags linux-next master
>          git checkout db7531d2b3775c662466e4eeda774986472c6d18
>          # save the attached .config to linux build tree
>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
>>> drivers/scsi/lpfc/lpfc_nvmet.c:3340:1: warning: no previous prototype for function 'lpfc_nvmet_prep_abort_wqe' [-Wmissing-prototypes]
>     lpfc_nvmet_prep_abort_wqe(struct lpfc_iocbq *pwqeq, u16 xritag, u8 opt)
>     ^
>     drivers/scsi/lpfc/lpfc_nvmet.c:3339:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
>     void
>     ^
>     static
>     1 warning generated.
>
> vim +/lpfc_nvmet_prep_abort_wqe +3340 drivers/scsi/lpfc/lpfc_nvmet.c
>
Fixed by  185d17e11e7f  scsi: lpfc: Fix missing prototype for 
lpfc_nvmet_prep_abort_wqe()

checked in yesterday....

-- james


[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 4163 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-11-20 18:56 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-20 10:26 [linux-next:master 5896/7280] drivers/scsi/lpfc/lpfc_nvmet.c:3340:1: warning: no previous prototype for function 'lpfc_nvmet_prep_abort_wqe' kernel test robot
2020-11-20 10:26 ` kernel test robot
2020-11-20 18:56 ` James Smart
2020-11-20 18:56   ` James Smart

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.