All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 3/5] block: remove the ->rq_disk field in struct request
Date: Tue, 28 Sep 2021 21:21:25 +0000	[thread overview]
Message-ID: <e9a6e00f-60e1-c604-9e08-3789fd057df9@nvidia.com> (raw)
In-Reply-To: <e88de776-fae9-7241-b741-9cf467f0965a@nvidia.com>

On 9/28/21 2:11 PM, Chaitanya Kulkarni wrote:
> External email: Use caution opening links or attachments
> 
> 
> On 9/27/21 10:22 PM, Christoph Hellwig wrote:
>> Just use the disk attached to the request_queue instead.
>>
>> Signed-off-by: Christoph Hellwig <hch@lst.de>
>> ---
> 
> Please consider adding :-
> 
> root@dev linux-block (for-next) # git diff drivers/mtd
> diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c
> index b8ae1ec14e17..f0488694afdb 100644
> --- a/drivers/mtd/mtd_blkdevs.c
> +++ b/drivers/mtd/mtd_blkdevs.c
> @@ -59,7 +59,7 @@ static blk_status_t do_blktrans_request(struct
> mtd_blktrans_ops *tr,
>           }
> 
>           if (blk_rq_pos(req) + blk_rq_cur_sectors(req) >
> -           get_capacity(req->rq_disk))
> +           get_capacity(req->q->disk))
>                   return BLK_STS_IOERR;
> 
>           switch (req_op(req)) {
> 

sorry for the noise, you have already done it in patch 1,
when I applied patch 1 it failed on my tree due to copy paste
error and I missed it ..





WARNING: multiple messages have this Message-ID (diff)
From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 3/5] block: remove the ->rq_disk field in struct request
Date: Tue, 28 Sep 2021 21:21:25 +0000	[thread overview]
Message-ID: <e9a6e00f-60e1-c604-9e08-3789fd057df9@nvidia.com> (raw)
In-Reply-To: <e88de776-fae9-7241-b741-9cf467f0965a@nvidia.com>

On 9/28/21 2:11 PM, Chaitanya Kulkarni wrote:
> External email: Use caution opening links or attachments
> 
> 
> On 9/27/21 10:22 PM, Christoph Hellwig wrote:
>> Just use the disk attached to the request_queue instead.
>>
>> Signed-off-by: Christoph Hellwig <hch@lst.de>
>> ---
> 
> Please consider adding :-
> 
> root@dev linux-block (for-next) # git diff drivers/mtd
> diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c
> index b8ae1ec14e17..f0488694afdb 100644
> --- a/drivers/mtd/mtd_blkdevs.c
> +++ b/drivers/mtd/mtd_blkdevs.c
> @@ -59,7 +59,7 @@ static blk_status_t do_blktrans_request(struct
> mtd_blktrans_ops *tr,
>           }
> 
>           if (blk_rq_pos(req) + blk_rq_cur_sectors(req) >
> -           get_capacity(req->rq_disk))
> +           get_capacity(req->q->disk))
>                   return BLK_STS_IOERR;
> 
>           switch (req_op(req)) {
> 

sorry for the noise, you have already done it in patch 1,
when I applied patch 1 it failed on my tree due to copy paste
error and I missed it ..




______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2021-09-28 21:21 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-28  5:22 remove ->rq_disk Christoph Hellwig
2021-09-28  5:22 ` Christoph Hellwig
2021-09-28  5:22 ` [PATCH 1/5] mtd_blkdevs: remove the sector out of range check in do_blktrans_request Christoph Hellwig
2021-09-28  5:22   ` Christoph Hellwig
2021-09-28  8:51   ` Miquel Raynal
2021-09-28  8:51     ` Miquel Raynal
2021-09-28  5:22 ` [PATCH 2/5] block: don't check ->rq_disk in merges Christoph Hellwig
2021-09-28  5:22   ` Christoph Hellwig
2021-09-28  5:22 ` [PATCH 3/5] block: remove the ->rq_disk field in struct request Christoph Hellwig
2021-09-28  5:22   ` Christoph Hellwig
2021-09-28 21:11   ` Chaitanya Kulkarni
2021-09-28 21:11     ` Chaitanya Kulkarni
2021-09-28 21:21     ` Chaitanya Kulkarni [this message]
2021-09-28 21:21       ` Chaitanya Kulkarni
2021-09-28 21:22   ` Chaitanya Kulkarni
2021-09-28 21:22     ` Chaitanya Kulkarni
2021-09-28  5:22 ` [PATCH 4/5] block: remove the gendisk argument to blk_execute_rq Christoph Hellwig
2021-09-28  5:22   ` Christoph Hellwig
2021-09-28 21:23   ` Chaitanya Kulkarni
2021-09-28 21:23     ` Chaitanya Kulkarni
2021-09-28  5:22 ` [PATCH 5/5] scsi: remove the gendisk argument to scsi_ioctl Christoph Hellwig
2021-09-28  5:22   ` Christoph Hellwig
2021-09-28 21:24   ` Chaitanya Kulkarni
2021-09-28 21:24     ` Chaitanya Kulkarni
2021-09-28 14:32 ` remove ->rq_disk Ming Lei
2021-09-28 14:32   ` Ming Lei
2021-09-29  7:07   ` Christoph Hellwig
2021-09-29  7:07     ` Christoph Hellwig
2021-09-29  8:04     ` Ming Lei
2021-09-29  8:04       ` Ming Lei
2021-11-26 12:17 remove ->rq_disk v2 Christoph Hellwig
2021-11-26 12:18 ` [PATCH 3/5] block: remove the ->rq_disk field in struct request Christoph Hellwig
2021-11-26 12:18   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e9a6e00f-60e1-c604-9e08-3789fd057df9@nvidia.com \
    --to=chaitanyak@nvidia.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.