* [PATCH] arm: mvebu: Use printf for printing fatal errors
@ 2021-12-17 17:31 Pali Rohár
2021-12-18 8:34 ` Stefan Roese
2021-12-18 13:50 ` Stefan Roese
0 siblings, 2 replies; 3+ messages in thread
From: Pali Rohár @ 2021-12-17 17:31 UTC (permalink / raw)
To: Stefan Roese; +Cc: Marek Behún, u-boot
There is no point to hide/disable fatal errors via debug() macro.
Print fatal errors loudly.
Signed-off-by: Pali Rohár <pali@kernel.org>
---
arch/arm/mach-mvebu/spl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-mvebu/spl.c b/arch/arm/mach-mvebu/spl.c
index 29a8adc9d79c..609495097585 100644
--- a/arch/arm/mach-mvebu/spl.c
+++ b/arch/arm/mach-mvebu/spl.c
@@ -313,7 +313,7 @@ void board_init_f(ulong dummy)
ret = spl_init();
if (ret) {
- debug("spl_init() failed: %d\n", ret);
+ printf("spl_init() failed: %d\n", ret);
hang();
}
@@ -329,7 +329,7 @@ void board_init_f(ulong dummy)
/* Setup DDR */
ret = ddr3_init();
if (ret) {
- debug("ddr3_init() failed: %d\n", ret);
+ printf("ddr3_init() failed: %d\n", ret);
hang();
}
#endif
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm: mvebu: Use printf for printing fatal errors
2021-12-17 17:31 [PATCH] arm: mvebu: Use printf for printing fatal errors Pali Rohár
@ 2021-12-18 8:34 ` Stefan Roese
2021-12-18 13:50 ` Stefan Roese
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Roese @ 2021-12-18 8:34 UTC (permalink / raw)
To: Pali Rohár; +Cc: Marek Behún, u-boot
On 12/17/21 18:31, Pali Rohár wrote:
> There is no point to hide/disable fatal errors via debug() macro.
> Print fatal errors loudly.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
Reviewed-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
> ---
> arch/arm/mach-mvebu/spl.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-mvebu/spl.c b/arch/arm/mach-mvebu/spl.c
> index 29a8adc9d79c..609495097585 100644
> --- a/arch/arm/mach-mvebu/spl.c
> +++ b/arch/arm/mach-mvebu/spl.c
> @@ -313,7 +313,7 @@ void board_init_f(ulong dummy)
>
> ret = spl_init();
> if (ret) {
> - debug("spl_init() failed: %d\n", ret);
> + printf("spl_init() failed: %d\n", ret);
> hang();
> }
>
> @@ -329,7 +329,7 @@ void board_init_f(ulong dummy)
> /* Setup DDR */
> ret = ddr3_init();
> if (ret) {
> - debug("ddr3_init() failed: %d\n", ret);
> + printf("ddr3_init() failed: %d\n", ret);
> hang();
> }
> #endif
>
Viele Grüße,
Stefan Roese
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm: mvebu: Use printf for printing fatal errors
2021-12-17 17:31 [PATCH] arm: mvebu: Use printf for printing fatal errors Pali Rohár
2021-12-18 8:34 ` Stefan Roese
@ 2021-12-18 13:50 ` Stefan Roese
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Roese @ 2021-12-18 13:50 UTC (permalink / raw)
To: Pali Rohár; +Cc: Marek Behún, u-boot
On 12/17/21 18:31, Pali Rohár wrote:
> There is no point to hide/disable fatal errors via debug() macro.
> Print fatal errors loudly.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
Applied to u-boot-marvell/next
Thanks,
Stefan
> ---
> arch/arm/mach-mvebu/spl.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-mvebu/spl.c b/arch/arm/mach-mvebu/spl.c
> index 29a8adc9d79c..609495097585 100644
> --- a/arch/arm/mach-mvebu/spl.c
> +++ b/arch/arm/mach-mvebu/spl.c
> @@ -313,7 +313,7 @@ void board_init_f(ulong dummy)
>
> ret = spl_init();
> if (ret) {
> - debug("spl_init() failed: %d\n", ret);
> + printf("spl_init() failed: %d\n", ret);
> hang();
> }
>
> @@ -329,7 +329,7 @@ void board_init_f(ulong dummy)
> /* Setup DDR */
> ret = ddr3_init();
> if (ret) {
> - debug("ddr3_init() failed: %d\n", ret);
> + printf("ddr3_init() failed: %d\n", ret);
> hang();
> }
> #endif
>
Viele Grüße,
Stefan Roese
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-18 13:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-17 17:31 [PATCH] arm: mvebu: Use printf for printing fatal errors Pali Rohár
2021-12-18 8:34 ` Stefan Roese
2021-12-18 13:50 ` Stefan Roese
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.