linux-next: build failure after merge of the slabh tree

linux-next: build failure after merge of the slabh tree

[Stephen Rothwell]

Hi Tejun,

After merging the slabh tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/dma/timb_dma.c: In function 'td_alloc_init_desc':
drivers/dma/timb_dma.c:381: error: implicit declaration of function 'kzalloc'
drivers/dma/timb_dma.c:381: warning: assignment makes pointer from integer without a cast
drivers/dma/timb_dma.c:389: warning: assignment makes pointer from integer without a cast
drivers/dma/timb_dma.c:410: error: implicit declaration of function 'kfree'
drivers/dma/timb_dma.c: In function 'td_probe':
drivers/dma/timb_dma.c:710: warning: assignment makes pointer from integer without a cast

Caused by commit d103d3b3e8512312b5254950035366d4422a479a ("percpu: don't
implicitly include slab.h from percpu.h") from the slabh tree interacting
with commit de5d4453c5b224eefd02b6a141ed411a76d458af ("dma: Add
timb-dma") from the async_tx tree.

I applied the following merge fixup patch which should be applied to the
async_tx tree (see Documentation/SubmitChecklist Rule #1 :-)).

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 29 Mar 2010 15:54:40 +1100
Subject: [PATCH] async_tx: use of kzalloc/kfree requires the include of slab.h

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/dma/timb_dma.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/dma/timb_dma.c b/drivers/dma/timb_dma.c
index e20d5c1..44b346d 100644
--- a/drivers/dma/timb_dma.c
+++ b/drivers/dma/timb_dma.c
@@ -27,6 +27,7 @@
 #include <linux/io.h>
 #include <linux/module.h>
 #include <linux/platform_device.h>
+#include <linux/slab.h>
 
 #include <linux/timb_dma.h>
 
-- 
1.7.0.3

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

Re: linux-next: build failure after merge of the slabh tree

[Dan Williams]

On Sun, Mar 28, 2010 at 10:02 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Tejun,
>
> After merging the slabh tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/dma/timb_dma.c: In function 'td_alloc_init_desc':
> drivers/dma/timb_dma.c:381: error: implicit declaration of function 'kzalloc'
> drivers/dma/timb_dma.c:381: warning: assignment makes pointer from integer without a cast
> drivers/dma/timb_dma.c:389: warning: assignment makes pointer from integer without a cast
> drivers/dma/timb_dma.c:410: error: implicit declaration of function 'kfree'
> drivers/dma/timb_dma.c: In function 'td_probe':
> drivers/dma/timb_dma.c:710: warning: assignment makes pointer from integer without a cast
>
> Caused by commit d103d3b3e8512312b5254950035366d4422a479a ("percpu: don't
> implicitly include slab.h from percpu.h") from the slabh tree interacting
> with commit de5d4453c5b224eefd02b6a141ed411a76d458af ("dma: Add
> timb-dma") from the async_tx tree.
>
> I applied the following merge fixup patch which should be applied to the
> async_tx tree (see Documentation/SubmitChecklist Rule #1 :-)).

Thanks, noted and applied.

Re: linux-next: build failure after merge of the slabh tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 247 bytes --]

Hi Dan,

On Mon, 29 Mar 2010 15:33:25 -0700 Dan Williams <dan.j.williams@intel.com> wrote:
>
> Thanks, noted and applied.

Thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: build failure after merge of the slabh tree

[Stephen Rothwell]

Hi Gregory,

On Mon, 29 Mar 2010 17:07:27 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the slabh tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/vbus/bus-proxy.c: In function 'vbus_driver_ioq_release':
> drivers/vbus/bus-proxy.c:192: error: implicit declaration of function 'kfree'
> drivers/vbus/bus-proxy.c: In function 'vbus_driver_ioq_alloc':
> drivers/vbus/bus-proxy.c:210: error: implicit declaration of function 'kzalloc'
> drivers/vbus/bus-proxy.c:210: warning: assignment makes pointer from integer without a cast
> drivers/vbus/bus-proxy.c:214: warning: assignment makes pointer from integer without a cast
> 
> Caused by commit d103d3b3e8512312b5254950035366d4422a479a ("percpu: don't
> implicitly include slab.h from percpu.h") from the slabh tree interacting
> with commit 5ff775e4c3d6b0ead7d8784797123a2deed73364 ("ioq: add
> driver-side vbus helpers") from the alacrity tree.
> 
> I applied the following merge fixup patch which should be applied to the
> alacrity tree (see Documentation/SubmitChecklist Rule #1 :-)).
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Mon, 29 Mar 2010 17:03:25 +1100
> Subject: [PATCH] vbus: use of kzalloc/kfree requires the include of slab.h

This patch is needed on the alacrity tree since the slabh tree has been
merged int Linus' tree some time ago.  Pleas apply (patch reposted below).

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 29 Mar 2010 17:03:25 +1100
Subject: [PATCH] vbus: use of kzalloc/kfree requires the include of slab.h

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/vbus/bus-proxy.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/vbus/bus-proxy.c b/drivers/vbus/bus-proxy.c
index 4792842..ae11f67 100644
--- a/drivers/vbus/bus-proxy.c
+++ b/drivers/vbus/bus-proxy.c
@@ -19,6 +19,7 @@
  */
 
 #include <linux/module.h>
+#include <linux/slab.h>
 #include <linux/vbus_driver.h>
 
 MODULE_AUTHOR("Gregory Haskins");
-- 
1.7.0.3


-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

Re: linux-next: build failure after merge of the slabh tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 433 bytes --]

Hi Dave,

On Thu, 01 Apr 2010 00:29:08 -0700 (PDT) David Miller <davem@davemloft.net> wrote:
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Thu, 1 Apr 2010 16:41:10 +1100
> 
> > I have applied the following patch for today.  Dave, could you apply this
> > to the net tree please?
> 
> Done.

Thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: build failure after merge of the slabh tree

[Tejun Heo]

On 04/01/2010 04:29 PM, David Miller wrote:
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Thu, 1 Apr 2010 16:41:10 +1100
> 
>> I have applied the following patch for today.  Dave, could you apply this
>> to the net tree please?
> 
> Done.

Thanks!

-- 
tejun

Re: linux-next: build failure after merge of the slabh tree

[David Miller]

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 1 Apr 2010 16:41:10 +1100

> I have applied the following patch for today.  Dave, could you apply this
> to the net tree please?

Done.

linux-next: build failure after merge of the slabh tree

[Stephen Rothwell]

Hi Tejun,

After merging the slabh tree, today's linux-next build (x86_64
allmodconfig) failed like this:

net/caif/cfcnfg.c: In function 'cfcnfg_create':
net/caif/cfcnfg.c:68: error: implicit declaration of function 'kmalloc'
net/caif/cfcnfg.c:68: warning: assignment makes pointer from integer without a cast
net/caif/cfcnfg.c:100: error: implicit declaration of function 'kfree'

Caused by commit 15c9ac0c80e390df09ce5730a7b08b13e07a8dd5 ("net-caif: add
CAIF generic caif support functions") from the net interacting with
commit de380b55f92986c1a84198149cb71b7228d15fbd ("percpu: don't
implicitly include slab.h from percpu.h") from the slabh tree.

I have applied the following patch for today.  Dave, could you apply this
to the net tree please?

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 1 Apr 2010 16:31:50 +1100
Subject: [PATCH] net-caif: using kmalloc/kfree requires the include of slab.h

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 net/caif/cfcnfg.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/net/caif/cfcnfg.c b/net/caif/cfcnfg.c
index 70a733d..c873e3d 100644
--- a/net/caif/cfcnfg.c
+++ b/net/caif/cfcnfg.c
@@ -5,6 +5,7 @@
  */
 #include <linux/kernel.h>
 #include <linux/stddef.h>
+#include <linux/slab.h>
 #include <net/caif/caif_layer.h>
 #include <net/caif/cfpkt.h>
 #include <net/caif/cfcnfg.h>
-- 
1.7.0.3

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

linux-next: build failure after merge of the slabh tree

[Stephen Rothwell]

Hi Tejun,

After merging the slabh tree, today's linux-next build (x86_64
allmodconfig) failed like this:

net/caif/cfcnfg.c: In function 'cfcnfg_create':
net/caif/cfcnfg.c:68: error: implicit declaration of function 'kmalloc'
net/caif/cfcnfg.c:68: warning: assignment makes pointer from integer without a cast
net/caif/cfcnfg.c:100: error: implicit declaration of function 'kfree'

Caused by commit 15c9ac0c80e390df09ce5730a7b08b13e07a8dd5 ("net-caif: add
CAIF generic caif support functions") from the net interacting with
commit de380b55f92986c1a84198149cb71b7228d15fbd ("percpu: don't
implicitly include slab.h from percpu.h") from the slabh tree.

I have applied the following patch for today.  Dave, could you apply this
to the net tree please?

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 1 Apr 2010 16:31:50 +1100
Subject: [PATCH] net-caif: using kmalloc/kfree requires the include of slab.h

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 net/caif/cfcnfg.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/net/caif/cfcnfg.c b/net/caif/cfcnfg.c
index 70a733d..c873e3d 100644
--- a/net/caif/cfcnfg.c
+++ b/net/caif/cfcnfg.c
@@ -5,6 +5,7 @@
  */
 #include <linux/kernel.h>
 #include <linux/stddef.h>
+#include <linux/slab.h>
 #include <net/caif/caif_layer.h>
 #include <net/caif/cfpkt.h>
 #include <net/caif/cfcnfg.h>
-- 
1.7.0.3

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

Re: linux-next: build failure after merge of the slabh tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 287 bytes --]

Hi Jason,

On Tue, 30 Mar 2010 14:32:59 -0500 Jason Wessel <jason.wessel@windriver.com> wrote:
>
> This is applied and will appear in kgdb-next in the next hour.

Thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: build failure after merge of the slabh tree

[Jason Wessel]

On 03/29/2010 12:02 AM, Stephen Rothwell wrote:
> Hi Tejun,
>
> After merging the slabh tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> kernel/debug/kdb/kdb_support.c: In function 'kdb_strdup':
> kernel/debug/kdb/kdb_support.c:309: error: implicit declaration of function 'kmalloc'
> kernel/debug/kdb/kdb_support.c:309: warning: initialization makes pointer from integer without a cast
> kernel/debug/kdb/kdb_support.c: In function 'debug_kfree':
> kernel/debug/kdb/kdb_support.c:810: error: implicit declaration of function 'kfree'
>
> Caused by commit d103d3b3e8512312b5254950035366d4422a479a ("percpu: don't
> implicitly include slab.h from percpu.h") from the slabh tree interacting
> with commit 5572dd736e5577dfefafe2ad3b54760e8323e33d ("kdb: core for kgdb
> back end (1 of 2)") from the kgdb tree.
>
> I applied the following merge fixup patch which should be applied to the
> kdbg tree (see Documentation/SubmitChecklist Rule #1 :-)).
>
>   

But of course.

This is applied and will appear in kgdb-next in the next hour.

Thanks,
Jason.

Re: linux-next: build failure after merge of the slabh tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 357 bytes --]

Hi Jon,

On Tue, 30 Mar 2010 08:14:15 -0400 Jon Masters <jonathan@jonmasters.org> wrote:
>
> Can you remove the hwlat tree for the moment? I'm reworking it to use a
> newer mechanism and will then repost a more generic version.

OK, will do.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: build failure after merge of the slabh tree

[Jon Masters]

Hi Stephen,

Can you remove the hwlat tree for the moment? I'm reworking it to use a
newer mechanism and will then repost a more generic version.

Jon.

Re: linux-next: build failure after merge of the slabh tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 693 bytes --]

Hi Tejun,

On Mon, 29 Mar 2010 20:10:06 +0900 Tejun Heo <tj@kernel.org> wrote:
>
> Yikes, sorry about many failures.  Now that I think about it, it
> probably would have been wiser to run the conversion script on top of
> linux-next so that new ones in linux-next aren't missed by default.
> I'll do that and send out respective patches to each subsystem tree.

Thanks, that would be good.

> Thank you very much for taking the trouble to fix them up.  I'll soon
> submit more comprehensive fix up patches for code in linux-next but
> not in mainline.

Again, thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: build failure after merge of the slabh tree

[Tejun Heo]

Hello, Stephen.

On 03/29/2010 03:38 PM, Stephen Rothwell wrote:
> Again, thanks.  They were just one liner because I found them one at a
> time :-(

Yikes, sorry about many failures.  Now that I think about it, it
probably would have been wiser to run the conversion script on top of
linux-next so that new ones in linux-next aren't missed by default.
I'll do that and send out respective patches to each subsystem tree.

Thank you very much for taking the trouble to fix them up.  I'll soon
submit more comprehensive fix up patches for code in linux-next but
not in mainline.

-- 
tejun

Re: linux-next: build failure after merge of the slabh tree

[Takashi Iwai]

At Mon, 29 Mar 2010 19:01:48 +1100,
Stephen Rothwell wrote:
> 
> Hi Takashi,
> 
> On Mon, 29 Mar 2010 17:38:52 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > On Mon, 29 Mar 2010 08:28:09 +0200 Takashi Iwai <tiwai@suse.de> wrote:
> > >
> > > Thanks, I applied all these oneliners to sound/usb/* as a single
> > > patch now.
> > 
> > Again, thanks.  They were just one liner because I found them one at a
> > time :-(
> 
> Looks like you missed the one that updated sound/usb/pcm.c ... ah, I
> forgot to cc you, sorry.  Here is the patch again:
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Mon, 29 Mar 2010 16:37:58 +1100
> Subject: [PATCH] sound: usb pcm: use of kmalloc requires the include of slab.h
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>

Thanks, applied this one, too :)


Takashi


> ---
>  sound/usb/pcm.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c
> index 630e220..2bf0d77 100644
> --- a/sound/usb/pcm.c
> +++ b/sound/usb/pcm.c
> @@ -15,6 +15,7 @@
>   */
>  
>  #include <linux/init.h>
> +#include <linux/slab.h>
>  #include <linux/usb.h>
>  #include <linux/usb/audio.h>
>  #include <linux/usb/audio-v2.h>
> -- 
> 1.7.0.3
> 
> -- 
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au
> http://www.canb.auug.org.au/~sfr/
> 

Re: linux-next: build failure after merge of the slabh tree

[Stephen Rothwell]

Hi Takashi,

On Mon, 29 Mar 2010 17:38:52 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Mon, 29 Mar 2010 08:28:09 +0200 Takashi Iwai <tiwai@suse.de> wrote:
> >
> > Thanks, I applied all these oneliners to sound/usb/* as a single
> > patch now.
> 
> Again, thanks.  They were just one liner because I found them one at a
> time :-(

Looks like you missed the one that updated sound/usb/pcm.c ... ah, I
forgot to cc you, sorry.  Here is the patch again:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 29 Mar 2010 16:37:58 +1100
Subject: [PATCH] sound: usb pcm: use of kmalloc requires the include of slab.h

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 sound/usb/pcm.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c
index 630e220..2bf0d77 100644
--- a/sound/usb/pcm.c
+++ b/sound/usb/pcm.c
@@ -15,6 +15,7 @@
  */
 
 #include <linux/init.h>
+#include <linux/slab.h>
 #include <linux/usb.h>
 #include <linux/usb/audio.h>
 #include <linux/usb/audio-v2.h>
-- 
1.7.0.3

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

Re: linux-next: build failure after merge of the slabh tree

[Takashi Iwai]

At Mon, 29 Mar 2010 17:55:51 +1100,
Stephen Rothwell wrote:
> 
> Hi Tejun,
> 
> After merging the slabh tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> sound/soc/codecs/twl6040.c: In function 'twl6040_remove':
> sound/soc/codecs/twl6040.c:1052: error: implicit declaration of function 'kfree'
> sound/soc/codecs/twl6040.c: In function 'twl6040_codec_probe':
> sound/soc/codecs/twl6040.c:1073: error: implicit declaration of function 'kzalloc'
> sound/soc/codecs/twl6040.c:1073: warning: assignment makes pointer from integer without a cast
> 
> Caused by commit d103d3b3e8512312b5254950035366d4422a479a ("percpu: don't
> implicitly include slab.h from percpu.h") from the slabh tree interacting
> with commit 8ecbabd977dc64d2d8c9980420a3d72db06fe551 ("ASoC: TWL6040: Add
> twl6040 codec driver") from the sound tree.
> 
> I applied the following merge fixup patch which should be applied to the
> sound tree (see Documentation/SubmitChecklist Rule #1 :-)).  Hi Takashi,
> another one. :-(
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Mon, 29 Mar 2010 17:52:52 +1100
> Subject: [PATCH] Asoc: TWL6040: use of kzalloc/kfree requires the include of slab.h
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>

Applied to sound tree.  Thanks.


Takashi

> ---
>  sound/soc/codecs/twl6040.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/soc/codecs/twl6040.c b/sound/soc/codecs/twl6040.c
> index 0e4dce7..108c51a 100755
> --- a/sound/soc/codecs/twl6040.c
> +++ b/sound/soc/codecs/twl6040.c
> @@ -27,6 +27,7 @@
>  #include <linux/i2c.h>
>  #include <linux/gpio.h>
>  #include <linux/platform_device.h>
> +#include <linux/slab.h>
>  #include <linux/i2c/twl.h>
>  
>  #include <sound/core.h>
> -- 
> 1.7.0.3
> 
> -- 
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au
> http://www.canb.auug.org.au/~sfr/
> 

linux-next: build failure after merge of the slabh tree

[Stephen Rothwell]

Hi Tejun,

After merging the slabh tree, today's linux-next build (powerpc
allyesconfig) failed like this:

sound/soc/codecs/twl6040.c: In function 'twl6040_remove':
sound/soc/codecs/twl6040.c:1052: error: implicit declaration of function 'kfree'
sound/soc/codecs/twl6040.c: In function 'twl6040_codec_probe':
sound/soc/codecs/twl6040.c:1073: error: implicit declaration of function 'kzalloc'
sound/soc/codecs/twl6040.c:1073: warning: assignment makes pointer from integer without a cast

Caused by commit d103d3b3e8512312b5254950035366d4422a479a ("percpu: don't
implicitly include slab.h from percpu.h") from the slabh tree interacting
with commit 8ecbabd977dc64d2d8c9980420a3d72db06fe551 ("ASoC: TWL6040: Add
twl6040 codec driver") from the sound tree.

I applied the following merge fixup patch which should be applied to the
sound tree (see Documentation/SubmitChecklist Rule #1 :-)).  Hi Takashi,
another one. :-(

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 29 Mar 2010 17:52:52 +1100
Subject: [PATCH] Asoc: TWL6040: use of kzalloc/kfree requires the include of slab.h

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 sound/soc/codecs/twl6040.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/sound/soc/codecs/twl6040.c b/sound/soc/codecs/twl6040.c
index 0e4dce7..108c51a 100755
--- a/sound/soc/codecs/twl6040.c
+++ b/sound/soc/codecs/twl6040.c
@@ -27,6 +27,7 @@
 #include <linux/i2c.h>
 #include <linux/gpio.h>
 #include <linux/platform_device.h>
+#include <linux/slab.h>
 #include <linux/i2c/twl.h>
 
 #include <sound/core.h>
-- 
1.7.0.3

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

Re: linux-next: build failure after merge of the slabh tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 365 bytes --]

Hi Takashi,

On Mon, 29 Mar 2010 08:28:09 +0200 Takashi Iwai <tiwai@suse.de> wrote:
>
> Thanks, I applied all these oneliners to sound/usb/* as a single
> patch now.

Again, thanks.  They were just one liner because I found them one at a
time :-(

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: build failure after merge of the slabh tree

[Takashi Iwai]

At Mon, 29 Mar 2010 16:02:50 +1100,
Stephen Rothwell wrote:
> 
> Hi Tejun,
> 
> After merging the slabh tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> sound/usb/mixer_quirks.c: In function 'snd_usb_soundblaster_remote_init':
> sound/usb/mixer_quirks.c:144: error: implicit declaration of function 'kmalloc'
> sound/usb/mixer_quirks.c:144: warning: assignment makes pointer from integer without a cast
> 
> Caused by commit d103d3b3e8512312b5254950035366d4422a479a ("percpu: don't
> implicitly include slab.h from percpu.h") from the slabh tree interacting
> with commit 7b1eda223debcba706ab989a09c4eecb327aebdf ("ALSA: usb-mixer:
> factor out quirks") from the sound tree.
> 
> I applied the following merge fixup patch which should be applied to the
> sound tree (see Documentation/SubmitChecklist Rule #1 :-)).

Thanks, I applied all these oneliners to sound/usb/* as a single
patch now.


Takashi


> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Mon, 29 Mar 2010 15:59:58 +1100
> Subject: [PATCH] sound: use of kmalloc requires the include of slab.h
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  sound/usb/mixer_quirks.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/usb/mixer_quirks.c b/sound/usb/mixer_quirks.c
> index 56b6659..e7df1e5 100644
> --- a/sound/usb/mixer_quirks.c
> +++ b/sound/usb/mixer_quirks.c
> @@ -26,6 +26,7 @@
>   */
>  
>  #include <linux/init.h>
> +#include <linux/slab.h>
>  #include <linux/usb.h>
>  #include <linux/usb/audio.h>
>  
> -- 
> 1.7.0.3
> 
> -- 
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au
> http://www.canb.auug.org.au/~sfr/
> 

linux-next: build failure after merge of the slabh tree

[Stephen Rothwell]

Hi Tejun,

After merging the slabh tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/vbus/bus-proxy.c: In function 'vbus_driver_ioq_release':
drivers/vbus/bus-proxy.c:192: error: implicit declaration of function 'kfree'
drivers/vbus/bus-proxy.c: In function 'vbus_driver_ioq_alloc':
drivers/vbus/bus-proxy.c:210: error: implicit declaration of function 'kzalloc'
drivers/vbus/bus-proxy.c:210: warning: assignment makes pointer from integer without a cast
drivers/vbus/bus-proxy.c:214: warning: assignment makes pointer from integer without a cast

Caused by commit d103d3b3e8512312b5254950035366d4422a479a ("percpu: don't
implicitly include slab.h from percpu.h") from the slabh tree interacting
with commit 5ff775e4c3d6b0ead7d8784797123a2deed73364 ("ioq: add
driver-side vbus helpers") from the alacrity tree.

I applied the following merge fixup patch which should be applied to the
alacrity tree (see Documentation/SubmitChecklist Rule #1 :-)).

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 29 Mar 2010 17:03:25 +1100
Subject: [PATCH] vbus: use of kzalloc/kfree requires the include of slab.h

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/vbus/bus-proxy.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/vbus/bus-proxy.c b/drivers/vbus/bus-proxy.c
index 4792842..ae11f67 100644
--- a/drivers/vbus/bus-proxy.c
+++ b/drivers/vbus/bus-proxy.c
@@ -19,6 +19,7 @@
  */
 
 #include <linux/module.h>
+#include <linux/slab.h>
 #include <linux/vbus_driver.h>
 
 MODULE_AUTHOR("Gregory Haskins");
-- 
1.7.0.3

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

linux-next: build failure after merge of the slabh tree

[Stephen Rothwell]

Hi Tejun,

After merging the slabh tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/usb/helper.c: In function 'snd_usb_ctl_msg':
sound/usb/helper.c:97: error: implicit declaration of function 'kfree'

Caused by commit d103d3b3e8512312b5254950035366d4422a479a ("percpu: don't
implicitly include slab.h from percpu.h") from the slabh tree interacting
with commit e5779998bf8b70e48a6cc208c8b61b33bd6117ea ("ALSA: usb-audio:
refactor code") from the sound tree.

I applied the following merge fixup patch which should be applied to the
sound tree (see Documentation/SubmitChecklist Rule #1 :-)).

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 29 Mar 2010 16:58:16 +1100
Subject: [PATCH] sound: usb helper: use of kfree requires the include of slab.h

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 sound/usb/helper.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/sound/usb/helper.c b/sound/usb/helper.c
index ba7dba4..d48d6f8 100644
--- a/sound/usb/helper.c
+++ b/sound/usb/helper.c
@@ -16,6 +16,7 @@
  */
 
 #include <linux/init.h>
+#include <linux/slab.h>
 #include <linux/usb.h>
 
 #include "usbaudio.h"
-- 
1.7.0.3

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

linux-next: build failure after merge of the slabh tree

[Stephen Rothwell]

Hi Tejun,

After merging the slabh tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/mtd/sm_ftl.c: In function 'sm_create_sysfs_attributes':
drivers/mtd/sm_ftl.c:65: error: implicit declaration of function 'kmalloc'
drivers/mtd/sm_ftl.c:65: warning: initialization makes pointer from integer without a cast
drivers/mtd/sm_ftl.c:71: error: implicit declaration of function 'kzalloc'
drivers/mtd/sm_ftl.c:71: warning: assignment makes pointer from integer without a cast
drivers/mtd/sm_ftl.c:84: warning: assignment makes pointer from integer without a cast
drivers/mtd/sm_ftl.c:88: warning: assignment makes pointer from integer without a cast
drivers/mtd/sm_ftl.c: In function 'sm_delete_sysfs_attributes':
drivers/mtd/sm_ftl.c:107: error: implicit declaration of function 'kfree'
drivers/mtd/sm_ftl.c: In function 'sm_init_zone':
drivers/mtd/sm_ftl.c:757: warning: assignment makes pointer from integer without a cast
drivers/mtd/sm_ftl.c: In function 'sm_add_mtd':
drivers/mtd/sm_ftl.c:1123: warning: assignment makes pointer from integer without a cast
drivers/mtd/sm_ftl.c:1141: warning: assignment makes pointer from integer without a cast
drivers/mtd/sm_ftl.c:1147: warning: assignment makes pointer from integer without a cast
drivers/mtd/sm_ftl.c:1152: warning: assignment makes pointer from integer without a cast
drivers/mtd/sm_ftl.c:1161: warning: assignment makes pointer from integer without a cast

Caused by commit d103d3b3e8512312b5254950035366d4422a479a ("percpu: don't
implicitly include slab.h from percpu.h") from the slabh tree interacting
with commit 7d17c02a01a111f40986859f044c8c4cce8a4aa6 ("mtd: Add new
SmartMedia/xD FTL") from the mtd tree.

I applied the following merge fixup patch which should be applied to the
mtd tree (see Documentation/SubmitChecklist Rule #1 :-)).

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 29 Mar 2010 16:51:20 +1100
Subject: [PATCH] mtd: SmartMedia/xD FTL: use of kmalloc/kfree requires the include of slab.h

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/mtd/sm_ftl.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/mtd/sm_ftl.c b/drivers/mtd/sm_ftl.c
index a9b4e34..4c21589 100644
--- a/drivers/mtd/sm_ftl.c
+++ b/drivers/mtd/sm_ftl.c
@@ -15,6 +15,7 @@
 #include <linux/freezer.h>
 #include <linux/sysfs.h>
 #include <linux/bitops.h>
+#include <linux/slab.h>
 #include <linux/mtd/nand_ecc.h>
 #include "nand/sm_common.h"
 #include "sm_ftl.h"
-- 
1.7.0.3

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

linux-next: build failure after merge of the slabh tree

[Stephen Rothwell]

Hi Tejun,

After merging the slabh tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/input/misc/pcf8574_keypad.c: In function 'pcf8574_kp_probe':
drivers/input/misc/pcf8574_keypad.c:95: error: implicit declaration of function 'kzalloc'
drivers/input/misc/pcf8574_keypad.c:95: warning: assignment makes pointer from integer without a cast
drivers/input/misc/pcf8574_keypad.c:156: error: implicit declaration of function 'kfree'

Caused by commit d103d3b3e8512312b5254950035366d4422a479a ("percpu: don't
implicitly include slab.h from percpu.h") from the slabh tree interacting
with commit 88643169de358b8e5af101151d913ad80e4c64df ("Input: add PCF8574
I2C keypad input device driver") from the input tree.

I applied the following merge fixup patch which should be applied to the
input tree (see Documentation/SubmitChecklist Rule #1 :-)).

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 29 Mar 2010 16:45:42 +1100
Subject: [PATCH] input: pcf8574_keypad: use of kzalloc/kfree requires the include of slab.h

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/input/misc/pcf8574_keypad.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/input/misc/pcf8574_keypad.c b/drivers/input/misc/pcf8574_keypad.c
index cb135e5..5c3ac4e 100644
--- a/drivers/input/misc/pcf8574_keypad.c
+++ b/drivers/input/misc/pcf8574_keypad.c
@@ -11,6 +11,7 @@
 #include <linux/input.h>
 #include <linux/interrupt.h>
 #include <linux/i2c.h>
+#include <linux/slab.h>
 #include <linux/workqueue.h>
 
 #define DRV_NAME "pcf8574_keypad"
-- 
1.7.0.3

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

linux-next: build failure after merge of the slabh tree

[Stephen Rothwell]

Hi Tejun,

After merging the slabh tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/usb/pcm.c: In function 'snd_usb_pcm_check_knot':
sound/usb/pcm.c:751: error: implicit declaration of function 'kmalloc'
sound/usb/pcm.c:751: warning: assignment makes pointer from integer without a cast

Caused by commit d103d3b3e8512312b5254950035366d4422a479a ("percpu: don't
implicitly include slab.h from percpu.h") from the slabh tree interacting
with commit e5779998bf8b70e48a6cc208c8b61b33bd6117ea ("ALSA: usb-audio:
refactor code") from the sound tree.

I applied the following merge fixup patch which should be applied to the
sound tree (see Documentation/SubmitChecklist Rule #1 :-)).

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 29 Mar 2010 16:37:58 +1100
Subject: [PATCH] sound: usb pcm: use of kmalloc requires the include of slab.h

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 sound/usb/pcm.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c
index 630e220..2bf0d77 100644
--- a/sound/usb/pcm.c
+++ b/sound/usb/pcm.c
@@ -15,6 +15,7 @@
  */
 
 #include <linux/init.h>
+#include <linux/slab.h>
 #include <linux/usb.h>
 #include <linux/usb/audio.h>
 #include <linux/usb/audio-v2.h>
-- 
1.7.0.3

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

linux-next: build failure after merge of the slabh tree

[Stephen Rothwell]

Hi Tejun,

After merging the slabh tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/usb/endpoint.c: In function 'free_substream':
sound/usb/endpoint.c:47: error: implicit declaration of function 'kfree'
sound/usb/endpoint.c: In function 'snd_usb_add_audio_endpoint':
sound/usb/endpoint.c:118: error: implicit declaration of function 'kzalloc'
sound/usb/endpoint.c:118: warning: assignment makes pointer from integer without a cast
sound/usb/endpoint.c: In function 'snd_usb_parse_audio_endpoints':
sound/usb/endpoint.c:289: warning: assignment makes pointer from integer without a cast

Caused by commit d103d3b3e8512312b5254950035366d4422a479a ("percpu: don't
implicitly include slab.h from percpu.h") from the slabh tree interacting
with commit e5779998bf8b70e48a6cc208c8b61b33bd6117ea ("ALSA: usb-audio:
refactor code") from the sound tree.

I applied the following merge fixup patch which should be applied to the
sound tree (see Documentation/SubmitChecklist Rule #1 :-)).

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 29 Mar 2010 16:32:36 +1100
Subject: [PATCH] sound: usb endpoint: use of kzalloc/kfree requires the include of slab.h

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 sound/usb/endpoint.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/sound/usb/endpoint.c b/sound/usb/endpoint.c
index 7b84b61..ef07a6d 100644
--- a/sound/usb/endpoint.c
+++ b/sound/usb/endpoint.c
@@ -16,6 +16,7 @@
  */
 
 #include <linux/init.h>
+#include <linux/slab.h>
 #include <linux/usb.h>
 #include <linux/usb/audio.h>
 #include <linux/usb/audio-v2.h>
-- 
1.7.0.3

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

linux-next: build failure after merge of the slabh tree

[Stephen Rothwell]

Hi Tejun,

After merging the slabh tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/usb/format.c: In function 'parse_audio_format_rates_v1':
sound/usb/format.c:163: error: implicit declaration of function 'kmalloc'
sound/usb/format.c:163: warning: assignment makes pointer from integer without a cast
sound/usb/format.c: In function 'parse_audio_format_rates_v2':
sound/usb/format.c:231: error: implicit declaration of function 'kzalloc'
sound/usb/format.c:231: warning: assignment makes pointer from integer without a cast
sound/usb/format.c:249: warning: assignment makes pointer from integer without a cast
sound/usb/format.c:271: error: implicit declaration of function 'kfree'

Caused by commit d103d3b3e8512312b5254950035366d4422a479a ("percpu: don't
implicitly include slab.h from percpu.h") from the slabh tree interacting
with commit e5779998bf8b70e48a6cc208c8b61b33bd6117ea ("ALSA: usb-audio:
refactor code") from the sound tree.

I applied the following merge fixup patch which should be applied to the
sound tree (see Documentation/SubmitChecklist Rule #1 :-)).

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 29 Mar 2010 16:23:34 +1100
Subject: [PATCH] sound: usb format: use of kmalloc/kzalloc/kfree requires the include of slab.h

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 sound/usb/format.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/sound/usb/format.c b/sound/usb/format.c
index fcadedd..b87cf87 100644
--- a/sound/usb/format.c
+++ b/sound/usb/format.c
@@ -16,6 +16,7 @@
  */
 
 #include <linux/init.h>
+#include <linux/slab.h>
 #include <linux/usb.h>
 #include <linux/usb/audio.h>
 #include <linux/usb/audio-v2.h>
-- 
1.7.0.3

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

linux-next: build failure after merge of the slabh tree

[Stephen Rothwell]

Hi Tejun,

After merging the slabh tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/input/misc/ad714x.c: In function 'ad714x_probe':
drivers/input/misc/ad714x.c:1087: error: implicit declaration of function 'kzalloc'
drivers/input/misc/ad714x.c:1091: warning: assignment makes pointer from integer without a cast
drivers/input/misc/ad714x.c:1266: error: implicit declaration of function 'kfree'

Caused by commit d103d3b3e8512312b5254950035366d4422a479a ("percpu: don't
implicitly include slab.h from percpu.h") from the slabh tree interacting
with commit a9afb42434d88906ba9e99ef88d7aebfddaf24a4 ("Input: add Analog Devices AD714x captouch input driver") from the input tree.

I applied the following merge fixup patch which should be applied to the
input tree (see Documentation/SubmitChecklist Rule #1 :-)).

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 29 Mar 2010 16:14:15 +1100
Subject: [PATCH] Input: ad714x: use of kzalloc/kfree requires the include of slab.h

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/input/misc/ad714x.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/input/misc/ad714x.c b/drivers/input/misc/ad714x.c
index f8c4e45..0fe27ba 100644
--- a/drivers/input/misc/ad714x.c
+++ b/drivers/input/misc/ad714x.c
@@ -10,6 +10,7 @@
 #include <linux/init.h>
 #include <linux/input.h>
 #include <linux/interrupt.h>
+#include <linux/slab.h>
 #include <linux/input/ad714x.h>
 #include "ad714x.h"
 
-- 
1.7.0.3

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

linux-next: build failure after merge of the slabh tree

[Stephen Rothwell]

Hi Tejun,

After merging the slabh tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/usb/quirks.c: In function 'create_fixed_stream_quirk':
sound/usb/quirks.c:136: error: implicit declaration of function 'kmalloc'
sound/usb/quirks.c:136: warning: assignment makes pointer from integer without a cast
sound/usb/quirks.c:138: error: implicit declaration of function 'kfree'
sound/usb/quirks.c: In function 'create_uaxx_quirk':
sound/usb/quirks.c:223: warning: assignment makes pointer from integer without a cast

Caused by commit d103d3b3e8512312b5254950035366d4422a479a ("percpu: don't
implicitly include slab.h from percpu.h") from the slabh tree interacting
with commit e5779998bf8b70e48a6cc208c8b61b33bd6117ea ("ALSA: usb-audio:
refactor code") from the sound tree.

I applied the following merge fixup patch which should be applied to the
sound tree (see Documentation/SubmitChecklist Rule #1 :-)).

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 29 Mar 2010 16:08:03 +1100
Subject: [PATCH] sound: quirks: use of kmalloc/kfree requires the include of slab.h

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 sound/usb/quirks.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
index d4ced64..136e5b4 100644
--- a/sound/usb/quirks.c
+++ b/sound/usb/quirks.c
@@ -15,6 +15,7 @@
  */
 
 #include <linux/init.h>
+#include <linux/slab.h>
 #include <linux/usb.h>
 #include <linux/usb/audio.h>
 
-- 
1.7.0.3

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

linux-next: build failure after merge of the slabh tree

[Stephen Rothwell]

Hi Tejun,

After merging the slabh tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/usb/mixer_quirks.c: In function 'snd_usb_soundblaster_remote_init':
sound/usb/mixer_quirks.c:144: error: implicit declaration of function 'kmalloc'
sound/usb/mixer_quirks.c:144: warning: assignment makes pointer from integer without a cast

Caused by commit d103d3b3e8512312b5254950035366d4422a479a ("percpu: don't
implicitly include slab.h from percpu.h") from the slabh tree interacting
with commit 7b1eda223debcba706ab989a09c4eecb327aebdf ("ALSA: usb-mixer:
factor out quirks") from the sound tree.

I applied the following merge fixup patch which should be applied to the
sound tree (see Documentation/SubmitChecklist Rule #1 :-)).

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 29 Mar 2010 15:59:58 +1100
Subject: [PATCH] sound: use of kmalloc requires the include of slab.h

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 sound/usb/mixer_quirks.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/sound/usb/mixer_quirks.c b/sound/usb/mixer_quirks.c
index 56b6659..e7df1e5 100644
--- a/sound/usb/mixer_quirks.c
+++ b/sound/usb/mixer_quirks.c
@@ -26,6 +26,7 @@
  */
 
 #include <linux/init.h>
+#include <linux/slab.h>
 #include <linux/usb.h>
 #include <linux/usb/audio.h>
 
-- 
1.7.0.3

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

linux-next: build failure after merge of the slabh tree

[Stephen Rothwell]

Hi Tejun,

After merging the slabh tree, today's linux-next build (x86_64
allmodconfig) failed like this:

kernel/debug/kdb/kdb_support.c: In function 'kdb_strdup':
kernel/debug/kdb/kdb_support.c:309: error: implicit declaration of function 'kmalloc'
kernel/debug/kdb/kdb_support.c:309: warning: initialization makes pointer from integer without a cast
kernel/debug/kdb/kdb_support.c: In function 'debug_kfree':
kernel/debug/kdb/kdb_support.c:810: error: implicit declaration of function 'kfree'

Caused by commit d103d3b3e8512312b5254950035366d4422a479a ("percpu: don't
implicitly include slab.h from percpu.h") from the slabh tree interacting
with commit 5572dd736e5577dfefafe2ad3b54760e8323e33d ("kdb: core for kgdb
back end (1 of 2)") from the kgdb tree.

I applied the following merge fixup patch which should be applied to the
kdbg tree (see Documentation/SubmitChecklist Rule #1 :-)).

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 29 Mar 2010 15:49:05 +1100
Subject: [PATCH] kgdb: use of kmalloc/kfree requires the include of slab.h

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 kernel/debug/kdb/kdb_support.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/kernel/debug/kdb/kdb_support.c b/kernel/debug/kdb/kdb_support.c
index 788dbfe..45344d5 100644
--- a/kernel/debug/kdb/kdb_support.c
+++ b/kernel/debug/kdb/kdb_support.c
@@ -24,6 +24,7 @@
 #include <linux/delay.h>
 #include <linux/uaccess.h>
 #include <linux/kdb.h>
+#include <linux/slab.h>
 #include "kdb_private.h"
 
 /*
-- 
1.7.0.3

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

linux-next: build failure after merge of the slabh tree

[Stephen Rothwell]

Hi Tejun,

After merging the slabh tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

drivers/misc/hwlat_detector.c: In function 'debug_sample_fread':
drivers/misc/hwlat_detector.c:713: error: implicit declaration of function 'kzalloc'
drivers/misc/hwlat_detector.c:713: warning: assignment makes pointer from integer without a cast
drivers/misc/hwlat_detector.c:755: error: implicit declaration of function 'kfree'

Caused by commit d103d3b3e8512312b5254950035366d4422a479a ("percpu: don't
implicitly include slab.h from percpu.h") from the slabh tree interacting
with commit 94366eaeaf5ac4831637de39eac48ca62afe4e2a ("hwlat_detector: A
system hardware latency detector") from the hwlat tree.

I applied the following merge fixup which should be applied to the hwlat
tree anyway, please Jon (see Documentation/SubmitChecklist Rule #1 :-))?

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 29 Mar 2010 15:38:45 +1100
Subject: [PATCH] hwlat: using kzalloc/kfree requires the include of slab.h

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/misc/hwlat_detector.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/misc/hwlat_detector.c b/drivers/misc/hwlat_detector.c
index e02d8e1..a56baf4 100644
--- a/drivers/misc/hwlat_detector.c
+++ b/drivers/misc/hwlat_detector.c
@@ -50,6 +50,7 @@
 #include <linux/uaccess.h>
 #include <linux/version.h>
 #include <linux/delay.h>
+#include <linux/slab.h>
 
 #define BUF_SIZE_DEFAULT	262144UL		/* 8K*(sizeof(entry)) */
 #define BUF_FLAGS		(RB_FL_OVERWRITE)	/* no block on full */
-- 
1.7.0.3


-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/