* [PATCH] dmaengine: mv_xor_v2: Fix a resource leak in mv_xor_v2_remove()
@ 2022-10-24 19:50 Christophe JAILLET
2022-11-04 14:23 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2022-10-24 19:50 UTC (permalink / raw)
To: Vinod Koul, Gregory CLEMENT, Rob Herring
Cc: linux-kernel, kernel-janitors, Christophe JAILLET, dmaengine
A clk_prepare_enable() call in the probe is not balanced by a corresponding
clk_disable_unprepare() in the remove function.
Add the missing call.
Fixes: 3cd2c313f1d6 ("dmaengine: mv_xor_v2: Fix clock resource by adding a register clock")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/dma/mv_xor_v2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/dma/mv_xor_v2.c b/drivers/dma/mv_xor_v2.c
index f629ef6fd3c2..113834e1167b 100644
--- a/drivers/dma/mv_xor_v2.c
+++ b/drivers/dma/mv_xor_v2.c
@@ -893,6 +893,7 @@ static int mv_xor_v2_remove(struct platform_device *pdev)
tasklet_kill(&xor_dev->irq_tasklet);
clk_disable_unprepare(xor_dev->clk);
+ clk_disable_unprepare(xor_dev->reg_clk);
return 0;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dmaengine: mv_xor_v2: Fix a resource leak in mv_xor_v2_remove()
2022-10-24 19:50 [PATCH] dmaengine: mv_xor_v2: Fix a resource leak in mv_xor_v2_remove() Christophe JAILLET
@ 2022-11-04 14:23 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2022-11-04 14:23 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Gregory CLEMENT, Rob Herring, linux-kernel, kernel-janitors, dmaengine
On 24-10-22, 21:50, Christophe JAILLET wrote:
> A clk_prepare_enable() call in the probe is not balanced by a corresponding
> clk_disable_unprepare() in the remove function.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-04 14:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-24 19:50 [PATCH] dmaengine: mv_xor_v2: Fix a resource leak in mv_xor_v2_remove() Christophe JAILLET
2022-11-04 14:23 ` Vinod Koul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.