* [PATCH 08/12] block/vmdk: Remove superfluous breaks
@ 2020-07-13 9:05 Yi Wang
2020-07-13 9:36 ` Thomas Huth
0 siblings, 1 reply; 3+ messages in thread
From: Yi Wang @ 2020-07-13 9:05 UTC (permalink / raw)
To: qemu-devel; +Cc: wang.yi59, Liao Pingfang, wang.liang82, xue.zhihong
From: Liao Pingfang <liao.pingfang@zte.com.cn>
Remove superfluous breaks, as there is a "return" before them.
Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>
Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
block/vmdk.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index 28cec50..8f222e3 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -1053,14 +1053,11 @@ static int vmdk_open_sparse(BlockDriverState *bs, BdrvChild *file, int flags,
switch (magic) {
case VMDK3_MAGIC:
return vmdk_open_vmfs_sparse(bs, file, flags, errp);
- break;
case VMDK4_MAGIC:
return vmdk_open_vmdk4(bs, file, flags, options, errp);
- break;
default:
error_setg(errp, "Image not in VMDK format");
return -EINVAL;
- break;
}
}
--
2.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 08/12] block/vmdk: Remove superfluous breaks
2020-07-13 9:05 [PATCH 08/12] block/vmdk: Remove superfluous breaks Yi Wang
@ 2020-07-13 9:36 ` Thomas Huth
2020-09-01 6:37 ` Laurent Vivier
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Huth @ 2020-07-13 9:36 UTC (permalink / raw)
To: Yi Wang, qemu-devel
Cc: xue.zhihong, QEMU Trivial, Qemu-block, wang.liang82, Liao Pingfang
On 13/07/2020 11.05, Yi Wang wrote:
> From: Liao Pingfang <liao.pingfang@zte.com.cn>
>
> Remove superfluous breaks, as there is a "return" before them.
>
> Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>
> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> block/vmdk.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/block/vmdk.c b/block/vmdk.c
> index 28cec50..8f222e3 100644
> --- a/block/vmdk.c
> +++ b/block/vmdk.c
> @@ -1053,14 +1053,11 @@ static int vmdk_open_sparse(BlockDriverState *bs, BdrvChild *file, int flags,
> switch (magic) {
> case VMDK3_MAGIC:
> return vmdk_open_vmfs_sparse(bs, file, flags, errp);
> - break;
> case VMDK4_MAGIC:
> return vmdk_open_vmdk4(bs, file, flags, options, errp);
> - break;
> default:
> error_setg(errp, "Image not in VMDK format");
> return -EINVAL;
> - break;
> }
> }
>
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 08/12] block/vmdk: Remove superfluous breaks
2020-07-13 9:36 ` Thomas Huth
@ 2020-09-01 6:37 ` Laurent Vivier
0 siblings, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2020-09-01 6:37 UTC (permalink / raw)
To: Thomas Huth, Yi Wang, qemu-devel
Cc: QEMU Trivial, wang.liang82, Liao Pingfang, Qemu-block, xue.zhihong
Le 13/07/2020 à 11:36, Thomas Huth a écrit :
> On 13/07/2020 11.05, Yi Wang wrote:
>> From: Liao Pingfang <liao.pingfang@zte.com.cn>
>>
>> Remove superfluous breaks, as there is a "return" before them.
>>
>> Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>
>> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
>> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>> block/vmdk.c | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/block/vmdk.c b/block/vmdk.c
>> index 28cec50..8f222e3 100644
>> --- a/block/vmdk.c
>> +++ b/block/vmdk.c
>> @@ -1053,14 +1053,11 @@ static int vmdk_open_sparse(BlockDriverState *bs, BdrvChild *file, int flags,
>> switch (magic) {
>> case VMDK3_MAGIC:
>> return vmdk_open_vmfs_sparse(bs, file, flags, errp);
>> - break;
>> case VMDK4_MAGIC:
>> return vmdk_open_vmdk4(bs, file, flags, options, errp);
>> - break;
>> default:
>> error_setg(errp, "Image not in VMDK format");
>> return -EINVAL;
>> - break;
>> }
>> }
>>
>>
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
>
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-01 6:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-13 9:05 [PATCH 08/12] block/vmdk: Remove superfluous breaks Yi Wang
2020-07-13 9:36 ` Thomas Huth
2020-09-01 6:37 ` Laurent Vivier
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.