From: m.brock@vanmierlo.com To: Manikanta Guntupalli <manikanta.guntupalli@amd.com> Cc: git@amd.com, michal.simek@amd.com, gregkh@linuxfoundation.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, jirislaby@kernel.org, linux-arm-kernel@lists.infradead.org, radhey.shyam.pandey@amd.com, srinivas.goud@amd.com, shubhrajyoti.datta@amd.com, manion05gk@gmail.com Subject: Re: [PATCH V3 1/2] dt-bindings: Add optional gpio property to uartps node to support rs485 Date: Sat, 28 Oct 2023 12:59:28 +0200 [thread overview] Message-ID: <ea3ee738155af7a0f19c2fef3a482a7d@vanmierlo.com> (raw) In-Reply-To: <20231024144847.2316941-2-manikanta.guntupalli@amd.com> Manikanta Guntupalli schreef op 2023-10-24 16:48: > Add optional gpio property to uartps node and reference to rs485.yaml > > On Xilinx/AMD Kria SOM KD240 board rs485 connects via TI ISOW1432 > Transceiver device, where one GPIO is used for driving DE/RE signals. > With rs485 half duplex configuration, DE and RE are shorted to each > other, > and at a time, any node acts as either a driver or a receiver. > > Here, > DE - Driver enable. If pin is floating, driver is disabled. > RE - Receiver enable. If pin is floating, receiver buffer is disabled. > > For more deatils, please find below link which contains Transceiver > device(ISOW1432) datasheet > https://www.ti.com/lit/ds/symlink/isow1432.pdf?ts=1682607122706&ref_url=https%253A%252F%252Fwww.ti.com%252Fproduct%252FISOW1432%252Fpart-details%252FISOW1432DFMR%253FkeyMatch%253DISOW1432DFMR%2526tisearch%253Dsearch-everything%2526usecase%253DOPN > > rts-gpios is optional property, because it is not required > for uart console node. > > Signed-off-by: Manikanta Guntupalli <manikanta.guntupalli@amd.com> > --- > Changes for V2: > Modify optional gpio name to xlnx,phy-ctrl-gpios. > Update commit description. > Changes for V3: > Modify optional gpio name to rts-gpios. > Update commit description. > --- > Documentation/devicetree/bindings/serial/cdns,uart.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/serial/cdns,uart.yaml > b/Documentation/devicetree/bindings/serial/cdns,uart.yaml > index e35ad1109efc..7ee305f9a45f 100644 > --- a/Documentation/devicetree/bindings/serial/cdns,uart.yaml > +++ b/Documentation/devicetree/bindings/serial/cdns,uart.yaml > @@ -46,6 +46,11 @@ properties: > power-domains: > maxItems: 1 > > + rts-gpios: > + description: Optional GPIO to control transmit/receive on RS485 > phy > + in halfduplex mode. > + maxItems: 1 > + Why would this be related to RS485? A user could also have a need for a gpio instead of the native pin to be used as normal rts. All RS485 references can be removed. > required: > - compatible > - reg > @@ -55,6 +60,7 @@ required: > > allOf: > - $ref: serial.yaml# > + - $ref: rs485.yaml# > - if: > properties: > compatible: Maarten
WARNING: multiple messages have this Message-ID (diff)
From: m.brock@vanmierlo.com To: Manikanta Guntupalli <manikanta.guntupalli@amd.com> Cc: git@amd.com, michal.simek@amd.com, gregkh@linuxfoundation.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, jirislaby@kernel.org, linux-arm-kernel@lists.infradead.org, radhey.shyam.pandey@amd.com, srinivas.goud@amd.com, shubhrajyoti.datta@amd.com, manion05gk@gmail.com Subject: Re: [PATCH V3 1/2] dt-bindings: Add optional gpio property to uartps node to support rs485 Date: Sat, 28 Oct 2023 12:59:28 +0200 [thread overview] Message-ID: <ea3ee738155af7a0f19c2fef3a482a7d@vanmierlo.com> (raw) In-Reply-To: <20231024144847.2316941-2-manikanta.guntupalli@amd.com> Manikanta Guntupalli schreef op 2023-10-24 16:48: > Add optional gpio property to uartps node and reference to rs485.yaml > > On Xilinx/AMD Kria SOM KD240 board rs485 connects via TI ISOW1432 > Transceiver device, where one GPIO is used for driving DE/RE signals. > With rs485 half duplex configuration, DE and RE are shorted to each > other, > and at a time, any node acts as either a driver or a receiver. > > Here, > DE - Driver enable. If pin is floating, driver is disabled. > RE - Receiver enable. If pin is floating, receiver buffer is disabled. > > For more deatils, please find below link which contains Transceiver > device(ISOW1432) datasheet > https://www.ti.com/lit/ds/symlink/isow1432.pdf?ts=1682607122706&ref_url=https%253A%252F%252Fwww.ti.com%252Fproduct%252FISOW1432%252Fpart-details%252FISOW1432DFMR%253FkeyMatch%253DISOW1432DFMR%2526tisearch%253Dsearch-everything%2526usecase%253DOPN > > rts-gpios is optional property, because it is not required > for uart console node. > > Signed-off-by: Manikanta Guntupalli <manikanta.guntupalli@amd.com> > --- > Changes for V2: > Modify optional gpio name to xlnx,phy-ctrl-gpios. > Update commit description. > Changes for V3: > Modify optional gpio name to rts-gpios. > Update commit description. > --- > Documentation/devicetree/bindings/serial/cdns,uart.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/serial/cdns,uart.yaml > b/Documentation/devicetree/bindings/serial/cdns,uart.yaml > index e35ad1109efc..7ee305f9a45f 100644 > --- a/Documentation/devicetree/bindings/serial/cdns,uart.yaml > +++ b/Documentation/devicetree/bindings/serial/cdns,uart.yaml > @@ -46,6 +46,11 @@ properties: > power-domains: > maxItems: 1 > > + rts-gpios: > + description: Optional GPIO to control transmit/receive on RS485 > phy > + in halfduplex mode. > + maxItems: 1 > + Why would this be related to RS485? A user could also have a need for a gpio instead of the native pin to be used as normal rts. All RS485 references can be removed. > required: > - compatible > - reg > @@ -55,6 +60,7 @@ required: > > allOf: > - $ref: serial.yaml# > + - $ref: rs485.yaml# > - if: > properties: > compatible: Maarten _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-10-28 10:59 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-10-24 14:48 [PATCH V3 0/2] Add rs485 support to uartps driver Manikanta Guntupalli 2023-10-24 14:48 ` Manikanta Guntupalli 2023-10-24 14:48 ` [PATCH V3 1/2] dt-bindings: Add optional gpio property to uartps node to support rs485 Manikanta Guntupalli 2023-10-24 14:48 ` Manikanta Guntupalli 2023-10-26 18:07 ` Rob Herring 2023-10-26 18:07 ` Rob Herring 2023-10-28 10:59 ` m.brock [this message] 2023-10-28 10:59 ` m.brock 2023-10-24 14:48 ` [PATCH V3 2/2] tty: serial: uartps: Add rs485 support to uartps driver Manikanta Guntupalli 2023-10-24 14:48 ` Manikanta Guntupalli 2023-10-24 15:02 ` Ilpo Järvinen 2023-10-24 15:02 ` Ilpo Järvinen 2023-11-04 15:46 ` m.brock 2023-11-04 15:46 ` m.brock 2023-11-10 11:44 ` Guntupalli, Manikanta 2023-11-10 11:44 ` Guntupalli, Manikanta 2023-11-12 19:37 ` Lino Sanfilippo 2023-11-12 19:37 ` Lino Sanfilippo 2023-11-15 6:50 ` Guntupalli, Manikanta 2023-11-15 6:50 ` Guntupalli, Manikanta 2023-11-18 19:35 ` Lino Sanfilippo 2023-11-18 19:35 ` Lino Sanfilippo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ea3ee738155af7a0f19c2fef3a482a7d@vanmierlo.com \ --to=m.brock@vanmierlo.com \ --cc=conor+dt@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=git@amd.com \ --cc=gregkh@linuxfoundation.org \ --cc=jirislaby@kernel.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-serial@vger.kernel.org \ --cc=manikanta.guntupalli@amd.com \ --cc=manion05gk@gmail.com \ --cc=michal.simek@amd.com \ --cc=radhey.shyam.pandey@amd.com \ --cc=robh+dt@kernel.org \ --cc=shubhrajyoti.datta@amd.com \ --cc=srinivas.goud@amd.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.