All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xavier Claessens <xavier.claessens@collabora.com>
To: Ezequiel Garcia <ezequiel@collabora.com>,
	kieran.bingham@ideasonboard.com,
	Ariel D'Alessandro <ariel@vanguardiasur.com.ar>,
	linux-media@vger.kernel.org
Cc: hverkuil@xs4all.nl, sean@mess.org, p.zabel@pengutronix.de,
	laurent.pinchart@ideasonboard.com, nicolas@ndufresne.ca,
	gjasny@googlemail.com,
	nicolas Dufresne <nicolas.dufresne@collabora.com>
Subject: Re: [PATCH v1 1/1] Add support for meson building
Date: Fri, 19 Jun 2020 15:04:57 -0400	[thread overview]
Message-ID: <ea49c99ceeba47cee958fed6b04773963757d49d.camel@collabora.com> (raw)
In-Reply-To: <f2bf8846e265024c20a77fa618d54455b3b7ca95.camel@collabora.com>

Le vendredi 19 juin 2020 à 11:12 -0300, Ezequiel Garcia a écrit :
> I've looked through, and about the only thing that stands out to me
> > is
> > the way you're joining strings.
> > 
> > Meson provides a join_paths() function specifically for that.
> > Now we're "probably" not going to build this library on anything
> > other
> > than linux, but I think the function still has merit over the
> > arbitrary
> > strings which I mis-interpreted for 'divide' at first glance :S
> > 

Note that you can also use 'some' / 'path' instead of
join_paths('some', 'path'). AFAIK '/' works fine in Windows paths too.


  parent reply	other threads:[~2020-06-19 19:05 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-18 13:33 [PATCH v1 0/1] Add support for meson building Ariel D'Alessandro
2020-06-18 13:33 ` [PATCH v1 1/1] " Ariel D'Alessandro
2020-06-18 13:57   ` Kieran Bingham
2020-06-18 14:06     ` Laurent Pinchart
2020-06-18 14:11       ` Kieran Bingham
2020-06-19 14:12     ` Ezequiel Garcia
2020-06-19 14:42       ` Laurent Pinchart
2020-06-19 18:40         ` Xavier Claessens
2020-06-20  4:45           ` VDRU VDRU
2020-06-22 18:07           ` Gregor Jasny
2020-06-22 19:09             ` Gregor Jasny
2020-06-23 17:26               ` Ariel D'Alessandro
2020-06-24 19:46                 ` Gregor Jasny
2020-06-25 18:32                   ` Ariel D'Alessandro
2020-06-29 18:44                     ` Gregor Jasny
2020-07-03  2:15                       ` Ariel D'Alessandro
2020-06-25 18:52                 ` Ariel D'Alessandro
2020-06-29 18:56                   ` Gregor Jasny
2020-07-08  5:48                     ` Ariel D'Alessandro
2020-07-16 19:48                       ` Gregor Jasny
2020-06-19 19:04       ` Xavier Claessens [this message]
2020-06-22 19:19     ` Ariel D'Alessandro
2020-06-19 12:10 ` [PATCH v1 0/1] " Sean Young
2020-06-19 14:09   ` Ezequiel Garcia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ea49c99ceeba47cee958fed6b04773963757d49d.camel@collabora.com \
    --to=xavier.claessens@collabora.com \
    --cc=ariel@vanguardiasur.com.ar \
    --cc=ezequiel@collabora.com \
    --cc=gjasny@googlemail.com \
    --cc=hverkuil@xs4all.nl \
    --cc=kieran.bingham@ideasonboard.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=nicolas.dufresne@collabora.com \
    --cc=nicolas@ndufresne.ca \
    --cc=p.zabel@pengutronix.de \
    --cc=sean@mess.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.