* [PATCH] brcmfmac: fix error return code in brcmf_cfg80211_connect()
@ 2020-11-13 6:28 Zhang Changzhong
2020-11-13 8:45 ` Chi-Hsien.Lin
2020-11-24 15:00 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Zhang Changzhong @ 2020-11-13 6:28 UTC (permalink / raw)
To: arend.vanspriel, franky.lin, hante.meuleman, chi-hsien.lin,
wright.feng, kvalo, davem, kuba, stanley.hsu
Cc: linux-wireless, brcm80211-dev-list.pdl, brcm80211-dev-list,
netdev, linux-kernel
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Fixes: 3b1e0a7bdfee ("brcmfmac: add support for SAE authentication offload")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
index a2dbbb9..0ee421f 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
@@ -2137,7 +2137,8 @@ brcmf_cfg80211_connect(struct wiphy *wiphy, struct net_device *ndev,
BRCMF_WSEC_MAX_PSK_LEN);
else if (profile->use_fwsup == BRCMF_PROFILE_FWSUP_SAE) {
/* clean up user-space RSNE */
- if (brcmf_fil_iovar_data_set(ifp, "wpaie", NULL, 0)) {
+ err = brcmf_fil_iovar_data_set(ifp, "wpaie", NULL, 0);
+ if (err) {
bphy_err(drvr, "failed to clean up user-space RSNE\n");
goto done;
}
--
2.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] brcmfmac: fix error return code in brcmf_cfg80211_connect()
2020-11-13 6:28 [PATCH] brcmfmac: fix error return code in brcmf_cfg80211_connect() Zhang Changzhong
@ 2020-11-13 8:45 ` Chi-Hsien.Lin
2020-11-24 15:00 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Chi-Hsien.Lin @ 2020-11-13 8:45 UTC (permalink / raw)
To: zhangchangzhong, arend.vanspriel, franky.lin, hante.meuleman,
Wright.Feng, kvalo, davem, kuba, Chung-Hsien.Hsu
Cc: linux-wireless, brcm80211-dev-list.pdl, brcm80211-dev-list,
netdev, linux-kernel
> Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in th>
>
> Fixes: 3b1e0a7bdfee ("brcmfmac: add support for SAE authentication offload")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Reviewed-by: Chi-hsien Lin <chi-hsien.lin@infineon.com>
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadc>
> index a2dbbb9..0ee421f 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> @@ -2137,7 +2137,8 @@ brcmf_cfg80211_connect(struct wiphy *wiphy, struct net_device *ndev,
> BRCMF_WSEC_MAX_PSK_LEN);
> else if (profile->use_fwsup == BRCMF_PROFILE_FWSUP_SAE) {
> /* clean up user-space RSNE */
> - if (brcmf_fil_iovar_data_set(ifp, "wpaie", NULL, 0)) {
> + err = brcmf_fil_iovar_data_set(ifp, "wpaie", NULL, 0);
> + if (err) {
> bphy_err(drvr, "failed to clean up user-space RSNE\n");
> goto done;
> }
> --
> 2.9.5
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] brcmfmac: fix error return code in brcmf_cfg80211_connect()
2020-11-13 6:28 [PATCH] brcmfmac: fix error return code in brcmf_cfg80211_connect() Zhang Changzhong
2020-11-13 8:45 ` Chi-Hsien.Lin
@ 2020-11-24 15:00 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2020-11-24 15:00 UTC (permalink / raw)
To: Zhang Changzhong
Cc: arend.vanspriel, franky.lin, hante.meuleman, chi-hsien.lin,
wright.feng, davem, kuba, stanley.hsu, linux-wireless,
brcm80211-dev-list.pdl, brcm80211-dev-list, netdev, linux-kernel
Zhang Changzhong <zhangchangzhong@huawei.com> wrote:
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: 3b1e0a7bdfee ("brcmfmac: add support for SAE authentication offload")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
> Reviewed-by: Chi-hsien Lin <chi-hsien.lin@infineon.com>
Patch applied to wireless-drivers-next.git, thanks.
37ff144d29ac brcmfmac: fix error return code in brcmf_cfg80211_connect()
--
https://patchwork.kernel.org/project/linux-wireless/patch/1605248896-16812-1-git-send-email-zhangchangzhong@huawei.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-24 15:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-13 6:28 [PATCH] brcmfmac: fix error return code in brcmf_cfg80211_connect() Zhang Changzhong
2020-11-13 8:45 ` Chi-Hsien.Lin
2020-11-24 15:00 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.