All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Rasesh Mody <rmody@marvell.com>,
	Sudarsana Kalluru <skalluru@marvell.com>,
	GR-Linux-NIC-Dev@marvell.com
Cc: "David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH -next 031/491] BROCADE BNA 10 GIGABIT ETHERNET DRIVER: Use fallthrough;
Date: Tue, 10 Mar 2020 21:51:45 -0700	[thread overview]
Message-ID: <ea7518e03a5bda3fb9de0f25a0e6624d4d6e7eea.1583896349.git.joe@perches.com> (raw)
In-Reply-To: <cover.1583896344.git.joe@perches.com>

Convert the various uses of fallthrough comments to fallthrough;

Done via script
Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/

Signed-off-by: Joe Perches <joe@perches.com>
---
 drivers/net/ethernet/brocade/bna/bfa_ioc.c   | 8 +++-----
 drivers/net/ethernet/brocade/bna/bna_enet.c  | 2 +-
 drivers/net/ethernet/brocade/bna/bna_tx_rx.c | 3 +--
 3 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/drivers/net/ethernet/brocade/bna/bfa_ioc.c b/drivers/net/ethernet/brocade/bna/bfa_ioc.c
index e17bfc..e9248c 100644
--- a/drivers/net/ethernet/brocade/bna/bfa_ioc.c
+++ b/drivers/net/ethernet/brocade/bna/bfa_ioc.c
@@ -321,7 +321,7 @@ bfa_ioc_sm_getattr(struct bfa_ioc *ioc, enum ioc_event event)
 	case IOC_E_PFFAILED:
 	case IOC_E_HWERROR:
 		del_timer(&ioc->ioc_timer);
-		/* fall through */
+		fallthrough;
 	case IOC_E_TIMEOUT:
 		ioc->cbfn->enable_cbfn(ioc->bfa, BFA_STATUS_IOC_FAILURE);
 		bfa_fsm_set_state(ioc, bfa_ioc_sm_fail);
@@ -780,8 +780,7 @@ bfa_iocpf_sm_enabling(struct bfa_iocpf *iocpf, enum iocpf_event event)
 
 	case IOCPF_E_INITFAIL:
 		del_timer(&ioc->iocpf_timer);
-		/* fall through */
-
+		fallthrough;
 	case IOCPF_E_TIMEOUT:
 		bfa_nw_ioc_hw_sem_release(ioc);
 		if (event == IOCPF_E_TIMEOUT)
@@ -849,8 +848,7 @@ bfa_iocpf_sm_disabling(struct bfa_iocpf *iocpf, enum iocpf_event event)
 
 	case IOCPF_E_FAIL:
 		del_timer(&ioc->iocpf_timer);
-		/* fall through*/
-
+		fallthrough;
 	case IOCPF_E_TIMEOUT:
 		bfa_ioc_set_cur_ioc_fwstate(ioc, BFI_IOC_FAIL);
 		bfa_fsm_set_state(iocpf, bfa_iocpf_sm_disabling_sync);
diff --git a/drivers/net/ethernet/brocade/bna/bna_enet.c b/drivers/net/ethernet/brocade/bna/bna_enet.c
index 40107a9..a2c983 100644
--- a/drivers/net/ethernet/brocade/bna/bna_enet.c
+++ b/drivers/net/ethernet/brocade/bna/bna_enet.c
@@ -1084,7 +1084,7 @@ bna_enet_sm_cfg_wait(struct bna_enet *enet,
 
 	case ENET_E_CHLD_STOPPED:
 		bna_enet_rx_start(enet);
-		/* Fall through */
+		fallthrough;
 	case ENET_E_FWRESP_PAUSE:
 		if (enet->flags & BNA_ENET_F_PAUSE_CHANGED) {
 			enet->flags &= ~BNA_ENET_F_PAUSE_CHANGED;
diff --git a/drivers/net/ethernet/brocade/bna/bna_tx_rx.c b/drivers/net/ethernet/brocade/bna/bna_tx_rx.c
index b5ecbfe..cd2bfb 100644
--- a/drivers/net/ethernet/brocade/bna/bna_tx_rx.c
+++ b/drivers/net/ethernet/brocade/bna/bna_tx_rx.c
@@ -1636,8 +1636,7 @@ bna_bfi_rx_enet_start(struct bna_rx *rx)
 						&q1->qpt);
 			cfg_req->q_cfg[i].qs.rx_buffer_size =
 				htons((u16)q1->buffer_size);
-			/* Fall through */
-
+			fallthrough;
 		case BNA_RXP_SINGLE:
 			/* Large/Single RxQ */
 			bfi_enet_datapath_q_init(&cfg_req->q_cfg[i].ql.q,
-- 
2.24.0


      parent reply	other threads:[~2020-03-11  5:07 UTC|newest]

Thread overview: 187+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-11  4:51 [MPTCP] [PATCH -next 000/491] treewide: use fallthrough; Joe Perches
2020-03-11 17:24 ` Joe Perches
2020-03-11  4:51 ` [Bridge] " Joe Perches
2020-03-11  4:51 ` [Cluster-devel] " Joe Perches
2020-03-11  4:51 ` [OpenRISC] " Joe Perches
2020-03-11  4:51 ` [Intel-wired-lan] " Joe Perches
2020-03-11  4:51 ` [OpenRISC] " Joe Perches
2020-03-11  4:51 ` Joe Perches
2020-03-11  4:51 ` Joe Perches
2020-03-11  4:51 ` Joe Perches
2020-03-11  4:51 ` [Xen-devel] " Joe Perches
2020-03-11  4:51 ` [Intel-gfx] " Joe Perches
2020-03-11  4:51 ` Joe Perches
2020-03-11  4:51 ` Joe Perches
2020-03-11  4:51 ` Joe Perches
2020-03-11  4:51 ` Joe Perches
2020-03-11  4:51 ` Joe Perches
2020-03-11  4:51 ` Joe Perches
2020-03-11  4:51 ` Joe Perches
2020-03-11  4:51 ` [f2fs-dev] " Joe Perches
2020-03-11  4:51 ` Joe Perches
2020-03-11  4:51 ` Joe Perches
2020-03-11  4:51 ` [Ocfs2-devel] " Joe Perches
2020-03-11  4:51 ` Joe Perches
2020-03-11  4:51 ` Joe Perches
2020-03-11  4:51 ` Joe Perches
2020-03-11  4:51 ` Joe Perches
2020-03-11  4:51 ` [PATCH -next 001/491] MELLANOX ETHERNET INNOVA DRIVERS: Use fallthrough; Joe Perches
2020-03-11  7:01   ` Leon Romanovsky
2020-03-12  6:23   ` David Miller
2020-03-12  6:26     ` Joe Perches
2020-03-12  8:03       ` David Miller
2020-03-12 19:45       ` Jakub Kicinski
2020-03-12 19:52         ` Joe Perches
2020-03-11  4:51 ` [PATCH -next 002/491] MARVELL OCTEONTX2 RVU ADMIN FUNCTION DRIVER: " Joe Perches
2020-03-11  4:51 ` [PATCH -next 003/491] MELLANOX MLX5 core VPI driver: " Joe Perches
2020-03-11  7:00   ` Leon Romanovsky
2020-03-11  4:51 ` [PATCH -next 004/491] PERFORMANCE EVENTS SUBSYSTEM: " Joe Perches
2020-03-11 15:30   ` Peter Zijlstra
2020-03-12  6:15     ` Joe Perches
2020-03-11 19:20   ` Thomas Bogendoerfer
2020-03-11  4:51 ` [PATCH -next 005/491] ARM/UNIPHIER ARCHITECTURE: " Joe Perches
2020-03-11  4:51   ` Joe Perches
2020-03-11  5:15   ` Masahiro Yamada
2020-03-11  5:15     ` Masahiro Yamada
2020-03-11 14:31     ` Joe Perches
2020-03-11 14:31       ` Joe Perches
2020-03-12  8:56       ` Greg Kroah-Hartman
2020-03-12  8:56         ` Greg Kroah-Hartman
2020-03-12  9:02         ` Masahiro Yamada
2020-03-12  9:02           ` Masahiro Yamada
2020-03-12  9:36           ` Greg Kroah-Hartman
2020-03-12  9:36             ` Greg Kroah-Hartman
2020-03-12  9:37           ` Joe Perches
2020-03-12  9:37             ` Joe Perches
2020-03-12 13:47             ` Theodore Y. Ts'o
2020-03-12 13:47               ` Theodore Y. Ts'o
2020-03-12 14:15               ` Joe Perches
2020-03-12 14:15                 ` Joe Perches
2020-03-12  9:03         ` Joe Perches
2020-03-12  9:03           ` Joe Perches
2020-03-11  4:51 ` [PATCH -next 006/491] ARM/RISCPC " Joe Perches
2020-03-11  4:51   ` Joe Perches
2020-03-12 10:11   ` Russell King - ARM Linux admin
2020-03-12 10:11     ` Russell King - ARM Linux admin
2020-03-12 10:19     ` Joe Perches
2020-03-12 10:19       ` Joe Perches
2020-03-11  4:51 ` [PATCH -next 007/491] KERNEL VIRTUAL MACHINE FOR ARM/ARM64 (KVM/arm, KVM/arm64): " Joe Perches
2020-03-11  4:51   ` Joe Perches
2020-03-11  4:51   ` Joe Perches
2020-03-11  4:51 ` [PATCH -next 008/491] ARM/CIRRUS LOGIC EP93XX ARM ARCHITECTURE: " Joe Perches
2020-03-11  4:51   ` Joe Perches
2020-03-13 19:26   ` Alexander Sverdlin
2020-03-13 19:26     ` Alexander Sverdlin
2020-03-11  4:51 ` [PATCH -next 009/491] ARM/Amlogic Meson SoC support: " Joe Perches
2020-03-11  4:51   ` Joe Perches
2020-03-11  4:51   ` Joe Perches
2020-03-11  4:51 ` [PATCH -next 010/491] ARM/SAMSUNG EXYNOS ARM ARCHITECTURES: " Joe Perches
2020-03-11  4:51   ` Joe Perches
2020-03-13 14:26   ` Wolfram Sang
2020-03-13 14:26     ` Wolfram Sang
2020-03-14  1:17   ` Stephen Boyd
2020-03-14  1:17     ` Stephen Boyd
2020-05-13 11:59     ` Sylwester Nawrocki
2020-05-13 11:59       ` Sylwester Nawrocki
2020-03-11  4:51 ` [PATCH -next 011/491] ARM/QUALCOMM SUPPORT: " Joe Perches
2020-03-11  5:23   ` Amit Kucheria
2020-03-11  8:46   ` Marc Gonzalez
2020-03-11  8:46     ` Marc Gonzalez
2020-03-11 14:30     ` Joe Perches
2020-03-11 14:30       ` Joe Perches
2020-03-13 12:04   ` Stanimir Varbanov
2020-03-11  4:51 ` [PATCH -next 012/491] ARM/ZTE ARCHITECTURE: " Joe Perches
2020-03-11  4:51   ` Joe Perches
2020-03-11  4:51   ` Joe Perches
2020-03-11  4:51 ` [PATCH -next 013/491] INGENIC JZ47xx SoCs: " Joe Perches
2020-03-11  4:51   ` Joe Perches
2020-03-11  4:51   ` Joe Perches
2020-03-11  4:51   ` Joe Perches
2020-03-11  7:40   ` Miquel Raynal
2020-03-11  7:40     ` Miquel Raynal
2020-03-11  7:40     ` Miquel Raynal
2020-03-11  7:40     ` Miquel Raynal
2020-03-11 14:20     ` Ulf Hansson
2020-03-11 14:20       ` Ulf Hansson
2020-03-11 14:20       ` Ulf Hansson
2020-03-11 14:20       ` Ulf Hansson
2020-03-11 14:29       ` Miquel Raynal
2020-03-11 14:29         ` Miquel Raynal
2020-03-11 14:29         ` Miquel Raynal
2020-03-11 14:29         ` Miquel Raynal
2020-03-12  6:26     ` Joe Perches
2020-03-12  6:26       ` Joe Perches
2020-03-12  6:26       ` Joe Perches
2020-03-12  6:26       ` Joe Perches
2020-03-11  4:51 ` [PATCH -next 014/491] DECSTATION PLATFORM SUPPORT: " Joe Perches
2020-03-11 19:19   ` Thomas Bogendoerfer
2020-03-11  4:51 ` [PATCH -next 015/491] KERNEL VIRTUAL MACHINE FOR MIPS (KVM/mips): " Joe Perches
2020-03-11 19:20   ` Thomas Bogendoerfer
2020-03-11  4:51 ` [PATCH -next 016/491] KERNEL VIRTUAL MACHINE FOR POWERPC (KVM/powerpc): " Joe Perches
2020-03-11  4:51   ` Joe Perches
2020-03-11  4:51   ` Joe Perches
2020-03-19  1:18   ` Paul Mackerras
2020-03-19  1:18     ` Paul Mackerras
2020-03-19  1:18     ` Paul Mackerras
2020-03-19  1:22     ` Joe Perches
2020-03-19  1:22       ` Joe Perches
2020-03-19  1:22       ` Joe Perches
2020-03-19 23:33       ` Paul Mackerras
2020-03-19 23:33         ` Paul Mackerras
2020-03-19 23:33         ` Paul Mackerras
2020-03-11  4:51 ` [PATCH -next 017/491] CELL BROADBAND ENGINE ARCHITECTURE: " Joe Perches
2020-03-11  4:51   ` Joe Perches
2020-03-11  8:08   ` Arnd Bergmann
2020-03-11  8:08     ` Arnd Bergmann
2020-03-26 12:06   ` Michael Ellerman
2020-03-26 12:06     ` Michael Ellerman
2020-03-11  4:51 ` [PATCH -next 018/491] KERNEL VIRTUAL MACHINE for s390 (KVM/s390): " Joe Perches
2020-03-11 11:33   ` Christian Borntraeger
2020-03-13 12:04   ` Christian Borntraeger
2020-03-11  4:51 ` [PATCH -next 019/491] Hyper-V CORE AND DRIVERS: " Joe Perches
2020-03-11  4:51   ` Joe Perches
2020-03-11  4:51   ` Joe Perches
2020-03-11 11:00   ` Wei Liu
2020-03-11 11:00     ` Wei Liu
2020-03-11 11:00     ` Wei Liu
2020-03-11  4:51 ` [PATCH -next 020/491] XEN HYPERVISOR INTERFACE: " Joe Perches
2020-03-11  4:51   ` [Xen-devel] " Joe Perches
2020-03-11  6:47   ` Jürgen Groß
2020-03-11  6:47     ` [Xen-devel] " Jürgen Groß
2020-03-11  4:51 ` [PATCH -next 021/491] KERNEL VIRTUAL MACHINE FOR X86 (KVM/x86): " Joe Perches
2020-03-11  9:43   ` Paolo Bonzini
2020-03-11  4:51 ` [PATCH -next 022/491] X86 MCE INFRASTRUCTURE: " Joe Perches
2020-03-11 17:14   ` Borislav Petkov
2020-03-11  4:51 ` [PATCH -next 023/491] AMD KFD: " Joe Perches
2020-03-11  4:51   ` Joe Perches
2020-03-11  4:51   ` Joe Perches
2020-03-11 21:50   ` Felix Kuehling
2020-03-11 21:50     ` Felix Kuehling
2020-03-11 21:50     ` Felix Kuehling
2020-03-11 22:09     ` Joe Perches
2020-03-11 22:09       ` Joe Perches
2020-03-11 22:09       ` Joe Perches
2020-03-12 14:12       ` Alex Deucher
2020-03-12 14:12         ` Alex Deucher
2020-03-12 14:12         ` Alex Deucher
2020-03-11  4:51 ` [PATCH -next 024/491] AMD DISPLAY CORE: " Joe Perches
2020-03-11  4:51   ` Joe Perches
2020-03-11  4:51   ` Joe Perches
2020-03-12 14:10   ` Alex Deucher
2020-03-12 14:10     ` Alex Deucher
2020-03-12 14:10     ` Alex Deucher
2020-03-11  4:51 ` [PATCH -next 025/491] AMD POWERPLAY: " Joe Perches
2020-03-11  4:51   ` Joe Perches
2020-03-11  4:51   ` Joe Perches
2020-03-12 14:10   ` Alex Deucher
2020-03-12 14:10     ` Alex Deucher
2020-03-12 14:10     ` Alex Deucher
2020-03-11  4:51 ` [PATCH -next 026/491] INTEL GVT-g DRIVERS (Intel GPU Virtualization): " Joe Perches
2020-03-11  4:51   ` [Intel-gfx] " Joe Perches
2020-03-11  4:51   ` Joe Perches
2020-03-11  4:51 ` [PATCH -next 027/491] AMD XGBE DRIVER: " Joe Perches
2020-03-11  4:51 ` [PATCH -next 028/491] BROADCOM BNX2X 10 GIGABIT ETHERNET " Joe Perches
2020-03-11  4:51 ` [PATCH -next 029/491] BROADCOM BNXT_EN 50 " Joe Perches
2020-03-11  4:51 ` [PATCH -next 030/491] BROADCOM GENET " Joe Perches
2020-03-11 16:35   ` Florian Fainelli
2020-03-11  4:51 ` Joe Perches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ea7518e03a5bda3fb9de0f25a0e6624d4d6e7eea.1583896349.git.joe@perches.com \
    --to=joe@perches.com \
    --cc=GR-Linux-NIC-Dev@marvell.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rmody@marvell.com \
    --cc=skalluru@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.