From: Masahiro Yamada <masahiroy@kernel.org> To: Joe Perches <joe@perches.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jiri Slaby <jslaby@suse.com>, linux-serial@vger.kernel.org, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [PATCH -next 005/491] ARM/UNIPHIER ARCHITECTURE: Use fallthrough; Date: Wed, 11 Mar 2020 14:15:10 +0900 [thread overview] Message-ID: <CAK7LNAS7GAk9yXkPhbS3ByU+n9Gb-rk0PeLcXLCNwpW1B22aeg@mail.gmail.com> (raw) In-Reply-To: <dae0878058223a42c77d725b8d7c5845a7ef9dc0.1583896348.git.joe@perches.com> On Wed, Mar 11, 2020 at 2:07 PM Joe Perches <joe@perches.com> wrote: > > Convert the various uses of fallthrough comments to fallthrough; > > Done via script > Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/ > > Signed-off-by: Joe Perches <joe@perches.com> Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com> But, I think the patch subject should be prefixed: "serial: 8250_uniphier:" > --- > drivers/tty/serial/8250/8250_uniphier.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/tty/serial/8250/8250_uniphier.c b/drivers/tty/serial/8250/8250_uniphier.c > index e0b73a5..a2978ab 100644 > --- a/drivers/tty/serial/8250/8250_uniphier.c > +++ b/drivers/tty/serial/8250/8250_uniphier.c > @@ -75,7 +75,7 @@ static unsigned int uniphier_serial_in(struct uart_port *p, int offset) > break; > case UART_LCR: > valshift = 8; > - /* fall through */ > + fallthrough; > case UART_MCR: > offset = UNIPHIER_UART_LCR_MCR; > break; > @@ -101,7 +101,7 @@ static void uniphier_serial_out(struct uart_port *p, int offset, int value) > case UART_SCR: > /* No SCR for this hardware. Use CHAR as a scratch register */ > valshift = 8; > - /* fall through */ > + fallthrough; > case UART_FCR: > offset = UNIPHIER_UART_CHAR_FCR; > break; > @@ -109,7 +109,7 @@ static void uniphier_serial_out(struct uart_port *p, int offset, int value) > valshift = 8; > /* Divisor latch access bit does not exist. */ > value &= ~UART_LCR_DLAB; > - /* fall through */ > + fallthrough; > case UART_MCR: > offset = UNIPHIER_UART_LCR_MCR; > break; > -- > 2.24.0 > -- Best Regards Masahiro Yamada
WARNING: multiple messages have this Message-ID (diff)
From: Masahiro Yamada <masahiroy@kernel.org> To: Joe Perches <joe@perches.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, linux-serial@vger.kernel.org, Jiri Slaby <jslaby@suse.com> Subject: Re: [PATCH -next 005/491] ARM/UNIPHIER ARCHITECTURE: Use fallthrough; Date: Wed, 11 Mar 2020 14:15:10 +0900 [thread overview] Message-ID: <CAK7LNAS7GAk9yXkPhbS3ByU+n9Gb-rk0PeLcXLCNwpW1B22aeg@mail.gmail.com> (raw) In-Reply-To: <dae0878058223a42c77d725b8d7c5845a7ef9dc0.1583896348.git.joe@perches.com> On Wed, Mar 11, 2020 at 2:07 PM Joe Perches <joe@perches.com> wrote: > > Convert the various uses of fallthrough comments to fallthrough; > > Done via script > Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/ > > Signed-off-by: Joe Perches <joe@perches.com> Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com> But, I think the patch subject should be prefixed: "serial: 8250_uniphier:" > --- > drivers/tty/serial/8250/8250_uniphier.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/tty/serial/8250/8250_uniphier.c b/drivers/tty/serial/8250/8250_uniphier.c > index e0b73a5..a2978ab 100644 > --- a/drivers/tty/serial/8250/8250_uniphier.c > +++ b/drivers/tty/serial/8250/8250_uniphier.c > @@ -75,7 +75,7 @@ static unsigned int uniphier_serial_in(struct uart_port *p, int offset) > break; > case UART_LCR: > valshift = 8; > - /* fall through */ > + fallthrough; > case UART_MCR: > offset = UNIPHIER_UART_LCR_MCR; > break; > @@ -101,7 +101,7 @@ static void uniphier_serial_out(struct uart_port *p, int offset, int value) > case UART_SCR: > /* No SCR for this hardware. Use CHAR as a scratch register */ > valshift = 8; > - /* fall through */ > + fallthrough; > case UART_FCR: > offset = UNIPHIER_UART_CHAR_FCR; > break; > @@ -109,7 +109,7 @@ static void uniphier_serial_out(struct uart_port *p, int offset, int value) > valshift = 8; > /* Divisor latch access bit does not exist. */ > value &= ~UART_LCR_DLAB; > - /* fall through */ > + fallthrough; > case UART_MCR: > offset = UNIPHIER_UART_LCR_MCR; > break; > -- > 2.24.0 > -- Best Regards Masahiro Yamada _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-11 5:16 UTC|newest] Thread overview: 187+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-11 4:51 [MPTCP] [PATCH -next 000/491] treewide: use fallthrough; Joe Perches 2020-03-11 17:24 ` Joe Perches 2020-03-11 4:51 ` [Bridge] " Joe Perches 2020-03-11 4:51 ` [Cluster-devel] " Joe Perches 2020-03-11 4:51 ` [OpenRISC] " Joe Perches 2020-03-11 4:51 ` [Intel-wired-lan] " Joe Perches 2020-03-11 4:51 ` [OpenRISC] " Joe Perches 2020-03-11 4:51 ` Joe Perches 2020-03-11 4:51 ` Joe Perches 2020-03-11 4:51 ` Joe Perches 2020-03-11 4:51 ` [Xen-devel] " Joe Perches 2020-03-11 4:51 ` [Intel-gfx] " Joe Perches 2020-03-11 4:51 ` Joe Perches 2020-03-11 4:51 ` Joe Perches 2020-03-11 4:51 ` Joe Perches 2020-03-11 4:51 ` Joe Perches 2020-03-11 4:51 ` Joe Perches 2020-03-11 4:51 ` Joe Perches 2020-03-11 4:51 ` Joe Perches 2020-03-11 4:51 ` [f2fs-dev] " Joe Perches 2020-03-11 4:51 ` Joe Perches 2020-03-11 4:51 ` Joe Perches 2020-03-11 4:51 ` [Ocfs2-devel] " Joe Perches 2020-03-11 4:51 ` Joe Perches 2020-03-11 4:51 ` Joe Perches 2020-03-11 4:51 ` Joe Perches 2020-03-11 4:51 ` Joe Perches 2020-03-11 4:51 ` [PATCH -next 001/491] MELLANOX ETHERNET INNOVA DRIVERS: Use fallthrough; Joe Perches 2020-03-11 7:01 ` Leon Romanovsky 2020-03-12 6:23 ` David Miller 2020-03-12 6:26 ` Joe Perches 2020-03-12 8:03 ` David Miller 2020-03-12 19:45 ` Jakub Kicinski 2020-03-12 19:52 ` Joe Perches 2020-03-11 4:51 ` [PATCH -next 002/491] MARVELL OCTEONTX2 RVU ADMIN FUNCTION DRIVER: " Joe Perches 2020-03-11 4:51 ` [PATCH -next 003/491] MELLANOX MLX5 core VPI driver: " Joe Perches 2020-03-11 7:00 ` Leon Romanovsky 2020-03-11 4:51 ` [PATCH -next 004/491] PERFORMANCE EVENTS SUBSYSTEM: " Joe Perches 2020-03-11 15:30 ` Peter Zijlstra 2020-03-12 6:15 ` Joe Perches 2020-03-11 19:20 ` Thomas Bogendoerfer 2020-03-11 4:51 ` [PATCH -next 005/491] ARM/UNIPHIER ARCHITECTURE: " Joe Perches 2020-03-11 4:51 ` Joe Perches 2020-03-11 5:15 ` Masahiro Yamada [this message] 2020-03-11 5:15 ` Masahiro Yamada 2020-03-11 14:31 ` Joe Perches 2020-03-11 14:31 ` Joe Perches 2020-03-12 8:56 ` Greg Kroah-Hartman 2020-03-12 8:56 ` Greg Kroah-Hartman 2020-03-12 9:02 ` Masahiro Yamada 2020-03-12 9:02 ` Masahiro Yamada 2020-03-12 9:36 ` Greg Kroah-Hartman 2020-03-12 9:36 ` Greg Kroah-Hartman 2020-03-12 9:37 ` Joe Perches 2020-03-12 9:37 ` Joe Perches 2020-03-12 13:47 ` Theodore Y. Ts'o 2020-03-12 13:47 ` Theodore Y. Ts'o 2020-03-12 14:15 ` Joe Perches 2020-03-12 14:15 ` Joe Perches 2020-03-12 9:03 ` Joe Perches 2020-03-12 9:03 ` Joe Perches 2020-03-11 4:51 ` [PATCH -next 006/491] ARM/RISCPC " Joe Perches 2020-03-11 4:51 ` Joe Perches 2020-03-12 10:11 ` Russell King - ARM Linux admin 2020-03-12 10:11 ` Russell King - ARM Linux admin 2020-03-12 10:19 ` Joe Perches 2020-03-12 10:19 ` Joe Perches 2020-03-11 4:51 ` [PATCH -next 007/491] KERNEL VIRTUAL MACHINE FOR ARM/ARM64 (KVM/arm, KVM/arm64): " Joe Perches 2020-03-11 4:51 ` Joe Perches 2020-03-11 4:51 ` Joe Perches 2020-03-11 4:51 ` [PATCH -next 008/491] ARM/CIRRUS LOGIC EP93XX ARM ARCHITECTURE: " Joe Perches 2020-03-11 4:51 ` Joe Perches 2020-03-13 19:26 ` Alexander Sverdlin 2020-03-13 19:26 ` Alexander Sverdlin 2020-03-11 4:51 ` [PATCH -next 009/491] ARM/Amlogic Meson SoC support: " Joe Perches 2020-03-11 4:51 ` Joe Perches 2020-03-11 4:51 ` Joe Perches 2020-03-11 4:51 ` [PATCH -next 010/491] ARM/SAMSUNG EXYNOS ARM ARCHITECTURES: " Joe Perches 2020-03-11 4:51 ` Joe Perches 2020-03-13 14:26 ` Wolfram Sang 2020-03-13 14:26 ` Wolfram Sang 2020-03-14 1:17 ` Stephen Boyd 2020-03-14 1:17 ` Stephen Boyd 2020-05-13 11:59 ` Sylwester Nawrocki 2020-05-13 11:59 ` Sylwester Nawrocki 2020-03-11 4:51 ` [PATCH -next 011/491] ARM/QUALCOMM SUPPORT: " Joe Perches 2020-03-11 5:23 ` Amit Kucheria 2020-03-11 8:46 ` Marc Gonzalez 2020-03-11 8:46 ` Marc Gonzalez 2020-03-11 14:30 ` Joe Perches 2020-03-11 14:30 ` Joe Perches 2020-03-13 12:04 ` Stanimir Varbanov 2020-03-11 4:51 ` [PATCH -next 012/491] ARM/ZTE ARCHITECTURE: " Joe Perches 2020-03-11 4:51 ` Joe Perches 2020-03-11 4:51 ` Joe Perches 2020-03-11 4:51 ` [PATCH -next 013/491] INGENIC JZ47xx SoCs: " Joe Perches 2020-03-11 4:51 ` Joe Perches 2020-03-11 4:51 ` Joe Perches 2020-03-11 4:51 ` Joe Perches 2020-03-11 7:40 ` Miquel Raynal 2020-03-11 7:40 ` Miquel Raynal 2020-03-11 7:40 ` Miquel Raynal 2020-03-11 7:40 ` Miquel Raynal 2020-03-11 14:20 ` Ulf Hansson 2020-03-11 14:20 ` Ulf Hansson 2020-03-11 14:20 ` Ulf Hansson 2020-03-11 14:20 ` Ulf Hansson 2020-03-11 14:29 ` Miquel Raynal 2020-03-11 14:29 ` Miquel Raynal 2020-03-11 14:29 ` Miquel Raynal 2020-03-11 14:29 ` Miquel Raynal 2020-03-12 6:26 ` Joe Perches 2020-03-12 6:26 ` Joe Perches 2020-03-12 6:26 ` Joe Perches 2020-03-12 6:26 ` Joe Perches 2020-03-11 4:51 ` [PATCH -next 014/491] DECSTATION PLATFORM SUPPORT: " Joe Perches 2020-03-11 19:19 ` Thomas Bogendoerfer 2020-03-11 4:51 ` [PATCH -next 015/491] KERNEL VIRTUAL MACHINE FOR MIPS (KVM/mips): " Joe Perches 2020-03-11 19:20 ` Thomas Bogendoerfer 2020-03-11 4:51 ` [PATCH -next 016/491] KERNEL VIRTUAL MACHINE FOR POWERPC (KVM/powerpc): " Joe Perches 2020-03-11 4:51 ` Joe Perches 2020-03-11 4:51 ` Joe Perches 2020-03-19 1:18 ` Paul Mackerras 2020-03-19 1:18 ` Paul Mackerras 2020-03-19 1:18 ` Paul Mackerras 2020-03-19 1:22 ` Joe Perches 2020-03-19 1:22 ` Joe Perches 2020-03-19 1:22 ` Joe Perches 2020-03-19 23:33 ` Paul Mackerras 2020-03-19 23:33 ` Paul Mackerras 2020-03-19 23:33 ` Paul Mackerras 2020-03-11 4:51 ` [PATCH -next 017/491] CELL BROADBAND ENGINE ARCHITECTURE: " Joe Perches 2020-03-11 4:51 ` Joe Perches 2020-03-11 8:08 ` Arnd Bergmann 2020-03-11 8:08 ` Arnd Bergmann 2020-03-26 12:06 ` Michael Ellerman 2020-03-26 12:06 ` Michael Ellerman 2020-03-11 4:51 ` [PATCH -next 018/491] KERNEL VIRTUAL MACHINE for s390 (KVM/s390): " Joe Perches 2020-03-11 11:33 ` Christian Borntraeger 2020-03-13 12:04 ` Christian Borntraeger 2020-03-11 4:51 ` [PATCH -next 019/491] Hyper-V CORE AND DRIVERS: " Joe Perches 2020-03-11 4:51 ` Joe Perches 2020-03-11 4:51 ` Joe Perches 2020-03-11 11:00 ` Wei Liu 2020-03-11 11:00 ` Wei Liu 2020-03-11 11:00 ` Wei Liu 2020-03-11 4:51 ` [PATCH -next 020/491] XEN HYPERVISOR INTERFACE: " Joe Perches 2020-03-11 4:51 ` [Xen-devel] " Joe Perches 2020-03-11 6:47 ` Jürgen Groß 2020-03-11 6:47 ` [Xen-devel] " Jürgen Groß 2020-03-11 4:51 ` [PATCH -next 021/491] KERNEL VIRTUAL MACHINE FOR X86 (KVM/x86): " Joe Perches 2020-03-11 9:43 ` Paolo Bonzini 2020-03-11 4:51 ` [PATCH -next 022/491] X86 MCE INFRASTRUCTURE: " Joe Perches 2020-03-11 17:14 ` Borislav Petkov 2020-03-11 4:51 ` [PATCH -next 023/491] AMD KFD: " Joe Perches 2020-03-11 4:51 ` Joe Perches 2020-03-11 4:51 ` Joe Perches 2020-03-11 21:50 ` Felix Kuehling 2020-03-11 21:50 ` Felix Kuehling 2020-03-11 21:50 ` Felix Kuehling 2020-03-11 22:09 ` Joe Perches 2020-03-11 22:09 ` Joe Perches 2020-03-11 22:09 ` Joe Perches 2020-03-12 14:12 ` Alex Deucher 2020-03-12 14:12 ` Alex Deucher 2020-03-12 14:12 ` Alex Deucher 2020-03-11 4:51 ` [PATCH -next 024/491] AMD DISPLAY CORE: " Joe Perches 2020-03-11 4:51 ` Joe Perches 2020-03-11 4:51 ` Joe Perches 2020-03-12 14:10 ` Alex Deucher 2020-03-12 14:10 ` Alex Deucher 2020-03-12 14:10 ` Alex Deucher 2020-03-11 4:51 ` [PATCH -next 025/491] AMD POWERPLAY: " Joe Perches 2020-03-11 4:51 ` Joe Perches 2020-03-11 4:51 ` Joe Perches 2020-03-12 14:10 ` Alex Deucher 2020-03-12 14:10 ` Alex Deucher 2020-03-12 14:10 ` Alex Deucher 2020-03-11 4:51 ` [PATCH -next 026/491] INTEL GVT-g DRIVERS (Intel GPU Virtualization): " Joe Perches 2020-03-11 4:51 ` [Intel-gfx] " Joe Perches 2020-03-11 4:51 ` Joe Perches 2020-03-11 4:51 ` [PATCH -next 027/491] AMD XGBE DRIVER: " Joe Perches 2020-03-11 4:51 ` [PATCH -next 028/491] BROADCOM BNX2X 10 GIGABIT ETHERNET " Joe Perches 2020-03-11 4:51 ` [PATCH -next 029/491] BROADCOM BNXT_EN 50 " Joe Perches 2020-03-11 4:51 ` [PATCH -next 030/491] BROADCOM GENET " Joe Perches 2020-03-11 16:35 ` Florian Fainelli 2020-03-11 4:51 ` [PATCH -next 031/491] BROCADE BNA 10 GIGABIT " Joe Perches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAK7LNAS7GAk9yXkPhbS3ByU+n9Gb-rk0PeLcXLCNwpW1B22aeg@mail.gmail.com \ --to=masahiroy@kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=joe@perches.com \ --cc=jslaby@suse.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-serial@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.