* [PATCH] mt7601u: do not use WARN_ON in the datapath
[not found] <cover.1548171270.git.lorenzo.bianconi@redhat.com>
@ 2019-01-22 15:39 ` Lorenzo Bianconi
2019-01-22 19:30 ` Jakub Kicinski
2019-02-01 12:41 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Lorenzo Bianconi @ 2019-01-22 15:39 UTC (permalink / raw)
To: kubakici; +Cc: linux-wireless
Substitute WARN_ON with WARN_ON_ONCE in mt7601u_rx_next_seg_len
routine
Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
---
drivers/net/wireless/mediatek/mt7601u/dma.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/mediatek/mt7601u/dma.c b/drivers/net/wireless/mediatek/mt7601u/dma.c
index 7f3e3983b781..f7edeffb2b19 100644
--- a/drivers/net/wireless/mediatek/mt7601u/dma.c
+++ b/drivers/net/wireless/mediatek/mt7601u/dma.c
@@ -124,9 +124,9 @@ static u16 mt7601u_rx_next_seg_len(u8 *data, u32 data_len)
u16 dma_len = get_unaligned_le16(data);
if (data_len < min_seg_len ||
- WARN_ON(!dma_len) ||
- WARN_ON(dma_len + MT_DMA_HDRS > data_len) ||
- WARN_ON(dma_len & 0x3))
+ WARN_ON_ONCE(!dma_len) ||
+ WARN_ON_ONCE(dma_len + MT_DMA_HDRS > data_len) ||
+ WARN_ON_ONCE(dma_len & 0x3))
return 0;
return MT_DMA_HDRS + dma_len;
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mt7601u: do not use WARN_ON in the datapath
2019-01-22 15:39 ` [PATCH] mt7601u: do not use WARN_ON in the datapath Lorenzo Bianconi
@ 2019-01-22 19:30 ` Jakub Kicinski
2019-02-01 12:41 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2019-01-22 19:30 UTC (permalink / raw)
To: Lorenzo Bianconi; +Cc: linux-wireless
On Tue, 22 Jan 2019 16:39:34 +0100, Lorenzo Bianconi wrote:
> Substitute WARN_ON with WARN_ON_ONCE in mt7601u_rx_next_seg_len
> routine
>
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Acked-by: Jakub Kicinski <kubakici@wp.pl>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mt7601u: do not use WARN_ON in the datapath
2019-01-22 15:39 ` [PATCH] mt7601u: do not use WARN_ON in the datapath Lorenzo Bianconi
2019-01-22 19:30 ` Jakub Kicinski
@ 2019-02-01 12:41 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2019-02-01 12:41 UTC (permalink / raw)
To: Lorenzo Bianconi; +Cc: kubakici, linux-wireless
Lorenzo Bianconi <lorenzo.bianconi@redhat.com> wrote:
> Substitute WARN_ON with WARN_ON_ONCE in mt7601u_rx_next_seg_len
> routine
>
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
> Acked-by: Jakub Kicinski <kubakici@wp.pl>
Patch applied to wireless-drivers-next.git, thanks.
b6958ad021c1 mt7601u: do not use WARN_ON in the datapath
--
https://patchwork.kernel.org/patch/10775829/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-01 12:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <cover.1548171270.git.lorenzo.bianconi@redhat.com>
2019-01-22 15:39 ` [PATCH] mt7601u: do not use WARN_ON in the datapath Lorenzo Bianconi
2019-01-22 19:30 ` Jakub Kicinski
2019-02-01 12:41 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.