[PATCH 0/2] Adjustments in function call

[PATCH 0/2] Adjustments in function call

[Javier F. Arias]

This patchset fixes a warning and simplify a boolean expression in a
function call.

Javier F. Arias (2):
  staging: rtl8723bs: Fix line over 80 characters
  staging: rtl8723bs: Simplify boolean expression

 drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

-- 
2.20.1

[PATCH 1/2] staging: rtl8723bs: Fix line over 80 characters

[Javier F. Arias]

Fix line over 80 characters by wrapping arguments in function call.
Fix suggested by Julia Lawall <julia.lawall@lip6.fr>.

Signed-off-by: Javier F. Arias <jarias.linux@gmail.com>
---
 drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c b/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c
index c514cb735afd..0c2f3b2d4326 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c
@@ -188,7 +188,9 @@ void rtl8723b_HalDmWatchDog(struct adapter *Adapter)
 
 		bBtDisabled = hal_btcoex_IsBtDisabled(Adapter);
 
-		ODM_CmnInfoUpdate(&pHalData->odmpriv, ODM_CMNINFO_BT_ENABLED, ((bBtDisabled == true)?false:true));
+		ODM_CmnInfoUpdate(&pHalData->odmpriv,
+				  ODM_CMNINFO_BT_ENABLED,
+				  ((bBtDisabled == true)?false:true));
 
 		ODM_DMWatchdog(&pHalData->odmpriv);
 	}
-- 
2.20.1

[PATCH 2/2] staging: rtl8723bs: Simplify boolean expression

[Javier F. Arias]

Simplify expression that it's inverting a boolean value.
Issue found by Coccinelle.

Signed-off-by: Javier F. Arias <jarias.linux@gmail.com>
---
 drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c b/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c
index 0c2f3b2d4326..6f341d52afb6 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c
@@ -190,7 +190,7 @@ void rtl8723b_HalDmWatchDog(struct adapter *Adapter)
 
 		ODM_CmnInfoUpdate(&pHalData->odmpriv,
 				  ODM_CMNINFO_BT_ENABLED,
-				  ((bBtDisabled == true)?false:true));
+				  !bBtDisabled);
 
 		ODM_DMWatchdog(&pHalData->odmpriv);
 	}
-- 
2.20.1

Re: [Outreachy kernel] [PATCH 0/2] Adjustments in function call

[Julia Lawall]

On Fri, 18 Oct 2019, Javier F. Arias wrote:

> This patchset fixes a warning and simplify a boolean expression in a
> function call.

This is a v2 of something that you sent before, even though it was
previously only one patch.  Greg has to know what to take and what to
drop.

julia


>
> Javier F. Arias (2):
>   staging: rtl8723bs: Fix line over 80 characters
>   staging: rtl8723bs: Simplify boolean expression
>
>  drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> --
> 2.20.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/cover.1571448899.git.jarias.linux%40gmail.com.
>

Re: [Outreachy kernel] [PATCH 1/2] staging: rtl8723bs: Fix line over 80 characters

[Julia Lawall]

On Fri, 18 Oct 2019, Javier F. Arias wrote:

> Fix line over 80 characters by wrapping arguments in function call.
> Fix suggested by Julia Lawall <julia.lawall@lip6.fr>.

There is a Suggested-by: tag that would be better to use than the second
line.  That would limit the log message to what you are doing and why.

julia

>
> Signed-off-by: Javier F. Arias <jarias.linux@gmail.com>
> ---
>  drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c b/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c
> index c514cb735afd..0c2f3b2d4326 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c
> @@ -188,7 +188,9 @@ void rtl8723b_HalDmWatchDog(struct adapter *Adapter)
>
>  		bBtDisabled = hal_btcoex_IsBtDisabled(Adapter);
>
> -		ODM_CmnInfoUpdate(&pHalData->odmpriv, ODM_CMNINFO_BT_ENABLED, ((bBtDisabled == true)?false:true));
> +		ODM_CmnInfoUpdate(&pHalData->odmpriv,
> +				  ODM_CMNINFO_BT_ENABLED,
> +				  ((bBtDisabled == true)?false:true));
>
>  		ODM_DMWatchdog(&pHalData->odmpriv);
>  	}
> --
> 2.20.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/eaa22be21885d04e47f1be2ad7be007182bf22bc.1571448899.git.jarias.linux%40gmail.com.
>

Re: [Outreachy kernel] [PATCH 1/2] staging: rtl8723bs: Fix line over 80 characters

[Javier Arias]

[-- Attachment #1.1: Type: text/plain, Size: 2068 bytes --]

Hello again Julia,

I updated the patch but I didn't receive any feedback nor acceptance by 
Greg. Is there something I'm doing wrong?

Thanks

On Saturday, 19 October 2019 01:34:08 UTC-5, Julia Lawall wrote:
>
>
>
> On Fri, 18 Oct 2019, Javier F. Arias wrote: 
>
> > Fix line over 80 characters by wrapping arguments in function call. 
> > Fix suggested by Julia Lawall <julia...@lip6.fr <javascript:>>. 
>
> There is a Suggested-by: tag that would be better to use than the second 
> line.  That would limit the log message to what you are doing and why. 
>
> julia 
>
> > 
> > Signed-off-by: Javier F. Arias <jaria...@gmail.com <javascript:>> 
> > --- 
> >  drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 4 +++- 
> >  1 file changed, 3 insertions(+), 1 deletion(-) 
> > 
> > diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c 
> b/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c 
> > index c514cb735afd..0c2f3b2d4326 100644 
> > --- a/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c 
> > +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c 
> > @@ -188,7 +188,9 @@ void rtl8723b_HalDmWatchDog(struct adapter *Adapter) 
> > 
> >                  bBtDisabled = hal_btcoex_IsBtDisabled(Adapter); 
> > 
> > -                ODM_CmnInfoUpdate(&pHalData->odmpriv, 
> ODM_CMNINFO_BT_ENABLED, ((bBtDisabled == true)?false:true)); 
> > +                ODM_CmnInfoUpdate(&pHalData->odmpriv, 
> > +                                  ODM_CMNINFO_BT_ENABLED, 
> > +                                  ((bBtDisabled == true)?false:true)); 
> > 
> >                  ODM_DMWatchdog(&pHalData->odmpriv); 
> >          } 
> > -- 
> > 2.20.1 
> > 
> > -- 
> > You received this message because you are subscribed to the Google 
> Groups "outreachy-kernel" group. 
> > To unsubscribe from this group and stop receiving emails from it, send 
> an email to outreach...@googlegroups.com <javascript:>. 
> > To view this discussion on the web visit 
> https://groups.google.com/d/msgid/outreachy-kernel/eaa22be21885d04e47f1be2ad7be007182bf22bc.1571448899.git.jarias.linux%40gmail.com. 
>
> > 
>

[-- Attachment #1.2: Type: text/html, Size: 3851 bytes --]

Re: [Outreachy kernel] [PATCH 1/2] staging: rtl8723bs: Fix line over 80 characters

[Greg KH]

On Thu, Oct 24, 2019 at 10:49:06PM -0700, Javier Arias wrote:
> Hello again Julia,
> 
> I updated the patch but I didn't receive any feedback nor acceptance by 
> Greg. Is there something I'm doing wrong?

I have caught up with almost all outreachy patches, but not all.  Give
me another few days to do that.  If you have not heard back about a
patch within a week, feel free to resend it.

When I have caught up with everything, I will email the list letting
people know so that if they sent something and did not get a response,
they know to redo it.

thanks,

greg k-h

Re: [Outreachy kernel] [PATCH 1/2] staging: rtl8723bs: Fix line over 80 characters

[Javier Arias]

[-- Attachment #1.1: Type: text/plain, Size: 774 bytes --]

Ahh, I just was a bit worried that I sent them incorrectly. I'll wait. 
Thank you for your time! 

On Friday, 25 October 2019 08:22:51 UTC-5, Greg KH wrote:
>
> On Thu, Oct 24, 2019 at 10:49:06PM -0700, Javier Arias wrote: 
> > Hello again Julia, 
> > 
> > I updated the patch but I didn't receive any feedback nor acceptance by 
> > Greg. Is there something I'm doing wrong? 
>
> I have caught up with almost all outreachy patches, but not all.  Give 
> me another few days to do that.  If you have not heard back about a 
> patch within a week, feel free to resend it. 
>
> When I have caught up with everything, I will email the list letting 
> people know so that if they sent something and did not get a response, 
> they know to redo it. 
>
> thanks, 
>
> greg k-h 
>

[-- Attachment #1.2: Type: text/html, Size: 1087 bytes --]

Re: [Outreachy kernel] [PATCH 1/2] staging: rtl8723bs: Fix line over 80 characters

[Vaishali Thakkar]

On Sat, Oct 26, 2019 at 10:36 AM Javier Arias <jarias.linux@gmail.com> wrote:
>
> Ahh, I just was a bit worried that I sent them incorrectly. I'll wait. Thank you for your time!

Hi Javier,

Please don't top post. See the section 'Responding to emails
and responding inline' in the kernel first patch tutorial over
here: https://kernelnewbies.org/FirstKernelPatch

Thanks!

> On Friday, 25 October 2019 08:22:51 UTC-5, Greg KH wrote:
>>
>> On Thu, Oct 24, 2019 at 10:49:06PM -0700, Javier Arias wrote:
>> > Hello again Julia,
>> >
>> > I updated the patch but I didn't receive any feedback nor acceptance by
>> > Greg. Is there something I'm doing wrong?
>>
>> I have caught up with almost all outreachy patches, but not all.  Give
>> me another few days to do that.  If you have not heard back about a
>> patch within a week, feel free to resend it.
>>
>> When I have caught up with everything, I will email the list letting
>> people know so that if they sent something and did not get a response,
>> they know to redo it.
>>
>> thanks,
>>
>> greg k-h
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/3cc42615-39cb-4f9e-b162-4f4f800f2cca%40googlegroups.com.