From: Roger Quadros <rogerq@ti.com> To: Baolin Wang <baolin.wang@linaro.org> Cc: Felipe Balbi <balbi@kernel.org>, USB <linux-usb@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume Date: Wed, 28 Feb 2018 11:55:15 +0200 [thread overview] Message-ID: <eab78661-dee9-1ff3-0987-a47aed3ec8db@ti.com> (raw) In-Reply-To: <CAMz4kuLv6mOa5ijbEX-GoXyZ+=e8T_ZdpnVS7rbE7gmQo9RkGw@mail.gmail.com> Hi Baolin, On 28/02/18 05:04, Baolin Wang wrote: > Hi Roger, > > On 27 February 2018 at 19:22, Roger Quadros <rogerq@ti.com> wrote: >> In the following test we get stuck by sleeping forever in _dwc3_set_mode() >> after which dual-role switching doesn't work. >> >> On dra7-evm's dual-role port, >> - Load g_zero gadget driver and enumerate to host >> - suspend to mem >> - disconnect USB cable to host and connect otg cable with Pen drive in it. >> - resume system >> - we sleep indefinitely in _dwc3_set_mode due to. >> dwc3_gadget_exit()->usb_del_gadget_udc()->udc_stop()-> >> dwc3_gadget_stop()->wait_event_lock_irq() >> >> Let's clear the DWC3_EP_END_TRANSFER_PENDING flag on all endpoints >> so we don't wait in dwc3_gadget_stop(). > > I am curious why the DWC3_DEPEVT_EPCMDCMPLT event was not triggered > any more when you executed the DWC3_DEPCMD_ENDTRANSFER command? In this particular case the USB gadget has been disconnected from the host so we shouldn't be expecting any command completion events. > >> >> Signed-off-by: Roger Quadros <rogerq@ti.com> >> --- >> drivers/usb/dwc3/gadget.c | 14 ++++++++++++++ >> 1 file changed, 14 insertions(+) >> >> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c >> index 2bda4eb..0a360da 100644 >> --- a/drivers/usb/dwc3/gadget.c >> +++ b/drivers/usb/dwc3/gadget.c >> @@ -3273,6 +3273,20 @@ int dwc3_gadget_init(struct dwc3 *dwc) >> >> void dwc3_gadget_exit(struct dwc3 *dwc) >> { >> + int epnum; >> + unsigned long flags; >> + >> + spin_lock_irqsave(&dwc->lock, flags); >> + for (epnum = 2; epnum < DWC3_ENDPOINTS_NUM; epnum++) { >> + struct dwc3_ep *dep = dwc->eps[epnum]; >> + >> + if (!dep) >> + continue; >> + >> + dep->flags &= ~DWC3_EP_END_TRANSFER_PENDING; >> + } >> + spin_unlock_irqrestore(&dwc->lock, flags); >> + >> usb_del_gadget_udc(&dwc->gadget); >> dwc3_gadget_free_endpoints(dwc); >> dma_free_coherent(dwc->sysdev, DWC3_BOUNCE_SIZE, dwc->bounce, >> -- > -- cheers, -roger Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
WARNING: multiple messages have this Message-ID (diff)
From: Roger Quadros <rogerq@ti.com> To: Baolin Wang <baolin.wang@linaro.org> Cc: Felipe Balbi <balbi@kernel.org>, USB <linux-usb@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org> Subject: usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume Date: Wed, 28 Feb 2018 11:55:15 +0200 [thread overview] Message-ID: <eab78661-dee9-1ff3-0987-a47aed3ec8db@ti.com> (raw) Hi Baolin, On 28/02/18 05:04, Baolin Wang wrote: > Hi Roger, > > On 27 February 2018 at 19:22, Roger Quadros <rogerq@ti.com> wrote: >> In the following test we get stuck by sleeping forever in _dwc3_set_mode() >> after which dual-role switching doesn't work. >> >> On dra7-evm's dual-role port, >> - Load g_zero gadget driver and enumerate to host >> - suspend to mem >> - disconnect USB cable to host and connect otg cable with Pen drive in it. >> - resume system >> - we sleep indefinitely in _dwc3_set_mode due to. >> dwc3_gadget_exit()->usb_del_gadget_udc()->udc_stop()-> >> dwc3_gadget_stop()->wait_event_lock_irq() >> >> Let's clear the DWC3_EP_END_TRANSFER_PENDING flag on all endpoints >> so we don't wait in dwc3_gadget_stop(). > > I am curious why the DWC3_DEPEVT_EPCMDCMPLT event was not triggered > any more when you executed the DWC3_DEPCMD_ENDTRANSFER command? In this particular case the USB gadget has been disconnected from the host so we shouldn't be expecting any command completion events. > >> >> Signed-off-by: Roger Quadros <rogerq@ti.com> >> --- >> drivers/usb/dwc3/gadget.c | 14 ++++++++++++++ >> 1 file changed, 14 insertions(+) >> >> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c >> index 2bda4eb..0a360da 100644 >> --- a/drivers/usb/dwc3/gadget.c >> +++ b/drivers/usb/dwc3/gadget.c >> @@ -3273,6 +3273,20 @@ int dwc3_gadget_init(struct dwc3 *dwc) >> >> void dwc3_gadget_exit(struct dwc3 *dwc) >> { >> + int epnum; >> + unsigned long flags; >> + >> + spin_lock_irqsave(&dwc->lock, flags); >> + for (epnum = 2; epnum < DWC3_ENDPOINTS_NUM; epnum++) { >> + struct dwc3_ep *dep = dwc->eps[epnum]; >> + >> + if (!dep) >> + continue; >> + >> + dep->flags &= ~DWC3_EP_END_TRANSFER_PENDING; >> + } >> + spin_unlock_irqrestore(&dwc->lock, flags); >> + >> usb_del_gadget_udc(&dwc->gadget); >> dwc3_gadget_free_endpoints(dwc); >> dma_free_coherent(dwc->sysdev, DWC3_BOUNCE_SIZE, dwc->bounce, >> -- >
next prev parent reply other threads:[~2018-02-28 9:55 UTC|newest] Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-02-27 11:22 [PATCH] usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume Roger Quadros 2018-02-27 11:22 ` Roger Quadros 2018-02-28 3:04 ` [PATCH] " Baolin Wang 2018-02-28 3:04 ` Baolin Wang 2018-02-28 9:55 ` Roger Quadros [this message] 2018-02-28 9:55 ` Roger Quadros 2018-02-28 7:53 ` [PATCH] " Felipe Balbi 2018-02-28 7:53 ` Felipe Balbi 2018-02-28 9:59 ` [PATCH] " Roger Quadros 2018-02-28 9:59 ` Roger Quadros 2018-03-05 8:49 ` [PATCH] " Felipe Balbi 2018-03-05 8:49 ` Felipe Balbi 2018-03-05 9:45 ` [PATCH] " Roger Quadros 2018-03-05 9:45 ` Roger Quadros 2018-03-05 10:41 ` [PATCH] " Baolin Wang 2018-03-05 10:41 ` Baolin Wang 2018-03-05 11:03 ` [PATCH] " Roger Quadros 2018-03-05 11:03 ` Roger Quadros 2018-03-05 11:06 ` [PATCH] " Felipe Balbi 2018-03-05 11:06 ` Felipe Balbi 2018-03-05 11:14 ` [PATCH] " Roger Quadros 2018-03-05 11:14 ` Roger Quadros 2018-03-05 11:25 ` [PATCH] " Baolin Wang 2018-03-05 11:25 ` Baolin Wang 2018-03-05 11:27 ` [PATCH] " Felipe Balbi 2018-03-05 11:27 ` Felipe Balbi 2018-03-09 9:19 ` [PATCH] " Roger Quadros 2018-03-09 9:19 ` Roger Quadros 2018-03-09 9:23 ` [PATCH] " Felipe Balbi 2018-03-09 9:23 ` Felipe Balbi 2018-03-09 9:26 ` [PATCH] " Roger Quadros 2018-03-09 9:26 ` Roger Quadros 2018-03-09 9:49 ` [PATCH] " Roger Quadros 2018-03-09 9:49 ` Roger Quadros 2018-03-09 10:39 ` [PATCH] " Felipe Balbi 2018-03-09 10:39 ` Felipe Balbi 2018-03-09 10:36 ` [PATCH] " Felipe Balbi 2018-03-09 10:36 ` Felipe Balbi 2018-03-05 11:25 ` [PATCH] " Felipe Balbi 2018-03-05 11:25 ` Felipe Balbi 2018-03-09 12:47 ` [PATCH v2] " Roger Quadros 2018-03-09 12:47 ` [v2] " Roger Quadros 2018-03-16 10:34 ` [PATCH v2] " Roger Quadros 2018-03-16 10:34 ` [v2] " Roger Quadros 2018-03-16 11:00 ` [PATCH v2] " Felipe Balbi 2018-03-16 11:00 ` [v2] " Felipe Balbi 2018-03-16 11:03 ` [PATCH v2] " Roger Quadros 2018-03-16 11:03 ` [v2] " Roger Quadros 2018-03-16 11:43 ` [PATCH v2] " Minas Harutyunyan 2018-03-16 11:43 ` [v2] " Minas Harutyunyan 2018-03-16 12:25 ` [PATCH v2] " Felipe Balbi 2018-03-16 12:25 ` [v2] " Felipe Balbi 2018-03-17 6:33 ` [PATCH v2] " Minas Harutyunyan 2018-03-17 6:33 ` [v2] " Minas Harutyunyan 2018-03-19 8:54 ` [PATCH v2] " Felipe Balbi 2018-03-19 8:54 ` [v2] " Felipe Balbi 2018-03-19 11:36 ` [PATCH v2] " Minas Harutyunyan 2018-03-19 11:36 ` [v2] " Minas Harutyunyan 2018-03-19 13:53 ` [PATCH v2] " Minas Harutyunyan 2018-03-19 13:53 ` [v2] " Minas Harutyunyan 2018-04-10 6:29 ` [PATCH v2] " Minas Harutyunyan 2018-04-10 6:29 ` [v2] " Minas Harutyunyan 2018-04-10 7:31 ` [PATCH v2] " Felipe Balbi 2018-04-10 7:31 ` [v2] " Felipe Balbi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=eab78661-dee9-1ff3-0987-a47aed3ec8db@ti.com \ --to=rogerq@ti.com \ --cc=balbi@kernel.org \ --cc=baolin.wang@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.