All of lore.kernel.org
 help / color / mirror / Atom feed
From: Finn Thain <fthain@linux-m68k.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Wan Jiabing <wanjiabing@vivo.com>,
	James Smart <james.smart@broadcom.com>,
	Ram Vegesna <ram.vegesna@broadcom.com>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Daniel Wagner <dwagner@suse.de>,
	linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
	linux-kernel@vger.kernel.org, cocci@inria.fr
Subject: Re: [PATCH] scsi: elx: efct: remove unnecessary memset in efct_io
Date: Sat, 30 Apr 2022 17:48:06 +1000 (AEST)	[thread overview]
Message-ID: <eab847fe-8d17-1a38-b55e-e68a2f6a1829@linux-m68k.org> (raw)
In-Reply-To: <794191df-e745-c591-bf1d-37945f96e73a@wanadoo.fr>

[-- Attachment #1: Type: text/plain, Size: 490 bytes --]

On Sat, 30 Apr 2022, Christophe JAILLET wrote:

> Le 18/03/2022 à 15:52, Wan Jiabing a écrit :
> > io->sgl is allocated by kzalloc(). The memory is set to zero.
> > It is unnecessary to call memset again.
> > 
> 
> Hi,
> 
> Nitpick: this kzalloc() should be a kcalloc() to avoid an open-coded
> multiplication when computing the size to allocate.
> 

Seems like kcalloc() conversion could be a separate patch. Perhaps it 
could be done everywhere using a coccinelle script.

WARNING: multiple messages have this Message-ID (diff)
From: Finn Thain <fthain@linux-m68k.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Wan Jiabing <wanjiabing@vivo.com>,
	James Smart <james.smart@broadcom.com>,
	 Ram Vegesna <ram.vegesna@broadcom.com>,
	 "James E.J. Bottomley" <jejb@linux.ibm.com>,
	 "Martin K. Petersen" <martin.petersen@oracle.com>,
	 Daniel Wagner <dwagner@suse.de>,
	linux-scsi@vger.kernel.org,  target-devel@vger.kernel.org,
	linux-kernel@vger.kernel.org, cocci@inria.fr
Subject: Re: [cocci] [PATCH] scsi: elx: efct: remove unnecessary memset in efct_io
Date: Sat, 30 Apr 2022 17:48:06 +1000 (AEST)	[thread overview]
Message-ID: <eab847fe-8d17-1a38-b55e-e68a2f6a1829@linux-m68k.org> (raw)
In-Reply-To: <794191df-e745-c591-bf1d-37945f96e73a@wanadoo.fr>

[-- Attachment #1: Type: text/plain, Size: 490 bytes --]

On Sat, 30 Apr 2022, Christophe JAILLET wrote:

> Le 18/03/2022 à 15:52, Wan Jiabing a écrit :
> > io->sgl is allocated by kzalloc(). The memory is set to zero.
> > It is unnecessary to call memset again.
> > 
> 
> Hi,
> 
> Nitpick: this kzalloc() should be a kcalloc() to avoid an open-coded
> multiplication when computing the size to allocate.
> 

Seems like kcalloc() conversion could be a separate patch. Perhaps it 
could be done everywhere using a coccinelle script.

  reply	other threads:[~2022-04-30  7:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-18 14:52 [PATCH] scsi: elx: efct: remove unnecessary memset in efct_io Wan Jiabing
2022-04-30  6:29 ` Christophe JAILLET
2022-04-30  6:29   ` Christophe JAILLET
2022-04-30  7:48   ` Finn Thain [this message]
2022-04-30  7:48     ` [cocci] " Finn Thain
2022-04-30  9:06     ` Christophe JAILLET
2022-04-30  9:06       ` [cocci] " Christophe JAILLET
2022-05-03  0:51 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eab847fe-8d17-1a38-b55e-e68a2f6a1829@linux-m68k.org \
    --to=fthain@linux-m68k.org \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=cocci@inria.fr \
    --cc=dwagner@suse.de \
    --cc=james.smart@broadcom.com \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=ram.vegesna@broadcom.com \
    --cc=target-devel@vger.kernel.org \
    --cc=wanjiabing@vivo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.