[PATCH] drm/amdgpu/display: use GFP_ATOMIC in dcn21_validate_bandwidth_fp()

[PATCH] drm/amdgpu/display: use GFP_ATOMIC in dcn21_validate_bandwidth_fp()

[Holger Hoffstätte]

After fixing nested FPU contexts caused by 41401ac67791 we're still seeing
complaints about spurious kernel_fpu_end(). As it turns out this was
already fixed for dcn20 in commit f41ed88cbd ("drm/amdgpu/display:
use GFP_ATOMIC in dcn20_validate_bandwidth_internal") but never moved
forward to dcn21.

Signed-off-by: Holger Hoffstätte <holger@applied-asynchrony.com>
---
  drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
index 072f8c880924..1acadf9f5619 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
@@ -1339,7 +1339,7 @@ static noinline bool dcn21_validate_bandwidth_fp(struct dc *dc,
  	int vlevel = 0;
  	int pipe_split_from[MAX_PIPES];
  	int pipe_cnt = 0;
-	display_e2e_pipe_params_st *pipes = kzalloc(dc->res_pool->pipe_count * sizeof(display_e2e_pipe_params_st), GFP_KERNEL);
+	display_e2e_pipe_params_st *pipes = kzalloc(dc->res_pool->pipe_count * sizeof(display_e2e_pipe_params_st), GFP_ATOMIC);
  	DC_LOGGER_INIT(dc->ctx->logger);
  
  	BW_VAL_TRACE_COUNT();
-- 
2.30.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/amdgpu/display: use GFP_ATOMIC in dcn21_validate_bandwidth_fp()

[Alex Deucher]

On Fri, Mar 5, 2021 at 9:23 AM Holger Hoffstätte
<holger@applied-asynchrony.com> wrote:
>
> After fixing nested FPU contexts caused by 41401ac67791 we're still seeing
> complaints about spurious kernel_fpu_end(). As it turns out this was
> already fixed for dcn20 in commit f41ed88cbd ("drm/amdgpu/display:
> use GFP_ATOMIC in dcn20_validate_bandwidth_internal") but never moved
> forward to dcn21.
>
> Signed-off-by: Holger Hoffstätte <holger@applied-asynchrony.com>

Applied.  Thanks!

Alex

> ---
>   drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
> index 072f8c880924..1acadf9f5619 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
> @@ -1339,7 +1339,7 @@ static noinline bool dcn21_validate_bandwidth_fp(struct dc *dc,
>         int vlevel = 0;
>         int pipe_split_from[MAX_PIPES];
>         int pipe_cnt = 0;
> -       display_e2e_pipe_params_st *pipes = kzalloc(dc->res_pool->pipe_count * sizeof(display_e2e_pipe_params_st), GFP_KERNEL);
> +       display_e2e_pipe_params_st *pipes = kzalloc(dc->res_pool->pipe_count * sizeof(display_e2e_pipe_params_st), GFP_ATOMIC);
>         DC_LOGGER_INIT(dc->ctx->logger);
>
>         BW_VAL_TRACE_COUNT();
> --
> 2.30.1
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx