From: Martin Kepplinger <martin.kepplinger@puri.sm> To: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: festevam@gmail.com, krzk@kernel.org, devicetree@vger.kernel.org, kernel@pengutronix.de, kernel@puri.sm, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, m.felsch@pengutronix.de, mchehab@kernel.org, phone-devel@vger.kernel.org, robh@kernel.org, shawnguo@kernel.org, slongerbeam@gmail.com Subject: Re: [PATCH v6 1/3] dt-bindings: media: document the nxp,imx8mq-mipi-csi2 receiver phy and controller Date: Wed, 14 Jul 2021 20:07:44 +0200 [thread overview] Message-ID: <eae3abb65452a09f822088eab10b26a5d35273ea.camel@puri.sm> (raw) In-Reply-To: <YO8kgHoV/PVlF3oV@pendragon.ideasonboard.com> Am Mittwoch, dem 14.07.2021 um 20:53 +0300 schrieb Laurent Pinchart: > Hi Martin, > > Thank you for the patch. > > On Wed, Jul 14, 2021 at 01:19:29PM +0200, Martin Kepplinger wrote: > > The i.MX8MQ SoC integrates a different MIPI CSI receiver as the > > i.MX8MM so > > describe the DT bindings for it. > > > > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm> > > Reviewed-by: Rob Herring <robh@kernel.org> > > --- > > .../bindings/media/nxp,imx8mq-mipi-csi2.yaml | 173 > > ++++++++++++++++++ > > 1 file changed, 173 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/media/nxp,imx8mq-mipi-csi2.yaml > > > > diff --git a/Documentation/devicetree/bindings/media/nxp,imx8mq- > > mipi-csi2.yaml > > b/Documentation/devicetree/bindings/media/nxp,imx8mq-mipi-csi2.yaml > > new file mode 100644 > > index 000000000000..97222485f223 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/nxp,imx8mq-mipi- > > csi2.yaml > > @@ -0,0 +1,173 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: > > http://devicetree.org/schemas/media/nxp,imx8mq-mipi-csi2.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: NXP i.MX8MQ MIPI CSI-2 receiver > > + > > +maintainers: > > + - Martin Kepplinger <martin.kepplinger@puri.sm> > > + > > +description: |- > > + This binding covers the CSI-2 RX PHY and host controller > > included in the > > + NXP i.MX8MQ SoC. It handles the sensor/image input and process > > for all the > > + input imaging devices. > > + > > +properties: > > + compatible: > > + enum: > > + - fsl,imx8mq-mipi-csi2 > > + > > + reg: > > + maxItems: 1 > > + > > + clocks: > > + items: > > + - description: core is the RX Controller Core Clock input. > > This clock > > + must be exactly equal to or faster than the > > receive > > + byteclock from the RX DPHY. > > + - description: esc is the Rx Escape Clock. This must be the > > same escape > > + clock that the RX DPHY receives. > > + - description: ui is the pixel clock (phy_ref up to 333Mhz). > > Where did you get the 333MHz limit from ? The information I've > received > indicate a limit of 125MHz for the UI clock (and 266 and 133 MHz for > the > core and esc clocks respectively). The latest ref.manual revison has this corrected to 333Mhz. Look at the "changelog" they have in the RM, to find it quickly. > > With this addressed, > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > + See the reference manual for details. > > + > > + clock-names: > > + items: > > + - const: core > > + - const: esc > > + - const: ui > > + > > + power-domains: > > + maxItems: 1 > > + > > + resets: > > + items: > > + - description: CORE_RESET reset register bit definition > > + - description: PHY_REF_RESET reset register bit definition > > + - description: ESC_RESET reset register bit definition > > + > > + fsl,mipi-phy-gpr: > > + description: | > > + The phandle to the imx8mq syscon iomux-gpr with the register > > + for setting RX_ENABLE for the mipi receiver. > > + > > + The format should be as follows: > > + <gpr req_gpr> > > + gpr is the phandle to general purpose register node. > > + req_gpr is the gpr register offset of RX_ENABLE for the mipi > > phy. > > + $ref: /schemas/types.yaml#/definitions/phandle-array > > + items: > > + items: > > + - description: The 'gpr' is the phandle to general purpose > > register node. > > + - description: The 'req_gpr' is the gpr register offset > > containing > > + CSI2_1_RX_ENABLE or CSI2_2_RX_ENABLE > > respectively. > > + maximum: 0xff > > + > > + interconnects: > > + maxItems: 1 > > + > > + interconnect-names: > > + const: dram > > + > > + ports: > > + $ref: /schemas/graph.yaml#/properties/ports > > + > > + properties: > > + port@0: > > + $ref: /schemas/graph.yaml#/$defs/port-base > > + unevaluatedProperties: false > > + description: > > + Input port node, single endpoint describing the CSI-2 > > transmitter. > > + > > + properties: > > + endpoint: > > + $ref: video-interfaces.yaml# > > + unevaluatedProperties: false > > + > > + properties: > > + data-lanes: > > + items: > > + minItems: 1 > > + maxItems: 4 > > + items: > > + - const: 1 > > + - const: 2 > > + - const: 3 > > + - const: 4 > > + > > + required: > > + - data-lanes > > + > > + port@1: > > + $ref: /schemas/graph.yaml#/properties/port > > + description: > > + Output port node > > + > > + required: > > + - port@0 > > + - port@1 > > + > > +required: > > + - compatible > > + - reg > > + - clocks > > + - clock-names > > + - power-domains > > + - resets > > + - fsl,mipi-phy-gpr > > + - ports > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include <dt-bindings/clock/imx8mq-clock.h> > > + #include <dt-bindings/interconnect/imx8mq.h> > > + > > + csi@30a70000 { > > + compatible = "fsl,imx8mq-mipi-csi2"; > > + reg = <0x30a70000 0x1000>; > > + clocks = <&clk IMX8MQ_CLK_CSI1_CORE>, > > + <&clk IMX8MQ_CLK_CSI1_ESC>, > > + <&clk IMX8MQ_CLK_CSI1_PHY_REF>; > > + clock-names = "core", "esc", "ui"; > > + assigned-clocks = <&clk IMX8MQ_CLK_CSI1_CORE>, > > + <&clk IMX8MQ_CLK_CSI1_PHY_REF>, > > + <&clk IMX8MQ_CLK_CSI1_ESC>; > > + assigned-clock-rates = <266000000>, <200000000>, > > <66000000>; > > + assigned-clock-parents = <&clk IMX8MQ_SYS1_PLL_266M>, > > + <&clk IMX8MQ_SYS2_PLL_1000M>, > > + <&clk IMX8MQ_SYS1_PLL_800M>; > > + power-domains = <&pgc_mipi_csi1>; > > + resets = <&src IMX8MQ_RESET_MIPI_CSI1_CORE_RESET>, > > + <&src IMX8MQ_RESET_MIPI_CSI1_PHY_REF_RESET>, > > + <&src IMX8MQ_RESET_MIPI_CSI1_ESC_RESET>; > > + fsl,mipi-phy-gpr = <&iomuxc_gpr 0x88>; > > + interconnects = <&noc IMX8MQ_ICM_CSI1 &noc > > IMX8MQ_ICS_DRAM>; > > + interconnect-names = "dram"; > > + > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + > > + imx8mm_mipi_csi_in: endpoint { > > + remote-endpoint = <&imx477_out>; > > + data-lanes = <1 2 3 4>; > > + }; > > + }; > > + > > + port@1 { > > + reg = <1>; > > + > > + imx8mm_mipi_csi_out: endpoint { > > + remote-endpoint = <&csi_in>; > > + }; > > + }; > > + }; > > + }; > > + > > +... >
WARNING: multiple messages have this Message-ID (diff)
From: Martin Kepplinger <martin.kepplinger@puri.sm> To: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: festevam@gmail.com, krzk@kernel.org, devicetree@vger.kernel.org, kernel@pengutronix.de, kernel@puri.sm, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, m.felsch@pengutronix.de, mchehab@kernel.org, phone-devel@vger.kernel.org, robh@kernel.org, shawnguo@kernel.org, slongerbeam@gmail.com Subject: Re: [PATCH v6 1/3] dt-bindings: media: document the nxp,imx8mq-mipi-csi2 receiver phy and controller Date: Wed, 14 Jul 2021 20:07:44 +0200 [thread overview] Message-ID: <eae3abb65452a09f822088eab10b26a5d35273ea.camel@puri.sm> (raw) In-Reply-To: <YO8kgHoV/PVlF3oV@pendragon.ideasonboard.com> Am Mittwoch, dem 14.07.2021 um 20:53 +0300 schrieb Laurent Pinchart: > Hi Martin, > > Thank you for the patch. > > On Wed, Jul 14, 2021 at 01:19:29PM +0200, Martin Kepplinger wrote: > > The i.MX8MQ SoC integrates a different MIPI CSI receiver as the > > i.MX8MM so > > describe the DT bindings for it. > > > > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm> > > Reviewed-by: Rob Herring <robh@kernel.org> > > --- > > .../bindings/media/nxp,imx8mq-mipi-csi2.yaml | 173 > > ++++++++++++++++++ > > 1 file changed, 173 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/media/nxp,imx8mq-mipi-csi2.yaml > > > > diff --git a/Documentation/devicetree/bindings/media/nxp,imx8mq- > > mipi-csi2.yaml > > b/Documentation/devicetree/bindings/media/nxp,imx8mq-mipi-csi2.yaml > > new file mode 100644 > > index 000000000000..97222485f223 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/nxp,imx8mq-mipi- > > csi2.yaml > > @@ -0,0 +1,173 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: > > http://devicetree.org/schemas/media/nxp,imx8mq-mipi-csi2.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: NXP i.MX8MQ MIPI CSI-2 receiver > > + > > +maintainers: > > + - Martin Kepplinger <martin.kepplinger@puri.sm> > > + > > +description: |- > > + This binding covers the CSI-2 RX PHY and host controller > > included in the > > + NXP i.MX8MQ SoC. It handles the sensor/image input and process > > for all the > > + input imaging devices. > > + > > +properties: > > + compatible: > > + enum: > > + - fsl,imx8mq-mipi-csi2 > > + > > + reg: > > + maxItems: 1 > > + > > + clocks: > > + items: > > + - description: core is the RX Controller Core Clock input. > > This clock > > + must be exactly equal to or faster than the > > receive > > + byteclock from the RX DPHY. > > + - description: esc is the Rx Escape Clock. This must be the > > same escape > > + clock that the RX DPHY receives. > > + - description: ui is the pixel clock (phy_ref up to 333Mhz). > > Where did you get the 333MHz limit from ? The information I've > received > indicate a limit of 125MHz for the UI clock (and 266 and 133 MHz for > the > core and esc clocks respectively). The latest ref.manual revison has this corrected to 333Mhz. Look at the "changelog" they have in the RM, to find it quickly. > > With this addressed, > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > + See the reference manual for details. > > + > > + clock-names: > > + items: > > + - const: core > > + - const: esc > > + - const: ui > > + > > + power-domains: > > + maxItems: 1 > > + > > + resets: > > + items: > > + - description: CORE_RESET reset register bit definition > > + - description: PHY_REF_RESET reset register bit definition > > + - description: ESC_RESET reset register bit definition > > + > > + fsl,mipi-phy-gpr: > > + description: | > > + The phandle to the imx8mq syscon iomux-gpr with the register > > + for setting RX_ENABLE for the mipi receiver. > > + > > + The format should be as follows: > > + <gpr req_gpr> > > + gpr is the phandle to general purpose register node. > > + req_gpr is the gpr register offset of RX_ENABLE for the mipi > > phy. > > + $ref: /schemas/types.yaml#/definitions/phandle-array > > + items: > > + items: > > + - description: The 'gpr' is the phandle to general purpose > > register node. > > + - description: The 'req_gpr' is the gpr register offset > > containing > > + CSI2_1_RX_ENABLE or CSI2_2_RX_ENABLE > > respectively. > > + maximum: 0xff > > + > > + interconnects: > > + maxItems: 1 > > + > > + interconnect-names: > > + const: dram > > + > > + ports: > > + $ref: /schemas/graph.yaml#/properties/ports > > + > > + properties: > > + port@0: > > + $ref: /schemas/graph.yaml#/$defs/port-base > > + unevaluatedProperties: false > > + description: > > + Input port node, single endpoint describing the CSI-2 > > transmitter. > > + > > + properties: > > + endpoint: > > + $ref: video-interfaces.yaml# > > + unevaluatedProperties: false > > + > > + properties: > > + data-lanes: > > + items: > > + minItems: 1 > > + maxItems: 4 > > + items: > > + - const: 1 > > + - const: 2 > > + - const: 3 > > + - const: 4 > > + > > + required: > > + - data-lanes > > + > > + port@1: > > + $ref: /schemas/graph.yaml#/properties/port > > + description: > > + Output port node > > + > > + required: > > + - port@0 > > + - port@1 > > + > > +required: > > + - compatible > > + - reg > > + - clocks > > + - clock-names > > + - power-domains > > + - resets > > + - fsl,mipi-phy-gpr > > + - ports > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include <dt-bindings/clock/imx8mq-clock.h> > > + #include <dt-bindings/interconnect/imx8mq.h> > > + > > + csi@30a70000 { > > + compatible = "fsl,imx8mq-mipi-csi2"; > > + reg = <0x30a70000 0x1000>; > > + clocks = <&clk IMX8MQ_CLK_CSI1_CORE>, > > + <&clk IMX8MQ_CLK_CSI1_ESC>, > > + <&clk IMX8MQ_CLK_CSI1_PHY_REF>; > > + clock-names = "core", "esc", "ui"; > > + assigned-clocks = <&clk IMX8MQ_CLK_CSI1_CORE>, > > + <&clk IMX8MQ_CLK_CSI1_PHY_REF>, > > + <&clk IMX8MQ_CLK_CSI1_ESC>; > > + assigned-clock-rates = <266000000>, <200000000>, > > <66000000>; > > + assigned-clock-parents = <&clk IMX8MQ_SYS1_PLL_266M>, > > + <&clk IMX8MQ_SYS2_PLL_1000M>, > > + <&clk IMX8MQ_SYS1_PLL_800M>; > > + power-domains = <&pgc_mipi_csi1>; > > + resets = <&src IMX8MQ_RESET_MIPI_CSI1_CORE_RESET>, > > + <&src IMX8MQ_RESET_MIPI_CSI1_PHY_REF_RESET>, > > + <&src IMX8MQ_RESET_MIPI_CSI1_ESC_RESET>; > > + fsl,mipi-phy-gpr = <&iomuxc_gpr 0x88>; > > + interconnects = <&noc IMX8MQ_ICM_CSI1 &noc > > IMX8MQ_ICS_DRAM>; > > + interconnect-names = "dram"; > > + > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + > > + imx8mm_mipi_csi_in: endpoint { > > + remote-endpoint = <&imx477_out>; > > + data-lanes = <1 2 3 4>; > > + }; > > + }; > > + > > + port@1 { > > + reg = <1>; > > + > > + imx8mm_mipi_csi_out: endpoint { > > + remote-endpoint = <&csi_in>; > > + }; > > + }; > > + }; > > + }; > > + > > +... > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-14 18:07 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-14 11:19 [PATCH v6 0/3] media: imx: add support for imx8mq MIPI RX Martin Kepplinger 2021-07-14 11:19 ` Martin Kepplinger 2021-07-14 11:19 ` [PATCH v6 1/3] dt-bindings: media: document the nxp,imx8mq-mipi-csi2 receiver phy and controller Martin Kepplinger 2021-07-14 11:19 ` [PATCH v6 1/3] dt-bindings: media: document the nxp, imx8mq-mipi-csi2 " Martin Kepplinger 2021-07-14 15:44 ` [PATCH v6 1/3] dt-bindings: media: document the nxp,imx8mq-mipi-csi2 " Rob Herring 2021-07-14 15:44 ` [PATCH v6 1/3] dt-bindings: media: document the nxp, imx8mq-mipi-csi2 " Rob Herring 2021-07-14 17:53 ` [PATCH v6 1/3] dt-bindings: media: document the nxp,imx8mq-mipi-csi2 " Laurent Pinchart 2021-07-14 17:53 ` Laurent Pinchart 2021-07-14 18:07 ` Martin Kepplinger [this message] 2021-07-14 18:07 ` Martin Kepplinger 2021-07-14 18:07 ` Martin Kepplinger 2021-07-14 11:19 ` [PATCH v6 2/3] media: imx: add a driver for i.MX8MQ mipi csi rx " Martin Kepplinger 2021-07-14 11:19 ` Martin Kepplinger 2021-07-14 18:24 ` Laurent Pinchart 2021-07-14 18:24 ` Laurent Pinchart 2021-07-15 6:49 ` Martin Kepplinger 2021-07-15 6:49 ` Martin Kepplinger 2021-07-15 6:49 ` Martin Kepplinger 2021-07-15 21:47 ` Laurent Pinchart 2021-07-15 21:47 ` Laurent Pinchart 2021-07-15 7:37 ` Martin Kepplinger 2021-07-15 7:37 ` Martin Kepplinger 2021-07-15 7:37 ` Martin Kepplinger 2021-07-15 21:52 ` Laurent Pinchart 2021-07-15 21:52 ` Laurent Pinchart 2021-07-16 8:47 ` Martin Kepplinger 2021-07-16 8:47 ` Martin Kepplinger 2021-07-16 8:47 ` Martin Kepplinger 2021-07-16 10:47 ` Laurent Pinchart 2021-07-16 10:47 ` Laurent Pinchart 2021-07-19 10:46 ` Martin Kepplinger 2021-07-19 10:46 ` Martin Kepplinger 2021-07-19 10:46 ` Martin Kepplinger 2021-07-19 14:20 ` Martin Kepplinger 2021-07-19 14:20 ` Martin Kepplinger 2021-07-19 14:20 ` Martin Kepplinger 2021-07-14 11:19 ` [PATCH v6 3/3] arm64: dts: imx8mq: add mipi csi phy and csi bridge descriptions Martin Kepplinger 2021-07-14 11:19 ` Martin Kepplinger
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=eae3abb65452a09f822088eab10b26a5d35273ea.camel@puri.sm \ --to=martin.kepplinger@puri.sm \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=kernel@puri.sm \ --cc=krzk@kernel.org \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-staging@lists.linux.dev \ --cc=m.felsch@pengutronix.de \ --cc=mchehab@kernel.org \ --cc=phone-devel@vger.kernel.org \ --cc=robh@kernel.org \ --cc=shawnguo@kernel.org \ --cc=slongerbeam@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.