* [Intel-gfx] [PATCH 0/3] drm/i915/uncore: unclaimed reg debug race fix and optimization
@ 2023-07-04 9:48 Jani Nikula
2023-07-04 9:48 ` [Intel-gfx] [PATCH 1/3] drm/i915/uncore: split unclaimed_reg_debug() to header and footer Jani Nikula
` (6 more replies)
0 siblings, 7 replies; 14+ messages in thread
From: Jani Nikula @ 2023-07-04 9:48 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
Fix a race in unclaimed reg debug. This does increase the code size for
CONFIG_DRM_I915_DEBUG_MMIO=y.
However, also add an optimization to reduce code size for
CONFIG_DRM_I915_DEBUG_MMIO=n.
Do we care about the bloat for the debug config?
Before/after for both CONFIG_DRM_I915_DEBUG_MMIO=y and =n.
$ scripts/bloat-o-meter intel_uncore.before.with-debug.o intel_uncore.after.with-debug.o
add/remove: 0/2 grow/shrink: 10/0 up/down: 927/-149 (778)
Function old new delta
fwtable_read16 721 821 +100
fwtable_read32 719 817 +98
fwtable_read8 722 818 +96
fwtable_read64 722 817 +95
gen6_write16 679 772 +93
gen6_write8 678 769 +91
gen6_write32 677 768 +91
fwtable_write16 742 831 +89
fwtable_write8 741 828 +87
fwtable_write32 740 827 +87
__pfx___unclaimed_reg_debug 16 - -16
__unclaimed_reg_debug 133 - -133
Total: Before=33797, After=34575, chg +2.30%
$ scripts/bloat-o-meter intel_uncore.before.without-debug.o intel_uncore.after.without-debug.o
add/remove: 0/2 grow/shrink: 0/10 up/down: 0/-2557 (-2557)
Function old new delta
__pfx___unclaimed_reg_debug 16 - -16
__unclaimed_reg_debug 133 - -133
gen6_write8 678 446 -232
gen6_write32 677 445 -232
gen6_write16 679 447 -232
fwtable_read64 722 482 -240
fwtable_read32 719 479 -240
fwtable_read16 721 481 -240
fwtable_read8 722 480 -242
fwtable_write8 741 491 -250
fwtable_write32 740 490 -250
fwtable_write16 742 492 -250
Total: Before=33797, After=31240, chg -7.57%
Cc: Lee Shawn C <shawn.c.lee@intel.com>
Jani Nikula (3):
drm/i915/uncore: split unclaimed_reg_debug() to header and footer
drm/i915/uncore: fix race around i915->params.mmio_debug
drm/i915/uncore: optimize CONFIG_DRM_I915_DEBUG_MMIO=n more
drivers/gpu/drm/i915/intel_uncore.c | 47 ++++++++++++++++++-----------
1 file changed, 29 insertions(+), 18 deletions(-)
--
2.39.2
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Intel-gfx] [PATCH 1/3] drm/i915/uncore: split unclaimed_reg_debug() to header and footer
2023-07-04 9:48 [Intel-gfx] [PATCH 0/3] drm/i915/uncore: unclaimed reg debug race fix and optimization Jani Nikula
@ 2023-07-04 9:48 ` Jani Nikula
2023-07-06 10:50 ` Tvrtko Ursulin
2023-07-04 9:48 ` [Intel-gfx] [PATCH 2/3] drm/i915/uncore: fix race around i915->params.mmio_debug Jani Nikula
` (5 subsequent siblings)
6 siblings, 1 reply; 14+ messages in thread
From: Jani Nikula @ 2023-07-04 9:48 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
Make it easier to have different logic for the two for follow-up.
Cc: Lee Shawn C <shawn.c.lee@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/intel_uncore.c | 37 +++++++++++++++++------------
1 file changed, 22 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
index 796ebfe6c550..a88aa342b623 100644
--- a/drivers/gpu/drm/i915/intel_uncore.c
+++ b/drivers/gpu/drm/i915/intel_uncore.c
@@ -1926,10 +1926,8 @@ __unclaimed_previous_reg_debug(struct intel_uncore *uncore,
}
static inline void
-unclaimed_reg_debug(struct intel_uncore *uncore,
- const i915_reg_t reg,
- const bool read,
- const bool before)
+unclaimed_reg_debug_header(struct intel_uncore *uncore,
+ const i915_reg_t reg, const bool read)
{
if (likely(!uncore->i915->params.mmio_debug) || !uncore->debug)
return;
@@ -1937,13 +1935,22 @@ unclaimed_reg_debug(struct intel_uncore *uncore,
/* interrupts are disabled and re-enabled around uncore->lock usage */
lockdep_assert_held(&uncore->lock);
- if (before) {
- spin_lock(&uncore->debug->lock);
- __unclaimed_previous_reg_debug(uncore, reg, read);
- } else {
- __unclaimed_reg_debug(uncore, reg, read);
- spin_unlock(&uncore->debug->lock);
- }
+ spin_lock(&uncore->debug->lock);
+ __unclaimed_previous_reg_debug(uncore, reg, read);
+}
+
+static inline void
+unclaimed_reg_debug_footer(struct intel_uncore *uncore,
+ const i915_reg_t reg, const bool read)
+{
+ if (likely(!uncore->i915->params.mmio_debug) || !uncore->debug)
+ return;
+
+ /* interrupts are disabled and re-enabled around uncore->lock usage */
+ lockdep_assert_held(&uncore->lock);
+
+ __unclaimed_reg_debug(uncore, reg, read);
+ spin_unlock(&uncore->debug->lock);
}
#define __vgpu_read(x) \
@@ -2004,10 +2011,10 @@ __gen2_read(64)
u##x val = 0; \
assert_rpm_wakelock_held(uncore->rpm); \
spin_lock_irqsave(&uncore->lock, irqflags); \
- unclaimed_reg_debug(uncore, reg, true, true)
+ unclaimed_reg_debug_header(uncore, reg, true)
#define GEN6_READ_FOOTER \
- unclaimed_reg_debug(uncore, reg, true, false); \
+ unclaimed_reg_debug_footer(uncore, reg, true); \
spin_unlock_irqrestore(&uncore->lock, irqflags); \
trace_i915_reg_rw(false, reg, val, sizeof(val), trace); \
return val
@@ -2108,10 +2115,10 @@ __gen2_write(32)
trace_i915_reg_rw(true, reg, val, sizeof(val), trace); \
assert_rpm_wakelock_held(uncore->rpm); \
spin_lock_irqsave(&uncore->lock, irqflags); \
- unclaimed_reg_debug(uncore, reg, false, true)
+ unclaimed_reg_debug_header(uncore, reg, false)
#define GEN6_WRITE_FOOTER \
- unclaimed_reg_debug(uncore, reg, false, false); \
+ unclaimed_reg_debug_footer(uncore, reg, false); \
spin_unlock_irqrestore(&uncore->lock, irqflags)
#define __gen6_write(x) \
--
2.39.2
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Intel-gfx] [PATCH 2/3] drm/i915/uncore: fix race around i915->params.mmio_debug
2023-07-04 9:48 [Intel-gfx] [PATCH 0/3] drm/i915/uncore: unclaimed reg debug race fix and optimization Jani Nikula
2023-07-04 9:48 ` [Intel-gfx] [PATCH 1/3] drm/i915/uncore: split unclaimed_reg_debug() to header and footer Jani Nikula
@ 2023-07-04 9:48 ` Jani Nikula
2023-07-06 10:51 ` Tvrtko Ursulin
2023-07-04 9:48 ` [Intel-gfx] [PATCH 3/3] drm/i915/uncore: optimize CONFIG_DRM_I915_DEBUG_MMIO=n more Jani Nikula
` (4 subsequent siblings)
6 siblings, 1 reply; 14+ messages in thread
From: Jani Nikula @ 2023-07-04 9:48 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
Only check the conditions for unclaimed reg debug once to avoid locking
problems when i915->params.mmio_debug changes between header and footer.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/8749
Cc: Lee Shawn C <shawn.c.lee@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/intel_uncore.c | 21 ++++++++++++---------
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
index a88aa342b623..dfefad5a5fec 100644
--- a/drivers/gpu/drm/i915/intel_uncore.c
+++ b/drivers/gpu/drm/i915/intel_uncore.c
@@ -1925,27 +1925,26 @@ __unclaimed_previous_reg_debug(struct intel_uncore *uncore,
i915_mmio_reg_offset(reg));
}
-static inline void
+static inline bool __must_check
unclaimed_reg_debug_header(struct intel_uncore *uncore,
const i915_reg_t reg, const bool read)
{
if (likely(!uncore->i915->params.mmio_debug) || !uncore->debug)
- return;
+ return false;
/* interrupts are disabled and re-enabled around uncore->lock usage */
lockdep_assert_held(&uncore->lock);
spin_lock(&uncore->debug->lock);
__unclaimed_previous_reg_debug(uncore, reg, read);
+
+ return true;
}
static inline void
unclaimed_reg_debug_footer(struct intel_uncore *uncore,
const i915_reg_t reg, const bool read)
{
- if (likely(!uncore->i915->params.mmio_debug) || !uncore->debug)
- return;
-
/* interrupts are disabled and re-enabled around uncore->lock usage */
lockdep_assert_held(&uncore->lock);
@@ -2008,13 +2007,15 @@ __gen2_read(64)
#define GEN6_READ_HEADER(x) \
u32 offset = i915_mmio_reg_offset(reg); \
unsigned long irqflags; \
+ bool unclaimed_reg_debug; \
u##x val = 0; \
assert_rpm_wakelock_held(uncore->rpm); \
spin_lock_irqsave(&uncore->lock, irqflags); \
- unclaimed_reg_debug_header(uncore, reg, true)
+ unclaimed_reg_debug = unclaimed_reg_debug_header(uncore, reg, true)
#define GEN6_READ_FOOTER \
- unclaimed_reg_debug_footer(uncore, reg, true); \
+ if (unclaimed_reg_debug) \
+ unclaimed_reg_debug_footer(uncore, reg, true); \
spin_unlock_irqrestore(&uncore->lock, irqflags); \
trace_i915_reg_rw(false, reg, val, sizeof(val), trace); \
return val
@@ -2112,13 +2113,15 @@ __gen2_write(32)
#define GEN6_WRITE_HEADER \
u32 offset = i915_mmio_reg_offset(reg); \
unsigned long irqflags; \
+ bool unclaimed_reg_debug; \
trace_i915_reg_rw(true, reg, val, sizeof(val), trace); \
assert_rpm_wakelock_held(uncore->rpm); \
spin_lock_irqsave(&uncore->lock, irqflags); \
- unclaimed_reg_debug_header(uncore, reg, false)
+ unclaimed_reg_debug = unclaimed_reg_debug_header(uncore, reg, false)
#define GEN6_WRITE_FOOTER \
- unclaimed_reg_debug_footer(uncore, reg, false); \
+ if (unclaimed_reg_debug) \
+ unclaimed_reg_debug_footer(uncore, reg, false); \
spin_unlock_irqrestore(&uncore->lock, irqflags)
#define __gen6_write(x) \
--
2.39.2
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Intel-gfx] [PATCH 3/3] drm/i915/uncore: optimize CONFIG_DRM_I915_DEBUG_MMIO=n more
2023-07-04 9:48 [Intel-gfx] [PATCH 0/3] drm/i915/uncore: unclaimed reg debug race fix and optimization Jani Nikula
2023-07-04 9:48 ` [Intel-gfx] [PATCH 1/3] drm/i915/uncore: split unclaimed_reg_debug() to header and footer Jani Nikula
2023-07-04 9:48 ` [Intel-gfx] [PATCH 2/3] drm/i915/uncore: fix race around i915->params.mmio_debug Jani Nikula
@ 2023-07-04 9:48 ` Jani Nikula
2023-07-06 10:56 ` Tvrtko Ursulin
2023-07-04 10:02 ` [Intel-gfx] [PATCH 0/3] drm/i915/uncore: unclaimed reg debug race fix and optimization Jani Nikula
` (3 subsequent siblings)
6 siblings, 1 reply; 14+ messages in thread
From: Jani Nikula @ 2023-07-04 9:48 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
While the default for the mmio_debug parameter depends on
CONFIG_DRM_I915_DEBUG_MMIO, we look it up and include all the code for
unclaimed reg debugging even when CONFIG_DRM_I915_DEBUG_MMIO=n. Fix it.
Cc: Lee Shawn C <shawn.c.lee@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/intel_uncore.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
index dfefad5a5fec..da2edde4b6f6 100644
--- a/drivers/gpu/drm/i915/intel_uncore.c
+++ b/drivers/gpu/drm/i915/intel_uncore.c
@@ -1929,7 +1929,8 @@ static inline bool __must_check
unclaimed_reg_debug_header(struct intel_uncore *uncore,
const i915_reg_t reg, const bool read)
{
- if (likely(!uncore->i915->params.mmio_debug) || !uncore->debug)
+ if (!IS_ENABLED(CONFIG_DRM_I915_DEBUG_MMIO) ||
+ likely(!uncore->i915->params.mmio_debug) || !uncore->debug)
return false;
/* interrupts are disabled and re-enabled around uncore->lock usage */
--
2.39.2
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH 0/3] drm/i915/uncore: unclaimed reg debug race fix and optimization
2023-07-04 9:48 [Intel-gfx] [PATCH 0/3] drm/i915/uncore: unclaimed reg debug race fix and optimization Jani Nikula
` (2 preceding siblings ...)
2023-07-04 9:48 ` [Intel-gfx] [PATCH 3/3] drm/i915/uncore: optimize CONFIG_DRM_I915_DEBUG_MMIO=n more Jani Nikula
@ 2023-07-04 10:02 ` Jani Nikula
2023-07-04 11:26 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork
` (2 subsequent siblings)
6 siblings, 0 replies; 14+ messages in thread
From: Jani Nikula @ 2023-07-04 10:02 UTC (permalink / raw)
To: intel-gfx
On Tue, 04 Jul 2023, Jani Nikula <jani.nikula@intel.com> wrote:
> Fix a race in unclaimed reg debug. This does increase the code size for
> CONFIG_DRM_I915_DEBUG_MMIO=y.
>
> However, also add an optimization to reduce code size for
> CONFIG_DRM_I915_DEBUG_MMIO=n.
>
> Do we care about the bloat for the debug config?
>
> Before/after for both CONFIG_DRM_I915_DEBUG_MMIO=y and =n.
>
>
> $ scripts/bloat-o-meter intel_uncore.before.with-debug.o intel_uncore.after.with-debug.o
> add/remove: 0/2 grow/shrink: 10/0 up/down: 927/-149 (778)
> Function old new delta
> fwtable_read16 721 821 +100
> fwtable_read32 719 817 +98
> fwtable_read8 722 818 +96
> fwtable_read64 722 817 +95
> gen6_write16 679 772 +93
> gen6_write8 678 769 +91
> gen6_write32 677 768 +91
> fwtable_write16 742 831 +89
> fwtable_write8 741 828 +87
> fwtable_write32 740 827 +87
> __pfx___unclaimed_reg_debug 16 - -16
> __unclaimed_reg_debug 133 - -133
Looking at the size decrease for __unclaimed_reg_debug(), it occurs to
me the compiler wasn't previously inlining unclaimed_reg_debug()
regardless of the inline keyword. It just bundled unclaimed_reg_debug()
together with __unclaimed_reg_debug(), and called it.
The juggling here actually makes them both inline, which presumably was
the original intention.
The optimization for CONFIG_DRM_I915_DEBUG_MMIO=n below is the good
stuff.
BR,
Jani.
> Total: Before=33797, After=34575, chg +2.30%
>
> $ scripts/bloat-o-meter intel_uncore.before.without-debug.o intel_uncore.after.without-debug.o
> add/remove: 0/2 grow/shrink: 0/10 up/down: 0/-2557 (-2557)
> Function old new delta
> __pfx___unclaimed_reg_debug 16 - -16
> __unclaimed_reg_debug 133 - -133
> gen6_write8 678 446 -232
> gen6_write32 677 445 -232
> gen6_write16 679 447 -232
> fwtable_read64 722 482 -240
> fwtable_read32 719 479 -240
> fwtable_read16 721 481 -240
> fwtable_read8 722 480 -242
> fwtable_write8 741 491 -250
> fwtable_write32 740 490 -250
> fwtable_write16 742 492 -250
> Total: Before=33797, After=31240, chg -7.57%
>
> Cc: Lee Shawn C <shawn.c.lee@intel.com>
>
> Jani Nikula (3):
> drm/i915/uncore: split unclaimed_reg_debug() to header and footer
> drm/i915/uncore: fix race around i915->params.mmio_debug
> drm/i915/uncore: optimize CONFIG_DRM_I915_DEBUG_MMIO=n more
>
> drivers/gpu/drm/i915/intel_uncore.c | 47 ++++++++++++++++++-----------
> 1 file changed, 29 insertions(+), 18 deletions(-)
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/uncore: unclaimed reg debug race fix and optimization
2023-07-04 9:48 [Intel-gfx] [PATCH 0/3] drm/i915/uncore: unclaimed reg debug race fix and optimization Jani Nikula
` (3 preceding siblings ...)
2023-07-04 10:02 ` [Intel-gfx] [PATCH 0/3] drm/i915/uncore: unclaimed reg debug race fix and optimization Jani Nikula
@ 2023-07-04 11:26 ` Patchwork
2023-07-04 11:36 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-07-04 15:23 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
6 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2023-07-04 11:26 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/uncore: unclaimed reg debug race fix and optimization
URL : https://patchwork.freedesktop.org/series/120167/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
-./include/linux/spinlock.h:405:9: warning: context imbalance in 'fwtable_read16' - different lock contexts for basic block
-./include/linux/spinlock.h:405:9: warning: context imbalance in 'fwtable_read32' - different lock contexts for basic block
-./include/linux/spinlock.h:405:9: warning: context imbalance in 'fwtable_read64' - different lock contexts for basic block
-./include/linux/spinlock.h:405:9: warning: context imbalance in 'fwtable_read8' - different lock contexts for basic block
-./include/linux/spinlock.h:405:9: warning: context imbalance in 'gen6_write16' - different lock contexts for basic block
-./include/linux/spinlock.h:405:9: warning: context imbalance in 'gen6_write32' - different lock contexts for basic block
-./include/linux/spinlock.h:405:9: warning: context imbalance in 'gen6_write8' - different lock contexts for basic block
-./include/linux/spinlock.h:405:9: warning: too many warnings
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/uncore: unclaimed reg debug race fix and optimization
2023-07-04 9:48 [Intel-gfx] [PATCH 0/3] drm/i915/uncore: unclaimed reg debug race fix and optimization Jani Nikula
` (4 preceding siblings ...)
2023-07-04 11:26 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork
@ 2023-07-04 11:36 ` Patchwork
2023-07-04 15:23 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
6 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2023-07-04 11:36 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 10334 bytes --]
== Series Details ==
Series: drm/i915/uncore: unclaimed reg debug race fix and optimization
URL : https://patchwork.freedesktop.org/series/120167/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13344 -> Patchwork_120167v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/index.html
Participating hosts (41 -> 39)
------------------------------
Missing (2): fi-snb-2520m fi-pnv-d510
Known issues
------------
Here are the changes found in Patchwork_120167v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_lmem_swapping@parallel-random-engines:
- bat-mtlp-8: NOTRUN -> [SKIP][1] ([i915#4613]) +3 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/bat-mtlp-8/igt@gem_lmem_swapping@parallel-random-engines.html
* igt@i915_pm_rps@basic-api:
- bat-mtlp-8: NOTRUN -> [SKIP][2] ([i915#6621])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/bat-mtlp-8/igt@i915_pm_rps@basic-api.html
* igt@i915_selftest@live@gt_pm:
- bat-rpls-2: [PASS][3] -> [DMESG-FAIL][4] ([i915#4258] / [i915#7913])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13344/bat-rpls-2/igt@i915_selftest@live@gt_pm.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/bat-rpls-2/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@slpc:
- bat-rpls-1: NOTRUN -> [DMESG-WARN][5] ([i915#6367])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/bat-rpls-1/igt@i915_selftest@live@slpc.html
* igt@i915_suspend@basic-s3-without-i915:
- bat-mtlp-8: NOTRUN -> [SKIP][6] ([i915#6645])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/bat-mtlp-8/igt@i915_suspend@basic-s3-without-i915.html
- bat-rpls-1: NOTRUN -> [ABORT][7] ([i915#6687] / [i915#7978] / [i915#8668])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/bat-rpls-1/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- bat-adlp-9: NOTRUN -> [SKIP][8] ([i915#7828])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/bat-adlp-9/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
- bat-mtlp-8: NOTRUN -> [SKIP][9] ([i915#7828])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/bat-mtlp-8/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
- bat-jsl-1: NOTRUN -> [SKIP][10] ([i915#7828])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/bat-jsl-1/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
- bat-dg2-11: NOTRUN -> [SKIP][11] ([i915#1845] / [i915#5354]) +3 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html
* igt@prime_vgem@basic-fence-read:
- bat-mtlp-8: NOTRUN -> [SKIP][12] ([i915#3708]) +2 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/bat-mtlp-8/igt@prime_vgem@basic-fence-read.html
* igt@prime_vgem@basic-gtt:
- bat-mtlp-8: NOTRUN -> [SKIP][13] ([i915#3708] / [i915#4077]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/bat-mtlp-8/igt@prime_vgem@basic-gtt.html
#### Possible fixes ####
* igt@gem_exec_parallel@engines@userptr:
- bat-mtlp-8: [FAIL][14] ([i915#8672]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13344/bat-mtlp-8/igt@gem_exec_parallel@engines@userptr.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/bat-mtlp-8/igt@gem_exec_parallel@engines@userptr.html
* igt@gem_exec_suspend@basic-s0@smem:
- bat-jsl-1: [ABORT][16] ([i915#5122]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13344/bat-jsl-1/igt@gem_exec_suspend@basic-s0@smem.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/bat-jsl-1/igt@gem_exec_suspend@basic-s0@smem.html
* igt@i915_pm_rpm@basic-pci-d3-state:
- bat-mtlp-8: [ABORT][18] ([i915#7077] / [i915#7977] / [i915#8668]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13344/bat-mtlp-8/igt@i915_pm_rpm@basic-pci-d3-state.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/bat-mtlp-8/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@i915_selftest@live@guc:
- bat-rpls-2: [DMESG-WARN][20] ([i915#7852]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13344/bat-rpls-2/igt@i915_selftest@live@guc.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/bat-rpls-2/igt@i915_selftest@live@guc.html
* igt@i915_selftest@live@migrate:
- bat-dg2-11: [DMESG-WARN][22] ([i915#7699]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13344/bat-dg2-11/igt@i915_selftest@live@migrate.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/bat-dg2-11/igt@i915_selftest@live@migrate.html
- bat-atsm-1: [DMESG-FAIL][24] ([i915#7699] / [i915#7913]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13344/bat-atsm-1/igt@i915_selftest@live@migrate.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/bat-atsm-1/igt@i915_selftest@live@migrate.html
* igt@i915_selftest@live@requests:
- bat-rpls-1: [ABORT][26] ([i915#7920] / [i915#7982]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13344/bat-rpls-1/igt@i915_selftest@live@requests.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/bat-rpls-1/igt@i915_selftest@live@requests.html
* igt@i915_selftest@live@slpc:
- bat-mtlp-6: [DMESG-WARN][28] ([i915#6367]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13344/bat-mtlp-6/igt@i915_selftest@live@slpc.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/bat-mtlp-6/igt@i915_selftest@live@slpc.html
* igt@i915_selftest@live@workarounds:
- bat-adlp-9: [INCOMPLETE][30] ([i915#4983] / [i915#7677] / [i915#7913]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13344/bat-adlp-9/igt@i915_selftest@live@workarounds.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/bat-adlp-9/igt@i915_selftest@live@workarounds.html
- bat-mtlp-6: [DMESG-FAIL][32] ([i915#6763]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13344/bat-mtlp-6/igt@i915_selftest@live@workarounds.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/bat-mtlp-6/igt@i915_selftest@live@workarounds.html
* igt@i915_suspend@basic-s3-without-i915:
- bat-jsl-1: [FAIL][34] ([fdo#103375]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13344/bat-jsl-1/igt@i915_suspend@basic-s3-without-i915.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/bat-jsl-1/igt@i915_suspend@basic-s3-without-i915.html
#### Warnings ####
* igt@core_auth@basic-auth:
- bat-adlp-11: [ABORT][36] ([i915#8011]) -> [ABORT][37] ([i915#4423] / [i915#8011])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13344/bat-adlp-11/igt@core_auth@basic-auth.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/bat-adlp-11/igt@core_auth@basic-auth.html
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#6763]: https://gitlab.freedesktop.org/drm/intel/issues/6763
[i915#7077]: https://gitlab.freedesktop.org/drm/intel/issues/7077
[i915#7677]: https://gitlab.freedesktop.org/drm/intel/issues/7677
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7852]: https://gitlab.freedesktop.org/drm/intel/issues/7852
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7920]: https://gitlab.freedesktop.org/drm/intel/issues/7920
[i915#7977]: https://gitlab.freedesktop.org/drm/intel/issues/7977
[i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978
[i915#7982]: https://gitlab.freedesktop.org/drm/intel/issues/7982
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668
[i915#8672]: https://gitlab.freedesktop.org/drm/intel/issues/8672
Build changes
-------------
* Linux: CI_DRM_13344 -> Patchwork_120167v1
CI-20190529: 20190529
CI_DRM_13344: 57e06a441fe3b4ea99a2611371044ced7f4f3487 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7369: 22009ac9c26ceec8450dd312f5c93fc01d986348 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_120167v1: 57e06a441fe3b4ea99a2611371044ced7f4f3487 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
1a22c11241c3 drm/i915/uncore: optimize CONFIG_DRM_I915_DEBUG_MMIO=n more
349d10767546 drm/i915/uncore: fix race around i915->params.mmio_debug
a9c092725948 drm/i915/uncore: split unclaimed_reg_debug() to header and footer
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/index.html
[-- Attachment #2: Type: text/html, Size: 12089 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/uncore: unclaimed reg debug race fix and optimization
2023-07-04 9:48 [Intel-gfx] [PATCH 0/3] drm/i915/uncore: unclaimed reg debug race fix and optimization Jani Nikula
` (5 preceding siblings ...)
2023-07-04 11:36 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2023-07-04 15:23 ` Patchwork
6 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2023-07-04 15:23 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 36328 bytes --]
== Series Details ==
Series: drm/i915/uncore: unclaimed reg debug race fix and optimization
URL : https://patchwork.freedesktop.org/series/120167/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13344_full -> Patchwork_120167v1_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (9 -> 8)
------------------------------
Missing (1): shard-rkl0
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_120167v1_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@perf_pmu@frequency@gt0:
- {shard-dg1}: [PASS][1] -> [SKIP][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13344/shard-dg1-13/igt@perf_pmu@frequency@gt0.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg1-12/igt@perf_pmu@frequency@gt0.html
Known issues
------------
Here are the changes found in Patchwork_120167v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@drm_fdinfo@busy-idle@bcs0:
- shard-dg2: NOTRUN -> [SKIP][3] ([i915#8414]) +9 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg2-11/igt@drm_fdinfo@busy-idle@bcs0.html
* igt@gem_ctx_persistence@heartbeat-hang:
- shard-dg2: NOTRUN -> [SKIP][4] ([i915#8555])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg2-11/igt@gem_ctx_persistence@heartbeat-hang.html
* igt@gem_ctx_persistence@saturated-hostile-nopreempt@ccs0:
- shard-dg2: NOTRUN -> [SKIP][5] ([i915#5882]) +9 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg2-11/igt@gem_ctx_persistence@saturated-hostile-nopreempt@ccs0.html
* igt@gem_exec_balancer@full-late-pulse:
- shard-dg2: [PASS][6] -> [FAIL][7] ([i915#6032])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13344/shard-dg2-7/igt@gem_exec_balancer@full-late-pulse.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg2-3/igt@gem_exec_balancer@full-late-pulse.html
* igt@gem_exec_endless@dispatch@bcs0:
- shard-dg2: [PASS][8] -> [TIMEOUT][9] ([i915#3778] / [i915#7016] / [i915#7921])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13344/shard-dg2-12/igt@gem_exec_endless@dispatch@bcs0.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg2-1/igt@gem_exec_endless@dispatch@bcs0.html
* igt@gem_exec_fair@basic-deadline:
- shard-glk: NOTRUN -> [FAIL][10] ([i915#2846])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-glk6/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-none:
- shard-dg2: NOTRUN -> [SKIP][11] ([i915#3539] / [i915#4852])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg2-11/igt@gem_exec_fair@basic-none.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [PASS][12] -> [FAIL][13] ([i915#2842])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13344/shard-apl2/igt@gem_exec_fair@basic-none-solo@rcs0.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-apl4/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-rkl: [PASS][14] -> [FAIL][15] ([i915#2842])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13344/shard-rkl-2/igt@gem_exec_fair@basic-throttle@rcs0.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-rkl-2/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_params@secure-non-master:
- shard-dg2: NOTRUN -> [SKIP][16] ([fdo#112283])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg2-8/igt@gem_exec_params@secure-non-master.html
- shard-rkl: NOTRUN -> [SKIP][17] ([fdo#112283])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-rkl-6/igt@gem_exec_params@secure-non-master.html
* igt@gem_exec_reloc@basic-gtt-read-active:
- shard-dg2: NOTRUN -> [SKIP][18] ([i915#3281]) +4 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg2-11/igt@gem_exec_reloc@basic-gtt-read-active.html
* igt@gem_exec_schedule@preempt-queue-contexts-chain:
- shard-dg2: NOTRUN -> [SKIP][19] ([i915#4537] / [i915#4812])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg2-11/igt@gem_exec_schedule@preempt-queue-contexts-chain.html
* igt@gem_exec_suspend@basic-s4-devices@lmem0:
- shard-dg2: NOTRUN -> [ABORT][20] ([i915#7975] / [i915#8213] / [i915#8682])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg2-8/igt@gem_exec_suspend@basic-s4-devices@lmem0.html
* igt@gem_exec_suspend@basic-s4-devices@smem:
- shard-rkl: NOTRUN -> [ABORT][21] ([i915#7975] / [i915#8213])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-rkl-6/igt@gem_exec_suspend@basic-s4-devices@smem.html
* igt@gem_lmem_swapping@heavy-multi:
- shard-tglu: NOTRUN -> [SKIP][22] ([i915#4613])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-tglu-5/igt@gem_lmem_swapping@heavy-multi.html
* igt@gem_lmem_swapping@heavy-verify-multi-ccs:
- shard-apl: NOTRUN -> [SKIP][23] ([fdo#109271] / [i915#4613])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-apl6/igt@gem_lmem_swapping@heavy-verify-multi-ccs.html
* igt@gem_mmap_gtt@fault-concurrent-x:
- shard-snb: [PASS][24] -> [ABORT][25] ([i915#5161])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13344/shard-snb5/igt@gem_mmap_gtt@fault-concurrent-x.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-snb5/igt@gem_mmap_gtt@fault-concurrent-x.html
* igt@gem_mmap_gtt@ptrace:
- shard-dg2: NOTRUN -> [SKIP][26] ([i915#4077])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg2-11/igt@gem_mmap_gtt@ptrace.html
* igt@gem_pread@snoop:
- shard-dg2: NOTRUN -> [SKIP][27] ([i915#3282]) +2 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg2-8/igt@gem_pread@snoop.html
- shard-rkl: NOTRUN -> [SKIP][28] ([i915#3282])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-rkl-6/igt@gem_pread@snoop.html
* igt@gem_pxp@verify-pxp-stale-buf-optout-execution:
- shard-dg2: NOTRUN -> [SKIP][29] ([i915#4270])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg2-11/igt@gem_pxp@verify-pxp-stale-buf-optout-execution.html
* igt@gem_set_tiling_vs_blt@tiled-to-tiled:
- shard-dg2: NOTRUN -> [SKIP][30] ([i915#4079])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg2-5/igt@gem_set_tiling_vs_blt@tiled-to-tiled.html
* igt@i915_module_load@load:
- shard-apl: NOTRUN -> [SKIP][31] ([fdo#109271] / [i915#6227])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-apl6/igt@i915_module_load@load.html
* igt@i915_pm_backlight@bad-brightness:
- shard-dg2: NOTRUN -> [SKIP][32] ([i915#5354] / [i915#7561])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg2-11/igt@i915_pm_backlight@bad-brightness.html
* igt@i915_selftest@live@gt_heartbeat:
- shard-apl: [PASS][33] -> [DMESG-FAIL][34] ([i915#5334])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13344/shard-apl2/igt@i915_selftest@live@gt_heartbeat.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-apl4/igt@i915_selftest@live@gt_heartbeat.html
* igt@kms_async_flips@crc@pipe-b-hdmi-a-1:
- shard-rkl: NOTRUN -> [FAIL][35] ([i915#8247]) +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-rkl-7/igt@kms_async_flips@crc@pipe-b-hdmi-a-1.html
* igt@kms_async_flips@crc@pipe-c-hdmi-a-3:
- shard-dg2: NOTRUN -> [FAIL][36] ([i915#8247]) +3 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg2-5/igt@kms_async_flips@crc@pipe-c-hdmi-a-3.html
* igt@kms_atomic@plane-primary-overlay-mutable-zpos:
- shard-dg2: NOTRUN -> [SKIP][37] ([i915#404])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg2-11/igt@kms_atomic@plane-primary-overlay-mutable-zpos.html
* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip:
- shard-rkl: NOTRUN -> [SKIP][38] ([i915#5286])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-rkl-6/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html
* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip:
- shard-tglu: NOTRUN -> [SKIP][39] ([fdo#111615] / [i915#5286]) +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-tglu-5/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-async-flip:
- shard-dg2: NOTRUN -> [SKIP][40] ([i915#5190]) +5 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg2-8/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-async-flip.html
* igt@kms_big_joiner@basic:
- shard-dg2: NOTRUN -> [SKIP][41] ([i915#2705])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg2-11/igt@kms_big_joiner@basic.html
* igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][42] ([fdo#109271] / [i915#3886])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-apl6/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_gen12_rc_ccs_cc:
- shard-dg2: NOTRUN -> [SKIP][43] ([i915#3689] / [i915#3886] / [i915#5354]) +4 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg2-5/igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs:
- shard-rkl: NOTRUN -> [SKIP][44] ([i915#3886] / [i915#5354] / [i915#6095])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-rkl-6/igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-bad-aux-stride-4_tiled_mtl_rc_ccs:
- shard-tglu: NOTRUN -> [SKIP][45] ([i915#5354] / [i915#6095])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-tglu-5/igt@kms_ccs@pipe-c-bad-aux-stride-4_tiled_mtl_rc_ccs.html
* igt@kms_ccs@pipe-c-bad-rotation-90-4_tiled_dg2_rc_ccs:
- shard-rkl: NOTRUN -> [SKIP][46] ([i915#5354])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-rkl-6/igt@kms_ccs@pipe-c-bad-rotation-90-4_tiled_dg2_rc_ccs.html
* igt@kms_ccs@pipe-c-crc-primary-basic-4_tiled_mtl_rc_ccs:
- shard-dg2: NOTRUN -> [SKIP][47] ([i915#5354]) +14 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg2-11/igt@kms_ccs@pipe-c-crc-primary-basic-4_tiled_mtl_rc_ccs.html
* igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_mc_ccs:
- shard-tglu: NOTRUN -> [SKIP][48] ([i915#3689] / [i915#3886] / [i915#5354] / [i915#6095])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-tglu-5/igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-d-bad-rotation-90-4_tiled_dg2_rc_ccs_cc:
- shard-tglu: NOTRUN -> [SKIP][49] ([i915#3689] / [i915#5354] / [i915#6095]) +2 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-tglu-5/igt@kms_ccs@pipe-d-bad-rotation-90-4_tiled_dg2_rc_ccs_cc.html
* igt@kms_ccs@pipe-d-missing-ccs-buffer-y_tiled_gen12_mc_ccs:
- shard-dg2: NOTRUN -> [SKIP][50] ([i915#3689] / [i915#5354]) +6 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg2-5/igt@kms_ccs@pipe-d-missing-ccs-buffer-y_tiled_gen12_mc_ccs.html
* igt@kms_chamelium_audio@dp-audio:
- shard-tglu: NOTRUN -> [SKIP][51] ([i915#7828]) +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-tglu-5/igt@kms_chamelium_audio@dp-audio.html
* igt@kms_chamelium_hpd@vga-hpd-without-ddc:
- shard-dg2: NOTRUN -> [SKIP][52] ([i915#7828])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg2-5/igt@kms_chamelium_hpd@vga-hpd-without-ddc.html
* igt@kms_content_protection@legacy@pipe-a-dp-4:
- shard-dg2: NOTRUN -> [TIMEOUT][53] ([i915#7173])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg2-11/igt@kms_content_protection@legacy@pipe-a-dp-4.html
* igt@kms_content_protection@uevent@pipe-a-dp-4:
- shard-dg2: NOTRUN -> [FAIL][54] ([i915#1339])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg2-11/igt@kms_content_protection@uevent@pipe-a-dp-4.html
* igt@kms_cursor_crc@cursor-sliding-32x10:
- shard-dg2: NOTRUN -> [SKIP][55] ([i915#3555]) +3 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg2-11/igt@kms_cursor_crc@cursor-sliding-32x10.html
* igt@kms_cursor_legacy@cursorb-vs-flipb-legacy:
- shard-dg2: NOTRUN -> [SKIP][56] ([fdo#109274] / [i915#5354])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg2-8/igt@kms_cursor_legacy@cursorb-vs-flipb-legacy.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: [PASS][57] -> [FAIL][58] ([i915#2346])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13344/shard-glk7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-glk9/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-apl: [PASS][59] -> [FAIL][60] ([i915#2346]) +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13344/shard-apl2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-apl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_flip@2x-nonexisting-fb:
- shard-dg2: NOTRUN -> [SKIP][61] ([fdo#109274])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg2-5/igt@kms_flip@2x-nonexisting-fb.html
* igt@kms_flip@2x-plain-flip-fb-recreate-interruptible:
- shard-tglu: NOTRUN -> [SKIP][62] ([fdo#109274] / [i915#3637]) +1 similar issue
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-tglu-5/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible.html
* igt@kms_flip@2x-plain-flip-ts-check-interruptible:
- shard-snb: NOTRUN -> [SKIP][63] ([fdo#109271]) +6 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-snb6/igt@kms_flip@2x-plain-flip-ts-check-interruptible.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs-downscaling@pipe-a-valid-mode:
- shard-dg2: NOTRUN -> [SKIP][64] ([i915#2672])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg2-11/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs-downscaling@pipe-a-valid-mode.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-mmap-wc:
- shard-dg2: NOTRUN -> [SKIP][65] ([i915#8708]) +9 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg2-11/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbc-2p-shrfb-fliptrack-mmap-gtt:
- shard-rkl: NOTRUN -> [SKIP][66] ([fdo#111825]) +1 similar issue
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-2p-shrfb-fliptrack-mmap-gtt.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-blt:
- shard-dg2: NOTRUN -> [SKIP][67] ([i915#3458]) +3 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg2-11/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-gtt:
- shard-rkl: NOTRUN -> [SKIP][68] ([i915#3023])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-rkl-6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-mmap-cpu:
- shard-tglu: NOTRUN -> [SKIP][69] ([fdo#109280]) +4 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-tglu-5/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-indfb-plflip-blt:
- shard-rkl: NOTRUN -> [SKIP][70] ([fdo#111825] / [i915#1825])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-rkl-6/igt@kms_frontbuffer_tracking@psr-2p-primscrn-indfb-plflip-blt.html
* igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-75@pipe-a-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][71] ([i915#5176]) +7 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-rkl-1/igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-75@pipe-a-hdmi-a-2.html
* igt@kms_plane_scaling@planes-downscale-factor-0-25-unity-scaling@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][72] ([i915#5235]) +1 similar issue
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-rkl-1/igt@kms_plane_scaling@planes-downscale-factor-0-25-unity-scaling@pipe-b-hdmi-a-2.html
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-b-dp-4:
- shard-dg2: NOTRUN -> [SKIP][73] ([i915#5235]) +15 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg2-11/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-b-dp-4.html
* igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf:
- shard-apl: NOTRUN -> [SKIP][74] ([fdo#109271] / [i915#658])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-apl6/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area:
- shard-dg2: NOTRUN -> [SKIP][75] ([i915#658])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg2-11/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area.html
* igt@kms_psr@cursor_mmap_cpu:
- shard-dg2: NOTRUN -> [SKIP][76] ([i915#1072])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg2-5/igt@kms_psr@cursor_mmap_cpu.html
* igt@kms_psr@psr2_primary_page_flip:
- shard-tglu: NOTRUN -> [SKIP][77] ([fdo#110189]) +1 similar issue
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-tglu-5/igt@kms_psr@psr2_primary_page_flip.html
* igt@kms_setmode@clone-exclusive-crtc:
- shard-tglu: NOTRUN -> [SKIP][78] ([i915#3555]) +1 similar issue
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-tglu-5/igt@kms_setmode@clone-exclusive-crtc.html
* igt@kms_sysfs_edid_timing:
- shard-dg2: [PASS][79] -> [FAIL][80] ([IGT#2])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13344/shard-dg2-12/igt@kms_sysfs_edid_timing.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg2-8/igt@kms_sysfs_edid_timing.html
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-dg2: [PASS][81] -> [FAIL][82] ([fdo#103375] / [i915#6121]) +2 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13344/shard-dg2-1/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg2-5/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
* igt@kms_vblank@pipe-d-ts-continuation-dpms-rpm:
- shard-apl: NOTRUN -> [SKIP][83] ([fdo#109271]) +62 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-apl1/igt@kms_vblank@pipe-d-ts-continuation-dpms-rpm.html
* igt@perf@unprivileged-single-ctx-counters:
- shard-tglu: NOTRUN -> [SKIP][84] ([fdo#109289])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-tglu-5/igt@perf@unprivileged-single-ctx-counters.html
* igt@perf_pmu@rc6-all-gts:
- shard-dg2: NOTRUN -> [SKIP][85] ([i915#8516])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg2-8/igt@perf_pmu@rc6-all-gts.html
- shard-rkl: NOTRUN -> [SKIP][86] ([i915#8516])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-rkl-6/igt@perf_pmu@rc6-all-gts.html
* igt@v3d/v3d_perfmon@create-perfmon-invalid-counters:
- shard-glk: NOTRUN -> [SKIP][87] ([fdo#109271]) +12 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-glk6/igt@v3d/v3d_perfmon@create-perfmon-invalid-counters.html
* igt@v3d/v3d_perfmon@get-values-valid-perfmon:
- shard-tglu: NOTRUN -> [SKIP][88] ([fdo#109315] / [i915#2575])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-tglu-5/igt@v3d/v3d_perfmon@get-values-valid-perfmon.html
* igt@v3d/v3d_submit_cl@multisync-out-syncs:
- shard-dg2: NOTRUN -> [SKIP][89] ([i915#2575]) +2 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg2-11/igt@v3d/v3d_submit_cl@multisync-out-syncs.html
* igt@vc4/vc4_mmap@mmap-bo:
- shard-tglu: NOTRUN -> [SKIP][90] ([i915#2575])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-tglu-5/igt@vc4/vc4_mmap@mmap-bo.html
* igt@vc4/vc4_perfmon@destroy-invalid-perfmon:
- shard-dg2: NOTRUN -> [SKIP][91] ([i915#7711])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg2-11/igt@vc4/vc4_perfmon@destroy-invalid-perfmon.html
#### Possible fixes ####
* igt@drm_fdinfo@most-busy-idle-check-all@rcs0:
- shard-rkl: [FAIL][92] ([i915#7742]) -> [PASS][93]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13344/shard-rkl-7/igt@drm_fdinfo@most-busy-idle-check-all@rcs0.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-rkl-6/igt@drm_fdinfo@most-busy-idle-check-all@rcs0.html
* igt@gem_barrier_race@remote-request@rcs0:
- shard-apl: [ABORT][94] ([i915#7461] / [i915#8211] / [i915#8234]) -> [PASS][95]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13344/shard-apl6/igt@gem_barrier_race@remote-request@rcs0.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-apl1/igt@gem_barrier_race@remote-request@rcs0.html
* igt@gem_eio@hibernate:
- shard-dg2: [ABORT][96] ([i915#7975] / [i915#8213]) -> [PASS][97]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13344/shard-dg2-6/igt@gem_eio@hibernate.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg2-11/igt@gem_eio@hibernate.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglu: [FAIL][98] ([i915#2842]) -> [PASS][99]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13344/shard-tglu-9/igt@gem_exec_fair@basic-pace-share@rcs0.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-tglu-7/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_whisper@basic-fds-priority-all:
- shard-tglu: [INCOMPLETE][100] ([i915#6755] / [i915#7392]) -> [PASS][101]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13344/shard-tglu-5/igt@gem_exec_whisper@basic-fds-priority-all.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-tglu-5/igt@gem_exec_whisper@basic-fds-priority-all.html
* igt@gem_lmem_swapping@smem-oom@lmem0:
- {shard-dg1}: [TIMEOUT][102] ([i915#5493]) -> [PASS][103]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13344/shard-dg1-19/igt@gem_lmem_swapping@smem-oom@lmem0.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg1-13/igt@gem_lmem_swapping@smem-oom@lmem0.html
* igt@gen9_exec_parse@allowed-single:
- shard-glk: [ABORT][104] ([i915#5566]) -> [PASS][105]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13344/shard-glk1/igt@gen9_exec_parse@allowed-single.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-glk6/igt@gen9_exec_parse@allowed-single.html
* igt@i915_pm_rpm@dpms-mode-unset-lpsp:
- {shard-dg1}: [SKIP][106] ([i915#1397]) -> [PASS][107]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13344/shard-dg1-12/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg1-19/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html
* igt@i915_pm_rpm@dpms-mode-unset-non-lpsp:
- shard-dg2: [SKIP][108] ([i915#1397]) -> [PASS][109] +3 similar issues
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13344/shard-dg2-12/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg2-5/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html
* igt@i915_pm_rpm@dpms-non-lpsp:
- shard-rkl: [SKIP][110] ([i915#1397]) -> [PASS][111] +2 similar issues
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13344/shard-rkl-7/igt@i915_pm_rpm@dpms-non-lpsp.html
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-rkl-6/igt@i915_pm_rpm@dpms-non-lpsp.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-glk: [FAIL][112] ([i915#4767]) -> [PASS][113]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13344/shard-glk2/igt@kms_fbcon_fbt@fbc-suspend.html
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-glk2/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-apl: [ABORT][114] ([i915#180]) -> [PASS][115]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13344/shard-apl1/igt@kms_flip@flip-vs-suspend@c-dp1.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-apl6/igt@kms_flip@flip-vs-suspend@c-dp1.html
* igt@kms_frontbuffer_tracking@fbc-stridechange:
- shard-dg2: [FAIL][116] ([i915#6880]) -> [PASS][117]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13344/shard-dg2-8/igt@kms_frontbuffer_tracking@fbc-stridechange.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg2-6/igt@kms_frontbuffer_tracking@fbc-stridechange.html
* igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend:
- shard-dg2: [FAIL][118] ([fdo#103375] / [i915#6121]) -> [PASS][119]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13344/shard-dg2-5/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg2-12/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html
#### Warnings ####
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-rkl: [FAIL][120] ([i915#2876]) -> [FAIL][121] ([i915#2842])
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13344/shard-rkl-2/igt@gem_exec_fair@basic-pace@rcs0.html
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-rkl-7/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_lmem_swapping@smem-oom@lmem0:
- shard-dg2: [TIMEOUT][122] ([i915#5493]) -> [DMESG-WARN][123] ([i915#4936] / [i915#5493])
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13344/shard-dg2-1/igt@gem_lmem_swapping@smem-oom@lmem0.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg2-5/igt@gem_lmem_swapping@smem-oom@lmem0.html
* igt@kms_fbcon_fbt@psr:
- shard-rkl: [SKIP][124] ([fdo#110189] / [i915#3955]) -> [SKIP][125] ([i915#3955])
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13344/shard-rkl-2/igt@kms_fbcon_fbt@psr.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-rkl-7/igt@kms_fbcon_fbt@psr.html
* igt@prime_mmap@test_aperture_limit@test_aperture_limit-smem:
- shard-dg2: [CRASH][126] ([i915#7331]) -> [INCOMPLETE][127] ([i915#5493])
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13344/shard-dg2-7/igt@prime_mmap@test_aperture_limit@test_aperture_limit-smem.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/shard-dg2-11/igt@prime_mmap@test_aperture_limit@test_aperture_limit-smem.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1339]: https://gitlab.freedesktop.org/drm/intel/issues/1339
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2876]: https://gitlab.freedesktop.org/drm/intel/issues/2876
[i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3778]: https://gitlab.freedesktop.org/drm/intel/issues/3778
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4537]: https://gitlab.freedesktop.org/drm/intel/issues/4537
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4936]: https://gitlab.freedesktop.org/drm/intel/issues/4936
[i915#5161]: https://gitlab.freedesktop.org/drm/intel/issues/5161
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5882]: https://gitlab.freedesktop.org/drm/intel/issues/5882
[i915#6032]: https://gitlab.freedesktop.org/drm/intel/issues/6032
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6121]: https://gitlab.freedesktop.org/drm/intel/issues/6121
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6755]: https://gitlab.freedesktop.org/drm/intel/issues/6755
[i915#6880]: https://gitlab.freedesktop.org/drm/intel/issues/6880
[i915#7016]: https://gitlab.freedesktop.org/drm/intel/issues/7016
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7173]: https://gitlab.freedesktop.org/drm/intel/issues/7173
[i915#7331]: https://gitlab.freedesktop.org/drm/intel/issues/7331
[i915#7392]: https://gitlab.freedesktop.org/drm/intel/issues/7392
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7921]: https://gitlab.freedesktop.org/drm/intel/issues/7921
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#8211]: https://gitlab.freedesktop.org/drm/intel/issues/8211
[i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
[i915#8234]: https://gitlab.freedesktop.org/drm/intel/issues/8234
[i915#8247]: https://gitlab.freedesktop.org/drm/intel/issues/8247
[i915#8399]: https://gitlab.freedesktop.org/drm/intel/issues/8399
[i915#8414]: https://gitlab.freedesktop.org/drm/intel/issues/8414
[i915#8502]: https://gitlab.freedesktop.org/drm/intel/issues/8502
[i915#8516]: https://gitlab.freedesktop.org/drm/intel/issues/8516
[i915#8555]: https://gitlab.freedesktop.org/drm/intel/issues/8555
[i915#8661]: https://gitlab.freedesktop.org/drm/intel/issues/8661
[i915#8682]: https://gitlab.freedesktop.org/drm/intel/issues/8682
[i915#8708]: https://gitlab.freedesktop.org/drm/intel/issues/8708
Build changes
-------------
* Linux: CI_DRM_13344 -> Patchwork_120167v1
CI-20190529: 20190529
CI_DRM_13344: 57e06a441fe3b4ea99a2611371044ced7f4f3487 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7369: 22009ac9c26ceec8450dd312f5c93fc01d986348 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_120167v1: 57e06a441fe3b4ea99a2611371044ced7f4f3487 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120167v1/index.html
[-- Attachment #2: Type: text/html, Size: 42507 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH 1/3] drm/i915/uncore: split unclaimed_reg_debug() to header and footer
2023-07-04 9:48 ` [Intel-gfx] [PATCH 1/3] drm/i915/uncore: split unclaimed_reg_debug() to header and footer Jani Nikula
@ 2023-07-06 10:50 ` Tvrtko Ursulin
0 siblings, 0 replies; 14+ messages in thread
From: Tvrtko Ursulin @ 2023-07-06 10:50 UTC (permalink / raw)
To: Jani Nikula, intel-gfx
On 04/07/2023 10:48, Jani Nikula wrote:
> Make it easier to have different logic for the two for follow-up.
>
> Cc: Lee Shawn C <shawn.c.lee@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/intel_uncore.c | 37 +++++++++++++++++------------
> 1 file changed, 22 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
> index 796ebfe6c550..a88aa342b623 100644
> --- a/drivers/gpu/drm/i915/intel_uncore.c
> +++ b/drivers/gpu/drm/i915/intel_uncore.c
> @@ -1926,10 +1926,8 @@ __unclaimed_previous_reg_debug(struct intel_uncore *uncore,
> }
>
> static inline void
> -unclaimed_reg_debug(struct intel_uncore *uncore,
> - const i915_reg_t reg,
> - const bool read,
> - const bool before)
> +unclaimed_reg_debug_header(struct intel_uncore *uncore,
> + const i915_reg_t reg, const bool read)
> {
> if (likely(!uncore->i915->params.mmio_debug) || !uncore->debug)
> return;
> @@ -1937,13 +1935,22 @@ unclaimed_reg_debug(struct intel_uncore *uncore,
> /* interrupts are disabled and re-enabled around uncore->lock usage */
> lockdep_assert_held(&uncore->lock);
>
> - if (before) {
> - spin_lock(&uncore->debug->lock);
> - __unclaimed_previous_reg_debug(uncore, reg, read);
> - } else {
> - __unclaimed_reg_debug(uncore, reg, read);
> - spin_unlock(&uncore->debug->lock);
> - }
> + spin_lock(&uncore->debug->lock);
> + __unclaimed_previous_reg_debug(uncore, reg, read);
> +}
> +
> +static inline void
> +unclaimed_reg_debug_footer(struct intel_uncore *uncore,
> + const i915_reg_t reg, const bool read)
> +{
> + if (likely(!uncore->i915->params.mmio_debug) || !uncore->debug)
> + return;
> +
> + /* interrupts are disabled and re-enabled around uncore->lock usage */
> + lockdep_assert_held(&uncore->lock);
> +
> + __unclaimed_reg_debug(uncore, reg, read);
> + spin_unlock(&uncore->debug->lock);
> }
>
> #define __vgpu_read(x) \
> @@ -2004,10 +2011,10 @@ __gen2_read(64)
> u##x val = 0; \
> assert_rpm_wakelock_held(uncore->rpm); \
> spin_lock_irqsave(&uncore->lock, irqflags); \
> - unclaimed_reg_debug(uncore, reg, true, true)
> + unclaimed_reg_debug_header(uncore, reg, true)
>
> #define GEN6_READ_FOOTER \
> - unclaimed_reg_debug(uncore, reg, true, false); \
> + unclaimed_reg_debug_footer(uncore, reg, true); \
> spin_unlock_irqrestore(&uncore->lock, irqflags); \
> trace_i915_reg_rw(false, reg, val, sizeof(val), trace); \
> return val
> @@ -2108,10 +2115,10 @@ __gen2_write(32)
> trace_i915_reg_rw(true, reg, val, sizeof(val), trace); \
> assert_rpm_wakelock_held(uncore->rpm); \
> spin_lock_irqsave(&uncore->lock, irqflags); \
> - unclaimed_reg_debug(uncore, reg, false, true)
> + unclaimed_reg_debug_header(uncore, reg, false)
>
> #define GEN6_WRITE_FOOTER \
> - unclaimed_reg_debug(uncore, reg, false, false); \
> + unclaimed_reg_debug_footer(uncore, reg, false); \
> spin_unlock_irqrestore(&uncore->lock, irqflags)
>
> #define __gen6_write(x) \
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH 2/3] drm/i915/uncore: fix race around i915->params.mmio_debug
2023-07-04 9:48 ` [Intel-gfx] [PATCH 2/3] drm/i915/uncore: fix race around i915->params.mmio_debug Jani Nikula
@ 2023-07-06 10:51 ` Tvrtko Ursulin
0 siblings, 0 replies; 14+ messages in thread
From: Tvrtko Ursulin @ 2023-07-06 10:51 UTC (permalink / raw)
To: Jani Nikula, intel-gfx
On 04/07/2023 10:48, Jani Nikula wrote:
> Only check the conditions for unclaimed reg debug once to avoid locking
> problems when i915->params.mmio_debug changes between header and footer.
>
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/8749
> Cc: Lee Shawn C <shawn.c.lee@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/intel_uncore.c | 21 ++++++++++++---------
> 1 file changed, 12 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
> index a88aa342b623..dfefad5a5fec 100644
> --- a/drivers/gpu/drm/i915/intel_uncore.c
> +++ b/drivers/gpu/drm/i915/intel_uncore.c
> @@ -1925,27 +1925,26 @@ __unclaimed_previous_reg_debug(struct intel_uncore *uncore,
> i915_mmio_reg_offset(reg));
> }
>
> -static inline void
> +static inline bool __must_check
> unclaimed_reg_debug_header(struct intel_uncore *uncore,
> const i915_reg_t reg, const bool read)
> {
> if (likely(!uncore->i915->params.mmio_debug) || !uncore->debug)
> - return;
> + return false;
>
> /* interrupts are disabled and re-enabled around uncore->lock usage */
> lockdep_assert_held(&uncore->lock);
>
> spin_lock(&uncore->debug->lock);
> __unclaimed_previous_reg_debug(uncore, reg, read);
> +
> + return true;
> }
>
> static inline void
> unclaimed_reg_debug_footer(struct intel_uncore *uncore,
> const i915_reg_t reg, const bool read)
> {
> - if (likely(!uncore->i915->params.mmio_debug) || !uncore->debug)
> - return;
> -
> /* interrupts are disabled and re-enabled around uncore->lock usage */
> lockdep_assert_held(&uncore->lock);
>
> @@ -2008,13 +2007,15 @@ __gen2_read(64)
> #define GEN6_READ_HEADER(x) \
> u32 offset = i915_mmio_reg_offset(reg); \
> unsigned long irqflags; \
> + bool unclaimed_reg_debug; \
> u##x val = 0; \
> assert_rpm_wakelock_held(uncore->rpm); \
> spin_lock_irqsave(&uncore->lock, irqflags); \
> - unclaimed_reg_debug_header(uncore, reg, true)
> + unclaimed_reg_debug = unclaimed_reg_debug_header(uncore, reg, true)
>
> #define GEN6_READ_FOOTER \
> - unclaimed_reg_debug_footer(uncore, reg, true); \
> + if (unclaimed_reg_debug) \
> + unclaimed_reg_debug_footer(uncore, reg, true); \
> spin_unlock_irqrestore(&uncore->lock, irqflags); \
> trace_i915_reg_rw(false, reg, val, sizeof(val), trace); \
> return val
> @@ -2112,13 +2113,15 @@ __gen2_write(32)
> #define GEN6_WRITE_HEADER \
> u32 offset = i915_mmio_reg_offset(reg); \
> unsigned long irqflags; \
> + bool unclaimed_reg_debug; \
> trace_i915_reg_rw(true, reg, val, sizeof(val), trace); \
> assert_rpm_wakelock_held(uncore->rpm); \
> spin_lock_irqsave(&uncore->lock, irqflags); \
> - unclaimed_reg_debug_header(uncore, reg, false)
> + unclaimed_reg_debug = unclaimed_reg_debug_header(uncore, reg, false)
>
> #define GEN6_WRITE_FOOTER \
> - unclaimed_reg_debug_footer(uncore, reg, false); \
> + if (unclaimed_reg_debug) \
> + unclaimed_reg_debug_footer(uncore, reg, false); \
> spin_unlock_irqrestore(&uncore->lock, irqflags)
>
> #define __gen6_write(x) \
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH 3/3] drm/i915/uncore: optimize CONFIG_DRM_I915_DEBUG_MMIO=n more
2023-07-04 9:48 ` [Intel-gfx] [PATCH 3/3] drm/i915/uncore: optimize CONFIG_DRM_I915_DEBUG_MMIO=n more Jani Nikula
@ 2023-07-06 10:56 ` Tvrtko Ursulin
2023-07-06 12:06 ` Jani Nikula
0 siblings, 1 reply; 14+ messages in thread
From: Tvrtko Ursulin @ 2023-07-06 10:56 UTC (permalink / raw)
To: Jani Nikula, intel-gfx
On 04/07/2023 10:48, Jani Nikula wrote:
> While the default for the mmio_debug parameter depends on
> CONFIG_DRM_I915_DEBUG_MMIO, we look it up and include all the code for
> unclaimed reg debugging even when CONFIG_DRM_I915_DEBUG_MMIO=n. Fix it.
>
> Cc: Lee Shawn C <shawn.c.lee@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/intel_uncore.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
> index dfefad5a5fec..da2edde4b6f6 100644
> --- a/drivers/gpu/drm/i915/intel_uncore.c
> +++ b/drivers/gpu/drm/i915/intel_uncore.c
> @@ -1929,7 +1929,8 @@ static inline bool __must_check
> unclaimed_reg_debug_header(struct intel_uncore *uncore,
> const i915_reg_t reg, const bool read)
> {
> - if (likely(!uncore->i915->params.mmio_debug) || !uncore->debug)
> + if (!IS_ENABLED(CONFIG_DRM_I915_DEBUG_MMIO) ||
> + likely(!uncore->i915->params.mmio_debug) || !uncore->debug)
> return false;
But now it would not be possible to enable mmio_debug, if Kconfig
_default_ is 'n'. What am I missing?
Regards,
Tvrtko
>
> /* interrupts are disabled and re-enabled around uncore->lock usage */
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH 3/3] drm/i915/uncore: optimize CONFIG_DRM_I915_DEBUG_MMIO=n more
2023-07-06 10:56 ` Tvrtko Ursulin
@ 2023-07-06 12:06 ` Jani Nikula
2023-07-06 13:48 ` Tvrtko Ursulin
0 siblings, 1 reply; 14+ messages in thread
From: Jani Nikula @ 2023-07-06 12:06 UTC (permalink / raw)
To: Tvrtko Ursulin, intel-gfx
On Thu, 06 Jul 2023, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote:
> On 04/07/2023 10:48, Jani Nikula wrote:
>> While the default for the mmio_debug parameter depends on
>> CONFIG_DRM_I915_DEBUG_MMIO, we look it up and include all the code for
>> unclaimed reg debugging even when CONFIG_DRM_I915_DEBUG_MMIO=n. Fix it.
>>
>> Cc: Lee Shawn C <shawn.c.lee@intel.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>> drivers/gpu/drm/i915/intel_uncore.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
>> index dfefad5a5fec..da2edde4b6f6 100644
>> --- a/drivers/gpu/drm/i915/intel_uncore.c
>> +++ b/drivers/gpu/drm/i915/intel_uncore.c
>> @@ -1929,7 +1929,8 @@ static inline bool __must_check
>> unclaimed_reg_debug_header(struct intel_uncore *uncore,
>> const i915_reg_t reg, const bool read)
>> {
>> - if (likely(!uncore->i915->params.mmio_debug) || !uncore->debug)
>> + if (!IS_ENABLED(CONFIG_DRM_I915_DEBUG_MMIO) ||
>> + likely(!uncore->i915->params.mmio_debug) || !uncore->debug)
>> return false;
>
> But now it would not be possible to enable mmio_debug, if Kconfig
> _default_ is 'n'. What am I missing?
You're not missing anything, I am. *facepalm*
The question is, are the first two acceptable without the third?
BR,
Jani.
>
> Regards,
>
> Tvrtko
>
>>
>> /* interrupts are disabled and re-enabled around uncore->lock usage */
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH 3/3] drm/i915/uncore: optimize CONFIG_DRM_I915_DEBUG_MMIO=n more
2023-07-06 12:06 ` Jani Nikula
@ 2023-07-06 13:48 ` Tvrtko Ursulin
2023-07-25 3:01 ` Lee, Shawn C
0 siblings, 1 reply; 14+ messages in thread
From: Tvrtko Ursulin @ 2023-07-06 13:48 UTC (permalink / raw)
To: Jani Nikula, intel-gfx
On 06/07/2023 13:06, Jani Nikula wrote:
> On Thu, 06 Jul 2023, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote:
>> On 04/07/2023 10:48, Jani Nikula wrote:
>>> While the default for the mmio_debug parameter depends on
>>> CONFIG_DRM_I915_DEBUG_MMIO, we look it up and include all the code for
>>> unclaimed reg debugging even when CONFIG_DRM_I915_DEBUG_MMIO=n. Fix it.
>>>
>>> Cc: Lee Shawn C <shawn.c.lee@intel.com>
>>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>>> ---
>>> drivers/gpu/drm/i915/intel_uncore.c | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
>>> index dfefad5a5fec..da2edde4b6f6 100644
>>> --- a/drivers/gpu/drm/i915/intel_uncore.c
>>> +++ b/drivers/gpu/drm/i915/intel_uncore.c
>>> @@ -1929,7 +1929,8 @@ static inline bool __must_check
>>> unclaimed_reg_debug_header(struct intel_uncore *uncore,
>>> const i915_reg_t reg, const bool read)
>>> {
>>> - if (likely(!uncore->i915->params.mmio_debug) || !uncore->debug)
>>> + if (!IS_ENABLED(CONFIG_DRM_I915_DEBUG_MMIO) ||
>>> + likely(!uncore->i915->params.mmio_debug) || !uncore->debug)
>>> return false;
>>
>> But now it would not be possible to enable mmio_debug, if Kconfig
>> _default_ is 'n'. What am I missing?
>
> You're not missing anything, I am. *facepalm*
>
> The question is, are the first two acceptable without the third?
What are 1st, 2nd and 3rd in your counting?
This area is confusing me a little bit.
If I look at unclaimed_reg_debug it appears unclaimed register debug
depends on mmio_debug.
But if I look at the message output by
intel_uncore_arm_unclaimed_mmio_detection it appears that on detecting
an unclaimed register we suggest to enable mmio_debug.
Isn't that a contradiction?
Regards,
Tvrtko
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH 3/3] drm/i915/uncore: optimize CONFIG_DRM_I915_DEBUG_MMIO=n more
2023-07-06 13:48 ` Tvrtko Ursulin
@ 2023-07-25 3:01 ` Lee, Shawn C
0 siblings, 0 replies; 14+ messages in thread
From: Lee, Shawn C @ 2023-07-25 3:01 UTC (permalink / raw)
To: Tvrtko Ursulin, Nikula, Jani, intel-gfx
>On 06/07/2023 13:06, Jani Nikula wrote:
>> On Thu, 06 Jul 2023, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote:
>>> On 04/07/2023 10:48, Jani Nikula wrote:
>>>> While the default for the mmio_debug parameter depends on
>>>> CONFIG_DRM_I915_DEBUG_MMIO, we look it up and include all the code
>>>> for unclaimed reg debugging even when CONFIG_DRM_I915_DEBUG_MMIO=n. Fix it.
>>>>
>>>> Cc: Lee Shawn C <shawn.c.lee@intel.com>
>>>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>>>> ---
>>>> drivers/gpu/drm/i915/intel_uncore.c | 3 ++-
>>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/gpu/drm/i915/intel_uncore.c
>>>> b/drivers/gpu/drm/i915/intel_uncore.c
>>>> index dfefad5a5fec..da2edde4b6f6 100644
>>>> --- a/drivers/gpu/drm/i915/intel_uncore.c
>>>> +++ b/drivers/gpu/drm/i915/intel_uncore.c
>>>> @@ -1929,7 +1929,8 @@ static inline bool __must_check
>>>> unclaimed_reg_debug_header(struct intel_uncore *uncore,
>>>> const i915_reg_t reg, const bool read)
>>>> {
>>>> - if (likely(!uncore->i915->params.mmio_debug) || !uncore->debug)
>>>> + if (!IS_ENABLED(CONFIG_DRM_I915_DEBUG_MMIO) ||
>>>> + likely(!uncore->i915->params.mmio_debug) || !uncore->debug)
>>>> return false;
>>>
>>> But now it would not be possible to enable mmio_debug, if Kconfig
>>> _default_ is 'n'. What am I missing?
>>
>> You're not missing anything, I am. *facepalm*
>>
>> The question is, are the first two acceptable without the third?
>
>What are 1st, 2nd and 3rd in your counting?
>
>This area is confusing me a little bit.
>
>If I look at unclaimed_reg_debug it appears unclaimed register debug depends on mmio_debug.
>
>But if I look at the message output by
>intel_uncore_arm_unclaimed_mmio_detection it appears that on detecting an unclaimed register we suggest to enable mmio_debug.
>
>Isn't that a contradiction?
>
>Regards,
>
>Tvrtko
Hi Jani, Tvrtko,
We are still waiting for these patches to fix issue. May I get your help to re-visit this series? Thanks!
Best regards,
Shawn
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2023-07-25 3:02 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-04 9:48 [Intel-gfx] [PATCH 0/3] drm/i915/uncore: unclaimed reg debug race fix and optimization Jani Nikula
2023-07-04 9:48 ` [Intel-gfx] [PATCH 1/3] drm/i915/uncore: split unclaimed_reg_debug() to header and footer Jani Nikula
2023-07-06 10:50 ` Tvrtko Ursulin
2023-07-04 9:48 ` [Intel-gfx] [PATCH 2/3] drm/i915/uncore: fix race around i915->params.mmio_debug Jani Nikula
2023-07-06 10:51 ` Tvrtko Ursulin
2023-07-04 9:48 ` [Intel-gfx] [PATCH 3/3] drm/i915/uncore: optimize CONFIG_DRM_I915_DEBUG_MMIO=n more Jani Nikula
2023-07-06 10:56 ` Tvrtko Ursulin
2023-07-06 12:06 ` Jani Nikula
2023-07-06 13:48 ` Tvrtko Ursulin
2023-07-25 3:01 ` Lee, Shawn C
2023-07-04 10:02 ` [Intel-gfx] [PATCH 0/3] drm/i915/uncore: unclaimed reg debug race fix and optimization Jani Nikula
2023-07-04 11:26 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork
2023-07-04 11:36 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-07-04 15:23 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.