* [PATCH v2 0/3] staging: vt6655: Fix coding style issues
@ 2018-10-06 11:24 Mamta Shukla
2018-10-06 11:26 ` [PATCH v2 1/3] staging: vt6655: Add blank line after function/struct/union/enum declarations Mamta Shukla
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Mamta Shukla @ 2018-10-06 11:24 UTC (permalink / raw)
To: outreachy-kernel; +Cc: forest, gregkh
This patch series fixes checkpatch issues such as:
-Add blank line after function/struct/union/enum declarations
-Add spaces around '*','-'
-Remove unnecessary space after cast to conform kernel coding style.
change in v2:
-Merge patch 2 and patch 3 as it solves same coding issue.
Mamta Shukla (3):
staging: vt6655: Add blank line after function/struct/union/enum declarations
staging: vt6655: Add spaces around operators
staging: vt6655: Remove space after cast
drivers/staging/vt6655/rxtx.c | 29 +++++++++++++++--------------
1 file changed, 15 insertions(+), 14 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH v2 1/3] staging: vt6655: Add blank line after function/struct/union/enum declarations 2018-10-06 11:24 [PATCH v2 0/3] staging: vt6655: Fix coding style issues Mamta Shukla @ 2018-10-06 11:26 ` Mamta Shukla 2018-10-06 17:50 ` [Outreachy kernel] " Himanshu Jha 2018-10-06 11:30 ` [PATCH v2 2/3] staging: vt6655: Add spaces around operators Mamta Shukla 2018-10-06 11:31 ` [PATCH v2 3/3] staging: vt6655: Remove space after cast Mamta Shukla 2 siblings, 1 reply; 7+ messages in thread From: Mamta Shukla @ 2018-10-06 11:26 UTC (permalink / raw) To: outreachy-kernel; +Cc: forest, gregkh Add blank line after function/struct/union/enum declarations to fix checkpatch issue. CHECK: Please use a blank line after function/struct/union/enum declarations Signed-off-by: Mamta Shukla <mamtashukla555@gmail.com> --- No change in v2. drivers/staging/vt6655/rxtx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index 9c4a532..8ae9c68 100644 --- a/drivers/staging/vt6655/rxtx.c +++ b/drivers/staging/vt6655/rxtx.c @@ -65,6 +65,7 @@ {RATE_12M, RATE_18M, RATE_24M, RATE_36M, RATE_48M}, /* fallback_rate0 */ {RATE_12M, RATE_12M, RATE_18M, RATE_24M, RATE_36M}, /* fallback_rate1 */ }; + static const unsigned short wFB_Opt1[2][5] = { {RATE_12M, RATE_18M, RATE_24M, RATE_24M, RATE_36M}, /* fallback_rate0 */ {RATE_6M, RATE_6M, RATE_12M, RATE_12M, RATE_18M}, /* fallback_rate1 */ -- 1.9.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Outreachy kernel] [PATCH v2 1/3] staging: vt6655: Add blank line after function/struct/union/enum declarations 2018-10-06 11:26 ` [PATCH v2 1/3] staging: vt6655: Add blank line after function/struct/union/enum declarations Mamta Shukla @ 2018-10-06 17:50 ` Himanshu Jha 0 siblings, 0 replies; 7+ messages in thread From: Himanshu Jha @ 2018-10-06 17:50 UTC (permalink / raw) To: Mamta Shukla; +Cc: outreachy-kernel, forest, gregkh On Sat, Oct 06, 2018 at 04:56:36PM +0530, Mamta Shukla wrote: > Add blank line after function/struct/union/enum declarations to fix > checkpatch issue. > CHECK: Please use a blank line after function/struct/union/enum > declarations > > Signed-off-by: Mamta Shukla <mamtashukla555@gmail.com> Reviewed-by: Himanshu Jha <himanshujha199640@gmail.com> > --- > > No change in v2. > > drivers/staging/vt6655/rxtx.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c > index 9c4a532..8ae9c68 100644 > --- a/drivers/staging/vt6655/rxtx.c > +++ b/drivers/staging/vt6655/rxtx.c > @@ -65,6 +65,7 @@ > {RATE_12M, RATE_18M, RATE_24M, RATE_36M, RATE_48M}, /* fallback_rate0 */ > {RATE_12M, RATE_12M, RATE_18M, RATE_24M, RATE_36M}, /* fallback_rate1 */ > }; > + > static const unsigned short wFB_Opt1[2][5] = { > {RATE_12M, RATE_18M, RATE_24M, RATE_24M, RATE_36M}, /* fallback_rate0 */ > {RATE_6M, RATE_6M, RATE_12M, RATE_12M, RATE_18M}, /* fallback_rate1 */ > -- > 1.9.1 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/ff2e07eedb4220c53ff681ec6fefb5aa637ae9cb.1538823377.git.mamtashukla555%40gmail.com. > For more options, visit https://groups.google.com/d/optout. -- Himanshu Jha Undergraduate Student Department of Electronics & Communication Guru Tegh Bahadur Institute of Technology ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 2/3] staging: vt6655: Add spaces around operators 2018-10-06 11:24 [PATCH v2 0/3] staging: vt6655: Fix coding style issues Mamta Shukla 2018-10-06 11:26 ` [PATCH v2 1/3] staging: vt6655: Add blank line after function/struct/union/enum declarations Mamta Shukla @ 2018-10-06 11:30 ` Mamta Shukla 2018-10-06 17:50 ` [Outreachy kernel] " Himanshu Jha 2018-10-06 11:31 ` [PATCH v2 3/3] staging: vt6655: Remove space after cast Mamta Shukla 2 siblings, 1 reply; 7+ messages in thread From: Mamta Shukla @ 2018-10-06 11:30 UTC (permalink / raw) To: outreachy-kernel; +Cc: forest, gregkh Add spaces around '*' and '-' to fix checkpatch issue. Signed-off-by: Mamta Shukla <mamtashukla555@gmail.com> --- change in v2: -Merge patch 2 and patch 3 and submit this as a new patch in this patch series. drivers/staging/vt6655/rxtx.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index 8ae9c68..1eb8cea 100644 --- a/drivers/staging/vt6655/rxtx.c +++ b/drivers/staging/vt6655/rxtx.c @@ -213,12 +213,12 @@ static __le16 vnt_rxtx_rsvtime_le16(struct vnt_private *priv, u8 pkt_type, } else if (byRTSRsvType == 3) { /* CTSTxRrvTime_ba, only in 2.4GHZ */ uCTSTime = BBuGetFrameTime(pDevice->byPreambleType, byPktType, 14, pDevice->byTopCCKBasicRate); uAckTime = BBuGetFrameTime(pDevice->byPreambleType, byPktType, 14, pDevice->byTopOFDMBasicRate); - uRrvTime = uCTSTime + uAckTime + uDataTime + 2*pDevice->uSIFS; + uRrvTime = uCTSTime + uAckTime + uDataTime + 2 * pDevice->uSIFS; return cpu_to_le16((u16)uRrvTime); } /* RTSRrvTime */ - uRrvTime = uRTSTime + uCTSTime + uAckTime + uDataTime + 3*pDevice->uSIFS; + uRrvTime = uRTSTime + uCTSTime + uAckTime + uDataTime + 3 * pDevice->uSIFS; return cpu_to_le16((u16)uRrvTime); } @@ -241,7 +241,7 @@ static __le16 vnt_rxtx_rsvtime_le16(struct vnt_private *priv, u8 pkt_type, bool bLastFrag = false; unsigned int uAckTime = 0, uNextPktTime = 0; - if (uFragIdx == (uMACfragNum-1)) + if (uFragIdx == (uMACfragNum - 1)) bLastFrag = true; switch (byDurType) { @@ -254,7 +254,7 @@ static __le16 vnt_rxtx_rsvtime_le16(struct vnt_private *priv, u8 pkt_type, return 0; } } else {/* First Frag or Mid Frag */ - if (uFragIdx == (uMACfragNum-2)) + if (uFragIdx == (uMACfragNum - 2)) uNextPktTime = s_uGetTxRsvTime(pDevice, byPktType, cbLastFragmentSize, wRate, bNeedAck); else uNextPktTime = s_uGetTxRsvTime(pDevice, byPktType, cbFrameLength, wRate, bNeedAck); @@ -277,7 +277,7 @@ static __le16 vnt_rxtx_rsvtime_le16(struct vnt_private *priv, u8 pkt_type, return 0; } } else {/* First Frag or Mid Frag */ - if (uFragIdx == (uMACfragNum-2)) + if (uFragIdx == (uMACfragNum - 2)) uNextPktTime = s_uGetTxRsvTime(pDevice, byPktType, cbLastFragmentSize, wRate, bNeedAck); else uNextPktTime = s_uGetTxRsvTime(pDevice, byPktType, cbFrameLength, wRate, bNeedAck); @@ -306,7 +306,7 @@ static __le16 vnt_rxtx_rsvtime_le16(struct vnt_private *priv, u8 pkt_type, else if (wRate > RATE_54M) wRate = RATE_54M; - if (uFragIdx == (uMACfragNum-2)) + if (uFragIdx == (uMACfragNum - 2)) uNextPktTime = s_uGetTxRsvTime(pDevice, byPktType, cbLastFragmentSize, wFB_Opt0[FB_RATE0][wRate-RATE_18M], bNeedAck); else uNextPktTime = s_uGetTxRsvTime(pDevice, byPktType, cbFrameLength, wFB_Opt0[FB_RATE0][wRate-RATE_18M], bNeedAck); @@ -317,7 +317,7 @@ static __le16 vnt_rxtx_rsvtime_le16(struct vnt_private *priv, u8 pkt_type, else if (wRate > RATE_54M) wRate = RATE_54M; - if (uFragIdx == (uMACfragNum-2)) + if (uFragIdx == (uMACfragNum - 2)) uNextPktTime = s_uGetTxRsvTime(pDevice, byPktType, cbLastFragmentSize, wFB_Opt1[FB_RATE0][wRate-RATE_18M], bNeedAck); else uNextPktTime = s_uGetTxRsvTime(pDevice, byPktType, cbFrameLength, wFB_Opt1[FB_RATE0][wRate-RATE_18M], bNeedAck); @@ -347,7 +347,7 @@ static __le16 vnt_rxtx_rsvtime_le16(struct vnt_private *priv, u8 pkt_type, else if (wRate > RATE_54M) wRate = RATE_54M; - if (uFragIdx == (uMACfragNum-2)) + if (uFragIdx == (uMACfragNum - 2)) uNextPktTime = s_uGetTxRsvTime(pDevice, byPktType, cbLastFragmentSize, wFB_Opt0[FB_RATE1][wRate-RATE_18M], bNeedAck); else uNextPktTime = s_uGetTxRsvTime(pDevice, byPktType, cbFrameLength, wFB_Opt0[FB_RATE1][wRate-RATE_18M], bNeedAck); @@ -358,7 +358,7 @@ static __le16 vnt_rxtx_rsvtime_le16(struct vnt_private *priv, u8 pkt_type, else if (wRate > RATE_54M) wRate = RATE_54M; - if (uFragIdx == (uMACfragNum-2)) + if (uFragIdx == (uMACfragNum - 2)) uNextPktTime = s_uGetTxRsvTime(pDevice, byPktType, cbLastFragmentSize, wFB_Opt1[FB_RATE1][wRate-RATE_18M], bNeedAck); else uNextPktTime = s_uGetTxRsvTime(pDevice, byPktType, cbFrameLength, wFB_Opt1[FB_RATE1][wRate-RATE_18M], bNeedAck); -- 1.9.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Outreachy kernel] [PATCH v2 2/3] staging: vt6655: Add spaces around operators 2018-10-06 11:30 ` [PATCH v2 2/3] staging: vt6655: Add spaces around operators Mamta Shukla @ 2018-10-06 17:50 ` Himanshu Jha 0 siblings, 0 replies; 7+ messages in thread From: Himanshu Jha @ 2018-10-06 17:50 UTC (permalink / raw) To: Mamta Shukla; +Cc: outreachy-kernel, forest, gregkh On Sat, Oct 06, 2018 at 05:00:00PM +0530, Mamta Shukla wrote: > Add spaces around '*' and '-' to fix checkpatch issue. > > Signed-off-by: Mamta Shukla <mamtashukla555@gmail.com> Reviewed-by: Himanshu Jha <himanshujha199640@gmail.com> > --- > > change in v2: > -Merge patch 2 and patch 3 and submit this as > a new patch in this patch series. > > drivers/staging/vt6655/rxtx.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c > index 8ae9c68..1eb8cea 100644 > --- a/drivers/staging/vt6655/rxtx.c > +++ b/drivers/staging/vt6655/rxtx.c > @@ -213,12 +213,12 @@ static __le16 vnt_rxtx_rsvtime_le16(struct vnt_private *priv, u8 pkt_type, > } else if (byRTSRsvType == 3) { /* CTSTxRrvTime_ba, only in 2.4GHZ */ > uCTSTime = BBuGetFrameTime(pDevice->byPreambleType, byPktType, 14, pDevice->byTopCCKBasicRate); > uAckTime = BBuGetFrameTime(pDevice->byPreambleType, byPktType, 14, pDevice->byTopOFDMBasicRate); > - uRrvTime = uCTSTime + uAckTime + uDataTime + 2*pDevice->uSIFS; > + uRrvTime = uCTSTime + uAckTime + uDataTime + 2 * pDevice->uSIFS; > return cpu_to_le16((u16)uRrvTime); > } > > /* RTSRrvTime */ > - uRrvTime = uRTSTime + uCTSTime + uAckTime + uDataTime + 3*pDevice->uSIFS; > + uRrvTime = uRTSTime + uCTSTime + uAckTime + uDataTime + 3 * pDevice->uSIFS; > return cpu_to_le16((u16)uRrvTime); > } > > @@ -241,7 +241,7 @@ static __le16 vnt_rxtx_rsvtime_le16(struct vnt_private *priv, u8 pkt_type, > bool bLastFrag = false; > unsigned int uAckTime = 0, uNextPktTime = 0; > > - if (uFragIdx == (uMACfragNum-1)) > + if (uFragIdx == (uMACfragNum - 1)) > bLastFrag = true; > > switch (byDurType) { > @@ -254,7 +254,7 @@ static __le16 vnt_rxtx_rsvtime_le16(struct vnt_private *priv, u8 pkt_type, > return 0; > } > } else {/* First Frag or Mid Frag */ > - if (uFragIdx == (uMACfragNum-2)) > + if (uFragIdx == (uMACfragNum - 2)) > uNextPktTime = s_uGetTxRsvTime(pDevice, byPktType, cbLastFragmentSize, wRate, bNeedAck); > else > uNextPktTime = s_uGetTxRsvTime(pDevice, byPktType, cbFrameLength, wRate, bNeedAck); > @@ -277,7 +277,7 @@ static __le16 vnt_rxtx_rsvtime_le16(struct vnt_private *priv, u8 pkt_type, > return 0; > } > } else {/* First Frag or Mid Frag */ > - if (uFragIdx == (uMACfragNum-2)) > + if (uFragIdx == (uMACfragNum - 2)) > uNextPktTime = s_uGetTxRsvTime(pDevice, byPktType, cbLastFragmentSize, wRate, bNeedAck); > else > uNextPktTime = s_uGetTxRsvTime(pDevice, byPktType, cbFrameLength, wRate, bNeedAck); > @@ -306,7 +306,7 @@ static __le16 vnt_rxtx_rsvtime_le16(struct vnt_private *priv, u8 pkt_type, > else if (wRate > RATE_54M) > wRate = RATE_54M; > > - if (uFragIdx == (uMACfragNum-2)) > + if (uFragIdx == (uMACfragNum - 2)) > uNextPktTime = s_uGetTxRsvTime(pDevice, byPktType, cbLastFragmentSize, wFB_Opt0[FB_RATE0][wRate-RATE_18M], bNeedAck); > else > uNextPktTime = s_uGetTxRsvTime(pDevice, byPktType, cbFrameLength, wFB_Opt0[FB_RATE0][wRate-RATE_18M], bNeedAck); > @@ -317,7 +317,7 @@ static __le16 vnt_rxtx_rsvtime_le16(struct vnt_private *priv, u8 pkt_type, > else if (wRate > RATE_54M) > wRate = RATE_54M; > > - if (uFragIdx == (uMACfragNum-2)) > + if (uFragIdx == (uMACfragNum - 2)) > uNextPktTime = s_uGetTxRsvTime(pDevice, byPktType, cbLastFragmentSize, wFB_Opt1[FB_RATE0][wRate-RATE_18M], bNeedAck); > else > uNextPktTime = s_uGetTxRsvTime(pDevice, byPktType, cbFrameLength, wFB_Opt1[FB_RATE0][wRate-RATE_18M], bNeedAck); > @@ -347,7 +347,7 @@ static __le16 vnt_rxtx_rsvtime_le16(struct vnt_private *priv, u8 pkt_type, > else if (wRate > RATE_54M) > wRate = RATE_54M; > > - if (uFragIdx == (uMACfragNum-2)) > + if (uFragIdx == (uMACfragNum - 2)) > uNextPktTime = s_uGetTxRsvTime(pDevice, byPktType, cbLastFragmentSize, wFB_Opt0[FB_RATE1][wRate-RATE_18M], bNeedAck); > else > uNextPktTime = s_uGetTxRsvTime(pDevice, byPktType, cbFrameLength, wFB_Opt0[FB_RATE1][wRate-RATE_18M], bNeedAck); > @@ -358,7 +358,7 @@ static __le16 vnt_rxtx_rsvtime_le16(struct vnt_private *priv, u8 pkt_type, > else if (wRate > RATE_54M) > wRate = RATE_54M; > > - if (uFragIdx == (uMACfragNum-2)) > + if (uFragIdx == (uMACfragNum - 2)) > uNextPktTime = s_uGetTxRsvTime(pDevice, byPktType, cbLastFragmentSize, wFB_Opt1[FB_RATE1][wRate-RATE_18M], bNeedAck); > else > uNextPktTime = s_uGetTxRsvTime(pDevice, byPktType, cbFrameLength, wFB_Opt1[FB_RATE1][wRate-RATE_18M], bNeedAck); > -- > 1.9.1 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/eb334e41286c10e2350603e2de51da22255aade6.1538823377.git.mamtashukla555%40gmail.com. > For more options, visit https://groups.google.com/d/optout. -- Himanshu Jha Undergraduate Student Department of Electronics & Communication Guru Tegh Bahadur Institute of Technology ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 3/3] staging: vt6655: Remove space after cast 2018-10-06 11:24 [PATCH v2 0/3] staging: vt6655: Fix coding style issues Mamta Shukla 2018-10-06 11:26 ` [PATCH v2 1/3] staging: vt6655: Add blank line after function/struct/union/enum declarations Mamta Shukla 2018-10-06 11:30 ` [PATCH v2 2/3] staging: vt6655: Add spaces around operators Mamta Shukla @ 2018-10-06 11:31 ` Mamta Shukla 2018-10-06 17:50 ` [Outreachy kernel] " Himanshu Jha 2 siblings, 1 reply; 7+ messages in thread From: Mamta Shukla @ 2018-10-06 11:31 UTC (permalink / raw) To: outreachy-kernel; +Cc: forest, gregkh Remove space after cast to fix checkpatch issue. CHECK: No space is necessary after a cast Signed-off-by: Mamta Shukla <mamtashukla555@gmail.com> --- No change in v2. drivers/staging/vt6655/rxtx.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index 1eb8cea..a7c1e46 100644 --- a/drivers/staging/vt6655/rxtx.c +++ b/drivers/staging/vt6655/rxtx.c @@ -1094,7 +1094,7 @@ static __le16 vnt_rxtx_rsvtime_le16(struct vnt_private *priv, u8 pkt_type, sizeof(struct vnt_tx_datahead_g); } else { /* RTS_needless */ pvRrvTime = (void *)(pbyTxBufferAddr + wTxBufSize); - pMICHDR = (struct vnt_mic_hdr *) (pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_cts)); + pMICHDR = (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_cts)); pvRTS = NULL; pvCTS = (void *) (pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_cts) + cbMICHDR); pvTxDataHd = (void *)(pbyTxBufferAddr + wTxBufSize + @@ -1106,7 +1106,7 @@ static __le16 vnt_rxtx_rsvtime_le16(struct vnt_private *priv, u8 pkt_type, /* Auto Fall Back */ if (bRTS) {/* RTS_need */ pvRrvTime = (void *)(pbyTxBufferAddr + wTxBufSize); - pMICHDR = (struct vnt_mic_hdr *) (pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts)); + pMICHDR = (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts)); pvRTS = (void *) (pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts) + cbMICHDR); pvCTS = NULL; pvTxDataHd = (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts) + @@ -1115,7 +1115,7 @@ static __le16 vnt_rxtx_rsvtime_le16(struct vnt_private *priv, u8 pkt_type, cbMICHDR + sizeof(struct vnt_rts_g_fb) + sizeof(struct vnt_tx_datahead_g_fb); } else { /* RTS_needless */ pvRrvTime = (void *)(pbyTxBufferAddr + wTxBufSize); - pMICHDR = (struct vnt_mic_hdr *) (pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_cts)); + pMICHDR = (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_cts)); pvRTS = NULL; pvCTS = (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_cts) + cbMICHDR); pvTxDataHd = (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_cts) + @@ -1129,7 +1129,7 @@ static __le16 vnt_rxtx_rsvtime_le16(struct vnt_private *priv, u8 pkt_type, if (byFBOption == AUTO_FB_NONE) { if (bRTS) { pvRrvTime = (void *)(pbyTxBufferAddr + wTxBufSize); - pMICHDR = (struct vnt_mic_hdr *) (pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab)); + pMICHDR = (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab)); pvRTS = (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab) + cbMICHDR); pvCTS = NULL; pvTxDataHd = (void *)(pbyTxBufferAddr + wTxBufSize + @@ -1138,7 +1138,7 @@ static __le16 vnt_rxtx_rsvtime_le16(struct vnt_private *priv, u8 pkt_type, cbMICHDR + sizeof(struct vnt_rts_ab) + sizeof(struct vnt_tx_datahead_ab); } else { /* RTS_needless, need MICHDR */ pvRrvTime = (void *)(pbyTxBufferAddr + wTxBufSize); - pMICHDR = (struct vnt_mic_hdr *) (pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab)); + pMICHDR = (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab)); pvRTS = NULL; pvCTS = NULL; pvTxDataHd = (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab) + cbMICHDR); -- 1.9.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Outreachy kernel] [PATCH v2 3/3] staging: vt6655: Remove space after cast 2018-10-06 11:31 ` [PATCH v2 3/3] staging: vt6655: Remove space after cast Mamta Shukla @ 2018-10-06 17:50 ` Himanshu Jha 0 siblings, 0 replies; 7+ messages in thread From: Himanshu Jha @ 2018-10-06 17:50 UTC (permalink / raw) To: Mamta Shukla; +Cc: outreachy-kernel, forest, gregkh On Sat, Oct 06, 2018 at 05:01:35PM +0530, Mamta Shukla wrote: > Remove space after cast to fix checkpatch issue. > CHECK: No space is necessary after a cast > > Signed-off-by: Mamta Shukla <mamtashukla555@gmail.com> Reviewed-by: Himanshu Jha <himanshujha199640@gmail.com> > --- > No change in v2. > > drivers/staging/vt6655/rxtx.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c > index 1eb8cea..a7c1e46 100644 > --- a/drivers/staging/vt6655/rxtx.c > +++ b/drivers/staging/vt6655/rxtx.c > @@ -1094,7 +1094,7 @@ static __le16 vnt_rxtx_rsvtime_le16(struct vnt_private *priv, u8 pkt_type, > sizeof(struct vnt_tx_datahead_g); > } else { /* RTS_needless */ > pvRrvTime = (void *)(pbyTxBufferAddr + wTxBufSize); > - pMICHDR = (struct vnt_mic_hdr *) (pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_cts)); > + pMICHDR = (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_cts)); > pvRTS = NULL; > pvCTS = (void *) (pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_cts) + cbMICHDR); > pvTxDataHd = (void *)(pbyTxBufferAddr + wTxBufSize + > @@ -1106,7 +1106,7 @@ static __le16 vnt_rxtx_rsvtime_le16(struct vnt_private *priv, u8 pkt_type, > /* Auto Fall Back */ > if (bRTS) {/* RTS_need */ > pvRrvTime = (void *)(pbyTxBufferAddr + wTxBufSize); > - pMICHDR = (struct vnt_mic_hdr *) (pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts)); > + pMICHDR = (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts)); > pvRTS = (void *) (pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts) + cbMICHDR); > pvCTS = NULL; > pvTxDataHd = (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts) + > @@ -1115,7 +1115,7 @@ static __le16 vnt_rxtx_rsvtime_le16(struct vnt_private *priv, u8 pkt_type, > cbMICHDR + sizeof(struct vnt_rts_g_fb) + sizeof(struct vnt_tx_datahead_g_fb); > } else { /* RTS_needless */ > pvRrvTime = (void *)(pbyTxBufferAddr + wTxBufSize); > - pMICHDR = (struct vnt_mic_hdr *) (pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_cts)); > + pMICHDR = (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_cts)); > pvRTS = NULL; > pvCTS = (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_cts) + cbMICHDR); > pvTxDataHd = (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_cts) + > @@ -1129,7 +1129,7 @@ static __le16 vnt_rxtx_rsvtime_le16(struct vnt_private *priv, u8 pkt_type, > if (byFBOption == AUTO_FB_NONE) { > if (bRTS) { > pvRrvTime = (void *)(pbyTxBufferAddr + wTxBufSize); > - pMICHDR = (struct vnt_mic_hdr *) (pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab)); > + pMICHDR = (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab)); > pvRTS = (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab) + cbMICHDR); > pvCTS = NULL; > pvTxDataHd = (void *)(pbyTxBufferAddr + wTxBufSize + > @@ -1138,7 +1138,7 @@ static __le16 vnt_rxtx_rsvtime_le16(struct vnt_private *priv, u8 pkt_type, > cbMICHDR + sizeof(struct vnt_rts_ab) + sizeof(struct vnt_tx_datahead_ab); > } else { /* RTS_needless, need MICHDR */ > pvRrvTime = (void *)(pbyTxBufferAddr + wTxBufSize); > - pMICHDR = (struct vnt_mic_hdr *) (pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab)); > + pMICHDR = (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab)); > pvRTS = NULL; > pvCTS = NULL; > pvTxDataHd = (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab) + cbMICHDR); > -- > 1.9.1 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/dbcd26b975bccc860d61ee4dfdf0cf58f3c77929.1538823377.git.mamtashukla555%40gmail.com. > For more options, visit https://groups.google.com/d/optout. -- Himanshu Jha Undergraduate Student Department of Electronics & Communication Guru Tegh Bahadur Institute of Technology ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-10-06 17:50 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-10-06 11:24 [PATCH v2 0/3] staging: vt6655: Fix coding style issues Mamta Shukla 2018-10-06 11:26 ` [PATCH v2 1/3] staging: vt6655: Add blank line after function/struct/union/enum declarations Mamta Shukla 2018-10-06 17:50 ` [Outreachy kernel] " Himanshu Jha 2018-10-06 11:30 ` [PATCH v2 2/3] staging: vt6655: Add spaces around operators Mamta Shukla 2018-10-06 17:50 ` [Outreachy kernel] " Himanshu Jha 2018-10-06 11:31 ` [PATCH v2 3/3] staging: vt6655: Remove space after cast Mamta Shukla 2018-10-06 17:50 ` [Outreachy kernel] " Himanshu Jha
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.