Re: [PATCH 02/18] x86/apic.c: use plain bool

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 30/06/17 18:01, Wei Liu wrote:
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
>  xen/arch/x86/apic.c        | 30 +++++++++++++++---------------
>  xen/include/asm-x86/apic.h |  4 ++--
>  2 files changed, 17 insertions(+), 17 deletions(-)
>
> diff --git a/xen/arch/x86/apic.c b/xen/arch/x86/apic.c
> index 8c6c2f5819..28a1ef8a58 100644
> --- a/xen/arch/x86/apic.c
> +++ b/xen/arch/x86/apic.c
> @@ -37,8 +37,8 @@
>  #include <io_ports.h>
>  #include <xen/kexec.h>
>  
> -static bool_t tdt_enabled __read_mostly;
> -static bool_t tdt_enable __initdata = 1;
> +static bool tdt_enabled __read_mostly;
> +static bool tdt_enable __initdata = true;

As we are cleaning things up,

static bool __read_mostly tdt_enabled;
static bool __initdata tdt_enable = true;

>  boolean_param("tdt", tdt_enable);
>  
>  static struct {
> @@ -70,7 +70,7 @@ static s8 __initdata enable_local_apic; /* -1=force-disable, +1=force-enable */
>   */
>  u8 __read_mostly apic_verbosity;
>  
> -static bool_t __initdata opt_x2apic = 1;
> +static bool __initdata opt_x2apic = true;
>  boolean_param("x2apic", opt_x2apic);
>  
>  /*
> @@ -79,8 +79,8 @@ boolean_param("x2apic", opt_x2apic);
>   */
>  static enum apic_mode apic_boot_mode = APIC_MODE_INVALID;
>  
> -bool_t __read_mostly x2apic_enabled = 0;
> -bool_t __read_mostly directed_eoi_enabled = 0;
> +bool __read_mostly x2apic_enabled = false;
> +bool __read_mostly directed_eoi_enabled = false;

I believe the "= false" are redundant here.

Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel