All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vlastimil Babka <vbabka@suse.cz>
To: Yisheng Xie <xieyisheng1@huawei.com>,
	akpm@linux-foundation.org, mhocko@suse.com,
	mgorman@techsingularity.net, iamjoonsoo.kim@lge.com,
	rientjes@google.com, minchan@kernel.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	guohanjun@huawei.com, qiuxishi@huawei.com, liubo95@huawei.com
Subject: Re: [RFC] mm/compaction: ignore block suitable after check large free page
Date: Fri, 10 Mar 2017 08:30:00 +0100	[thread overview]
Message-ID: <eb3bbece-77ea-b88f-d4bf-dbf9bdf7f413@suse.cz> (raw)
In-Reply-To: <1489119648-59583-1-git-send-email-xieyisheng1@huawei.com>

On 03/10/2017 05:20 AM, Yisheng Xie wrote:
> If the migrate target is a large free page and we ignore suitable,
> it may not good for defrag. So move the ignore block suitable after
> check large free page.

Right. But in practice I expect close to no impact, because direct
compaction shouldn't have to be called if there's a >=pageblock_order
page already available.

> Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
> ---
>  mm/compaction.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/mm/compaction.c b/mm/compaction.c
> index 0fdfde0..4bf2a5d 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -991,9 +991,6 @@ static bool too_many_isolated(struct zone *zone)
>  static bool suitable_migration_target(struct compact_control *cc,
>  							struct page *page)
>  {
> -	if (cc->ignore_block_suitable)
> -		return true;
> -
>  	/* If the page is a large free page, then disallow migration */
>  	if (PageBuddy(page)) {
>  		/*
> @@ -1005,6 +1002,9 @@ static bool suitable_migration_target(struct compact_control *cc,
>  			return false;
>  	}
>  
> +	if (cc->ignore_block_suitable)
> +		return true;
> +
>  	/* If the block is MIGRATE_MOVABLE or MIGRATE_CMA, allow migration */
>  	if (migrate_async_suitable(get_pageblock_migratetype(page)))
>  		return true;
> 

WARNING: multiple messages have this Message-ID (diff)
From: Vlastimil Babka <vbabka@suse.cz>
To: Yisheng Xie <xieyisheng1@huawei.com>,
	akpm@linux-foundation.org, mhocko@suse.com,
	mgorman@techsingularity.net, iamjoonsoo.kim@lge.com,
	rientjes@google.com, minchan@kernel.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	guohanjun@huawei.com, qiuxishi@huawei.com, liubo95@huawei.com
Subject: Re: [RFC] mm/compaction: ignore block suitable after check large free page
Date: Fri, 10 Mar 2017 08:30:00 +0100	[thread overview]
Message-ID: <eb3bbece-77ea-b88f-d4bf-dbf9bdf7f413@suse.cz> (raw)
In-Reply-To: <1489119648-59583-1-git-send-email-xieyisheng1@huawei.com>

On 03/10/2017 05:20 AM, Yisheng Xie wrote:
> If the migrate target is a large free page and we ignore suitable,
> it may not good for defrag. So move the ignore block suitable after
> check large free page.

Right. But in practice I expect close to no impact, because direct
compaction shouldn't have to be called if there's a >=pageblock_order
page already available.

> Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
> ---
>  mm/compaction.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/mm/compaction.c b/mm/compaction.c
> index 0fdfde0..4bf2a5d 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -991,9 +991,6 @@ static bool too_many_isolated(struct zone *zone)
>  static bool suitable_migration_target(struct compact_control *cc,
>  							struct page *page)
>  {
> -	if (cc->ignore_block_suitable)
> -		return true;
> -
>  	/* If the page is a large free page, then disallow migration */
>  	if (PageBuddy(page)) {
>  		/*
> @@ -1005,6 +1002,9 @@ static bool suitable_migration_target(struct compact_control *cc,
>  			return false;
>  	}
>  
> +	if (cc->ignore_block_suitable)
> +		return true;
> +
>  	/* If the block is MIGRATE_MOVABLE or MIGRATE_CMA, allow migration */
>  	if (migrate_async_suitable(get_pageblock_migratetype(page)))
>  		return true;
> 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2017-03-10  7:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-10  4:20 [RFC] mm/compaction: ignore block suitable after check large free page Yisheng Xie
2017-03-10  4:20 ` Yisheng Xie
2017-03-10  7:30 ` Vlastimil Babka [this message]
2017-03-10  7:30   ` Vlastimil Babka
2017-03-10  9:53   ` Yisheng Xie
2017-03-10  9:53     ` Yisheng Xie
2017-03-13  9:51     ` Vlastimil Babka
2017-03-13  9:51       ` Vlastimil Babka
2017-03-13 12:16       ` Yisheng Xie
2017-03-13 12:16         ` Yisheng Xie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eb3bbece-77ea-b88f-d4bf-dbf9bdf7f413@suse.cz \
    --to=vbabka@suse.cz \
    --cc=akpm@linux-foundation.org \
    --cc=guohanjun@huawei.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=liubo95@huawei.com \
    --cc=mgorman@techsingularity.net \
    --cc=mhocko@suse.com \
    --cc=minchan@kernel.org \
    --cc=qiuxishi@huawei.com \
    --cc=rientjes@google.com \
    --cc=xieyisheng1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.