All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann@suse.de>
To: Tian Tao <tiantao6@hisilicon.com>,
	airlied@linux.ie, daniel@ffwll.ch, kraxel@redhat.com,
	alexander.deucher@amd.com, tglx@linutronix.de,
	dri-devel@lists.freedesktop.org, xinliang.liu@linaro.org,
	maarten.lankhorst@linux.intel.com, mripard@kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH drm/hisilicon 3/3] drm/hisilicon: Use the new api devm_drm_irq_install
Date: Thu, 26 Nov 2020 14:15:06 +0100	[thread overview]
Message-ID: <eb55484d-d621-f91f-8d1b-51832440067d@suse.de> (raw)
In-Reply-To: <1606392140-57954-4-git-send-email-tiantao6@hisilicon.com>


[-- Attachment #1.1.1: Type: text/plain, Size: 1492 bytes --]

Hi

Am 26.11.20 um 13:02 schrieb Tian Tao:
> Use devm_drm_irq_install to register interrupts so that
> drm_irq_uninstall is not called when hibmc is removed.
> 
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>

Thanks!

> ---
>   drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
> index ea3d81b..77792e3 100644
> --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
> +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
> @@ -247,9 +247,6 @@ static int hibmc_unload(struct drm_device *dev)
>   
>   	drm_atomic_helper_shutdown(dev);
>   
> -	if (dev->irq_enabled)
> -		drm_irq_uninstall(dev);
> -
>   	pci_disable_msi(dev->pdev);
>   	hibmc_kms_fini(priv);
>   	hibmc_mm_fini(priv);
> @@ -284,7 +281,7 @@ static int hibmc_load(struct drm_device *dev)
>   	if (ret) {
>   		drm_warn(dev, "enabling MSI failed: %d\n", ret);
>   	} else {
> -		ret = drm_irq_install(dev, dev->pdev->irq);
> +		ret = devm_drm_irq_install(dev, dev->pdev->irq);
>   		if (ret)
>   			drm_warn(dev, "install irq failed: %d\n", ret);
>   	}
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

[-- Attachment #1.1.2: OpenPGP_0x680DC11D530B7A23.asc --]
[-- Type: application/pgp-keys, Size: 8003 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Thomas Zimmermann <tzimmermann@suse.de>
To: Tian Tao <tiantao6@hisilicon.com>,
	airlied@linux.ie, daniel@ffwll.ch, kraxel@redhat.com,
	alexander.deucher@amd.com, tglx@linutronix.de,
	dri-devel@lists.freedesktop.org, xinliang.liu@linaro.org,
	maarten.lankhorst@linux.intel.com, mripard@kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH drm/hisilicon 3/3] drm/hisilicon: Use the new api devm_drm_irq_install
Date: Thu, 26 Nov 2020 14:15:06 +0100	[thread overview]
Message-ID: <eb55484d-d621-f91f-8d1b-51832440067d@suse.de> (raw)
In-Reply-To: <1606392140-57954-4-git-send-email-tiantao6@hisilicon.com>


[-- Attachment #1.1.1.1: Type: text/plain, Size: 1492 bytes --]

Hi

Am 26.11.20 um 13:02 schrieb Tian Tao:
> Use devm_drm_irq_install to register interrupts so that
> drm_irq_uninstall is not called when hibmc is removed.
> 
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>

Thanks!

> ---
>   drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
> index ea3d81b..77792e3 100644
> --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
> +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
> @@ -247,9 +247,6 @@ static int hibmc_unload(struct drm_device *dev)
>   
>   	drm_atomic_helper_shutdown(dev);
>   
> -	if (dev->irq_enabled)
> -		drm_irq_uninstall(dev);
> -
>   	pci_disable_msi(dev->pdev);
>   	hibmc_kms_fini(priv);
>   	hibmc_mm_fini(priv);
> @@ -284,7 +281,7 @@ static int hibmc_load(struct drm_device *dev)
>   	if (ret) {
>   		drm_warn(dev, "enabling MSI failed: %d\n", ret);
>   	} else {
> -		ret = drm_irq_install(dev, dev->pdev->irq);
> +		ret = devm_drm_irq_install(dev, dev->pdev->irq);
>   		if (ret)
>   			drm_warn(dev, "install irq failed: %d\n", ret);
>   	}
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

[-- Attachment #1.1.1.2: OpenPGP_0x680DC11D530B7A23.asc --]
[-- Type: application/pgp-keys, Size: 8003 bytes --]

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-11-26 13:15 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-26 12:02 [PATCH drm/hisilicon 0/3] Add the new api to install irq Tian Tao
2020-11-26 12:02 ` Tian Tao
2020-11-26 12:02 ` [PATCH drm/hisilicon 1/3] drm/hisilicon: Code refactoring for hibmc_drm_drv Tian Tao
2020-11-26 12:02   ` Tian Tao
2020-11-26 13:05   ` Thomas Zimmermann
2020-11-26 13:05     ` Thomas Zimmermann
2020-11-26 13:13     ` Thomas Zimmermann
2020-11-26 13:13       ` Thomas Zimmermann
2020-11-26 12:02 ` [PATCH drm/hisilicon 2/3] drm/irq: Add the new api to install irq Tian Tao
2020-11-26 12:02   ` Tian Tao
2020-11-26 13:12   ` Thomas Zimmermann
2020-11-26 13:12     ` Thomas Zimmermann
2020-11-26 12:02 ` [PATCH drm/hisilicon 3/3] drm/hisilicon: Use the new api devm_drm_irq_install Tian Tao
2020-11-26 12:02   ` Tian Tao
2020-11-26 13:15   ` Thomas Zimmermann [this message]
2020-11-26 13:15     ` Thomas Zimmermann
2020-12-02  8:47 [PATCH drm/hisilicon 0/3] Add the new api to install irq Tian Tao
2020-12-02  8:47 ` [PATCH drm/hisilicon 3/3] drm/hisilicon: Use the new api devm_drm_irq_install Tian Tao
2020-12-02  8:47   ` Tian Tao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eb55484d-d621-f91f-8d1b-51832440067d@suse.de \
    --to=tzimmermann@suse.de \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kraxel@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tiantao6@hisilicon.com \
    --cc=xinliang.liu@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.