From: Marcin Niestroj <m.niestroj@grinn-global.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: kbuild test robot <lkp@intel.com>,
kbuild-all@01.org, Tony Lindgren <tony@atomide.com>,
Rob Herring <robh+dt@kernel.org>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Keerthy <j-keerthy@ti.com>, Pawel Moll <pawel.moll@arm.com>,
Alessandro Zummo <a.zummo@towertech.it>,
rtc-linux@googlegroups.com, linux-omap@vger.kernel.org,
devicetree@vger.kernel.org
Subject: [rtc-linux] Re: [PATCH v5] rtc: omap: Support ext_wakeup configuration
Date: Wed, 14 Sep 2016 11:21:48 +0200 [thread overview]
Message-ID: <eb67e85b-4651-33e0-abb7-339d83f36463@grinn-global.com> (raw)
In-Reply-To: <20160913215837.xstx4c6d4pr42hgh@piout.net>
On 13.09.2016 23:58, Alexandre Belloni wrote:
> Hi,
>
> On 12/09/2016 at 11:01:05 +0200, Marcin Niestroj wrote :
>> I guess we are missing PINCTRL in Kconfig. I didn't add that before,
>> because I thought that there is a dependency chain GENERIC_PINCONF ->
>> PINCONF -> PINCTRL.
>>
>> So to resolve this issue:
>> 1) Should we add "select" or "depends on" for PINCTRL?
>> 2) Should this option be somehow related to COMPILE_TEST?
>>
>
> Adding a "depends on PINCTRL" line should be enough to solve that issue.
>
Ok, will add that together with "depends on OF", as I noticed it is
also needed.
But right now we will not be able to compile this driver with
COMPILE_TEST, unless we select some architecture that selects PINCTRL.
So maybe it is a good idea to change "config PINCTRL" option from
'bool' to 'bool "Support PINCTRL" if COMPILE_TEST', so we can enable it
manually?
--
Marcin Niestroj
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
WARNING: multiple messages have this Message-ID (diff)
From: Marcin Niestroj <m.niestroj-z3quKL4iOrmQ6ZAhV5LmOA@public.gmane.org>
To: Alexandre Belloni
<alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: kbuild test robot <lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
kbuild-all-JC7UmRfGjtg@public.gmane.org,
Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Grygorii Strashko
<grygorii.strashko-l0cyMroinI0@public.gmane.org>,
Keerthy <j-keerthy-l0cyMroinI0@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Alessandro Zummo
<a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org>,
rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v5] rtc: omap: Support ext_wakeup configuration
Date: Wed, 14 Sep 2016 11:21:48 +0200 [thread overview]
Message-ID: <eb67e85b-4651-33e0-abb7-339d83f36463@grinn-global.com> (raw)
In-Reply-To: <20160913215837.xstx4c6d4pr42hgh-m++hUPXGwpdeoWH0uzbU5w@public.gmane.org>
On 13.09.2016 23:58, Alexandre Belloni wrote:
> Hi,
>
> On 12/09/2016 at 11:01:05 +0200, Marcin Niestroj wrote :
>> I guess we are missing PINCTRL in Kconfig. I didn't add that before,
>> because I thought that there is a dependency chain GENERIC_PINCONF ->
>> PINCONF -> PINCTRL.
>>
>> So to resolve this issue:
>> 1) Should we add "select" or "depends on" for PINCTRL?
>> 2) Should this option be somehow related to COMPILE_TEST?
>>
>
> Adding a "depends on PINCTRL" line should be enough to solve that issue.
>
Ok, will add that together with "depends on OF", as I noticed it is
also needed.
But right now we will not be able to compile this driver with
COMPILE_TEST, unless we select some architecture that selects PINCTRL.
So maybe it is a good idea to change "config PINCTRL" option from
'bool' to 'bool "Support PINCTRL" if COMPILE_TEST', so we can enable it
manually?
--
Marcin Niestroj
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2016-09-14 9:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 10:52 [rtc-linux] [PATCH v5] rtc: omap: Support ext_wakeup configuration Marcin Niestroj
2016-09-08 10:52 ` Marcin Niestroj
2016-09-08 14:20 ` [rtc-linux] " kbuild test robot
2016-09-08 14:20 ` kbuild test robot
2016-09-12 9:01 ` [rtc-linux] " Marcin Niestroj
2016-09-12 9:01 ` Marcin Niestroj
2016-09-13 21:58 ` [rtc-linux] " Alexandre Belloni
2016-09-13 21:58 ` Alexandre Belloni
2016-09-14 9:21 ` Marcin Niestroj [this message]
2016-09-14 9:21 ` Marcin Niestroj
2016-09-15 12:08 ` [rtc-linux] " Alexandre Belloni
2016-09-15 12:08 ` Alexandre Belloni
2016-09-08 14:27 ` [rtc-linux] " kbuild test robot
2016-09-08 14:27 ` kbuild test robot
2016-09-08 15:03 ` [rtc-linux] " kbuild test robot
2016-09-08 15:03 ` kbuild test robot
2016-09-16 15:37 ` [rtc-linux] " Rob Herring
2016-09-16 15:37 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb67e85b-4651-33e0-abb7-339d83f36463@grinn-global.com \
--to=m.niestroj@grinn-global.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=grygorii.strashko@ti.com \
--cc=j-keerthy@ti.com \
--cc=kbuild-all@01.org \
--cc=linux-omap@vger.kernel.org \
--cc=lkp@intel.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.