From: Jiada Wang <jiada_wang@mentor.com> To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Cc: <horms@verge.net.au>, <magnus.damm@gmail.com>, <robh+dt@kernel.org>, <mark.rutland@arm.com>, <lgirdwood@gmail.com>, <broonie@kernel.org>, <perex@perex.cz>, <tiwai@suse.com>, <geert@linux-m68k.org>, <linux-renesas-soc@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <alsa-devel@alsa-project.org> Subject: Re: [PATCH 5/5] ASoC: rsnd: dma: use extended audio dmac registers when available Date: Wed, 13 Mar 2019 15:34:00 +0900 [thread overview] Message-ID: <eb7ac3a6-e386-09e8-54b0-2e0eda90ad66@mentor.com> (raw) In-Reply-To: <87h8c7gv73.wl-kuninori.morimoto.gx@renesas.com> Hi Morimoto-san thanks for your comments On 2019/03/13 15:23, Kuninori Morimoto wrote: > > Hi Jiada > >> Some of SoCs have both basic and extended dmac registers set >> basic set only supports busif0 ~ busif3, in order to use >> busif4 ~ busif7, extended audio dmac registers need to be used. >> >> This patch changes to use extended dmac registers set when it is >> available in device-tree. >> >> Signed-off-by: Jiada Wang <jiada_wang@mentor.com> >> --- > > 1st of all, if you want to post this kind of patch-set, > you *should* post driver side patch 1st, and if it was accepted, > you need to post SoC side patch. Then, you need to indicate > to SoC maintainer which branch/commit should be based. > Otherwise, it will 100% breaks git-bisect. > yes, you're right, sorry about this > 2nd, in my understanding, our conclusion at Renesas-ML > is that we don't need to think about basic/extend DMAC register. > Because extend area is 100% covering basic area. > In other words, it is compatible. > Driver side don't need to think about it. > I am a little confused, because latest comment received from simon, suggests to let driver to decide which register set to use. for me, I think it's not necessary, if extended register set is available, driver shall always use it. Thanks, Jiada >> --- a/sound/soc/sh/rcar/dma.c >> +++ b/sound/soc/sh/rcar/dma.c >> @@ -830,7 +830,10 @@ int rsnd_dma_probe(struct rsnd_priv *priv) >> /* >> * for Gen2 or later >> */ >> - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "audmapp"); >> + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "extaudmapp"); >> + if (!res) >> + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, >> + "audmapp"); >> dmac = devm_kzalloc(dev, sizeof(*dmac), GFP_KERNEL); >> if (!dmac || !res) { >> dev_err(dev, "dma allocate failed\n"); >> -- >> 2.19.2 >>
WARNING: multiple messages have this Message-ID (diff)
From: Jiada Wang <jiada_wang@mentor.com> To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Cc: horms@verge.net.au, magnus.damm@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, geert@linux-m68k.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH 5/5] ASoC: rsnd: dma: use extended audio dmac registers when available Date: Wed, 13 Mar 2019 15:34:00 +0900 [thread overview] Message-ID: <eb7ac3a6-e386-09e8-54b0-2e0eda90ad66@mentor.com> (raw) In-Reply-To: <87h8c7gv73.wl-kuninori.morimoto.gx@renesas.com> Hi Morimoto-san thanks for your comments On 2019/03/13 15:23, Kuninori Morimoto wrote: > > Hi Jiada > >> Some of SoCs have both basic and extended dmac registers set >> basic set only supports busif0 ~ busif3, in order to use >> busif4 ~ busif7, extended audio dmac registers need to be used. >> >> This patch changes to use extended dmac registers set when it is >> available in device-tree. >> >> Signed-off-by: Jiada Wang <jiada_wang@mentor.com> >> --- > > 1st of all, if you want to post this kind of patch-set, > you *should* post driver side patch 1st, and if it was accepted, > you need to post SoC side patch. Then, you need to indicate > to SoC maintainer which branch/commit should be based. > Otherwise, it will 100% breaks git-bisect. > yes, you're right, sorry about this > 2nd, in my understanding, our conclusion at Renesas-ML > is that we don't need to think about basic/extend DMAC register. > Because extend area is 100% covering basic area. > In other words, it is compatible. > Driver side don't need to think about it. > I am a little confused, because latest comment received from simon, suggests to let driver to decide which register set to use. for me, I think it's not necessary, if extended register set is available, driver shall always use it. Thanks, Jiada >> --- a/sound/soc/sh/rcar/dma.c >> +++ b/sound/soc/sh/rcar/dma.c >> @@ -830,7 +830,10 @@ int rsnd_dma_probe(struct rsnd_priv *priv) >> /* >> * for Gen2 or later >> */ >> - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "audmapp"); >> + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "extaudmapp"); >> + if (!res) >> + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, >> + "audmapp"); >> dmac = devm_kzalloc(dev, sizeof(*dmac), GFP_KERNEL); >> if (!dmac || !res) { >> dev_err(dev, "dma allocate failed\n"); >> -- >> 2.19.2 >>
next prev parent reply other threads:[~2019-03-13 6:34 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-13 5:58 [PATCH 5/5] ASoC: rsnd: dma: use extended audio dmac registers when available Jiada Wang 2019-03-13 5:58 ` Jiada Wang 2019-03-13 6:23 ` Kuninori Morimoto 2019-03-13 6:23 ` Kuninori Morimoto 2019-03-13 6:33 ` Kuninori Morimoto 2019-03-13 6:33 ` Kuninori Morimoto 2019-03-13 6:36 ` Jiada Wang 2019-03-13 6:36 ` Jiada Wang 2019-03-13 6:34 ` Jiada Wang [this message] 2019-03-13 6:34 ` Jiada Wang 2019-03-13 6:57 ` Kuninori Morimoto 2019-03-13 6:57 ` Kuninori Morimoto 2019-03-13 8:52 ` Geert Uytterhoeven 2019-03-13 8:52 ` Geert Uytterhoeven 2019-03-18 5:22 ` Kuninori Morimoto
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=eb7ac3a6-e386-09e8-54b0-2e0eda90ad66@mentor.com \ --to=jiada_wang@mentor.com \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=geert@linux-m68k.org \ --cc=horms@verge.net.au \ --cc=kuninori.morimoto.gx@renesas.com \ --cc=lgirdwood@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=magnus.damm@gmail.com \ --cc=mark.rutland@arm.com \ --cc=perex@perex.cz \ --cc=robh+dt@kernel.org \ --cc=tiwai@suse.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.