Re: [PATCH v2 3/5] mt76: mt7915: add support for MT7986

[bo.jiao <bo.jiao@mediatek.com>]

hi Kalle,

got it, i will fix it ASAP.
thanks.

On Tue, 2022-01-11 at 18:40 +0200, Kalle Valo wrote:
> Bo Jiao <bo.jiao@mediatek.com> writes:
> 
> > From: Bo Jiao <Bo.Jiao@mediatek.com>
> > 
> > This adds MT7986 SoC integrated multi-band 4x4 WiFi 6/6E.
> > 
> > Co-developed-by: Peter Chiu <chui-hao.chiu@mediatek.com>
> > Signed-off-by: Peter Chiu <chui-hao.chiu@mediatek.com>
> > Co-developed-by: Ryder Lee <ryder.lee@mediatek.com>
> > Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
> > Signed-off-by: Sujuan Chen <sujuan.chen@mediatek.com>
> > Signed-off-by: Bo Jiao <Bo.Jiao@mediatek.com>
> 
> [...]
> 
> > +static int mt7986_wmac_adie_patch_7975(struct mt7915_dev *dev, u8
> > adie)
> > +{
> > +	if (/* disable CAL LDO and fine tune RFDIG LDO */
> > +	    mt76_wmac_spi_write(dev, adie, 0x348, 0x00000002) ||
> > +	    mt76_wmac_spi_write(dev, adie, 0x378, 0x00000002) ||
> > +	    mt76_wmac_spi_write(dev, adie, 0x3a8, 0x00000002) ||
> > +	    mt76_wmac_spi_write(dev, adie, 0x3d8, 0x00000002) ||
> > +	    /* set CKA driving and filter */
> > +	    mt76_wmac_spi_write(dev, adie, 0xa1c, 0x30000aaa) ||
> > +	    /* set CKB LDO to 1.4V */
> > +	    mt76_wmac_spi_write(dev, adie, 0xa84, 0x8470008a) ||
> > +	    /* turn on SX0 LTBUF */
> > +	    mt76_wmac_spi_write(dev, adie, 0x074, 0x00000002) ||
> > +	    /* CK_BUF_SW_EN = 1 (all buf in manual mode.) */
> > +	    mt76_wmac_spi_write(dev, adie, 0xaa4, 0x01001fc0) ||
> > +	    /* BT mode/WF normal mode 00000005 */
> > +	    mt76_wmac_spi_write(dev, adie, 0x070, 0x00000005) ||
> > +	    /* BG thermal sensor offset update */
> > +	    mt76_wmac_spi_write(dev, adie, 0x344, 0x00000088) ||
> > +	    mt76_wmac_spi_write(dev, adie, 0x374, 0x00000088) ||
> > +	    mt76_wmac_spi_write(dev, adie, 0x3a4, 0x00000088) ||
> > +	    mt76_wmac_spi_write(dev, adie, 0x3d4, 0x00000088) ||
> > +	    /* set WCON VDD IPTAT to "0000" */
> > +	    mt76_wmac_spi_write(dev, adie, 0xa80, 0x44d07000) ||
> > +	    /* change back LTBUF SX3 drving to default value */
> > +	    mt76_wmac_spi_write(dev, adie, 0xa88, 0x3900aaaa) ||
> > +	    /* SM input cap off */
> > +	    mt76_wmac_spi_write(dev, adie, 0x2c4, 0x00000000) ||
> > +	    /* set CKB driving and filter */
> > +	    mt76_wmac_spi_write(dev, adie, 0x2c8, 0x00000072))
> > +		return -ETIMEDOUT;
> > +
> > +	return 0;
> > +}
> 
> I commmented about this monster in v1, see my comments there.
> 
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek