All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Chiu <chui-hao.chiu@mediatek.com>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: Felix Fietkau <nbd@nbd.name>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	Ryder Lee <ryder.lee@mediatek.com>,
	"Xing Song" <xing.song@mediatek.com>,
	Sujuan Chen <sujuan.chen@mediatek.com>,
	Shayne Chen <shayne.chen@mediatek.com>,
	Evelyn Tsai <evelyn.tsai@mediatek.com>,
	linux-mediatek <linux-mediatek@lists.infradead.org>,
	Bo Jiao <bo.jiao@mediatek.com>
Subject: Re: [PATCH v2 3/5] mt76: mt7915: add support for MT7986
Date: Thu, 13 Jan 2022 18:10:29 +0800	[thread overview]
Message-ID: <2ab2731dc44494dbfe89363638cdcaf49351afbe.camel@mediatek.com> (raw)
In-Reply-To: <Yd7ZKb7Qsh4lGA5E@lore-desk>

On Wed, 2022-01-12 at 14:35 +0100, Lorenzo Bianconi wrote:
> > 
> > @@ -302,6 +316,15 @@ struct mt7915_dev {
> >  		u8 table_mask;
> >  		u8 n_agrt;
> >  	} twt;
> > +
> > +	struct reset_control *rstc;
> > +	void __iomem *dcm;
> > +	void __iomem *sku;
> > +
> > +	struct {
> > +		bool is_7975;
> > +		bool is_7976;
> > +	} adie[MT7986_MAX_ADIE_NUM];
> 
> do we really need it? Can we just read data from chip when necessary?
> it is not
> access in the hot-path, right?
> I think it is easier and more readable.

Adie registers are inaccessible after wfsys power on so we need some
places to store chip configuration.
We will modify it to make it more readable.
+ u32 adie;

thanks,
Peter


WARNING: multiple messages have this Message-ID (diff)
From: Peter Chiu <chui-hao.chiu@mediatek.com>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: Felix Fietkau <nbd@nbd.name>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	Ryder Lee <ryder.lee@mediatek.com>,
	"Xing Song" <xing.song@mediatek.com>,
	Sujuan Chen <sujuan.chen@mediatek.com>,
	Shayne Chen <shayne.chen@mediatek.com>,
	Evelyn Tsai <evelyn.tsai@mediatek.com>,
	linux-mediatek <linux-mediatek@lists.infradead.org>,
	Bo Jiao <bo.jiao@mediatek.com>
Subject: Re: [PATCH v2 3/5] mt76: mt7915: add support for MT7986
Date: Thu, 13 Jan 2022 18:10:29 +0800	[thread overview]
Message-ID: <2ab2731dc44494dbfe89363638cdcaf49351afbe.camel@mediatek.com> (raw)
In-Reply-To: <Yd7ZKb7Qsh4lGA5E@lore-desk>

On Wed, 2022-01-12 at 14:35 +0100, Lorenzo Bianconi wrote:
> > 
> > @@ -302,6 +316,15 @@ struct mt7915_dev {
> >  		u8 table_mask;
> >  		u8 n_agrt;
> >  	} twt;
> > +
> > +	struct reset_control *rstc;
> > +	void __iomem *dcm;
> > +	void __iomem *sku;
> > +
> > +	struct {
> > +		bool is_7975;
> > +		bool is_7976;
> > +	} adie[MT7986_MAX_ADIE_NUM];
> 
> do we really need it? Can we just read data from chip when necessary?
> it is not
> access in the hot-path, right?
> I think it is easier and more readable.

Adie registers are inaccessible after wfsys power on so we need some
places to store chip configuration.
We will modify it to make it more readable.
+ u32 adie;

thanks,
Peter


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

  reply	other threads:[~2022-01-13 10:10 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-11 11:59 [PATCH v2 0/5] add mt7986 support Bo Jiao
2022-01-11 11:59 ` Bo Jiao
2022-01-11 11:59 ` [PATCH v2 1/5] dt-bindings: net: wireless: mt76: document bindings for MT7986 Bo Jiao
2022-01-11 11:59   ` Bo Jiao
2022-01-11 15:14   ` Rob Herring
2022-01-11 15:14     ` Rob Herring
2022-01-11 21:53   ` Rob Herring
2022-01-11 21:53     ` Rob Herring
2022-01-12  6:11     ` bo.jiao
2022-01-11 11:59 ` [PATCH v2 2/5] mt76: redefine mt76_for_each_q_rx to adapt mt7986 changes Bo Jiao
2022-01-11 11:59   ` Bo Jiao
2022-01-11 11:59 ` [PATCH v2 3/5] mt76: mt7915: add support for MT7986 Bo Jiao
2022-01-11 11:59   ` Bo Jiao
2022-01-11 16:40   ` Kalle Valo
2022-01-11 16:40     ` Kalle Valo
2022-01-12  6:07     ` bo.jiao
2022-01-12 13:35   ` Lorenzo Bianconi
2022-01-12 13:35     ` Lorenzo Bianconi
2022-01-13 10:10     ` Peter Chiu [this message]
2022-01-13 10:10       ` Peter Chiu
2022-01-13 10:19       ` Lorenzo Bianconi
2022-01-13 10:19         ` Lorenzo Bianconi
2022-01-13 13:55         ` Lorenzo Bianconi
2022-01-13 13:55           ` Lorenzo Bianconi
2022-01-14  2:21           ` Peter Chiu
2022-01-14  2:21             ` Peter Chiu
2022-01-11 11:59 ` [PATCH v2 4/5] mt76: mt7915: add Kconfig entry " Bo Jiao
2022-01-11 11:59   ` Bo Jiao
2022-01-11 16:40   ` Kalle Valo
2022-01-11 16:40     ` Kalle Valo
2022-01-12 10:50   ` Lorenzo Bianconi
2022-01-12 10:50     ` Lorenzo Bianconi
2022-01-11 11:59 ` [PATCH v2 5/5] mt76: mt7915: introduce band_idx in mt7915_phy Bo Jiao
2022-01-11 11:59   ` Bo Jiao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2ab2731dc44494dbfe89363638cdcaf49351afbe.camel@mediatek.com \
    --to=chui-hao.chiu@mediatek.com \
    --cc=bo.jiao@mediatek.com \
    --cc=evelyn.tsai@mediatek.com \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lorenzo@kernel.org \
    --cc=nbd@nbd.name \
    --cc=ryder.lee@mediatek.com \
    --cc=shayne.chen@mediatek.com \
    --cc=sujuan.chen@mediatek.com \
    --cc=xing.song@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.