From: Jan Kiszka <jan.kiszka@siemens.com>
To: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: Jingoo Han <jingoohan1@gmail.com>,
Joao Pinto <Joao.Pinto@synopsys.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Subject: Re: [PATCH v4 4/8] PCI: Replace dev_node parameter of of_pci_get_host_bridge_resources with device
Date: Mon, 28 May 2018 12:46:35 +0200 [thread overview]
Message-ID: <eb9b477a-33c9-db45-9e62-101e3606e8ff@siemens.com> (raw)
In-Reply-To: <a74db976-d330-80b9-939e-dd164a20c8c3@mentor.com>
On 2018-05-28 12:00, Vladimir Zapolskiy wrote:
> Hi Jan, Bjorn,
>
> On 05/15/2018 12:07 PM, Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> Another step towards a managed version of
>> of_pci_get_host_bridge_resources(): Feed in the underlying device,
>> rather than just the OF node. This will allow to use managed resource
>> allocation internally later on.
>>
>> CC: Jingoo Han <jingoohan1@gmail.com>
>> CC: Joao Pinto <Joao.Pinto@synopsys.com>
>> CC: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>
> [snip]
>
>> diff --git a/drivers/pci/host/pcie-altera.c b/drivers/pci/host/pcie-altera.c
>> index a6af62e0256d..61802e55a00c 100644
>> --- a/drivers/pci/host/pcie-altera.c
>> +++ b/drivers/pci/host/pcie-altera.c
>> @@ -488,11 +488,10 @@ static int altera_pcie_parse_request_of_pci_ranges(struct altera_pcie *pcie)
>> {
>> int err, res_valid = 0;
>> struct device *dev = &pcie->pdev->dev;
>> - struct device_node *np = dev->of_node;
>> struct resource_entry *win;
>>
>> - err = of_pci_get_host_bridge_resources(np, 0, 0xff, &pcie->resources,
>> - NULL);
>> + err = of_pci_get_host_bridge_resources(dev, 0, 0xff
>> + &pcie->resources, NULL);
>> if (err)
>> return err;
>>
>
> In case if it is an undiscovered issue, a comma was mistakenly removed,
> which will result it compilation error.
>
> The problem is also found in pci/next , see commit 88e3909aa125.
Yes, that's known. We have a bisection breakage: The issue was fixed
again by patch 6 in that series.
Jan
--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: Jingoo Han <jingoohan1@gmail.com>,
Joao Pinto <Joao.Pinto@synopsys.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Subject: Re: [PATCH v4 4/8] PCI: Replace dev_node parameter of of_pci_get_host_bridge_resources with device
Date: Mon, 28 May 2018 12:46:35 +0200 [thread overview]
Message-ID: <eb9b477a-33c9-db45-9e62-101e3606e8ff@siemens.com> (raw)
In-Reply-To: <a74db976-d330-80b9-939e-dd164a20c8c3@mentor.com>
On 2018-05-28 12:00, Vladimir Zapolskiy wrote:
> Hi Jan, Bjorn,
>
> On 05/15/2018 12:07 PM, Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> Another step towards a managed version of
>> of_pci_get_host_bridge_resources(): Feed in the underlying device,
>> rather than just the OF node. This will allow to use managed resource
>> allocation internally later on.
>>
>> CC: Jingoo Han <jingoohan1@gmail.com>
>> CC: Joao Pinto <Joao.Pinto@synopsys.com>
>> CC: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>
> [snip]
>
>> diff --git a/drivers/pci/host/pcie-altera.c b/drivers/pci/host/pcie-altera.c
>> index a6af62e0256d..61802e55a00c 100644
>> --- a/drivers/pci/host/pcie-altera.c
>> +++ b/drivers/pci/host/pcie-altera.c
>> @@ -488,11 +488,10 @@ static int altera_pcie_parse_request_of_pci_ranges(struct altera_pcie *pcie)
>> {
>> int err, res_valid = 0;
>> struct device *dev = &pcie->pdev->dev;
>> - struct device_node *np = dev->of_node;
>> struct resource_entry *win;
>>
>> - err = of_pci_get_host_bridge_resources(np, 0, 0xff, &pcie->resources,
>> - NULL);
>> + err = of_pci_get_host_bridge_resources(dev, 0, 0xff
>> + &pcie->resources, NULL);
>> if (err)
>> return err;
>>
>
> In case if it is an undiscovered issue, a comma was mistakenly removed,
> which will result it compilation error.
>
> The problem is also found in pci/next , see commit 88e3909aa125.
Yes, that's known. We have a bisection breakage: The issue was fixed
again by patch 6 in that series.
Jan
--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: jan.kiszka@siemens.com (Jan Kiszka)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 4/8] PCI: Replace dev_node parameter of of_pci_get_host_bridge_resources with device
Date: Mon, 28 May 2018 12:46:35 +0200 [thread overview]
Message-ID: <eb9b477a-33c9-db45-9e62-101e3606e8ff@siemens.com> (raw)
In-Reply-To: <a74db976-d330-80b9-939e-dd164a20c8c3@mentor.com>
On 2018-05-28 12:00, Vladimir Zapolskiy wrote:
> Hi Jan, Bjorn,
>
> On 05/15/2018 12:07 PM, Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> Another step towards a managed version of
>> of_pci_get_host_bridge_resources(): Feed in the underlying device,
>> rather than just the OF node. This will allow to use managed resource
>> allocation internally later on.
>>
>> CC: Jingoo Han <jingoohan1@gmail.com>
>> CC: Joao Pinto <Joao.Pinto@synopsys.com>
>> CC: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>
> [snip]
>
>> diff --git a/drivers/pci/host/pcie-altera.c b/drivers/pci/host/pcie-altera.c
>> index a6af62e0256d..61802e55a00c 100644
>> --- a/drivers/pci/host/pcie-altera.c
>> +++ b/drivers/pci/host/pcie-altera.c
>> @@ -488,11 +488,10 @@ static int altera_pcie_parse_request_of_pci_ranges(struct altera_pcie *pcie)
>> {
>> int err, res_valid = 0;
>> struct device *dev = &pcie->pdev->dev;
>> - struct device_node *np = dev->of_node;
>> struct resource_entry *win;
>>
>> - err = of_pci_get_host_bridge_resources(np, 0, 0xff, &pcie->resources,
>> - NULL);
>> + err = of_pci_get_host_bridge_resources(dev, 0, 0xff
>> + &pcie->resources, NULL);
>> if (err)
>> return err;
>>
>
> In case if it is an undiscovered issue, a comma was mistakenly removed,
> which will result it compilation error.
>
> The problem is also found in pci/next , see commit 88e3909aa125.
Yes, that's known. We have a bisection breakage: The issue was fixed
again by patch 6 in that series.
Jan
--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2018-05-28 13:30 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-15 9:06 [PATCH v4 0/8] PCI: leak fixes, removable generic PCI host, assorted stuff Jan Kiszka
2018-05-15 9:06 ` Jan Kiszka
2018-05-15 9:07 ` [PATCH v4 1/8] PCI: Make pci_get_new_domain_nr() static Jan Kiszka
2018-05-15 9:07 ` Jan Kiszka
2018-05-15 9:07 ` [PATCH v4 2/8] PCI: Fix memory leak of devm_pci_alloc_host_bridge() Jan Kiszka
2018-05-15 9:07 ` Jan Kiszka
2018-05-15 9:07 ` [PATCH v4 3/8] PCI: Rename device node parameter of of_pci_get_host_bridge_resources() Jan Kiszka
2018-05-15 9:07 ` Jan Kiszka
2018-05-15 9:07 ` Jan Kiszka
2018-05-15 10:04 ` Vladimir Zapolskiy
2018-05-15 10:04 ` Vladimir Zapolskiy
2018-05-15 9:07 ` [PATCH v4 4/8] PCI: Replace dev_node parameter of of_pci_get_host_bridge_resources with device Jan Kiszka
2018-05-15 9:07 ` Jan Kiszka
2018-05-15 9:07 ` Jan Kiszka
2018-05-15 10:05 ` Vladimir Zapolskiy
2018-05-15 10:05 ` Vladimir Zapolskiy
2018-05-15 15:34 ` Jingoo Han
2018-05-15 15:34 ` Jingoo Han
2018-05-15 15:34 ` Jingoo Han
2018-05-28 10:00 ` Vladimir Zapolskiy
2018-05-28 10:00 ` Vladimir Zapolskiy
2018-05-28 10:00 ` Vladimir Zapolskiy
2018-05-28 10:46 ` Jan Kiszka [this message]
2018-05-28 10:46 ` Jan Kiszka
2018-05-28 10:46 ` Jan Kiszka
2018-05-29 13:20 ` Bjorn Helgaas
2018-05-29 13:20 ` Bjorn Helgaas
2018-05-15 9:07 ` [PATCH v4 5/8] PCI: Replace pr_*() with dev_*() in of_pci_get_host_bridge_resources() Jan Kiszka
2018-05-15 9:07 ` Jan Kiszka
2018-05-15 10:05 ` Vladimir Zapolskiy
2018-05-15 10:05 ` Vladimir Zapolskiy
2018-05-15 9:07 ` [PATCH v4 6/8] PCI: Rework of_pci_get_host_bridge_resources() to devm_of_pci_get_host_bridge_resources() Jan Kiszka
2018-05-15 9:07 ` Jan Kiszka
2018-05-15 10:06 ` Vladimir Zapolskiy
2018-05-15 10:06 ` Vladimir Zapolskiy
2018-05-15 14:28 ` Joao Pinto
2018-05-15 14:28 ` Joao Pinto
2018-05-15 14:28 ` Joao Pinto
2018-05-15 15:31 ` Jingoo Han
2018-05-15 15:31 ` Jingoo Han
2018-05-15 15:31 ` Jingoo Han
2018-05-15 16:48 ` Andy Shevchenko
2018-05-15 16:48 ` Andy Shevchenko
2018-05-15 16:48 ` Andy Shevchenko
2018-05-15 16:50 ` Andy Shevchenko
2018-05-15 16:50 ` Andy Shevchenko
2018-05-15 16:50 ` Andy Shevchenko
2018-05-16 12:31 ` [PATCH] PCI: Clean up resource allocation in devm_of_pci_get_host_bridge_resources() Jan Kiszka
2018-05-16 12:31 ` Jan Kiszka
2018-05-17 6:23 ` Vladimir Zapolskiy
2018-05-17 6:23 ` Vladimir Zapolskiy
2018-06-05 16:26 ` Andy Shevchenko
2018-06-05 16:26 ` Andy Shevchenko
2018-06-05 20:44 ` Bjorn Helgaas
2018-06-05 20:44 ` Bjorn Helgaas
2018-06-05 20:44 ` Bjorn Helgaas
2018-06-29 23:30 ` Bjorn Helgaas
2018-06-29 23:30 ` Bjorn Helgaas
2018-06-29 23:30 ` Bjorn Helgaas
2018-05-15 9:07 ` [PATCH v4 7/8] PCI: Add support for unbinding the generic PCI host controller Jan Kiszka
2018-05-15 9:07 ` Jan Kiszka
2018-05-15 9:07 ` [PATCH v4 8/8] PCI: Enable PCI_DOMAINS along with " Jan Kiszka
2018-05-15 9:07 ` Jan Kiszka
2018-05-15 19:00 ` [PATCH v4 0/8] PCI: leak fixes, removable generic PCI host, assorted stuff Bjorn Helgaas
2018-05-15 19:00 ` Bjorn Helgaas
2018-05-15 19:00 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb9b477a-33c9-db45-9e62-101e3606e8ff@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=Joao.Pinto@synopsys.com \
--cc=bhelgaas@google.com \
--cc=jingoohan1@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=vladimir_zapolskiy@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.