All of lore.kernel.org
 help / color / mirror / Atom feed
From: Georg Piewald <gpi@mailbox.org>
To: "fuego@lists.linuxfoundation.org" <fuego@lists.linuxfoundation.org>
Subject: [Fuego] Dockerfile vs install-debian.sh
Date: Mon, 27 Jul 2020 13:14:25 +0200	[thread overview]
Message-ID: <eba92086-a36d-2085-ca7a-3186ed733a1c@mailbox.org> (raw)

Hi guys,

I was just looking into how to install Fuego without a Docker container 
(since the CHANGELOG says it's possible). Apparently, that's what 
install-debian.sh is good for (or is there something else, that I missed?).

But honestly, this script seems like a halfhearted attempt to me and 
strongly violates the DRY principle. It is clearly descendant from 
Dockerfile, but did not evolve with it. Several later modifications in 
Dockerfile did not make it to install-debian.sh. How do you plan to keep 
these files in sync?

I propose to only let install-debian.sh have all the code that sets up 
the OS and installs all requirements. The Dockerfile instead should do 
(almost) nothing but execute install-debian.sh.

An additional benefit of that method is that it will be much easier to 
also keep Dockerfile.nojenkins in sync with the standard Dockerfile. 
Because here we have the same problem of lots of copied code, that is 
slowly drifting apart. We might even not need Dockerfile.nojenkins 
anymore at all.

I can offer to implement this, unless there are strong objections by anyone.

Regards, Georg

             reply	other threads:[~2020-07-27 11:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-27 11:14 Georg Piewald [this message]
2020-07-27 11:52 ` [Fuego] Dockerfile vs install-debian.sh daniel.sangorrin
2020-07-27 11:54   ` daniel.sangorrin
2020-07-27 17:41   ` Bird, Tim
2020-07-28  8:25   ` Georg Piewald
2020-07-28  9:25     ` daniel.sangorrin
2020-07-27 17:33 ` Bird, Tim
2020-07-30 21:38   ` Georg Piewald
2020-09-30 23:57     ` daniel.sangorrin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eba92086-a36d-2085-ca7a-3186ed733a1c@mailbox.org \
    --to=gpi@mailbox.org \
    --cc=fuego@lists.linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.