* [PATCH 1/2] doc: clarify L3 Tx checksum prerequisite
@ 2018-10-05 4:46 Jerin Jacob
2018-10-05 4:46 ` [PATCH 2/2] doc: clarify L4 " Jerin Jacob
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Jerin Jacob @ 2018-10-05 4:46 UTC (permalink / raw)
To: John McNamara, Marko Kovacevic
Cc: dev, thomas, ferruh.yigit, arybchenko, olivier.matz, Jerin Jacob, stable
Based on PKT_TX_IP_CKSUM definition the user needs
to fill l2_len and l3_len mbuf fields before issuing
HW Tx checksum request.
Fixes: dad1ec72a377 ("doc: document NIC features")
Cc: stable@dpdk.org
Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
See PKT_TX_IP_CKSUM at
https://git.dpdk.org/dpdk/tree/lib/librte_mbuf/rte_mbuf.h#n283
---
doc/guides/nics/features.rst | 1 +
1 file changed, 1 insertion(+)
diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
index b085bda86..e726a6bb8 100644
--- a/doc/guides/nics/features.rst
+++ b/doc/guides/nics/features.rst
@@ -562,6 +562,7 @@ Supports L3 checksum offload.
* **[uses] rte_eth_txconf,rte_eth_txmode**: ``offloads:DEV_TX_OFFLOAD_IPV4_CKSUM``.
* **[uses] mbuf**: ``mbuf.ol_flags:PKT_TX_IP_CKSUM``,
``mbuf.ol_flags:PKT_TX_IPV4`` | ``PKT_TX_IPV6``.
+* **[uses] mbuf**: ``mbuf.l2_len``, ``mbuf.l3_len``.
* **[provides] mbuf**: ``mbuf.ol_flags:PKT_RX_IP_CKSUM_UNKNOWN`` |
``PKT_RX_IP_CKSUM_BAD`` | ``PKT_RX_IP_CKSUM_GOOD`` |
``PKT_RX_IP_CKSUM_NONE``.
--
2.19.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/2] doc: clarify L4 Tx checksum prerequisite
2018-10-05 4:46 [PATCH 1/2] doc: clarify L3 Tx checksum prerequisite Jerin Jacob
@ 2018-10-05 4:46 ` Jerin Jacob
2018-10-05 6:45 ` Andrew Rybchenko
2018-10-05 6:44 ` [PATCH 1/2] doc: clarify L3 " Andrew Rybchenko
2018-10-05 19:56 ` Ferruh Yigit
2 siblings, 1 reply; 8+ messages in thread
From: Jerin Jacob @ 2018-10-05 4:46 UTC (permalink / raw)
To: John McNamara, Marko Kovacevic
Cc: dev, thomas, ferruh.yigit, arybchenko, olivier.matz, Jerin Jacob, stable
Based on PKT_TX_[TCP|UDP|SCTP]_CKSUM definition the user needs
to fill l2_len and l3_len mbuf fields before issuing HW Tx
checksum request.
Fixes: dad1ec72a377 ("doc: document NIC features")
Cc: stable@dpdk.org
Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
See PKT_TX_TCP_CKSUM defintion at
https://git.dpdk.org/dpdk/tree/lib/librte_mbuf/rte_mbuf.h#n269
---
doc/guides/nics/features.rst | 1 +
1 file changed, 1 insertion(+)
diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
index e726a6bb8..c39fb0074 100644
--- a/doc/guides/nics/features.rst
+++ b/doc/guides/nics/features.rst
@@ -582,6 +582,7 @@ Supports L4 checksum offload.
* **[uses] mbuf**: ``mbuf.ol_flags:PKT_TX_IPV4`` | ``PKT_TX_IPV6``,
``mbuf.ol_flags:PKT_TX_L4_NO_CKSUM`` | ``PKT_TX_TCP_CKSUM`` |
``PKT_TX_SCTP_CKSUM`` | ``PKT_TX_UDP_CKSUM``.
+* **[uses] mbuf**: ``mbuf.l2_len``, ``mbuf.l3_len``.
* **[provides] mbuf**: ``mbuf.ol_flags:PKT_RX_L4_CKSUM_UNKNOWN`` |
``PKT_RX_L4_CKSUM_BAD`` | ``PKT_RX_L4_CKSUM_GOOD`` |
``PKT_RX_L4_CKSUM_NONE``.
--
2.19.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] doc: clarify L3 Tx checksum prerequisite
2018-10-05 4:46 [PATCH 1/2] doc: clarify L3 Tx checksum prerequisite Jerin Jacob
2018-10-05 4:46 ` [PATCH 2/2] doc: clarify L4 " Jerin Jacob
@ 2018-10-05 6:44 ` Andrew Rybchenko
2018-10-05 7:06 ` Jerin Jacob
2018-10-09 10:19 ` Ferruh Yigit
2018-10-05 19:56 ` Ferruh Yigit
2 siblings, 2 replies; 8+ messages in thread
From: Andrew Rybchenko @ 2018-10-05 6:44 UTC (permalink / raw)
To: Jerin Jacob, John McNamara, Marko Kovacevic
Cc: dev, thomas, ferruh.yigit, olivier.matz, stable
On 10/5/18 7:46 AM, Jerin Jacob wrote:
> Based on PKT_TX_IP_CKSUM definition the user needs
> to fill l2_len and l3_len mbuf fields before issuing
> HW Tx checksum request.
>
> Fixes: dad1ec72a377 ("doc: document NIC features")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
plus one question below
> ---
>
> See PKT_TX_IP_CKSUM at
> https://git.dpdk.org/dpdk/tree/lib/librte_mbuf/rte_mbuf.h#n283
>
> ---
> doc/guides/nics/features.rst | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
> index b085bda86..e726a6bb8 100644
> --- a/doc/guides/nics/features.rst
> +++ b/doc/guides/nics/features.rst
> @@ -562,6 +562,7 @@ Supports L3 checksum offload.
> * **[uses] rte_eth_txconf,rte_eth_txmode**: ``offloads:DEV_TX_OFFLOAD_IPV4_CKSUM``.
> * **[uses] mbuf**: ``mbuf.ol_flags:PKT_TX_IP_CKSUM``,
> ``mbuf.ol_flags:PKT_TX_IPV4`` | ``PKT_TX_IPV6``.
Shouldn't PKT_TX_IPV6 be removed above since L3 checksum offload is not
applicable for IPv6?
> +* **[uses] mbuf**: ``mbuf.l2_len``, ``mbuf.l3_len``.
> * **[provides] mbuf**: ``mbuf.ol_flags:PKT_RX_IP_CKSUM_UNKNOWN`` |
> ``PKT_RX_IP_CKSUM_BAD`` | ``PKT_RX_IP_CKSUM_GOOD`` |
> ``PKT_RX_IP_CKSUM_NONE``.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] doc: clarify L4 Tx checksum prerequisite
2018-10-05 4:46 ` [PATCH 2/2] doc: clarify L4 " Jerin Jacob
@ 2018-10-05 6:45 ` Andrew Rybchenko
0 siblings, 0 replies; 8+ messages in thread
From: Andrew Rybchenko @ 2018-10-05 6:45 UTC (permalink / raw)
To: Jerin Jacob, John McNamara, Marko Kovacevic
Cc: dev, thomas, ferruh.yigit, olivier.matz, stable
On 10/5/18 7:46 AM, Jerin Jacob wrote:
> Based on PKT_TX_[TCP|UDP|SCTP]_CKSUM definition the user needs
> to fill l2_len and l3_len mbuf fields before issuing HW Tx
> checksum request.
>
> Fixes: dad1ec72a377 ("doc: document NIC features")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] doc: clarify L3 Tx checksum prerequisite
2018-10-05 6:44 ` [PATCH 1/2] doc: clarify L3 " Andrew Rybchenko
@ 2018-10-05 7:06 ` Jerin Jacob
2018-10-09 10:19 ` Ferruh Yigit
1 sibling, 0 replies; 8+ messages in thread
From: Jerin Jacob @ 2018-10-05 7:06 UTC (permalink / raw)
To: Andrew Rybchenko
Cc: John McNamara, Marko Kovacevic, dev, thomas, ferruh.yigit,
olivier.matz, stable
-----Original Message-----
> Date: Fri, 5 Oct 2018 09:44:43 +0300
> From: Andrew Rybchenko <arybchenko@solarflare.com>
> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, John McNamara
> <john.mcnamara@intel.com>, Marko Kovacevic <marko.kovacevic@intel.com>
> CC: dev@dpdk.org, thomas@monjalon.net, ferruh.yigit@intel.com,
> olivier.matz@6wind.com, stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 1/2] doc: clarify L3 Tx checksum prerequisite
> User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
> Thunderbird/60.0
>
> External Email
>
> On 10/5/18 7:46 AM, Jerin Jacob wrote:
>
> Based on PKT_TX_IP_CKSUM definition the user needs
> to fill l2_len and l3_len mbuf fields before issuing
> HW Tx checksum request.
>
> Fixes: dad1ec72a377 ("doc: document NIC features")
> Cc: stable@dpdk.org<mailto:stable@dpdk.org>
>
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com><mailto:jerin.jacob@caviumnetworks.com>
>
> Acked-by: Andrew Rybchenko <arybchenko@solarflare.com><mailto:arybchenko@solarflare.com>
>
> plus one question below
>
>
> ---
>
> See PKT_TX_IP_CKSUM at
> https://git.dpdk.org/dpdk/tree/lib/librte_mbuf/rte_mbuf.h#n283
>
> ---
> doc/guides/nics/features.rst | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
> index b085bda86..e726a6bb8 100644
> --- a/doc/guides/nics/features.rst
> +++ b/doc/guides/nics/features.rst
> @@ -562,6 +562,7 @@ Supports L3 checksum offload.
> * **[uses] rte_eth_txconf,rte_eth_txmode**: ``offloads:DEV_TX_OFFLOAD_IPV4_CKSUM``.
> * **[uses] mbuf**: ``mbuf.ol_flags:PKT_TX_IP_CKSUM``,
> ``mbuf.ol_flags:PKT_TX_IPV4`` | ``PKT_TX_IPV6``.
>
> Shouldn't PKT_TX_IPV6 be removed above since L3 checksum offload is not applicable for IPv6?
I think, some HW(What I am aware of) need to provide following[1] info in Tx
descriptors for checksum. IPV6 may be used by the HW in case, packet is
tunneled to see where inner start etc(thought it has outer_l3_len)(not strictly from outer checksum
perspective)
[1]
- IPV4
- IPV4 with csum
- IPV6
>
>
>
> +* **[uses] mbuf**: ``mbuf.l2_len``, ``mbuf.l3_len``.
> * **[provides] mbuf**: ``mbuf.ol_flags:PKT_RX_IP_CKSUM_UNKNOWN`` |
> ``PKT_RX_IP_CKSUM_BAD`` | ``PKT_RX_IP_CKSUM_GOOD`` |
> ``PKT_RX_IP_CKSUM_NONE``.
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] doc: clarify L3 Tx checksum prerequisite
2018-10-05 4:46 [PATCH 1/2] doc: clarify L3 Tx checksum prerequisite Jerin Jacob
2018-10-05 4:46 ` [PATCH 2/2] doc: clarify L4 " Jerin Jacob
2018-10-05 6:44 ` [PATCH 1/2] doc: clarify L3 " Andrew Rybchenko
@ 2018-10-05 19:56 ` Ferruh Yigit
2018-10-06 8:05 ` Jerin Jacob
2 siblings, 1 reply; 8+ messages in thread
From: Ferruh Yigit @ 2018-10-05 19:56 UTC (permalink / raw)
To: Jerin Jacob, John McNamara, Marko Kovacevic
Cc: dev, thomas, arybchenko, olivier.matz, stable
On 10/5/2018 5:46 AM, Jerin Jacob wrote:
> Based on PKT_TX_IP_CKSUM definition the user needs
> to fill l2_len and l3_len mbuf fields before issuing
> HW Tx checksum request.
>
> Fixes: dad1ec72a377 ("doc: document NIC features")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
>
> See PKT_TX_IP_CKSUM at
> https://git.dpdk.org/dpdk/tree/lib/librte_mbuf/rte_mbuf.h#n283
>
> ---
> doc/guides/nics/features.rst | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
> index b085bda86..e726a6bb8 100644
> --- a/doc/guides/nics/features.rst
> +++ b/doc/guides/nics/features.rst
> @@ -562,6 +562,7 @@ Supports L3 checksum offload.
> * **[uses] rte_eth_txconf,rte_eth_txmode**: ``offloads:DEV_TX_OFFLOAD_IPV4_CKSUM``.
> * **[uses] mbuf**: ``mbuf.ol_flags:PKT_TX_IP_CKSUM``,
> ``mbuf.ol_flags:PKT_TX_IPV4`` | ``PKT_TX_IPV6``.
> +* **[uses] mbuf**: ``mbuf.l2_len``, ``mbuf.l3_len``.
Thanks this was missing.
``mbuf.l2_len``, ``mbuf.l3_len`` are required for TX CKSUM offload, in
documentation there is no distinction for Rx or Tx, do you think does it worth
to clarify PMD `uses` these values for Tx cksum offload only?
> * **[provides] mbuf**: ``mbuf.ol_flags:PKT_RX_IP_CKSUM_UNKNOWN`` |
> ``PKT_RX_IP_CKSUM_BAD`` | ``PKT_RX_IP_CKSUM_GOOD`` |
> ``PKT_RX_IP_CKSUM_NONE``.
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] doc: clarify L3 Tx checksum prerequisite
2018-10-05 19:56 ` Ferruh Yigit
@ 2018-10-06 8:05 ` Jerin Jacob
0 siblings, 0 replies; 8+ messages in thread
From: Jerin Jacob @ 2018-10-06 8:05 UTC (permalink / raw)
To: Ferruh Yigit
Cc: John McNamara, Marko Kovacevic, dev, thomas, arybchenko,
olivier.matz, stable
-----Original Message-----
> Date: Fri, 5 Oct 2018 20:56:47 +0100
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, John McNamara
> <john.mcnamara@intel.com>, Marko Kovacevic <marko.kovacevic@intel.com>
> CC: dev@dpdk.org, thomas@monjalon.net, arybchenko@solarflare.com,
> olivier.matz@6wind.com, stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 1/2] doc: clarify L3 Tx checksum prerequisite
> User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
> Thunderbird/52.9.1
>
> External Email
>
> On 10/5/2018 5:46 AM, Jerin Jacob wrote:
> > Based on PKT_TX_IP_CKSUM definition the user needs
> > to fill l2_len and l3_len mbuf fields before issuing
> > HW Tx checksum request.
> >
> > Fixes: dad1ec72a377 ("doc: document NIC features")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > ---
> >
> > See PKT_TX_IP_CKSUM at
> > https://git.dpdk.org/dpdk/tree/lib/librte_mbuf/rte_mbuf.h#n283
> >
> > ---
> > doc/guides/nics/features.rst | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
> > index b085bda86..e726a6bb8 100644
> > --- a/doc/guides/nics/features.rst
> > +++ b/doc/guides/nics/features.rst
> > @@ -562,6 +562,7 @@ Supports L3 checksum offload.
> > * **[uses] rte_eth_txconf,rte_eth_txmode**: ``offloads:DEV_TX_OFFLOAD_IPV4_CKSUM``.
> > * **[uses] mbuf**: ``mbuf.ol_flags:PKT_TX_IP_CKSUM``,
> > ``mbuf.ol_flags:PKT_TX_IPV4`` | ``PKT_TX_IPV6``.
> > +* **[uses] mbuf**: ``mbuf.l2_len``, ``mbuf.l3_len``.
>
> Thanks this was missing.
>
> ``mbuf.l2_len``, ``mbuf.l3_len`` are required for TX CKSUM offload, in
> documentation there is no distinction for Rx or Tx, do you think does it worth
> to clarify PMD `uses` these values for Tx cksum offload only?
IMO, there will not be any confusion as mbuf.l2_len comes under
uint64_t tx_offload in struct rte_mbuf.
>
>
> > * **[provides] mbuf**: ``mbuf.ol_flags:PKT_RX_IP_CKSUM_UNKNOWN`` |
> > ``PKT_RX_IP_CKSUM_BAD`` | ``PKT_RX_IP_CKSUM_GOOD`` |
> > ``PKT_RX_IP_CKSUM_NONE``.
> >
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] doc: clarify L3 Tx checksum prerequisite
2018-10-05 6:44 ` [PATCH 1/2] doc: clarify L3 " Andrew Rybchenko
2018-10-05 7:06 ` Jerin Jacob
@ 2018-10-09 10:19 ` Ferruh Yigit
1 sibling, 0 replies; 8+ messages in thread
From: Ferruh Yigit @ 2018-10-09 10:19 UTC (permalink / raw)
To: Andrew Rybchenko, Jerin Jacob, John McNamara, Marko Kovacevic
Cc: dev, thomas, olivier.matz, stable
On 10/5/2018 7:44 AM, Andrew Rybchenko wrote:
> On 10/5/18 7:46 AM, Jerin Jacob wrote:
>> Based on PKT_TX_IP_CKSUM definition the user needs
>> to fill l2_len and l3_len mbuf fields before issuing
>> HW Tx checksum request.
>>
>> Fixes: dad1ec72a377 ("doc: document NIC features")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
>
> Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
Series applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-10-09 10:19 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-05 4:46 [PATCH 1/2] doc: clarify L3 Tx checksum prerequisite Jerin Jacob
2018-10-05 4:46 ` [PATCH 2/2] doc: clarify L4 " Jerin Jacob
2018-10-05 6:45 ` Andrew Rybchenko
2018-10-05 6:44 ` [PATCH 1/2] doc: clarify L3 " Andrew Rybchenko
2018-10-05 7:06 ` Jerin Jacob
2018-10-09 10:19 ` Ferruh Yigit
2018-10-05 19:56 ` Ferruh Yigit
2018-10-06 8:05 ` Jerin Jacob
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.