[chrome-platform-linux:for-kernelci 16/25] drivers/platform/chrome/cros_ec_sensorhub.c:203:5: warning: "CONFIG_PM_SLEEP" is not defined, evaluates to 0

[chrome-platform-linux:for-kernelci 16/25] drivers/platform/chrome/cros_ec_sensorhub.c:203:5: warning: "CONFIG_PM_SLEEP" is not defined, evaluates to 0

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1942 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-kernelci
head:   aa21fd9d03153eca1642e9d99aaf8a41ea0ba325
commit: 793988ad04807c8b547123ec72b08786383ba9e3 [16/25] platform: chrome: sensorhub: Add FIFO support
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 793988ad04807c8b547123ec72b08786383ba9e3
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=sh 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/platform/chrome/cros_ec_sensorhub.c:203:5: warning: "CONFIG_PM_SLEEP" is not defined, evaluates to 0 [-Wundef]
    #if CONFIG_PM_SLEEP
        ^~~~~~~~~~~~~~~

vim +/CONFIG_PM_SLEEP +203 drivers/platform/chrome/cros_ec_sensorhub.c

   202	
 > 203	#if CONFIG_PM_SLEEP
   204	/*
   205	 * When the EC is suspending, we must stop sending interrupt,
   206	 * we may use the same interrupt line for waking up the device.
   207	 * Tell the EC to stop sending non-interrupt event on the iio ring.
   208	 */
   209	static int cros_ec_ring_suspend(struct device *dev)
   210	{
   211		struct platform_device *pdev = to_platform_device(dev);
   212		struct cros_ec_sensorhub *sensorhub = platform_get_drvdata(pdev);
   213		struct cros_ec_dev *ec = sensorhub->ec;
   214	
   215		if (cros_ec_check_features(ec, EC_FEATURE_MOTION_SENSE_FIFO))
   216			return cros_ec_sensorhub_ring_fifo_enable(sensorhub, false);
   217		return 0;
   218	}
   219	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 52240 bytes --]

Re: [chrome-platform-linux:for-kernelci 16/25] drivers/platform/chrome/cros_ec_sensorhub.c:203:5: warning: "CONFIG_PM_SLEEP" is not defined, evaluates to 0

[Enric Balletbo i Serra]

[-- Attachment #1: Type: text/plain, Size: 2217 bytes --]

Hi Gwendal,

On 16/11/19 5:30, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-kernelci
> head:   aa21fd9d03153eca1642e9d99aaf8a41ea0ba325
> commit: 793988ad04807c8b547123ec72b08786383ba9e3 [16/25] platform: chrome: sensorhub: Add FIFO support
> config: sh-allmodconfig (attached as .config)
> compiler: sh4-linux-gcc (GCC) 7.4.0
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout 793988ad04807c8b547123ec72b08786383ba9e3
>         # save the attached .config to linux build tree
>         GCC_VERSION=7.4.0 make.cross ARCH=sh 
> 
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
> 
> All warnings (new ones prefixed by >>):
> 
>>> drivers/platform/chrome/cros_ec_sensorhub.c:203:5: warning: "CONFIG_PM_SLEEP" is not defined, evaluates to 0 [-Wundef]
>     #if CONFIG_PM_SLEEP
>         ^~~~~~~~~~~~~~~
> 
> vim +/CONFIG_PM_SLEEP +203 drivers/platform/chrome/cros_ec_sensorhub.c
> 
>    202	
>  > 203	#if CONFIG_PM_SLEEP

Should be #ifdef. You *don't* need to resend the full series for this, I can do
that simple change.

Thanks,
 Enric

>    204	/*
>    205	 * When the EC is suspending, we must stop sending interrupt,
>    206	 * we may use the same interrupt line for waking up the device.
>    207	 * Tell the EC to stop sending non-interrupt event on the iio ring.
>    208	 */
>    209	static int cros_ec_ring_suspend(struct device *dev)
>    210	{
>    211		struct platform_device *pdev = to_platform_device(dev);
>    212		struct cros_ec_sensorhub *sensorhub = platform_get_drvdata(pdev);
>    213		struct cros_ec_dev *ec = sensorhub->ec;
>    214	
>    215		if (cros_ec_check_features(ec, EC_FEATURE_MOTION_SENSE_FIFO))
>    216			return cros_ec_sensorhub_ring_fifo_enable(sensorhub, false);
>    217		return 0;
>    218	}
>    219	
> 
> ---
> 0-DAY kernel test infrastructure                 Open Source Technology Center
> https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation
>