* [PATCH] ltp: Fix format security warnings with gcc10
@ 2020-05-20 5:26 Khem Raj
2020-05-20 5:32 ` ✗ patchtest: failure for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Khem Raj @ 2020-05-20 5:26 UTC (permalink / raw)
To: openembedded-core; +Cc: Khem Raj, Petr Vorel, Daniel Díaz
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Cc: Petr Vorel <petr.vorel@gmail.com>
Cc: Daniel Díaz <daniel.diaz@linaro.org>
---
...1-ptrace01-Fix-missing-format-string.patch | 32 +++++++++++++++++++
meta/recipes-extended/ltp/ltp_20200515.bb | 1 +
2 files changed, 33 insertions(+)
create mode 100644 meta/recipes-extended/ltp/ltp/0001-ptrace01-Fix-missing-format-string.patch
diff --git a/meta/recipes-extended/ltp/ltp/0001-ptrace01-Fix-missing-format-string.patch b/meta/recipes-extended/ltp/ltp/0001-ptrace01-Fix-missing-format-string.patch
new file mode 100644
index 0000000000..d3785546c9
--- /dev/null
+++ b/meta/recipes-extended/ltp/ltp/0001-ptrace01-Fix-missing-format-string.patch
@@ -0,0 +1,32 @@
+From adb9587466a493fdd9d4410f1b8b130ebca06daa Mon Sep 17 00:00:00 2001
+From: Khem Raj <raj.khem@gmail.com>
+Date: Tue, 19 May 2020 22:21:23 -0700
+Subject: [PATCH] ptrace01: Fix missing format string
+
+Fixes
+| ptrace01.c:89:2: error: format string is not a string literal
+(potentially insecure) [-Werror,-Wformat-security]
+| tst_res(TINFO, tc->message);
+| ^ ~~~~~~~~~~~
+
+Signed-off-by: Khem Raj <raj.khem@gmail.com>
+---
+ testcases/kernel/syscalls/ptrace/ptrace01.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/testcases/kernel/syscalls/ptrace/ptrace01.c b/testcases/kernel/syscalls/ptrace/ptrace01.c
+index 87a99e4150..9071bbabaf 100644
+--- a/testcases/kernel/syscalls/ptrace/ptrace01.c
++++ b/testcases/kernel/syscalls/ptrace/ptrace01.c
+@@ -86,7 +86,7 @@ static void run(unsigned int i)
+
+ got_signal = 0;
+
+- tst_res(TINFO, tc->message);
++ tst_res(TINFO, "%s", tc->message);
+
+ if (tc->handler == 1) {
+ parent_act.sa_handler = parent_handler;
+--
+2.26.2
+
diff --git a/meta/recipes-extended/ltp/ltp_20200515.bb b/meta/recipes-extended/ltp/ltp_20200515.bb
index 37bad53766..e82f6b33a1 100644
--- a/meta/recipes-extended/ltp/ltp_20200515.bb
+++ b/meta/recipes-extended/ltp/ltp_20200515.bb
@@ -34,6 +34,7 @@ SRC_URI = "git://github.com/linux-test-project/ltp.git \
file://0004-guard-mallocopt-with-__GLIBC__.patch \
file://0007-Fix-test_proc_kill-hanging.patch \
file://0001-Add-more-musl-exclusions.patch \
+ file://0001-ptrace01-Fix-missing-format-string.patch \
"
S = "${WORKDIR}/git"
--
2.26.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* ✗ patchtest: failure for ltp: Fix format security warnings with gcc10
2020-05-20 5:26 [PATCH] ltp: Fix format security warnings with gcc10 Khem Raj
@ 2020-05-20 5:32 ` Patchwork
2020-05-20 6:07 ` [PATCH] " Petr Vorel
2020-05-20 6:18 ` Petr Vorel
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2020-05-20 5:32 UTC (permalink / raw)
To: Khem Raj; +Cc: openembedded-core
== Series Details ==
Series: ltp: Fix format security warnings with gcc10
Revision: 1
URL : https://patchwork.openembedded.org/series/24228/
State : failure
== Summary ==
Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:
* Issue Series does not apply on top of target branch [test_series_merge_on_head]
Suggested fix Rebase your series on top of targeted branch
Targeted branch master (currently at 586061c469)
* Issue Added patch file is missing Upstream-Status in the header [test_upstream_status_presence_format]
Suggested fix Add Upstream-Status: <Valid status> to the header of meta/recipes-extended/ltp/ltp/0001-ptrace01-Fix-missing-format-string.patch
Standard format Upstream-Status: <Valid status>
Valid status Pending, Accepted, Backport, Denied, Inappropriate [reason], Submitted [where]
If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).
---
Guidelines: https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ltp: Fix format security warnings with gcc10
2020-05-20 5:26 [PATCH] ltp: Fix format security warnings with gcc10 Khem Raj
2020-05-20 5:32 ` ✗ patchtest: failure for " Patchwork
@ 2020-05-20 6:07 ` Petr Vorel
2020-05-20 6:18 ` Petr Vorel
2 siblings, 0 replies; 5+ messages in thread
From: Petr Vorel @ 2020-05-20 6:07 UTC (permalink / raw)
To: Khem Raj; +Cc: openembedded-core, Daniel Díaz
Hi Khem,
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> Cc: Petr Vorel <petr.vorel@gmail.com>
> Cc: Daniel Díaz <daniel.diaz@linaro.org>
Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
Nice, just easy fix. Please just send patch to LTP ML.
Some time ago I tried to add -Wformat-security in upstream LTP travis CI, don't
remember why I haven't finished the effort. If this is the only needed fix,
we'll enable it.
BTW how to add -Wformat-security in for openembedded-core (for next time)?
Kind regards,
Petr
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ltp: Fix format security warnings with gcc10
2020-05-20 5:26 [PATCH] ltp: Fix format security warnings with gcc10 Khem Raj
2020-05-20 5:32 ` ✗ patchtest: failure for " Patchwork
2020-05-20 6:07 ` [PATCH] " Petr Vorel
@ 2020-05-20 6:18 ` Petr Vorel
2020-05-20 11:05 ` [OE-core] " Richard Purdie
2 siblings, 1 reply; 5+ messages in thread
From: Petr Vorel @ 2020-05-20 6:18 UTC (permalink / raw)
To: Khem Raj; +Cc: openembedded-core, Daniel Díaz
Hi Khem,
I see patch has already merged in upstream.
How about adding Upstream status: 58424835952641f4fd60c0ae3ab6c64decca3f8a
Kind regards,
Petr
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [OE-core] [PATCH] ltp: Fix format security warnings with gcc10
2020-05-20 6:18 ` Petr Vorel
@ 2020-05-20 11:05 ` Richard Purdie
0 siblings, 0 replies; 5+ messages in thread
From: Richard Purdie @ 2020-05-20 11:05 UTC (permalink / raw)
To: Petr Vorel, Khem Raj; +Cc: openembedded-core, Daniel Díaz
On Wed, 2020-05-20 at 08:18 +0200, Petr Vorel wrote:
> Hi Khem,
>
> I see patch has already merged in upstream.
> How about adding Upstream status:
> 58424835952641f4fd60c0ae3ab6c64decca3f8a
I tweaked it to Upstream-Status: backport.
Cheers,
Richard
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-05-20 11:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-20 5:26 [PATCH] ltp: Fix format security warnings with gcc10 Khem Raj
2020-05-20 5:32 ` ✗ patchtest: failure for " Patchwork
2020-05-20 6:07 ` [PATCH] " Petr Vorel
2020-05-20 6:18 ` Petr Vorel
2020-05-20 11:05 ` [OE-core] " Richard Purdie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.