From: Matthias Brugger <matthias.bgg@gmail.com> To: Chen-Yu Tsai <wenst@chromium.org> Cc: "Rob Herring" <robh+dt@kernel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, "AngeloGioacchino Del Regno" <angelogioacchino.delregno@collabora.com>, "Nícolas F . R . A . Prado" <nfraprado@collabora.com> Subject: Re: [PATCH 0/4] arm64: dts: mediatek: Fix systimer clock description Date: Fri, 16 Dec 2022 12:29:20 +0100 [thread overview] Message-ID: <ec30d7c3-39af-197b-58df-440dcdb27a36@gmail.com> (raw) In-Reply-To: <20221201084229.3464449-1-wenst@chromium.org> On 01/12/2022 09:42, Chen-Yu Tsai wrote: > Hi, > > This series fixes the clock description for the systimer block. The > systimer is fed by the main 26 MHz oscillator, and internally divides > the clock, normally by 2. > > However this ended up being modeled in various incorrect ways, such as > the clock divider being in the TOPCKGEN block, or as a standalone 13 MHz > oscillator. > > This series fixes the description of the systimer clock input in an ABI > compatible way, i.e. the clock rate of the input clock remains the same > at 13 MHz. The clock is now modeled as a divide-by-2 fixed factor clock > being fed by the main oscillator. > > An added benefit is that in Linux the systimer no longer requires the > main SoC clk driver to do an early init dance. > > Please have a look. > > The next step would be to fix up the systimer driver in a backward > compatible way and have it read the divider value from hardware. > Whole series applied, thanks! > > Regards > ChenYu > > Chen-Yu Tsai (4): > arm64: dts: mediatek: mt8183: Fix systimer 13 MHz clock description > arm64: dts: mediatek: mt8192: Fix systimer 13 MHz clock description > arm64: dts: mediatek: mt8195: Fix systimer 13 MHz clock description > arm64: dts: mediatek: mt8186: Fix systimer 13 MHz clock description > > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 12 ++++++++++-- > arch/arm64/boot/dts/mediatek/mt8186.dtsi | 8 +++++--- > arch/arm64/boot/dts/mediatek/mt8192.dtsi | 12 ++++++++++-- > arch/arm64/boot/dts/mediatek/mt8195.dtsi | 11 ++++++++++- > 4 files changed, 35 insertions(+), 8 deletions(-) >
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Brugger <matthias.bgg@gmail.com> To: Chen-Yu Tsai <wenst@chromium.org> Cc: "Rob Herring" <robh+dt@kernel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, "AngeloGioacchino Del Regno" <angelogioacchino.delregno@collabora.com>, "Nícolas F . R . A . Prado" <nfraprado@collabora.com> Subject: Re: [PATCH 0/4] arm64: dts: mediatek: Fix systimer clock description Date: Fri, 16 Dec 2022 12:29:20 +0100 [thread overview] Message-ID: <ec30d7c3-39af-197b-58df-440dcdb27a36@gmail.com> (raw) In-Reply-To: <20221201084229.3464449-1-wenst@chromium.org> On 01/12/2022 09:42, Chen-Yu Tsai wrote: > Hi, > > This series fixes the clock description for the systimer block. The > systimer is fed by the main 26 MHz oscillator, and internally divides > the clock, normally by 2. > > However this ended up being modeled in various incorrect ways, such as > the clock divider being in the TOPCKGEN block, or as a standalone 13 MHz > oscillator. > > This series fixes the description of the systimer clock input in an ABI > compatible way, i.e. the clock rate of the input clock remains the same > at 13 MHz. The clock is now modeled as a divide-by-2 fixed factor clock > being fed by the main oscillator. > > An added benefit is that in Linux the systimer no longer requires the > main SoC clk driver to do an early init dance. > > Please have a look. > > The next step would be to fix up the systimer driver in a backward > compatible way and have it read the divider value from hardware. > Whole series applied, thanks! > > Regards > ChenYu > > Chen-Yu Tsai (4): > arm64: dts: mediatek: mt8183: Fix systimer 13 MHz clock description > arm64: dts: mediatek: mt8192: Fix systimer 13 MHz clock description > arm64: dts: mediatek: mt8195: Fix systimer 13 MHz clock description > arm64: dts: mediatek: mt8186: Fix systimer 13 MHz clock description > > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 12 ++++++++++-- > arch/arm64/boot/dts/mediatek/mt8186.dtsi | 8 +++++--- > arch/arm64/boot/dts/mediatek/mt8192.dtsi | 12 ++++++++++-- > arch/arm64/boot/dts/mediatek/mt8195.dtsi | 11 ++++++++++- > 4 files changed, 35 insertions(+), 8 deletions(-) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-12-16 11:29 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-12-01 8:42 [PATCH 0/4] arm64: dts: mediatek: Fix systimer clock description Chen-Yu Tsai 2022-12-01 8:42 ` Chen-Yu Tsai 2022-12-01 8:42 ` [PATCH 1/4] arm64: dts: mediatek: mt8183: Fix systimer 13 MHz " Chen-Yu Tsai 2022-12-01 8:42 ` Chen-Yu Tsai 2022-12-01 9:31 ` AngeloGioacchino Del Regno 2022-12-01 9:31 ` AngeloGioacchino Del Regno 2022-12-01 10:33 ` Chen-Yu Tsai 2022-12-01 10:33 ` Chen-Yu Tsai 2022-12-13 11:24 ` AngeloGioacchino Del Regno 2022-12-13 11:24 ` AngeloGioacchino Del Regno 2022-12-01 8:42 ` [PATCH 2/4] arm64: dts: mediatek: mt8192: " Chen-Yu Tsai 2022-12-01 8:42 ` Chen-Yu Tsai 2022-12-13 11:25 ` AngeloGioacchino Del Regno 2022-12-13 11:25 ` AngeloGioacchino Del Regno 2022-12-01 8:42 ` [PATCH 3/4] arm64: dts: mediatek: mt8195: " Chen-Yu Tsai 2022-12-01 8:42 ` Chen-Yu Tsai 2022-12-13 11:25 ` AngeloGioacchino Del Regno 2022-12-13 11:25 ` AngeloGioacchino Del Regno 2022-12-01 8:42 ` [PATCH 4/4] arm64: dts: mediatek: mt8186: " Chen-Yu Tsai 2022-12-01 8:42 ` Chen-Yu Tsai 2022-12-13 11:25 ` AngeloGioacchino Del Regno 2022-12-13 11:25 ` AngeloGioacchino Del Regno 2022-12-16 11:29 ` Matthias Brugger [this message] 2022-12-16 11:29 ` [PATCH 0/4] arm64: dts: mediatek: Fix systimer " Matthias Brugger
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ec30d7c3-39af-197b-58df-440dcdb27a36@gmail.com \ --to=matthias.bgg@gmail.com \ --cc=angelogioacchino.delregno@collabora.com \ --cc=devicetree@vger.kernel.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=nfraprado@collabora.com \ --cc=robh+dt@kernel.org \ --cc=wenst@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.