* [PATCH] drm/dp_mst: Zero assigned PBN when releasing VCPI slots
@ 2020-04-07 16:07 ` mikita.lipski
0 siblings, 0 replies; 6+ messages in thread
From: mikita.lipski @ 2020-04-07 16:07 UTC (permalink / raw)
To: amd-gfx, dri-devel; +Cc: Alexander.Deucher, Mikita Lipski
From: Mikita Lipski <mikita.lipski@amd.com>
Zero Port's PBN together with VCPI slots when releasing
allocated VCPI slots. That way when disabling the connector
it will not cause issues in drm_dp_mst_atomic_check verifying
branch bw limit.
Signed-off-by: Mikita Lipski <mikita.lipski@amd.com>
---
drivers/gpu/drm/drm_dp_mst_topology.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c
index 38bf111e5f9b..ed109dd15df6 100644
--- a/drivers/gpu/drm/drm_dp_mst_topology.c
+++ b/drivers/gpu/drm/drm_dp_mst_topology.c
@@ -4276,6 +4276,7 @@ int drm_dp_atomic_release_vcpi_slots(struct drm_atomic_state *state,
if (pos->vcpi) {
drm_dp_mst_put_port_malloc(port);
pos->vcpi = 0;
+ pos->pbn = 0;
}
return 0;
--
2.17.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] drm/dp_mst: Zero assigned PBN when releasing VCPI slots
@ 2020-04-07 16:07 ` mikita.lipski
0 siblings, 0 replies; 6+ messages in thread
From: mikita.lipski @ 2020-04-07 16:07 UTC (permalink / raw)
To: amd-gfx, dri-devel; +Cc: Alexander.Deucher, harry.wentland, Mikita Lipski
From: Mikita Lipski <mikita.lipski@amd.com>
Zero Port's PBN together with VCPI slots when releasing
allocated VCPI slots. That way when disabling the connector
it will not cause issues in drm_dp_mst_atomic_check verifying
branch bw limit.
Signed-off-by: Mikita Lipski <mikita.lipski@amd.com>
---
drivers/gpu/drm/drm_dp_mst_topology.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c
index 38bf111e5f9b..ed109dd15df6 100644
--- a/drivers/gpu/drm/drm_dp_mst_topology.c
+++ b/drivers/gpu/drm/drm_dp_mst_topology.c
@@ -4276,6 +4276,7 @@ int drm_dp_atomic_release_vcpi_slots(struct drm_atomic_state *state,
if (pos->vcpi) {
drm_dp_mst_put_port_malloc(port);
pos->vcpi = 0;
+ pos->pbn = 0;
}
return 0;
--
2.17.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/dp_mst: Zero assigned PBN when releasing VCPI slots
2020-04-07 16:07 ` mikita.lipski
@ 2020-04-08 0:29 ` Lyude Paul
-1 siblings, 0 replies; 6+ messages in thread
From: Lyude Paul @ 2020-04-08 0:29 UTC (permalink / raw)
To: mikita.lipski, amd-gfx, dri-devel; +Cc: Alexander.Deucher
Hey - didn't get a chance to take a look at this today but I will review asap!
On Tue, 2020-04-07 at 12:07 -0400, mikita.lipski@amd.com wrote:
> From: Mikita Lipski <mikita.lipski@amd.com>
>
> Zero Port's PBN together with VCPI slots when releasing
> allocated VCPI slots. That way when disabling the connector
> it will not cause issues in drm_dp_mst_atomic_check verifying
> branch bw limit.
>
> Signed-off-by: Mikita Lipski <mikita.lipski@amd.com>
> ---
> drivers/gpu/drm/drm_dp_mst_topology.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c
> b/drivers/gpu/drm/drm_dp_mst_topology.c
> index 38bf111e5f9b..ed109dd15df6 100644
> --- a/drivers/gpu/drm/drm_dp_mst_topology.c
> +++ b/drivers/gpu/drm/drm_dp_mst_topology.c
> @@ -4276,6 +4276,7 @@ int drm_dp_atomic_release_vcpi_slots(struct
> drm_atomic_state *state,
> if (pos->vcpi) {
> drm_dp_mst_put_port_malloc(port);
> pos->vcpi = 0;
> + pos->pbn = 0;
> }
>
> return 0;
--
Cheers,
Lyude Paul (she/her)
Associate Software Engineer at Red Hat
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/dp_mst: Zero assigned PBN when releasing VCPI slots
@ 2020-04-08 0:29 ` Lyude Paul
0 siblings, 0 replies; 6+ messages in thread
From: Lyude Paul @ 2020-04-08 0:29 UTC (permalink / raw)
To: mikita.lipski, amd-gfx, dri-devel; +Cc: Alexander.Deucher, harry.wentland
Hey - didn't get a chance to take a look at this today but I will review asap!
On Tue, 2020-04-07 at 12:07 -0400, mikita.lipski@amd.com wrote:
> From: Mikita Lipski <mikita.lipski@amd.com>
>
> Zero Port's PBN together with VCPI slots when releasing
> allocated VCPI slots. That way when disabling the connector
> it will not cause issues in drm_dp_mst_atomic_check verifying
> branch bw limit.
>
> Signed-off-by: Mikita Lipski <mikita.lipski@amd.com>
> ---
> drivers/gpu/drm/drm_dp_mst_topology.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c
> b/drivers/gpu/drm/drm_dp_mst_topology.c
> index 38bf111e5f9b..ed109dd15df6 100644
> --- a/drivers/gpu/drm/drm_dp_mst_topology.c
> +++ b/drivers/gpu/drm/drm_dp_mst_topology.c
> @@ -4276,6 +4276,7 @@ int drm_dp_atomic_release_vcpi_slots(struct
> drm_atomic_state *state,
> if (pos->vcpi) {
> drm_dp_mst_put_port_malloc(port);
> pos->vcpi = 0;
> + pos->pbn = 0;
> }
>
> return 0;
--
Cheers,
Lyude Paul (she/her)
Associate Software Engineer at Red Hat
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/dp_mst: Zero assigned PBN when releasing VCPI slots
2020-04-07 16:07 ` mikita.lipski
@ 2020-04-17 22:20 ` Lyude Paul
-1 siblings, 0 replies; 6+ messages in thread
From: Lyude Paul @ 2020-04-17 22:20 UTC (permalink / raw)
To: mikita.lipski, amd-gfx, dri-devel; +Cc: Alexander.Deucher
Reviewed-by: Lyude Paul <lyude@redhat.com>
In the future btw, you should use the DRM maintainer tools to add a Fixed-by
tag, since this:
Fixes: cd82d82cbc04 ("drm/dp_mst: Add branch bandwidth validation to MST
atomic check")
Also so it gets cc'd to stable, I'll fixup the patch and push it. Thanks!
On Tue, 2020-04-07 at 12:07 -0400, mikita.lipski@amd.com wrote:
> From: Mikita Lipski <mikita.lipski@amd.com>
>
> Zero Port's PBN together with VCPI slots when releasing
> allocated VCPI slots. That way when disabling the connector
> it will not cause issues in drm_dp_mst_atomic_check verifying
> branch bw limit.
>
> Signed-off-by: Mikita Lipski <mikita.lipski@amd.com>
> ---
> drivers/gpu/drm/drm_dp_mst_topology.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c
> b/drivers/gpu/drm/drm_dp_mst_topology.c
> index 38bf111e5f9b..ed109dd15df6 100644
> --- a/drivers/gpu/drm/drm_dp_mst_topology.c
> +++ b/drivers/gpu/drm/drm_dp_mst_topology.c
> @@ -4276,6 +4276,7 @@ int drm_dp_atomic_release_vcpi_slots(struct
> drm_atomic_state *state,
> if (pos->vcpi) {
> drm_dp_mst_put_port_malloc(port);
> pos->vcpi = 0;
> + pos->pbn = 0;
> }
>
> return 0;
--
Cheers,
Lyude Paul (she/her)
Associate Software Engineer at Red Hat
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/dp_mst: Zero assigned PBN when releasing VCPI slots
@ 2020-04-17 22:20 ` Lyude Paul
0 siblings, 0 replies; 6+ messages in thread
From: Lyude Paul @ 2020-04-17 22:20 UTC (permalink / raw)
To: mikita.lipski, amd-gfx, dri-devel; +Cc: Alexander.Deucher, harry.wentland
Reviewed-by: Lyude Paul <lyude@redhat.com>
In the future btw, you should use the DRM maintainer tools to add a Fixed-by
tag, since this:
Fixes: cd82d82cbc04 ("drm/dp_mst: Add branch bandwidth validation to MST
atomic check")
Also so it gets cc'd to stable, I'll fixup the patch and push it. Thanks!
On Tue, 2020-04-07 at 12:07 -0400, mikita.lipski@amd.com wrote:
> From: Mikita Lipski <mikita.lipski@amd.com>
>
> Zero Port's PBN together with VCPI slots when releasing
> allocated VCPI slots. That way when disabling the connector
> it will not cause issues in drm_dp_mst_atomic_check verifying
> branch bw limit.
>
> Signed-off-by: Mikita Lipski <mikita.lipski@amd.com>
> ---
> drivers/gpu/drm/drm_dp_mst_topology.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c
> b/drivers/gpu/drm/drm_dp_mst_topology.c
> index 38bf111e5f9b..ed109dd15df6 100644
> --- a/drivers/gpu/drm/drm_dp_mst_topology.c
> +++ b/drivers/gpu/drm/drm_dp_mst_topology.c
> @@ -4276,6 +4276,7 @@ int drm_dp_atomic_release_vcpi_slots(struct
> drm_atomic_state *state,
> if (pos->vcpi) {
> drm_dp_mst_put_port_malloc(port);
> pos->vcpi = 0;
> + pos->pbn = 0;
> }
>
> return 0;
--
Cheers,
Lyude Paul (she/her)
Associate Software Engineer at Red Hat
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-04-17 22:20 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-07 16:07 [PATCH] drm/dp_mst: Zero assigned PBN when releasing VCPI slots mikita.lipski
2020-04-07 16:07 ` mikita.lipski
2020-04-08 0:29 ` Lyude Paul
2020-04-08 0:29 ` Lyude Paul
2020-04-17 22:20 ` Lyude Paul
2020-04-17 22:20 ` Lyude Paul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.