From: Sahitya Tummala <stummala@codeaurora.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Alexander Polakov <apolyakov@beget.ru>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Jan Kara <jack@suse.cz>,
viro@zeniv.linux.org.uk, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] fs/dcache.c: fix spin lockup issue on nlru->lock
Date: Fri, 30 Jun 2017 08:46:57 +0530 [thread overview]
Message-ID: <ec645d13-5a25-0eaa-963b-3c3c3b2a72a2@codeaurora.org> (raw)
In-Reply-To: <20170629154828.5b4877348470c42352620f41@linux-foundation.org>
On 6/30/2017 4:18 AM, Andrew Morton wrote:
>
>> --- a/fs/dcache.c
>> +++ b/fs/dcache.c
>> @@ -1133,11 +1133,12 @@ void shrink_dcache_sb(struct super_block *sb)
>> LIST_HEAD(dispose);
>>
>> freed = list_lru_walk(&sb->s_dentry_lru,
>> - dentry_lru_isolate_shrink, &dispose, UINT_MAX);
>> + dentry_lru_isolate_shrink, &dispose, 1024);
>>
>> this_cpu_sub(nr_dentry_unused, freed);
>> shrink_dentry_list(&dispose);
>> - } while (freed > 0);
>> + cond_resched();
>> + } while (list_lru_count(&sb->s_dentry_lru) > 0);
>> }
>> EXPORT_SYMBOL(shrink_dcache_sb);
> I'll add a cc:stable to this one - a large dentry list is a relatively
> common thing.
>
> I'm assumng that [1/2] does not need to be backported, OK?
I think we should include [1/2] as well along with this patch, as this patch
is using list_lru_count(), which can return incorrect count if [1/2] is
not included.
Also, all the previous patches submitted for fixing this issue must be
dropped i.e,
mm/list_lru.c: use cond_resched_lock() for nlru->lock must be dropped.
--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
WARNING: multiple messages have this Message-ID (diff)
From: Sahitya Tummala <stummala@codeaurora.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Alexander Polakov <apolyakov@beget.ru>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Jan Kara <jack@suse.cz>,
viro@zeniv.linux.org.uk, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] fs/dcache.c: fix spin lockup issue on nlru->lock
Date: Fri, 30 Jun 2017 08:46:57 +0530 [thread overview]
Message-ID: <ec645d13-5a25-0eaa-963b-3c3c3b2a72a2@codeaurora.org> (raw)
In-Reply-To: <20170629154828.5b4877348470c42352620f41@linux-foundation.org>
On 6/30/2017 4:18 AM, Andrew Morton wrote:
>
>> --- a/fs/dcache.c
>> +++ b/fs/dcache.c
>> @@ -1133,11 +1133,12 @@ void shrink_dcache_sb(struct super_block *sb)
>> LIST_HEAD(dispose);
>>
>> freed = list_lru_walk(&sb->s_dentry_lru,
>> - dentry_lru_isolate_shrink, &dispose, UINT_MAX);
>> + dentry_lru_isolate_shrink, &dispose, 1024);
>>
>> this_cpu_sub(nr_dentry_unused, freed);
>> shrink_dentry_list(&dispose);
>> - } while (freed > 0);
>> + cond_resched();
>> + } while (list_lru_count(&sb->s_dentry_lru) > 0);
>> }
>> EXPORT_SYMBOL(shrink_dcache_sb);
> I'll add a cc:stable to this one - a large dentry list is a relatively
> common thing.
>
> I'm assumng that [1/2] does not need to be backported, OK?
I think we should include [1/2] as well along with this patch, as this patch
is using list_lru_count(), which can return incorrect count if [1/2] is
not included.
Also, all the previous patches submitted for fixing this issue must be
dropped i.e,
mm/list_lru.c: use cond_resched_lock() for nlru->lock must be dropped.
--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-06-30 3:17 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-12 0:47 [PATCH] mm/list_lru.c: use cond_resched_lock() for nlru->lock Sahitya Tummala
2017-06-12 0:47 ` Sahitya Tummala
2017-06-12 13:11 ` Jan Kara
2017-06-12 13:11 ` Jan Kara
2017-06-15 21:05 ` Andrew Morton
2017-06-15 21:05 ` Andrew Morton
2017-06-16 14:44 ` Sahitya Tummala
2017-06-16 14:44 ` Sahitya Tummala
2017-06-17 11:14 ` Vladimir Davydov
2017-06-17 11:14 ` Vladimir Davydov
2017-06-20 2:52 ` Sahitya Tummala
2017-06-20 2:52 ` Sahitya Tummala
2017-06-21 6:39 ` [PATCH v2] fs/dcache.c: fix spin lockup issue on nlru->lock Sahitya Tummala
2017-06-21 6:39 ` Sahitya Tummala
2017-06-21 16:31 ` Vladimir Davydov
2017-06-21 16:31 ` Vladimir Davydov
2017-06-22 16:31 ` Sahitya Tummala
2017-06-22 16:31 ` Sahitya Tummala
2017-06-22 17:49 ` Vladimir Davydov
2017-06-22 17:49 ` Vladimir Davydov
2017-06-28 6:07 ` [PATCH v3 1/2] mm/list_lru.c: fix list_lru_count_node() to be race free Sahitya Tummala
2017-06-28 6:07 ` Sahitya Tummala
2017-06-28 6:07 ` [PATCH v3 2/2] fs/dcache.c: fix spin lockup issue on nlru->lock Sahitya Tummala
2017-06-28 6:07 ` Sahitya Tummala
2017-06-28 17:18 ` [PATCH v3 1/2] mm/list_lru.c: fix list_lru_count_node() to be race free Vladimir Davydov
2017-06-28 17:18 ` Vladimir Davydov
2017-06-29 3:39 ` [PATCH v4 " Sahitya Tummala
2017-06-29 3:39 ` Sahitya Tummala
2017-07-01 16:28 ` Vladimir Davydov
2017-07-01 16:28 ` Vladimir Davydov
2017-06-29 3:39 ` [PATCH v4 2/2] fs/dcache.c: fix spin lockup issue on nlru->lock Sahitya Tummala
2017-06-29 3:39 ` Sahitya Tummala
2017-06-29 22:48 ` Andrew Morton
2017-06-29 22:48 ` Andrew Morton
2017-06-30 3:16 ` Sahitya Tummala [this message]
2017-06-30 3:16 ` Sahitya Tummala
2017-07-01 16:28 ` Vladimir Davydov
2017-07-01 16:28 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec645d13-5a25-0eaa-963b-3c3c3b2a72a2@codeaurora.org \
--to=stummala@codeaurora.org \
--cc=akpm@linux-foundation.org \
--cc=apolyakov@beget.ru \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vdavydov.dev@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.