All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net] ipv4: Avoid caching dsts when lookup skipped nh oif check
@ 2017-04-20 12:58 Robert Shearman
  2017-04-20 14:21 ` David Ahern
  2017-04-20 22:18 ` [PATCH net] ipv4: Avoid caching dsts when lookup skipped nh oif check David Ahern
  0 siblings, 2 replies; 12+ messages in thread
From: Robert Shearman @ 2017-04-20 12:58 UTC (permalink / raw)
  To: davem; +Cc: netdev, David Ahern, Robert Shearman

David reported that doing the following:

    ip li add red type vrf table 10
    ip link set dev eth1 vrf red
    ip addr add 127.0.0.1/8 dev red
    ip link set dev eth1 up
    ip li set red up
    ping -c1 -w1 -I red 127.0.0.1
    ip li del red

results in a hang with this message:

    unregister_netdevice: waiting for red to become free. Usage count = 1

The problem is caused by caching the dst used for sending the packet
out of the specified interface on the route that the lookup returned
from the local table when the rule for the lookup in the local table
is ordered before the rule for lookups using l3mdevs. Thus the dst
could stay around until the route in the local table is deleted which
may be never.

Address the problem by not allocating a cacheable output dst if
FLOWI_FLAG_SKIP_NH_OIF is set and the nh device differs from the
device used for the dst.

Fixes: ebfc102c566d ("net: vrf: Flip IPv4 output path from FIB lookup hook to out hook")
Reported-by: David Ahern <dsa@cumulusnetworks.com>
Signed-off-by: Robert Shearman <rshearma@brocade.com>
---
 net/ipv4/route.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/net/ipv4/route.c b/net/ipv4/route.c
index acd69cfe2951..f667783ffd19 100644
--- a/net/ipv4/route.c
+++ b/net/ipv4/route.c
@@ -2125,6 +2125,14 @@ static struct rtable *__mkroute_output(const struct fib_result *res,
 		fi = NULL;
 	}
 
+	/* If the flag to skip the nh oif check is set then the output
+	 * device may not match the nh device, so cannot use or add to
+	 * cache in that case.
+	 */
+	if (unlikely(fl4->flowi4_flags & FLOWI_FLAG_SKIP_NH_OIF &&
+		     FIB_RES_NH(*res).nh_dev != dev_out))
+		do_cache = false;
+
 	fnhe = NULL;
 	do_cache &= fi != NULL;
 	if (do_cache) {
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 12+ messages in thread
end of thread, other threads:[~2017-04-24 16:52 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-20 12:58 [PATCH net] ipv4: Avoid caching dsts when lookup skipped nh oif check Robert Shearman
2017-04-20 14:21 ` David Ahern
2017-04-20 14:39   ` Robert Shearman
2017-04-20 14:59     ` David Ahern
2017-04-20 15:05       ` Robert Shearman
2017-04-20 15:16         ` David Ahern
2017-04-20 15:35           ` Robert Shearman
2017-04-21 20:34             ` [PATCH net v2] ipv4: Avoid caching l3mdev dst on mismatched local route Robert Shearman
2017-04-21 20:37               ` David Ahern
2017-04-24 16:52               ` David Miller
2017-04-20 22:18 ` [PATCH net] ipv4: Avoid caching dsts when lookup skipped nh oif check David Ahern
2017-04-21 17:17   ` Robert Shearman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.